[PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/staging

[PATCH 4/5] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging

[PATCH 5/5] staging: cxt1e1: fix checkpatch errors with open brace '{'

clean up checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 62 +++--- 1 file changed, 25 insertions(+), 37 deletions(-) diff --git a/drivers

Re: [PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

OK. sorry. I will send again. Thanks. Daeseok Youn 2014-02-28 16:28 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote: clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Patch is white space dammaged

[PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/drivers/staging/cxt1e1

[PATCH] staging: lustre: make functions as static

These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++-- 1 file changed

Re: [PATCH] staging: lustre: make functions as static

Actually , I saw some code like this file which is seperate line between return value and function name. So I didn't make one line of them. Ok, I will make another patch after merge this one. Thanks. Daeseok Youn. 2014-02-26 18:20 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Wed, Feb

Re: [PATCH] staging: lustre: make functions as static

Oh.. sorry. Ok, I will seperate this patch as you said. Thanks. Daeseok Youn. 2014-02-26 20:31 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote: Actually , I saw some code like this file which is seperate line between return value

[PATCH v2] staging: lustre: make functions as static

These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++-- 1 file changed

Re: [PATCH] staging: ced401: remove redundant spin_unlock

2014-02-24 17:06 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote: From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Mon, 24 Feb 2014 09:17:41 +0900 Subject

[PATCH v2] staging: ced401: fix double unlock bug

: context imbalance in 'Handle1401Esc' - unexpected unlock Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/ced1401/usb1401.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index efc310c..8195eb9 100644

Re: [PATCH v2] staging: ced401: fix double unlock bug

Ok. I will make a patch based on linux-next branch and send it again. Thanks. Daeseok Youn 2014-02-25 9:43 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: After spin_lock() is called, all of if-else conditions in this brace should

[PATCH] staging: ced401: remove redundant spin_unlock

From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Mon, 24 Feb 2014 09:17:41 +0900 Subject: [PATCH] staging: ced401: remove redundant spin_unlock sparse says: drivers/staging/ced1401/usb1401.c:1080:28: warning: context imbalance

Re: [PATCH] staging : android : fix checkpatch issues

similar with this patch. You can see with this url https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45 If you don't mind, let me know why it is not good. Thanks. Daeseok Youn 2014-02

Re: [PATCH] staging : android : fix checkpatch issues

OK. I will re-send this patch except replacing seq_printf() with seq_puts(). Your review helped me a lot. Thanks. Daeseok Youn. 2014-02-10 19:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote: Thanks for reviewing. Yes, I just

[PATCH] staging : android : sync : fix a checkpatch warning

From 16140b1ec1b1e1060f74707e4a6661aface81a14 Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Mon, 10 Feb 2014 14:36:48 +0900 Subject: [PATCH] staging : android : sync : fix a checkpatch warning - WARNING: missing space after return type Signed-off-by: Daeseok Youn

[PATCH] staging: android: timed_output: fix a checkpatch warning

From 866c5eb6cb88b59702802876a724dfd0144c447e Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Mon, 10 Feb 2014 14:38:05 +0900 Subject: [PATCH] staging: android: timed_output: fix a checkpatch warning - WARNING: Multiple spaces after return type Signed-off-by: Daeseok

Re: [PATCH] staging : ion : Fix some checkpatch warnings and an error

(*has_signaled)(struct sync_pt *pt); 2014-02-10 15:07 GMT+09:00 Joe Perches j...@perches.com: On Mon, 2014-02-10 at 14:56 +0900, Daeseok Youn wrote: Hello. diff --git a/drivers/staging/android/ion/ion_priv.h b/drivers/staging/android/ion/ion_priv.h [] - struct sg_table *(*map_dma

Re: [PATCH] staging : android : sync : fix a checkpatch warning

CC+ Joe Perches. 2014-02-10 14:58 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: From 16140b1ec1b1e1060f74707e4a6661aface81a14 Mon Sep 17 00:00:00 2001 From: Daeseok Youn daeseok.y...@gmail.com Date: Mon, 10 Feb 2014 14:36:48 +0900 Subject: [PATCH] staging : android : sync : fix a checkpatch

<    1   2   3   4   5