Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

2016-05-26 21:29 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: > On 26/05/16 05:56, DaeSeok Youn wrote: >> 2016-05-26 6:48 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: >>> On 20/05/16 10:51, Daeseok Youn wrote: >>>> the "brd&qu

Re: [PATCH 2/2] staging: dgnc: remove redundant null check in

2016-05-26 7:00 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: > On 20/05/16 10:51, Daeseok Youn wrote: >> the "brd" was already checked for NULL before calling dgnc_do_remap(). >> >> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> >&g

Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

2016-05-26 6:48 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: > On 20/05/16 10:51, Daeseok Youn wrote: >> the "brd" value cannot be NULL in dgnc_finalize_board_init(). >> Because "brd" as a parameter of this function was already >> chec

[PATCH 2/2] staging: dgnc: remove redundant null check in

the "brd" was already checked for NULL before calling dgnc_do_remap(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgn

[PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

the "brd" value cannot be NULL in dgnc_finalize_board_init(). Because "brd" as a parameter of this function was already checked for NULL. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletion

[PATCH] staging: dgnc: re-arrange functions for removing forward

Re-arrange the functions for removing forward declarations in dgnc_cls.c file. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- After applying this patch, the object file size was NOT changed. drivers/staging/dgnc/dgnc_cls.c | 949 +++- 1 file c

[PATCH 3/3] staging: dgnc: removes redundant null check and change

The dgnc_set_modem_info() used only channel_t variable. Any other variables were used only for checking NULL. So fist parameter changed from "tty_struct" to "channel_t" and useless NULL checks and variables are removed. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.co

[PATCH 2/3] staging: dgnc: remove redundant variable null check

The unit struct(un_t) was not used in dgnc_tty_hangup(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 52a1613..5

[PATCH 1/3] staging: dgnc: remove redundant local variable for

The local variable "bd" was not used in dgnc_carrier() function. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty

[PATCH 2/2 RESEND] staging: dgnc: remove useless error value assignment

The "result" variable in dgnc_get_mstat() was initialized with "-EIO". But if the "ch" is not null, "result" will be set to zero and if the "ch" is null, dgnc_get_mstat() will return "-ENXIO" as an error. So "-EIO" err

[PATCH 1/2 RESEND] staging: dgnc: remove redundant NULL checks in

The dgnc_block_til_ready() is only used in dgnc_tty_open(). The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open(). And also tty and un were tested about NULL so these variables doesn't need to check for NULL in dgnc_block_til_ready(). Signed-off-by: Daeseok Y

Re: [PATCH 1/3] staging: dgnc: remove redundant NULL check in

2016-05-09 21:08 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Wed, May 04, 2016 at 02:13:04PM +0900, Daeseok Youn wrote: >> tty and ch are already checked for NULL >> before calling dgnc_block_til_ready(). >> >> Signed-off-by: Daeseok Youn <daeseok.y

Re: [PATCH 2/3] staging: dgnc: remove useless assigned error value in

2016-05-09 21:09 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Wed, May 04, 2016 at 02:13:26PM +0900, Daeseok Youn wrote: >> the result in dgnc_get_mstat() was initialized with -EIO but >> there are no use of EIO as a result in this function. >> >> Signe

[PATCH 3/3] staging: dgnc: Need to check for NULL of ch

the "ch" from brd structure could be NULL, it need to check for NULL. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging

[PATCH 2/3] staging: dgnc: remove redundant condition check

dgnc_board(brd) was already checked for NULL before calling neo_parse_isr(). And also port doesn't need to check. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_n

[PATCH 1/3] staging: dgnc: fix 'line over 80 characters'

fix checkpatch.pl warning about 'line over 80 characters'. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_sysfs.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/s

[PATCH] staging: dgnc: Fix a NULL pointer dereference

Carpenter <dan.carpen...@oracle.com> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 2

Re: staging: dgnc: use tty_alloc_driver instead of kcalloc

2016-05-03 17:15 GMT+09:00 Dan Carpenter <dan.carpen...@oracle.com>: > Hello Daeseok Youn, Hello Dan, > > The patch 60b3109e5e2d: "staging: dgnc: use tty_alloc_driver instead > of kcalloc" from Apr 14, 2016, leads to the following static checker > warning: &

[PATCH 1/3] staging: dgnc: remove redundant NULL check in

tty and ch are already checked for NULL before calling dgnc_block_til_ready(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/s

[PATCH 3/3] staging: dgnc: clean up the dgnc_get_modem_info()

the "ch" in dgnc_get_modem_info() was already checked before calling this function and also if "ch" is not NULL, dgnc_get_mstat() returns valid value so it doesn't need to check an error. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/st

[PATCH] staging: dgnc: use tty_alloc_driver instead of kcalloc

The tty_alloc_driver() can allocate memory for ttys and termios. And also allocated memory will be released easily with put_tty_driver() call. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c

[PATCH 2/2] staging: dgnc: remove redundant NULL check in

There were already checking NULL about channel_t / un_t before calling dgnc_maxcps_room(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/staging/dgnc/dgnc

[PATCH 1/2] staging: dgnc: return -ENOMEM when kzalloc failed

The kzalloc can be failed when memory is not enough to allocate. When kzalloc failed, it need to return error code with ENOMEM Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/stagin

[PATCH 2/2] staging: dgnc: remove blank line

fix checkpatch.pl warning: Blank lines aren't necessary after an open brace '{' Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c

[PATCH 1/2] staging: dgnc: remove parenthesis around the CONST |

remove parenthesis around the CONST | CONST. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 5e46ac8..4

[PATCH 2/2] staging: dgnc: fix CamelCase in dgnc_tty.c

fix checkpatch.pl warning about 'Avoid CamelCase' Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 2 +- drivers/staging/dgnc/digi.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/d

[PATCH 1/2] staging: dgnc: remove too many traverse pointer

The "ch->ch_bd" is already assined to "bd" but this is only for checking null or MAGIC number. in the dgnc_tty_ioctl function, bd can be used for referencing to board_ops structure. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers

[PATCH 2/2] staging: dgnc: clean up dgnc_input function

This is for fixing checkpatch.pl warning about "Alignment should match open parenthesis" but if that is fixed, code line is over 80 characters. I think "ch->ch_rqueue + tail + i" could be declared once in the begining of loop. Signed-off-by: Daeseok Youn <daeseok.y.

[PATCH 1/2] staging: dgnc: remove useless variables for saving tty's

It doesn't need to save major number with variable. And there are no use of these variables(dgnc_serial_major and dgnc_transparent_print_major) Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 3 --- drivers/staging/dgnc/dgnc_tty.c| 4 -

[PATCH 3/3] staging: dgnc: fix Logical continuations.

fix checkpatch.pl warning about 'Logical continuations should be on the previous line' Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/d

[PATCH 1/3] staging: dgnc: remove parenthesis around the CONST |

remove parenthesis around the CONST | CONST. It will be also fixed checkpatch.pl warning about "Alignment should match open parenthesis" becasue parenthesis were removed by this patch. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc

Re: [PATCH] staging: dgnc: replace dgnc_offset_table with bit shift.

2016-03-25 22:15 GMT+09:00 walter harms <wha...@bfs.de>: > > > Am 25.03.2016 12:33, schrieb Daeseok Youn: >> the dgnc_offset_table has a same value with (1 << port). >> So I tried to replace dgnc_offset_table array with 1 << port. >> And also there a

[PATCH] staging: dgnc: replace dgnc_offset_table with bit shift.

the dgnc_offset_table has a same value with (1 << port). So I tried to replace dgnc_offset_table array with 1 << port. And also there are redundant assignments(tmp and current_port) inside while loop for checking uart port, and remove them. Signed-off-by: Daeseok Youn <daeseok

Re: [PATCH 1/2] staging: dgnc: fix 'line over 80 characters'

2016-03-25 12:19 GMT+09:00 Joe Perches <j...@perches.com>: > On Fri, 2016-03-25 at 11:44 +0900, Daeseok Youn wrote: >> fix checkpatch.pl warning about 'line over 80 characters' >> in dgnc_neo.c > [] >> diff --git a/drivers/staging/dgnc/dgnc_neo.c >&g

[PATCH 2/2] staging: dgnc: fix Logical continuations should be on the

fix checkpatch.pl warning about 'Logical continuations should be on the previous line' in dgnc_neo.c file. I think the 'force' need to check first, because if the 'force' is true, it doesn't need to call another function call. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- d

[PATCH 1/2] staging: dgnc: fix 'line over 80 characters'

fix checkpatch.pl warning about 'line over 80 characters' in dgnc_neo.c Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_neo.c | 66 +++-- 1 file changed, 44 insertions(+), 22 deletions(-) diff --git a/drivers/stagin

[PATCH 2/2] staging: dgnc: remove unused variable in dgnc_board

TtyRefCnt was not used anywhere in dgnc. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h index 3d8e15f..44216ae

[PATCH 1/2] staging: dgnc: fix CamelCase in dgnc_drvier.h and

fix checkpatch.pl warning about CamelCase Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 12 ++-- drivers/staging/dgnc/dgnc_tty.c| 32 2 files changed, 22 insertions(+), 22 deletions(-) diff

[PATCH V2] staging: dgnc: fix CamelCase in dgnc_driver.c

fix checkpatch.pl warning about CamelCase. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- V2: fix build errors reported by kbuild test robot. And also save the attached .config file to my linux build tree. build successfully without any errors. drivers/stagin

[PATCH] staging: dgnc: fix CamelCase in dgnc_driver.c

fix checkpatch.pl warning about CamelCase. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.c | 52 +++--- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/d

Re: [PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc

2016-03-22 22:02 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Tue, Mar 22, 2016 at 04:40:24PM +0900, DaeSeok Youn wrote: >> 2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: >> > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote: &g

Re: [PATCH] staging: dgnc: fix camelcase of SerialDriver and PrintDriver

is module. (I had been fixing issues dgap module that was removed in linux-next branch. dgnc has same issues what dgap has. I can also fix issues in dgnc module.) Thanks for comment. regards, Daeseok. > > just my two cents > > re, > wh > > Am 22.03.2016 10:20, schrieb Daese

[PATCH] staging: dgnc: fix camelcase of SerialDriver and PrintDriver

fix the checkpatch.pl warning about CamelCase. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c| 118 ++--- 2 files changed, 61 insertions(+), 61 deletions(-) diff

Re: [PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc

2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote: >> the tty_alloc_driver() can allocate memory for ttys and termios. >> And also it can release allocated memory easly with using >> put_tty

Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct

2016-03-22 6:05 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote: >> For using tty_alloc_driver, SerialDriver has to be pointer type. > > Yes, but you aren't calling tty_alloc_driver, so this patch totally >

Re: [PATCH 1/3] staging: dgnc: fix camelcase of SerialDriver and

2016-03-22 6:02 GMT+09:00 Greg KH <gre...@linuxfoundation.org>: > On Mon, Mar 14, 2016 at 01:28:01PM +0900, Daeseok Youn wrote: >> Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> > > Your subject: does not make sense, and I can't take a patch without any > cha

[PATCH 2/3] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc

[PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 86 +++-- 1 file chang

[PATCH 1/3] staging: dgnc: fix camelcase of SerialDriver and

Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c| 118 ++--- 2 files changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/d

Re: [PATCH 2/2] Staging: dgap: modified the block comments

2016-03-10 17:21 GMT+09:00 Tanvi Surana : > I have modified the file dgap.c ,making changes to the multiline > comments,thus making them appear presentable > > Signed-Off-By: Tanvi Surana > --- > drivers/staging/dgap/dgap.c | 59 >

[PATCH 2/2 V2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- V2: removes appended email header on top of commit log drivers/staging/dgnc/dgnc_tty.

[PATCH 1/2 V2] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- V2: removes appended email header on top of commit log drivers/stagin

Re: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct

2016-03-07 16:10 GMT+09:00 Sudip Mukherjee <sudipm.mukher...@gmail.com>: > > On Mon, Feb 29, 2016 at 11:15:51AM +0900, Daeseok Youn wrote: > > From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 > > From: Daeseok Youn <daeseok.y...@gmail.com> >

[PATCH 2/2 v2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- v2 : typo in subject, changed from dgap to dgnc drivers/staging/dgnc/dgnc_tty.

[PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc

>From 60b1e6e5d9401f10f584928d4feeb8a3b72b46a9 Mon Sep 17 00:00:00 2001 From: Daeseok Youn <daeseok.y...@gmail.com> Date: Mon, 29 Feb 2016 11:04:02 +0900 Subject: [PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc the tty_alloc_driver() can allocate memory for ttys an

[PATCH 1/2] staging: dgnc: use pointer type of tty_struct

>From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 From: Daeseok Youn <daeseok.y...@gmail.com> Date: Thu, 25 Feb 2016 14:53:37 +0900 Subject: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct For using tty_alloc_driver, SerialDriver has to be pointer type. It

[PATCH] staging: dgap: fix if statement that always evaluates to true

cppcheck warning: (warnning) Logical disjunction always evaluates to true Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

Re: staging/dgap/dgap.c:981: bad if test ?

that are ccon and epc. If configuration file has another type for concentrator, returns -1 but it always return an error. Thanks for reporting. regards, Daeseok Youn. commit f6aa0164cd3b1c5192e87f5651ec382c3bc3abac Author: Daeseok Youn daeseok.y...@gmail.com Date: Sat Aug 9 14:38:41 2014 +0900

[PATCH] staging: dgap: use gotos for handling error in dgap_remap()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index bdb5317..518ab56 100644 --- a/drivers/staging

[PATCH 1/4] staging: dgap: set tty's flags by tty_alloc_driver()

tty's flags can be set by calling tty_alloc_driver(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index aa393d2

[PATCH 2/4] staging: dgap: fix memory leak caused by double allocation of tty_structs

The tty_struct of serial_driver and print_driver were getting allocated twice. One is allocated in tty_alloc_driver(), the other is in dgap_tty_register(). So remove these in dgap_tty_register(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 16

[PATCH 3/4] staging: dgap: remove useless variables for saving tty's major

The board_t has a tty_struct(serial_driver and print_driver) that has a major number. When major number is compared in dgap_tty_open(), just use brd-serial_driver{print_driver}-major. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |9 ++--- drivers

[PATCH 4/4] staging: dgap: introducing find_board_by_major()

use find_board_by_major function instead of getting a brd from static arrary. Becasue tty's major number doesn't start zero and we can find a brd from dgap_board[]. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 28 +--- 1 files

[PATCH] staging: dgap: remove unnecessary function

The dgap_init_global() initialize the dgap_board that is a global variable as static and dgap_poll_timer. But init_timer() is called twice in dgap_start() and dgap_board doesn't need to be initialized to NULL. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c

Re: [PATCH V2] staging: dgap: re-arrange functions for removing forward declarations

Hi, 2014-10-31 5:33 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell ma...@compro.net Signed-off-by: Daeseok Youn daeseok.y...@gmail.com Tested

Re: [PATCH RESEND] staging: dgap: re-arrange functions for removing forward declarations

Hi, 2014-10-29 18:22 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell ma...@compro.net Signed-off-by: Daeseok Youn daeseok.y...@gmail.com

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

Hi, 2014-10-14 11:19 GMT+09:00 Joe Perches j...@perches.com: On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote: On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch has too many changes for re

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

Hi, 2014-10-13 23:56 GMT+09:00 Joe Perches j...@perches.com: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing

Re: [PATCH V2] staging: dgap: introduce dgap_stop()

Hi, 2014-10-09 19:23 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote: On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote: The dgap_init_module() need to unwind for cleanup variables properly. Because

[PATCH 1/3] staging: dgap: remove unnecessary if statement for checking NULL

dgap_release_remap() function is only called after the memory has been remapped so if statement for checking NULL doesn't need. And also release_mem_region() calls are moved after iounmap() calls. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 13

[PATCH 2/3] staging: dgap: change function names properly

dgap_do_remap() and dgap_release_remap() names could be changed to dgap_remap() and dgap_unmap(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 3/3] staging: dgap: introduce dgap_stop()

The dgap_init_module() need to unwind for cleanup variables properly. Because dgap_init_module() calls dgap_cleanup_module() for freeing variables but this function is possible to free variables which are not allocated. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap

Re: [PATCH 3/3] staging: dgap: introduce dgap_stop()

Hi, Dan 2014-10-08 20:37 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: All three of these patches are good and a nice improvement. This one is a good bugfix. I have some notes for later, though below. On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote: diff --git a/drivers

[PATCH V2] staging: dgap: introduce dgap_stop()

The dgap_init_module() need to unwind for cleanup variables properly. Because dgap_init_module() calls dgap_cleanup_module() for freeing variables but this function is possible to free variables which are not allocated. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: change ulong which

Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board()

2014-09-25 16:50 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Thu, Sep 25, 2014 at 09:26:47AM +0900, DaeSeok Youn wrote: Hi, 2014-09-24 18:45 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote: static void

Re: [PATCH 2/3] staging: dgap: adds missing iounmap for re_map_port in dgap_release_remap()

Hi, 2014-09-24 18:42 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Wed, Sep 24, 2014 at 12:36:48PM +0300, Dan Carpenter wrote: On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote: Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |1

Re: [PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board()

Hi, 2014-09-24 18:45 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote: static void dgap_release_remap(struct board_t *brd) { - release_mem_region(brd-membase, 0x20); - release_mem_region(brd-membase + PCI_IO_OFFSET

[PATCH 1/3] staging: dgap: remove unused 'runwait' variable

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |1 - drivers/staging/dgap/dgap.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index db8ccd1..779d144 100644 --- a/drivers

[PATCH 3/3] staging: dgap: use dgap_release_remap() in dgap_cleanup_board()

Just simply use dgap_release_remap() in dgap_cleanup_board() for releasing map memory. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 25 ++--- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/staging/dgap/dgap.c

[PATCH 2/3] staging: dgap: adds missing iounmap for re_map_port in dgap_release_remap()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 779d144..637ea8a 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers

Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

Hi, 2014-09-16 15:31 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote: @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty, struct file *file) * Go to sleep to ensure RTS/DTR

[PATCH V2] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

on dgap_tty_init(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: remove singal_pending(). drivers/staging/dgap/dgap.c | 37 +++-- drivers/staging/dgap/dgap.h |3 --- 2 files changed, 7 insertions(+), 33 deletions(-) diff --git a/drivers/staging/dgap

[PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep()

on dgap_tty_init(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 36 ++-- drivers/staging/dgap/dgap.h |3 --- 2 files changed, 6 insertions(+), 33 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH 1/2] staging: dgap: remove redundant setting a variable

The brd(board_t) is initialized with zero, so intr_used is not needed to set zero when request_irq() is failed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap

[PATCH 2/2] staging: dgap: remove useless a variable within board_t

The use_interrupts is used only in dagp_request_irq() for checking a value from user config file. It doesn't need in board_t struct. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |4 +--- drivers/staging/dgap/dgap.h |1 - 2 files changed, 1 insertions

[PATCH 1/7 V2] staging: dgap: remove useless variable

, various allocated variables in a board will free properly. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: update change log. drivers/staging/dgap/dgap.c | 48 +- drivers/staging/dgap/dgap.h |3 -- 2 files changed, 20 insertions(+), 31

Re: [PATCH 1/7] staging: dgap: remove useless variable

Hi, Dan 2014-08-11 19:56 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote: dgap_major_serial_registered and dgap_major_transparent_print_registered could be checked whether a board is initialized. But it doesn't need to check

[PATCH 2/7] staging: dgap: remove redundant declarations.

These are already defined in dgap.h. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 55c06c9..b1253c0 100644

[PATCH 1/7] staging: dgap: remove useless variable

dgap_major_serial_registered and dgap_major_transparent_print_registered could be checked whether a board is initialized. But it doesn't need to check that variables becasue dgap module isn't calling the dgap_cleanup_tty() without initializing for a board completely. Signed-off-by: Daeseok Youn

[PATCH 3/7] staging: dgap: cleanup duplicated warning message on dgap_tty_init()

If true_count is not same with brd-nasync, warning messages are printed. But it has duplicated messages within if statement. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git

[PATCH 4/7] staging: dgap: Simplify set a board type from configration file

. The dgap_gettok() returns that number so just set to board.type and also v_type can be removed. In case of boards of PCI type are set variables to zero. These can be removed because p as cnode get memory from kzalloc so already set to zero. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com

[PATCH 5/7] staging: dgap: Simplify to set a concentrator type

need to conc.v_type. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 26 +++--- drivers/staging/dgap/dgap.h |1 - 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c

[PATCH 6/7] staging: dgap: Simplify to set a module type

It is same manner with setting a board type. After allocating a type of MNODE, get a token value set to module.type. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 26 +++--- drivers/staging/dgap/dgap.h |1 - 2 files changed, 7

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

Hi, Mark and Greg. Thanks for testing. :-) Greg, is this patch possible to merge to your staging tree? Please check for me. patch : https://lkml.org/lkml/2014/7/31/2 Thanks. regards, Daeseok Youn. 2014-08-04 21:40 GMT+09:00 Mark Hounschell ma...@compro.net: On 07/31/2014 07:14 PM, DaeSeok

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

2014-08-05 8:38 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Tue, Aug 05, 2014 at 08:33:16AM +0900, DaeSeok Youn wrote: Hi, Mark and Greg. Thanks for testing. :-) Greg, is this patch possible to merge to your staging tree? Please check for me. patch : https://lkml.org/lkml/2014/7/31/2

Re: [PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

Hi, Mark 2014-07-31 21:44 GMT+09:00 Mark Hounschell ma...@compro.net: On 07/31/2014 12:02 AM, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving

[PATCH V2] staging: dgap: introduce dgap_cleanup_nodes()

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

Re: [PATCH] staging: dgap: introduce dgap_cleanup_nodes()

Hi, Mark. Thanks for testing. I am trying to solve this problem with config sample which is sent by you. regards, Daeseok Youn. 2014-07-17 22:27 GMT+09:00 Mark Hounschell ma...@compro.net: On 07/16/2014 09:35 PM, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: Hi, 2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote: The dgap_err() is printing a message

<    1   2   3   4   5   >