Re: [PATCH 00/37] net: manually convert files to ReST format - part 2

2020-04-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Thu, 30 Apr 2020 18:03:55 +0200 > That's the second part of my work to convert the networking > text files into ReST. it is based on today's linux-next (next-20200430). > > The full series (including those ones) are at: > >

Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

2019-12-12 Thread David Miller
From: Scott Schafer Date: Thu, 12 Dec 2019 09:02:00 -0600 > On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: >> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: >> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct >> > mbox_params *mbcp) >>

Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging

2019-12-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 9 Dec 2019 16:12:56 +0100 > syzbot keeps finding issues in the X.25 implementation that nobody is > interested in fixing. Given that all the x25 patches of the past years > that are not global cleanups tend to fix user-triggered oopses, is it > time to just

Re: [PATCH 1/2] staging: remove isdn capi drivers

2019-12-09 Thread David Miller
From: Greg Kroah-Hartman Date: Mon, 9 Dec 2019 16:37:43 +0100 > On Mon, Dec 09, 2019 at 04:11:13PM +0100, Arnd Bergmann wrote: >> As described in drivers/staging/isdn/TODO, the drivers are all >> assumed to be unmaintained and unused now, with gigaset being the >> last one to stop being

Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver

2019-11-04 Thread David Miller
From: Greg KH Date: Mon, 4 Nov 2019 13:20:09 +0100 > Why is this being submitted to staging? What is wrong with the "real" > part of the kernel for this? Agreed, this makes no sense at all. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] hp100: Move 100BaseVG AnyLAN driver to staging

2019-10-31 Thread David Miller
From: Joe Perches Date: Thu, 31 Oct 2019 11:23:37 -0700 > 100BaseVG AnyLAN hasn't been useful since 1996 or so and even then > didn't sell many devices. It's unlikely any are still in use. > > Move the driver to staging with the intent of removing it altogether > one day. > > Signed-off-by:

Re: [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors

2019-08-06 Thread David Miller
From: Nathan Chancellor Date: Fri, 2 Aug 2019 23:01:56 -0700 > After commit 171a9bae68c7 ("staging/octeon: Allow test build on > !MIPS"), the following combination of configs cause a few Kconfig > warnings and build errors (distilled from arm allyesconfig and Randy's > randconfig builds): > >

Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning

2019-08-02 Thread David Miller
From: Nathan Chancellor Date: Wed, 31 Jul 2019 11:50:24 -0700 > arm allyesconfig warns: > > WARNING: unmet direct dependencies detected for MDIO_OCTEON > Depends on [n]: NETDEVICES [=y] && MDIO_DEVICE [=y] && MDIO_BUS [=y] > && 64BIT && HAS_IOMEM [=y] && OF_MDIO [=y] > Selected by [y]: >

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread David Miller
From: Nathan Chancellor Date: Wed, 31 Jul 2019 09:35:09 -0700 > In file included from ../drivers/net/phy/mdio-octeon.c:14: > ../drivers/net/phy/mdio-cavium.h:111:36: error: implicit declaration of > function 'writeq'; did you mean 'writeb'? > [-Werror=implicit-function-declaration] > 111 |

Re: [PATCH v2] staging/octeon: Fix build error without CONFIG_NETDEVICES

2019-07-31 Thread David Miller
From: Greg KH Date: Wed, 31 Jul 2019 18:02:19 +0200 > From: YueHaibing > > While do COMPILE_TEST build without CONFIG_NETDEVICES, > we get Kconfig warning: > > WARNING: unmet direct dependencies detected for PHYLIB > Depends on [n]: NETDEVICES [=n] > Selected by [y]: > - OCTEON_ETHERNET

Re: next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731)

2019-07-31 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 31 Jul 2019 13:35:22 +0200 > On Wed, Jul 31, 2019 at 12:24:41PM +0100, Mark Brown wrote: >> On Wed, Jul 31, 2019 at 04:07:41AM -0700, kernelci.org bot wrote: >> >> Today's -next fails to build an ARM allmodconfig due to: >> >> > allmodconfig (arm, gcc-8) ―

Re: [PATCH v5 12/29] compat_ioctl: move drivers to compat_ptr_ioctl

2019-07-30 Thread David Miller
From: Arnd Bergmann Date: Tue, 30 Jul 2019 21:50:28 +0200 > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg

Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET

2019-07-24 Thread David Miller
From: YueHaibing Date: Wed, 24 Jul 2019 21:01:26 +0800 > Now if CONFIG_ETHERNET is not set, QLGE driver > building fails: > > drivers/staging/qlge/qlge_main.o: In function `qlge_remove': > drivers/staging/qlge/qlge_main.c:4831: undefined reference to > `unregister_netdev' > > Reported-by:

Re: [PATCH] qlge: Fix build error without CONFIG_ETHERNET

2019-07-24 Thread David Miller
From: David Miller Date: Wed, 24 Jul 2019 14:12:02 -0700 (PDT) > From: YueHaibing > Date: Wed, 24 Jul 2019 21:01:26 +0800 > >> Now if CONFIG_ETHERNET is not set, QLGE driver >> building fails: >> >> drivers/staging/qlge/qlge_main.o: In function `qlge

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-11 Thread David Miller
From: Joe Perches Date: Tue, 9 Jul 2019 22:04:13 -0700 > These GENMASK uses are inverted argument order and the > actual masks produced are incorrect. Fix them. > > Add checkpatch tests to help avoid more misuses too. Patches #7 and #8 applied to 'net', with appropriate Fixes tags added to

Re: [GIT PULL net-next, resend] isdn: deprecate non-mISDN drivers

2019-06-02 Thread David Miller
From: Arnd Bergmann Date: Fri, 31 May 2019 14:32:52 +0200 > [resending, rebased on top of today's net-next] > > The following changes since commit 7b3ed2a137b077bc0967352088b0adb6049eed20: > > Merge branch '100GbE' of > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue >

Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes

2019-05-07 Thread David Miller
From: Petr Štetiar Date: Mon, 6 May 2019 23:24:43 +0200 > this patch series is an attempt to fix the mess, I've somehow managed to > introduce. > > First patch in this series is defacto v5 of the previous 05/10 patch in the > series, but since the v4 of this 05/10 patch wasn't picked up by the

Re: [PATCH net-next] switchdev: Remove unused transaction item queue

2019-03-01 Thread David Miller
From: Florian Fainelli Date: Wed, 27 Feb 2019 16:29:16 -0800 > There are no more in tree users of the > switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure > in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API > and implementation to be switchdev

Re: [PATCH net-next v3 0/8] net: Remove switchdev_ops

2019-02-27 Thread David Miller
From: Florian Fainelli Date: Wed, 27 Feb 2019 11:44:24 -0800 > This patch series completes the removal of the switchdev_ops by > converting switchdev_port_attr_set() to use either the blocking > (process) or non-blocking (atomic) notifier since we typically need to > deal with both depending on

Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Feb 2019 16:37:38 -0800 > David, please ignore this version, I will repost one that actually > builds, need to keep mangling with my kernel configuration and keep > those drivers enabled... Ok. ___ devel mailing

Re: [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS

2019-02-12 Thread David Miller
From: Florian Fainelli Date: Mon, 11 Feb 2019 13:17:46 -0800 > AFAICT there is no code that attempts to get the value of the attribute > SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with > switchdev_port_attr_set(). > > This is effectively no doing anything and it can slow down future

Re: [PATCH net-next v4 0/9] net: Remove switchdev_ops

2019-02-11 Thread David Miller
From: Florian Fainelli Date: Mon, 11 Feb 2019 11:09:52 -0800 > David, I would like to get Ido's feedback on this to make sure I did not > miss something, thank you! Ok, Ido please look at this when you can. ___ devel mailing list

Re: [PATCH net-next v3 0/9] net: Remove switchdev_ops

2019-02-11 Thread David Miller
From: Florian Fainelli Date: Mon, 11 Feb 2019 09:31:42 -0800 > David, I will be reposting a v4 with Jiri's Acked-by as well as adding > fallthrough switch/case annotations so we don't regress on that front. > Thank you. Ok, thanks for letting me know.

Re: [PATCH net-next v2 00/16] net: Remove switchdev_ops

2019-02-10 Thread David Miller
From: Florian Fainelli Date: Sun, 10 Feb 2019 12:44:47 -0800 > I am going to submit a v3 which moves the port_attr_{get,set} to a > switchdev notifier, but does not yet get rid of > switchdev_port_attr_get() entirely since there is not a clear path yet > to split the setting between non-sleeping

Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-06 Thread David Miller
From: David Miller Date: Wed, 06 Feb 2019 13:50:50 -0800 (PST) > From: Florian Fainelli > Date: Wed, 6 Feb 2019 09:45:34 -0800 > >> Based on discussion with Ido and feedback from Jakub there are clearly >> two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARE

Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-06 Thread David Miller
From: Florian Fainelli Date: Wed, 6 Feb 2019 09:45:34 -0800 > Based on discussion with Ido and feedback from Jakub there are clearly > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > > - PF/VF drivers which typically only implement return the port's parent > ID, yet

Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled

2018-12-24 Thread David Miller
From: Florian Westphal Date: Fri, 21 Dec 2018 21:57:26 +0100 > skb->sp doesn't exist anymore in the next-next tree, so mips defconfig > no longer builds. Use helper instead to reset the secpath. > > Not even compile tested. > > Cc: Greg Kroah-Hartman > Reported-by: Guenter Roeck > Fixes:

Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-20 Thread David Miller
From: Sergio Paracuellos Date: Wed, 19 Dec 2018 20:46:26 +0100 > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos I am assuming the devicetree folks will take this into their tree or similar. If

Re: [PATCH net-next 0/8] Pass extack to NETDEV_PRE_UP

2018-12-05 Thread David Miller
Your CC list is so huge that vger.kernel.org dropped all of your postings. That CC list is not reasonable at all, trim it down to the most minimum set. Probably 2 or 3 mailing lists, primarily netdev, and maybe a small handful of specific developers. Nothing more.

Re: [PATCH net-next 00/12] switchdev: Convert switchdev_port_obj_{add,del}() to notifiers

2018-11-23 Thread David Miller
From: Petr Machata Date: Thu, 22 Nov 2018 23:27:52 + > An offloading driver may need to have access to switchdev events on > ports that aren't directly under its control. An example is a VXLAN port > attached to a bridge offloaded by a driver. The driver needs to know > about VLANs

Re: [PATCH net-next 0/4] VLAN tag handling cleanup

2018-11-21 Thread David Miller
From: Michał Mirosław Date: Tue, 20 Nov 2018 13:20:30 +0100 > This is a cleanup set after VLAN_TAG_PRESENT removal. The CFI bit > handling is made similar to how other tag fields are used. Series applied, thanks. ___ devel mailing list

Re: [PATCH net-next,v3] hv_netvsc: fix vf serial matching with pci slot info

2018-10-15 Thread David Miller
From: Haiyang Zhang Date: Mon, 15 Oct 2018 19:06:15 + > From: Haiyang Zhang > > The VF device's serial number is saved as a string in PCI slot's > kobj name, not the slot->number. This patch corrects the netvsc > driver, so the VF device can be successfully paired with synthetic > NIC. >

Re: [v3, 6/6] net: dpaa2: fix and improve dpaa2-ptp driver

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:30 +0800 > This patch is to fix and improve dpaa2-ptp driver > in some places. > > - Fixed the return for some functions. > - Replaced kzalloc with devm_kzalloc. > - Removed dev_set_drvdata(dev, NULL). > - Made ptp_dpaa2_caps const. > >

Re: [v3, 3/6] net: dpaa2: fix dependency of config FSL_DPAA2_ETH

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:27 +0800 > The NETDEVICES dependency and ETHERNET dependency hadn't > been required since dpaa2-eth was moved out of staging. > Also allowed COMPILE_TEST for dpaa2-eth. > > Signed-off-by: Yangbo Lu Applied.

Re: [v3, 5/6] net: dpaa2: remove unused code for dprtc

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:29 +0800 > This patch is to removed unused code for dprtc. > This code will be re-added along with more features > of dpaa2-ptp added. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list

Re: [v3, 4/6] net: dpaa2: rename rtc as ptp in dpaa2-ptp driver

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:28 +0800 > In dpaa2-ptp driver, it's odd to use rtc in names of > some functions and structures except these dprtc APIs. > This patch is to use ptp instead of rtc in names. > > Signed-off-by: Yangbo Lu Applied.

Re: [v3, 2/6] MAINTAINERS: update files maintained under DPAA2 PTP/ETHERNET

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:26 +0800 > The files maintained under DPAA2 PTP/ETHERNET needs to > be updated since dpaa2 ptp driver had been moved into > drivers/net/ethernet/freescale/dpaa2/. > > Signed-off-by: Yangbo Lu Applied. ___

Re: [v3, 1/6] net: dpaa2: move DPAA2 PTP driver out of staging/

2018-10-08 Thread David Miller
From: Yangbo Lu Date: Mon, 8 Oct 2018 15:44:25 +0800 > This patch is to move DPAA2 PTP driver out of staging/ > since the dpaa2-eth had been moved out. > > Signed-off-by: Yangbo Lu Applied. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet_info internal field initialization

2018-10-02 Thread David Miller
From: Haiyang Zhang Date: Fri, 28 Sep 2018 14:41:23 + > From: Haiyang Zhang > > The RSC feature -- a bit field "internal" was added here with total > size unchanged: > struct rndis_per_packet_info { > u32 size; > u32 type:31; > u32 internal:1; > u32 ppi_offset; > };

Re: [PATCH net-next,v2,0/3] hv_netvsc: Support LRO/RSC in the vSwitch

2018-09-22 Thread David Miller
From: Haiyang Zhang Date: Fri, 21 Sep 2018 18:20:34 + > From: Haiyang Zhang > > The patch adds support for LRO/RSC in the vSwitch feature. It reduces > the per packet processing overhead by coalescing multiple TCP segments > when possible. The feature is enabled by default on VMs running

Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 20:32:44 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [PATCH v2 0/2] hv_netvsc: associate VF and PV device by serial number

2018-09-17 Thread David Miller
From: Stephen Hemminger Date: Fri, 14 Sep 2018 12:54:55 -0700 > The Hyper-V implementation of PCI controller has concept of 32 bit serial > number > (not to be confused with PCI-E serial number). This value is sent in the > protocol > from the host to indicate SR-IOV VF device is attached to

Re: [PATCH net-next 1/2] PCI: hv: support reporting serial number as slot information

2018-09-01 Thread David Miller
From: Stephen Hemminger Date: Wed, 29 Aug 2018 09:24:51 -0700 > + spin_lock_irqsave(>device_list_lock, flags); > + list_for_each_entry(hpdev, >children, list_entry) { > + if (hpdev->pci_slot) > + continue; > + > + slot_nr =

Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver

2018-09-01 Thread David Miller
From: Ioana Radulescu Date: Wed, 29 Aug 2018 04:42:38 -0500 > The Freescale/NXP DPAA2 Ethernet driver was first included in > drivers/staging, due to its dependencies on two components located > there at the time of its initial submission: > * the fsl-mc bus driver, which was moved to

Re: [PATCH v2] hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()

2018-09-01 Thread David Miller
From: Dexuan Cui Date: Thu, 30 Aug 2018 05:42:13 + > > This patch fixes the race between netvsc_probe() and > rndis_set_subchannel(), which can cause a deadlock. > > These are the related 3 paths which show the deadlock: ... > Before path #1 finishes, path #2 can start to run, because

Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()

2018-08-29 Thread David Miller
From: Dexuan Cui Date: Thu, 30 Aug 2018 00:58:48 + >> From: David Miller >> Sent: Wednesday, August 29, 2018 17:49 >> >> From: Dexuan Cui >> Date: Wed, 22 Aug 2018 21:20:03 + >> >> > --- >> > drivers/net/hyperv/netvsc_drv.c | 11

Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe()

2018-08-29 Thread David Miller
From: Dexuan Cui Date: Wed, 22 Aug 2018 21:20:03 + > --- > drivers/net/hyperv/netvsc_drv.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > > FYI: these are the related 3 paths which show the deadlock: This incredibly useful information belongs in the commit log

Re: [PATCH] hv/netvsc: Fix NULL dereference at single queue mode fallback

2018-08-14 Thread David Miller
From: Takashi Iwai Date: Tue, 14 Aug 2018 19:10:50 +0200 > The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback > to single queue mode") tried to fix the fallback behavior to a single > queue mode, but it changed the function to return zero incorrectly, > while the function

Re: [PATCH v4 net-next] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-07-30 Thread David Miller
From: Yidong Ren Date: Mon, 30 Jul 2018 17:09:45 + > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters already exist in current code. Exposing > these counters

Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes

2018-07-23 Thread David Miller
] v4l: omap4iss: Add support for OMAP4 camera > interface - Video devices") > Suggested-by: Linus Torvalds > Cc: David Miller > Cc: Randy Dunlap > Signed-off-by: Guenter Roeck Acked-by: David S. Miller ___ devel mailin

Re: [PATCH net,v2] hv_netvsc: Fix napi reschedule while receive completion is busy

2018-07-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Jul 2018 17:11:13 + > From: Haiyang Zhang > > If out ring is full temporarily and receive completion cannot go out, > we may still need to reschedule napi if certain conditions are met. > Otherwise the napi poll might be stopped forever, and cause network

Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync

2018-06-30 Thread David Miller
From: Haiyang Zhang Date: Fri, 29 Jun 2018 14:07:16 -0700 > From: Stephen Hemminger > > When doing device hotplug the sub channel must be async to avoid > deadlock issues because device is discovered in softirq context. > > When doing changes to MTU and number of channels, the setup > must be

Re: [PATCH net] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

2018-06-14 Thread David Miller
From: Haiyang Zhang Date: Thu, 14 Jun 2018 18:29:09 -0700 > From: Haiyang Zhang > > These fields in struct ndis_ipsecv2_offload and struct ndis_rsc_offload > are one byte according to the specs. This patch defines them with the > right size. These structs are not in use right now, but will be

Re: [PATCH net-next] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

2018-06-14 Thread David Miller
Bug fixes should be targetted at net, not net-next. Furthermore, net-next is closed. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net 0/3] hv_netvsc: notification and namespace fixes

2018-06-12 Thread David Miller
From: Stephen Hemminger Date: Mon, 11 Jun 2018 12:44:53 -0700 > This set of patches addresses two set of fixes. First it backs out > the common callback model which was merged in net-next without > completing all the review feedback or getting maintainer approval. > > Then it fixes the

Re: [PATCH] hv_netvsc: Add per-cpu ethtool stats for netvsc

2018-06-07 Thread David Miller
From: Yidong Ren Date: Wed, 6 Jun 2018 15:27:00 -0700 > From: Yidong Ren > > This patch implements following ethtool stats fields for netvsc: > cpu_tx/rx_packets/bytes > cpu_vf_tx/rx_packets/bytes > > Corresponding per-cpu counters exist in current code. Exposing these > counters will help

Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup

2018-06-07 Thread David Miller
From: Dexuan Cui Date: Wed, 6 Jun 2018 21:32:51 + > > Recently people reported the NIC stops working after > "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not > enabled, after the refactoring of the common detach logic: when the NIC > has sub-channels, usually we

Re: [PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()

2018-06-03 Thread David Miller
From: Wei Yongjun Date: Thu, 31 May 2018 02:04:43 + > Fix to return a negative error code from the failover register fail > error handling case instead of 0, as done elsewhere in this function. > > Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use > the failover

Re: [PATCH net-next v4 0/8] net: bridge: Notify about bridge VLANs

2018-05-31 Thread David Miller
From: Petr Machata Date: Wed, 30 May 2018 02:55:34 +0200 > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced

Re: [PATCH net-next] hv_netvsc: Add handlers for ethtool get/set msg level

2018-05-23 Thread David Miller
From: Haiyang Zhang Date: Tue, 22 May 2018 11:29:34 -0700 > From: Haiyang Zhang > > The handlers for ethtool get/set msg level are missing from netvsc. > This patch adds them. > > Signed-off-by: Haiyang Zhang

Re: [PATCH v2] hv_netvsc: Fix net device attach on older Windows hosts

2018-05-10 Thread David Miller
From: Mohammed Gamal Date: Wed, 9 May 2018 10:17:34 +0200 > On older windows hosts the net_device instance is returned to > the caller of rndis_filter_device_add() without having the presence > bit set first. This would cause any subsequent calls to network device >

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation

2018-04-18 Thread David Miller
From: Haiyang Zhang Date: Tue, 17 Apr 2018 15:31:47 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 and 6.1 message structures, and includes > these versions into NetVSC/NetVSP version negotiation process. > > Signed-off-by:

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

2018-04-11 Thread David Miller
From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 > Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Also, all of your networking submissions have been dropped

Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

2018-04-05 Thread David Miller
From: Mohammed Gamal Date: Thu, 5 Apr 2018 21:09:17 +0200 > Guests running on WS2012 hosts would not shutdown when changing network > interface setting (e.g. Number of channels, MTU ... etc). > > This patch series addresses these shutdown issues we enecountered with WS2012

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

2018-04-05 Thread David Miller
From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang

Re: [PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

2018-03-31 Thread David Miller
From: Haiyang Zhang Date: Fri, 30 Mar 2018 13:57:59 -0700 > From: Haiyang Zhang > > The variables, msg and data, have the same value. This patch removes > the extra one. > > Signed-off-by: Haiyang Zhang Applied.

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-26 Thread David Miller
From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > >

Re: [PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-25 Thread David Miller
From: Haiyang Zhang Date: Thu, 22 Mar 2018 12:01:12 -0700 > Fix the status code returned to the host. Also add range > check for rx packet offset and length. Series applied, thank you. ___ devel mailing list

Re: [PATCH PATCH net 0/4] hv_netvsc: fix races during shutdown and changes

2018-03-22 Thread David Miller
From: Stephen Hemminger Date: Tue, 20 Mar 2018 15:03:01 -0700 > This set of patches fixes issues identified by Vitaly Kuznetsov and > Mohammed Gamal related to state changes in Hyper-v network driver. > > A lot of the issues are because setting up the netvsc device

Re: [PATCH net-next 0/2] hv_netvsc: minor enhancements

2018-03-17 Thread David Miller
From: Stephen Hemminger Date: Fri, 16 Mar 2018 15:44:26 -0700 > A couple of small things for net-next Series applied, thanks Stephen. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

2018-03-16 Thread David Miller
From: Mohammed Gamal Date: Tue, 13 Mar 2018 20:06:50 +0100 > Dring high network traffic changes to network interface parameters > such as number of channels or MTU can cause a kernel panic with a NULL > pointer dereference. This is due to netvsc_device_remove() being > called

Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

2018-03-09 Thread David Miller
From: Mohammed Gamal Date: Fri, 9 Mar 2018 12:22:22 +0100 > Commit 009f766 intended to filter multicast/broadcast, however > it did cause DHCP timeouts. A closer look showed that the filters > were not set properly causing this issue. > > Fixes: 009f766 ("hv_netvsc: filter

Re: [PATCH PATCH net v2 0/4] hv_netvsc: fix multicast flags and sync

2018-03-08 Thread David Miller
From: Stephen Hemminger Date: Wed, 7 Mar 2018 13:49:08 -0800 > This set of patches deals with the handling of multicast flags > and addresses in transparent VF mode. The recent set of patches > (in linux-net) had a couple of bugs. Series applied, thanks Stephen.

Re: [PATCH PATCH net v2 0/9] hv_netvsc: minor fixes

2018-03-04 Thread David Miller
From: Stephen Hemminger Date: Fri, 2 Mar 2018 13:49:00 -0800 > These are improvements to netvsc driver. They aren't functionality > changes so not targeting net-next; and they are not show stopper > bugs that need to go to stable either. > > v2 >- drop the irq

Re: [PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

2018-01-22 Thread David Miller
From: Haiyang Zhang Date: Fri, 19 Jan 2018 13:26:43 -0700 > From: Haiyang Zhang > > Since we no longer localize channel/CPU affiliation within one NUMA > node, num_online_cpus() is used as the number of channel cap, instead of > the

Re: [PATCH v1 2/4] lib/net_utils: Introduce mac_pton_from_user()

2017-12-20 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 20 Dec 2017 08:13:55 +0100 > On Tue, Dec 19, 2017 at 09:14:10PM +0200, Andy Shevchenko wrote: >> Some drivers are getting MAC from user space. Make a helper for them. >> >> Signed-off-by: Andy Shevchenko

Re: [PATCH net-next 0/6] hv_netvsc: minor changes

2017-12-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 12 Dec 2017 16:48:34 -0800 > This includes minor cleanup of code in send and receive path and > also a new statistic to check for allocation failures. This also > eliminates some of the extra RCU when not needed. > > There is a

Re: [PATCH net-next 0/2] hv_netvsc: Fix default and limit of recv buffe

2017-12-13 Thread David Miller
From: Stephen Hemminger Date: Mon, 11 Dec 2017 08:56:56 -0800 > The default for receive buffer descriptors is not correct, it should > match the default receive buffer size and the upper limit of receive > buffer size is too low. Also, for older versions of Window

Re: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

2017-12-08 Thread David Miller
From: Dan Carpenter Date: Fri, 8 Dec 2017 13:33:25 +0300 > On Thu, Dec 07, 2017 at 04:10:53PM -0800, Stephen Hemminger wrote: >> From: Haiyang Zhang >> >> It should be 31 MB on recent host versions. >> >> Signed-off-by: Haiyang Zhang

Re: [PATCH net-next 0/6] hv_netvsc: minor optimizations

2017-12-03 Thread David Miller
From: Stephen Hemminger Date: Fri, 1 Dec 2017 11:01:43 -0800 > These are a set of local optimizations the Hyper-V networking driver. > Also include a vmbus patch in this set, because it depends on the > netvsc that last used that function. Series applied. For the

Re: [PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-29 Thread David Miller
The net-next tree is closed, please resubmit this when the net-next tree opens again. Thank you. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH net v2] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-15 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 15 Nov 2017 15:12:55 +0100 > rndis_filter_device_add() is called both from netvsc_probe() when we > initially create the device and from set channels/mtu/ringparam > routines where we basically remove the device and add it back. > >

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-15 Thread David Miller
From: Greg KH <g...@kroah.com> Date: Wed, 15 Nov 2017 10:13:18 +0100 > On Wed, Nov 15, 2017 at 09:58:33AM +0900, David Miller wrote: >> From: Stephen Hemminger <step...@networkplumber.org> >> Date: Tue, 14 Nov 2017 08:37:13 -0800 >> >> > These are both o

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

2017-11-14 Thread David Miller
From: Stephen Hemminger Date: Tue, 14 Nov 2017 08:37:13 -0800 > These are both old decrepit protocols that need to be sent > to pasture. These need to go to gregkh and his staging/ tree, not net-next. ___ devel mailing list

Re: [PATCH net-next v2 0/2] hv_netvsc: fix a hang on channel/mtu changes

2017-11-07 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 2 Nov 2017 11:35:29 +0100 > It was found that netvsc driver doesn't survive e.g. > > # while true; do ethtool -L eth0 combined 4; ethtool -L eth0 combined 8; done" > > test. I was able to identify a hang in guest/host communication, it is

Re: [PATCH net-next 3/4] hv_netvsc: reset net_device_ctx->nvdev with rcu_assign_pointer()

2017-10-31 Thread David Miller
From: Vitaly Kuznetsov Date: Tue, 31 Oct 2017 15:40:06 +0100 > Eric Dumazet writes: > >> On Tue, 2017-10-31 at 14:42 +0100, Vitaly Kuznetsov wrote: >>> RCU_INIT_POINTER() is not suitable here as it doesn't give us ordering >>> guarantees (see the

Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-20 Thread David Miller
From: Dexuan Cui Date: Thu, 19 Oct 2017 03:33:14 + > > Without the patch, when hvs_open_connection() hasn't completely established > a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't > inserted the sock into the connected queue),

Re: [PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread David Miller
From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc:

Re: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size

2017-09-25 Thread David Miller
From: Colin King Date: Fri, 22 Sep 2017 16:50:23 +0100 > From: Colin Ian King > > Don't populate const array ver_list on the stack, instead make it > static. Makes the object code smaller by over 400 bytes: > > Before: >text

Re: [PATCH net] netvsc: increase default receive buffer size

2017-09-15 Thread David Miller
From: Stephen Hemminger Date: Thu, 14 Sep 2017 09:31:07 -0700 > The default receive buffer size was reduced by recent change > to a value which was appropriate for 10G and Windows Server 2016. > But the value is too small for full performance with 40G on Azure. >

Re: [PATCH net] netvsc: increase default receive buffer size

2017-09-14 Thread David Miller
From: Stephen Hemminger Date: Thu, 14 Sep 2017 09:31:07 -0700 > The default receive buffer size was reduced by recent change > to a value which was appropriate for 10G and Windows Server 2016. > But the value is too small for full performance with 40G on Azure. >

Re: [PATCH v2 net-next 1/2] hv_netvsc: fix deadlock on hotplug

2017-09-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:05 -0700 > When a virtual device is added dynamically (via host console), then > the vmbus sends an offer message for the primary channel. The processing > of this message for networking causes the network device to

Re: [PATCH v2 net-next 2/2] hv_netvsc: avoid unnecessary wakeups on subchannel creation

2017-09-11 Thread David Miller
From: Stephen Hemminger Date: Wed, 6 Sep 2017 13:53:06 -0700 > Only need to wakeup the initiator after all sub-channels > are opened. > > Signed-off-by: Stephen Hemminger Applied. ___ devel

Re: [PATCH net-next 0/2] netvsc: transparent VF related cleanups

2017-09-01 Thread David Miller
From: Stephen Hemminger Date: Thu, 31 Aug 2017 16:16:11 -0700 > The first gets rid of unnecessary ref counting, and second > allows removing hv_netvsc driver even if VF present. Series applied. ___ devel mailing list

Re: [PATCH v3 net-next] staging: irda: fix init level for irda core

2017-08-30 Thread David Miller
From: Greg KH Date: Wed, 30 Aug 2017 13:16:49 +0200 > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > link order changes when IRDA is built into the kernel. That causes a > kernel crash at boot time as netfilter isn't initialized yet. > >

Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel

2017-08-29 Thread David Miller
From: Greg KH Date: Tue, 29 Aug 2017 19:46:22 +0200 > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > link order changes when IRDA is built into the kernel. That causes a > kernel crash at boot time as netfilter isn't initialized yet. > >

Re: [PATCH net-next] staging: irda: force to be a kernel module

2017-08-29 Thread David Miller
From: Greg KH <gre...@linuxfoundation.org> Date: Tue, 29 Aug 2017 19:26:08 +0200 > On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote: >> From: Greg Kroah-Hartman <gre...@linuxfoundation.org> >> Date: Tue, 29 Aug 2017 11:14:17 +0200 >> >> > N

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-29 Thread David Miller
From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 16:48:50 +0200 > On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Aug 29, 2017

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-29 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 29 Aug 2017 12:59:00 +0200 > Hi Greg, > > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman > wrote: >> The IRDA code has long been obsolete and broken. So, to keep people >> from trying to use it, and to

Re: [PATCH net-next] staging: irda: force to be a kernel module

2017-08-29 Thread David Miller
From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 11:14:17 +0200 > Now that the IRDA networking code has moved into drivers/staging/, the > link order is changed for when it is initialized if built into the > system. This can cause a crash when initializing as the

  1   2   3   4   >