Re: [PATCH] vme: Fix integer overflow checking in vme_check_window()

st U64_MAX. > > Anyway, I put one integer overflow check at the start of the function > and deleted all existing checks. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Acked-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> > > diff --git a/drivers/vme/v

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/18, at 18:04, Martyn Welch <mar...@welchs.me.uk> wrote: > > > > On 18/10/15 18:53, Dmitry Kalinkin wrote: >> On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch <mar...@welchs.me.uk> wrote: >>> >>> On 11/10/15 01:13, Dmitry Ka

Re: [PATCH] vme: 8-bit status/id takes 256 values, not 255

On Sun, Oct 18, 2015 at 9:30 AM, Martyn Welch <mar...@welchs.me.uk> wrote: > On 10 October 2015 at 23:00, Dmitry Kalinkin <dmitry.kalin...@gmail.com> > wrote: >> Fixes an off by one array size. >> > > The Status/ID is an 8-bit value (OK, the standard states

Re: [PATCHv5] staging: vme_user: provide DMA functionality

On Sun, Oct 18, 2015 at 10:31 AM, Martyn Welch <mar...@welchs.me.uk> wrote: > > > On 11/10/15 01:13, Dmitry Kalinkin wrote: >> >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write functionality to the user s

[PATCHv6] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks...@itep.ru> --- v5: Added a validation for dma

Re: [PATCHv5] staging: vme_user: provide DMA functionality

> On 2015/10/17, at 23:52, Greg Kroah-Hartman <gre...@linuxfoundation.org> > wrote: > > On Sun, Oct 11, 2015 at 03:13:25AM +0300, Dmitry Kalinkin wrote: >> This introduces a new dma device that provides a single ioctl call that >> provides DMA read and write f

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

Hi Martyn, Sorry, your comment is too late. This patch is already in staging-next. Dmitri > On 2015/10/10, at 17:35, Martyn Welch <mar...@welchs.me.uk> wrote: > > On 5 October 2015 at 04:59, Dmitry Kalinkin <dmitry.kalin...@gmail.com> wrote: >> The

[PATCHv4 RESEND] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks...@itep.ru> --- In the last reply Martyn sugges

[PATCHv5] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.aleks..

[PATCH] vme: tsi148: silence uninitialized variable warning

: 0b0496625715 ("vme: change bus error handling scheme") Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> --- drivers/vme/bridges/vme_tsi148.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148

Re: [RESEND 3/4] vme: change bus error handling scheme

> On 18 Sep 2015, at 05:46, Martyn Welch <mar...@welchs.me.uk> wrote: > > > > On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote: >> From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> >> >> The current VME bus error handler adds errors to the

Re: [RESEND 3/4] vme: change bus error handling scheme

On Fri, Sep 18, 2015 at 5:46 AM, Martyn Welch <mar...@welchs.me.uk> wrote: > > > On 18/09/15 00:01, dmitry.kalin...@gmail.com wrote: >> >> From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> >> >> The current VME bus error handler adds errors to the

[RESEND 1/4] vme: move tsi148 error handling into VME subsystem

From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Error handling code found in tsi148 is not device specific. In fact it already relies on shared vme_bus_error struct and vme_bridge.vme_errors field. The other bridge driver could reuse this code if it is shared. This introduces a slight be

[RESEND 3/4] vme: change bus error handling scheme

From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> The current VME bus error handler adds errors to the bridge error list. vme_master_{read,write} then traverses that list to look for relevant errors. Such scheme didn't work well for accesses going through vme_master_mmap because they woul

[RESEND 2/4] vme: include address space in error filtering

From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Also changes vme_bus_error_handler to take generic address modifier code instead of raw contents of a device-specific attribute register. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> Cc: Igor Alekseev <igor.a

[RESEND 0/4] VME bus error handling overhaul

From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> This moves tsi148 error handling into VME subsystem so it can be shared with the other bridge driver. Then there is a change to close a fixme on separating errors by address space. And finally a fix for memory leak problem that was intr

[RESEND 4/4] vme: print unhandled VME access errors

From: Dmitry Kalinkin <dmitry.kalin...@gmail.com> This will enable error messages for accesses done through mmap. Signed-off-by: Dmitry Kalinkin <dmitry.kalin...@gmail.com> --- drivers/vme/vme.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vme/vme.c b/drive

Re: [PATCH 0/3] VME bus error handling overhaul

> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2015 at 01:31:47PM +0100, Martyn Welch wrote: >> Hi Dmitry, >> >> These are looking good to me. > > Can I get an "Acked-by:" or something so that I know it's ok to apply > these? > >

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman <gre...@linuxfoundation.org> > wrote: > > On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: >> >>> On 05 Aug 2015, at 16:12, Greg Kroah-Hartman <gre...@linuxfoundation.org> >>> wr

Re: [PATCH 0/3] VME bus error handling overhaul

> On 16 Sep 2015, at 11:55, Dmitry Kalinkin <dmitry.kalin...@gmail.com> wrote: > > >> On 16 Sep 2015, at 11:53, Greg Kroah-Hartman <gre...@linuxfoundation.org> >> wrote: >> >> On Wed, Sep 16, 2015 at 11:39:22AM -0400, Dmitry Kalinkin wrote: &

Re: vme_ca91cx42 doesn't touch VMEbus on read with vme_user

It seems that GE does some extra FPGA trickery for VME. Could it be that you need vmivme7805 driver? On 01 Aug 2015, at 01:28, Eisch, Jonathan D [PHYSA] jei...@iastate.edu wrote: Hello DriverDev, I recently installed the latest Debian with Kernel 3.16 including all the vme drivers

[RFC] Generic VME UIO

is intended for the merge into vme_user. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/Kconfig | 10 +++ drivers/staging/vme/devices/Makefile | 1 + drivers/staging/vme/devices/vme_uio.c | 158

[PATCH] staging: android: ion: reorder variable definitions

Prevents false positive missing empty line after a definition checkpatch warning. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers

[PATCH] vme: lower alignment requirement in pci bridge drivers

is excessive, alignment by granularity should be enough. This changes alignment constraint from size to a fixed constraint of 64K. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/vme/bridges/vme_ca91cx42.c | 2 +- drivers/vme/bridges/vme_tsi148.c | 2 +- 2 files changed, 2

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 08 Jul 2015, at 16:57, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 11:52, Dmitry Kalinkin wrote: The API I had in mind would have only vme_master_read and vme_master_write that would take absolute addresses (not relative to any window). These variants of access functions

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 08 Jul 2015, at 16:41, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 13:51, Alessio Igor Bogani wrote: Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like

Generic VME UIO driver

On 08 Jul 2015, at 16:22, Martyn Welch martyn.we...@ge.com wrote: On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice (such as receiving VME interrupts in user space, it's not really doable if the slave card is Release On Register Access

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

Hi Alessio, [Sorry for double post] On 07 Jul 2015, at 10:08, Alessio Igor Bogani alessioigorbog...@gmail.com wrote: Hi Dmitry, On 6 July 2015 at 19:24, Dmitry Kalinkin dmitry.kalin...@gmail.com wrote: [...] I'm not a VME expert, but it seems that VME windows are a quiet limited

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On 07 Jul 2015, at 15:51, Alessio Igor Bogani alessioigorbog...@gmail.com wrote: snip Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like mapping whole A16 once to be

Re: [PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch martyn.we...@ge.com wrote: On 26/06/15 21:39, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote: Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing list. I'm happy with the addition of DMA, just not sure whether it's worth adding an extra device file just to handle

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch martyn.we...@ge.com wrote: On 06/07/15 14:50, Dmitry Kalinkin wrote: On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote: Sorry about the *really* late reply, loads of emails some how missed my periodic search of the mailing

[PATCH] vme: print unhandled VME access errors

This will enable error messages for accesses done through mmap. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset. --- drivers/vme/vme.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/vme/vme.c

[PATCH 3/3] vme: change bus error handling scheme

. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_ca91cx42.c | 3 +- drivers/vme/bridges/vme_tsi148.c | 83 +- drivers/vme/vme.c | 92

[PATCH 1/3] vme: move tsi148 error handling into VME subsystem

in a rare case when err_chk=1 and kmalloc fails. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_tsi148.c | 93 +++- drivers/vme/vme.c| 86

[PATCH 2/3] vme: include address space in error filtering

Also changes vme_bus_error_handler to take generic address modifier code instead of raw contents of a device-specific attribute register. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_tsi148.c | 4 ++- drivers/vme

[PATCHv3 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 947a38e..7ca943c 100644 --- a/drivers/staging/vme/devices

[PATCHv3 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers

[PATCHv3 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers

[PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv3 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 7ca943c..b3e3c2d

[PATCHv3 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv3 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 73 +++--- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..a2345db 100644

[PATCHv3 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ef876a4..947a38e 100644

[PATCHv3 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644

[PATCHv3 0/9] vme_user checkpatch fixes and read()/write() rework

of EFAULT in a couple of places. v3 fixes (allow large read()/write()) to also remove the comment right above resource_to_user() v3 also renames (vme_user: return -EFAULT on __copy_*_user errors) to (switch to returning -EFAULT on __copy_*_user errors) Dmitry Kalinkin (9): staging: vme_user: fix

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On 25 Jun 2015, at 14:27, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file

Re: [PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On 25 Jun 2015, at 15:05, Dmitry Kalinkin dmitry.kalin...@gmail.com wrote: On 25 Jun 2015, at 14:27, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Tue, Jun 23, 2015 at 07:03:36PM +0300, Dmitry Kalinkin wrote: Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers

Re: [PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On 23 Jun 2015, at 16:51, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Jun 23, 2015 at 03:42:30PM +0300, Dmitry Kalinkin wrote: @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char __user *buf, size_t count, loff_t *ppos

Re: [PATCH 1/9] staging: vme_user: fix code alignment

On 23 Jun 2015, at 16:21, Frans Klaver franskla...@gmail.com wrote: You left one in the function declarations (vme_user_write). If you mean forward declarations, they are already gone in Greg’s tree:

[PATCH 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 28a70f4..6f5bbc4 100644 --- a/drivers/staging/vme/devices

[PATCH 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 85eb6ee..28a70f4 100644

[PATCH 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix

[PATCH 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 6f5bbc4..14f9554

[PATCH 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCH 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index b6d81e5..db5f890 100644 --- a/drivers

[PATCH 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 1f00ad7..b6d81e5 100644

[PATCH 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 285e00e..1f00ad7 100644 --- a/drivers

[PATCH 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 67 -- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index db5f890..52cd638 100644

[PATCHv2 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv2 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers

[PATCHv2 0/9] vme_user checkpatch fixes and read()/write() rework

of EFAULT in a couple of places. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix blank lines staging: vme_user: fix NULL comparison style staging: vme_user: fix kmalloc style staging: vme_user: allow large read()/write() staging: vme_user: return -EFAULT

[PATCHv2 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644

[PATCHv2 5/9] staging: vme_user: allow large read()/write()

-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 67 -- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 3467cde..101f7b9 100644

[PATCHv2 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index cf47649..de9eda5 100644 --- a/drivers/staging/vme/devices

[PATCHv2 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers

[PATCHv2 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 070e63f..cf47649 100644

[PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

[PATCHv2 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index de9eda5..efed9c7

[PATCHv4 4/4] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 201

[PATCHv4 3/4] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme

[PATCHv4 1/4] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff

[PATCHv4 0/4] vme DMA and user space driver improvements

This reorders patches so that Greg can take first three, while fourth awaits maintainer's approval. Dmitry Kalinkin (4): staging: vme_user: remove forward declarations staging: vme_user: remove open/release staging: vme_user: remove buf_unalloc helper staging: vme_user: provide DMA

[PATCHv4 2/4] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

On 13 Jun 2015, at 05:24, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Jun 13, 2015 at 05:04:28AM +0300, Dmitry Kalinkin wrote: On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: I thought 12 was the most harmless out of the whole set

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

On Sat, Jun 13, 2015 at 3:31 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jun 10, 2015 at 04:09:19PM +0300, Dmitry Kalinkin wrote: Also, there are some patches that IMO don't need any special VME subsystem expertise, namely: Documentation: mention vme_master_mmap() in VME

[PATCHv2 15/16] vme: tsi148: depend on HAS_DMA for Kconfig

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig index 9331064..f6d8545 100644

[PATCHv2 14/16] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme

[PATCHv2 12/16] staging: vme_user: remove forward declarations

Reorder code so that forward declarations are not needed. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 139 ++--- 1 file changed, 60 insertions(+), 79 deletions(-) diff

[PATCHv2 16/16] vme: provide uapi header

This separates VME related constants that are a part of both kernel and user space API into a common uapi header. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- include/linux/vme.h | 54

[PATCHv2 09/16] vme: ca91cx42: return error code on DMA error

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_ca91cx42.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c index e9bd657..f692efc 100644

[PATCHv2 04/16] vme: stop DMA transfer on interruption

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_ca91cx42.c | 17 ++--- drivers/vme/bridges/vme_tsi148.c | 15 +-- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/vme

[PATCHv2 05/16] staging: vme_user: refactor llseek to switch(){}

This makes vme_user_llseek ignore all minors that don't have llseek implementation. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions

[PATCHv2 10/16] vme: ca91cx42: fix LM_CTL address mask

Universe II datasheet defines following address space values for LM_CTL[16:18] 000=A16 001=A24 010=A32 011,100,101=Reserved 110=User1 111=User2 Mask 516 is not the right one for matching [16:18], instead we should use 716. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor

[PATCHv2 02/16] vme: tsi148: fix DMA lists longer that one item

DMA lists on tsi148 weren't processed further than the first item because of the broken logic. This regression was introduced in: ac1a4f2caf7b071 Staging: VME: Ensure TSI148 link list descriptors... Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru

[PATCHv2 07/16] vme: export vme_check_window()

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/vme.c | 5 +++-- include/linux/vme.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 1b78d27..5670891 100644

[PATCHv2 11/16] staging: vme_user: remove unused counters

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices

[PATCHv2 08/16] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 201

[PATCHv2 03/16] vme: tsi148: fix first DMA item mapping

-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/vme_tsi148.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index 1be4136

[PATCHv2 00/16] vme DMA and user space driver improvements

, email http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-July/029084.html mentions that we probably can now get rid of this comment: /* XXX We do not want to push aspace, cycle and width * to userspace as they are */ Dmitry Kalinkin (16): Documentation: mention

[PATCHv2 01/16] Documentation: mention vme_master_mmap() in VME API

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- Documentation/vme_api.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt index ffe6e22..ca5b827 100644 --- a/Documentation

[PATCHv2 06/16] vme: check for A64 overflow in vme_check_window()

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/vme.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 6bab2c4..1b78d27 100644 --- a/drivers/vme/vme.c +++ b

[PATCHv3 16/16] vme: provide uapi header

This separates VME related constants that are a part of both kernel and user space API into a common uapi header. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- include/linux/vme.h | 54

[PATCHv3 13/16] staging: vme_user: remove open/release

Checking for image[minor].resource != NULL is not needed since all resources are allocated before device is created. image[minor].users accounting is deleted because it's not being used. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers

[PATCHv3 14/16] staging: vme_user: remove buf_unalloc helper

buf_unalloc is essentially a vme_free_consistent: 1) image[i].kern_buf is never NULL in buf_alloc call 2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme

[PATCHv3 15/16] vme: tsi148: depend on HAS_DMA for Kconfig

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/bridges/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/Kconfig b/drivers/vme/bridges/Kconfig index 9331064..f6d8545 100644

[PATCHv3 06/16] vme: check for A64 overflow in vme_check_window()

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/vme/vme.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 6bab2c4..1b78d27 100644 --- a/drivers/vme/vme.c +++ b

[PATCHv3 08/16] staging: vme_user: provide DMA functionality

This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 201

[PATCHv3 11/16] staging: vme_user: remove unused counters

Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com Cc: Igor Alekseev igor.aleks...@itep.ru --- drivers/staging/vme/devices/vme_user.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices

  1   2   >