: Dan Carpenter <dan.carpen...@oracle.com>
Acked-by: Don Zickus <dzic...@redhat.com>
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> index 07594f4..ff2bd077 100644
> --- a/drivers/staging/unis
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
This patch fixes checkpatch warnings
Signed-off-by: Ravi Teja Darbha rav...@gmail.com
David,
Is this code removed after you ripped out the parahotplug stuff?
IOW, the next round of updates from Ben might obsolete this patch.
On Fri, Jun 05, 2015 at 06:04:14PM +0300, Dan Carpenter wrote:
Sorry, I should have read on the later patches. That sounds fine.
Hi Dan,
No worries. I will take the blame for that. I should have communicated
that or done a better job making less confusing. :-(
Cheers,
Don
On Thu, Jun 04, 2015 at 05:19:44PM +0300, Dan Carpenter wrote:
On Thu, Jun 04, 2015 at 09:22:40AM -0400, Benjamin Romer wrote:
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
index 4dd0a07..618732b 100644
---
On Sun, May 31, 2015 at 10:17:30AM +0900, Greg KH wrote:
On Tue, May 26, 2015 at 02:40:45PM -0400, Don Zickus wrote:
Hi,
GregKH ran into an issue where the last 13 patches didn't apply.
It looks like Ben cleaned up the patches to address checkpatch.pl
warnings and forgot to refresh
On Wed, May 27, 2015 at 07:02:51PM +0300, Dan Carpenter wrote:
Hello Don Zickus,
This is a semi-automatic email about new static checker warnings.
The patch 3032aeddd85e: staging: unisys: Convert bus functions to
pass bus_info pointer around from May 13, 2015, leads to the
following
From: David Kershner david.kersh...@unisys.com
Give the enum the correct values instead of based on other values.
Signed-off-by: David Kershner david.kersh...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/diagchannel.h | 34
The bus driver doesn't work in server mode, just remove the left over
pieces.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_main.c| 66 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 5 --
drivers/staging/unisys
From: David Kershner david.kersh...@unisys.com
Diagchannel.h is used primarily for the diagnostics channel. The
diagnostics channel is not being used by linux guests currently, so
the majority of the file is not needed. What is left is what is
needed to perform postcode vmcalls. Those postcodes
From: Jes Sorensen jes.soren...@redhat.com
min_size/max_size aren't used anywhere, and they were just causing
headaches in the drivers being ported over to the new interfaces.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
to visor_device. Various cleanups include re-arranging the failure
paths to make more sense.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/include/visorbus.h | 3 +
drivers/staging/unisys/visorbus/visorbus_main.c| 130 -
drivers/staging/unisys
From: David Kershner david.kersh...@unisys.com
Get rid of unused values in the enum.
Signed-off-by: David Kershner david.kersh...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/diagchannel.h | 32 +++-
1 file
deleted it.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_main.c| 88 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 16 +---
drivers/staging/unisys/visorbus/visorchipset.c | 54 -
3 files changed, 63
will not be used
in the public namespace.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_main.c | 52 ++---
1 file changed, 30 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys
visorbus.h to use u32 there. Fix
the resulting printk warning too.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/include/visorbus.h | 4 ++--
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
drivers/staging/unisys/visorbus/visorchipset.c | 6 --
3 files changed
' instead of bus/dev_info.
That change causes some fallout in the success case. Instead of setting
state bits and clearing info in the responders, do all that magic in the
responder wrappers.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_private.h | 4
to visor_device. Various cleanups include re-arranging the failure
paths to make more sense.
Pay attention to the create_visor_device function. This had a lot of
churn to simplify everything.
Lots of functions disappeared because they are not needed any more.
Signed-off-by: Don Zickus dzic
and 'struct
visorbus_devdata' to 'struct visor_device'.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_main.c | 127 +++-
1 file changed, 57 insertions(+), 70 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers
Removing stuff that isn't being used. Another prepartion patch to
allow us to use visor_device everywhere without the baggage of
bus/dev_info.
Signed-off-by: Don Zickus dzic...@redhat.com
---
drivers/staging/unisys/visorbus/visorbus_main.c| 72 --
drivers/staging/unisys
).
No functional changes, just surrounding patch context refresh.
David Kershner (3):
staging: unisys: Update diag serverity enum
staging: unisys: Remove unneeded fields in diagchannel.h
staging: unisys: Clean up diag_serverity enum
Don Zickus (9):
staging: unisys: Move channel creation up
On Sat, May 16, 2015 at 02:22:16PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 01:22:28PM -0400, Benjamin Romer wrote:
+ hdr_info = kzalloc(sizeof(*hdr_info), GFP_KERNEL);
+ if (!hdr_info) {
+ rc = NULL;
+ goto away_mem;
+ }
+
deleted it.
Signed-off-by: Don Zickus dzic...@redhat.com
---
V2: Fix bus/dev_create error path by adding bus/dev_info = NULL (Dan Carpenter)
---
drivers/staging/unisys/visorbus/visorbus_main.c| 87 +++---
drivers/staging/unisys/visorbus/visorbus_private.h | 16 +---
drivers
to visor_device. Various cleanups include re-arranging the failure
paths to make more sense.
Pay attention to the create_visor_device function. This had a lot of
churn to simplify everything.
Lots of functions disappeared because they are not needed any more.
Signed-off-by: Don Zickus dzic
On Sat, May 16, 2015 at 02:38:57PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 01:22:26PM -0400, Benjamin Romer wrote:
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1197,6 +1197,7 @@ bus_create(struct controlvm_message
On Sat, May 09, 2015 at 12:06:32PM +0300, Dan Carpenter wrote:
On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote:
On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote:
On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote:
From: Don Zickus dzic...@redhat.com
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote:
On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote:
This function leaks hdr_info on later error paths.
Never mind. I'm wrong. Sorry for the noise.
To be honest, I think I was right originally, but the
On Fri, May 08, 2015 at 11:00:18AM +0300, Dan Carpenter wrote:
On Tue, May 05, 2015 at 06:37:43PM -0400, Benjamin Romer wrote:
From: Don Zickus dzic...@redhat.com
@@ -1128,7 +1119,7 @@ device_epilog(u32 bus_no, u32 dev_no, struct
spar_segment_state state, u32 cmd,
switch (cmd
On Fri, May 08, 2015 at 04:02:06PM +0200, Greg KH wrote:
On Fri, May 08, 2015 at 09:56:41AM -0400, Don Zickus wrote:
On Fri, May 08, 2015 at 11:00:18AM +0300, Dan Carpenter wrote:
On Tue, May 05, 2015 at 06:37:43PM -0400, Benjamin Romer wrote:
From: Don Zickus dzic...@redhat.com
28 matches
Mail list logo
