Re: [PATCH RFC PKS/PMEM 51/58] kernel: Utilize new kmap_thread()

ira.we...@intel.com writes: > From: Ira Weiny > > This kmap() call is localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. Acked-by: "Eric W. Biederman" > > Cc: Eric Biederman > Signed-off-by: Ira Wein

Re: binderfs interferes with syzkaller?

Christian Brauner writes: > On Sun, Jan 26, 2020 at 09:55:35AM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 25, 2020 at 06:49:49PM +0100, Dmitry Vyukov wrote: >> > Hi binder maintainers, >> > >> > It seems that something has happened and now syzbot has 0 coverage in >> >

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

Christoph Hellwig <h...@lst.de> writes: > On Thu, May 17, 2018 at 12:28:01AM -0500, Eric W. Biederman wrote: >> > struct pid_namespace *proc_pid_namespace(struct inode *inode) >> > { >> >// maybe warn on for s_magic not on procfs?? &

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

Christoph Hellwig <h...@lst.de> writes: > On Sat, May 05, 2018 at 07:37:33AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig <h...@lst.de> writes: >> >> > The shole seq_file sequence already operates under a single RCU lock pair, >> > so mo

Re: [PATCH 34/40] atm: simplify procfs code

Christoph Hellwig <h...@lst.de> writes: > On Sat, May 05, 2018 at 07:51:18AM -0500, Eric W. Biederman wrote: >> Christoph Hellwig <h...@lst.de> writes: >> >> > Use remove_proc_subtree to remove the whole subtree on cleanup, and >> > unwind the reg

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

Christoph Hellwig writes: > The shole seq_file sequence already operates under a single RCU lock pair, > so move the pid namespace lookup into it, and stop grabbing a reference > and remove all kinds of boilerplate code. This is wrong. Move task_active_pid_ns(current) from open to

Re: [PATCH 38/40] ide: remove ide_driver_proc_write

permissions S_IFREG|S_IRUGO so I don't think the write support was ever finished. That cap_capable in the write method looks down right scary/buggy. Acked-by: "Eric W. Biederman" <ebied...@xmission.com> Eric > > Signed-off-by: Christoph Hellwig <h...@lst.de&

Re: [PATCH 34/40] atm: simplify procfs code

Christoph Hellwig writes: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Can you please explain why you are removing the error handling when you are