Re: [PATCH 1/3] usb: gadget: udc: Avoid tasklet passing a global

y to me. Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

Nicolas Boichat writes: > On Thu, Jul 23, 2020 at 9:17 PM Felipe Balbi wrote: >> >> Nicolas Boichat writes: >> >> > trace_printk should not be used in production code, replace it >> > call with dev_dbg. >> > >> > Signed-off

Re: [PATCH 1/4] usb: cdns3: gadget: Replace trace_printk by dev_dbg

Nicolas Boichat writes: > trace_printk should not be used in production code, replace it > call with dev_dbg. > > Signed-off-by: Nicolas Boichat > > --- > > Unclear why a trace_printk was used in the first place, it's > possible that some rate-limiting is necessary here. > >

Re: TODO advice for octeon-usb?

Hi, Aaro Koskinen writes: > I'm looking for input what should be done next to get > drivers/staging/octeon-usb out of staging. > > Thousands of checkpatch errors/warnings have been fixed (starting point > was ), > also the size of the

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

Hi, Joe Perches <j...@perches.com> writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi ___ devel mailing list de...@linuxdriverp

Re: [PATCH 00/26] constify local structures

Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

s.open-mesh.org > Cc: linux-blueto...@vger.kernel.org > Signed-off-by: Florian Westphal <f...@strlen.de> > --- for u_ether.c: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> > diff --git a/drivers/usb/gadget/function/u_ether.c > b/drivers/usb/gadget/function/

Re: [PATCH v5 01/46] usb: gadget: encapsulate endpoint claiming mechanism

Hi, On Thu, Aug 20, 2015 at 07:16:48PM +0200, Robert Baldyga wrote: On 08/20/2015 06:48 PM, Felipe Balbi wrote: On Thu, Aug 20, 2015 at 06:28:14PM +0200, Robert Baldyga wrote: Hi Felipe, On 08/20/2015 05:35 PM, Felipe Balbi wrote: [...] just letting you know that this regresses all gadget

Re: [PATCH v5 01/46] usb: gadget: encapsulate endpoint claiming mechanism

3b8932100aacb6cfbffe288ca93025d8b8430c00 Author: Felipe Balbi ba...@ti.com Date: Wed Aug 19 18:05:27 2015 -0500 usb: gadget: fix ep-claimed lifetime In order to fix a regression introduced by commit cc476b42a39d (usb: gadget: encapsulate endpoint claiming mechanism) we have to introduce a simple helper

Re: [PATCH v5 01/46] usb: gadget: encapsulate endpoint claiming mechanism

On Thu, Aug 20, 2015 at 06:28:14PM +0200, Robert Baldyga wrote: Hi Felipe, On 08/20/2015 05:35 PM, Felipe Balbi wrote: [...] just letting you know that this regresses all gadget drivers making them try to disable previously disabled endpoints and enable previously enabled endpoints. I

Re: [PATCH v5 00/46] usb: gadget: rework ep matching and claiming mechanism

. This solution is inspired by the 'feature flags' originally proposed by Felipe Balbi in 2013 [2], but unfortunately implementation of this feature has never been completed. Patches (4-36) add' capabilites flags' support to all UDC drivers present in the kernel tree. It's needed to be done

Re: [PATCH v5 07/46] usb: dwc3: gadget: add ep capabilities support

On Fri, Jul 31, 2015 at 04:00:19PM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH v5 40/46] usb: gadget: epautoconf: rework ep_matches() function

On Fri, Jul 31, 2015 at 04:00:52PM +0200, Robert Baldyga wrote: Rework ep_matches() function to make it shorter and more readable. Signed-off-by: Robert Baldyga r.bald...@samsung.com this regresses at least mass storage. How did you test it ? I'll keep all patches up to this one, please fix

Re: [PATCH v5 02/46] usb: gadget: add endpoint capabilities flags

Hi, On Fri, Jul 31, 2015 at 03:51:52PM +, David Laight wrote: From: Robert Baldyga Sent: 31 July 2015 15:00 Introduce struct usb_ep_caps which contains information about capabilities of usb endpoints - supported transfer types and directions. This structure should be filled by UDC

Re: [PATCH v4 04/46] staging: emxx_udc: add ep capabilities support

Hi, On Thu, Jul 30, 2015 at 09:15:38AM +0200, Robert Baldyga wrote: On 07/29/2015 05:20 PM, Felipe Balbi wrote: On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Fixed typo in epc-nulk to epc-bulk. Signed-off

Re: [PATCH v4 04/46] staging: emxx_udc: add ep capabilities support

On Mon, Jul 27, 2015 at 11:16:14AM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Fixed typo in epc-nulk to epc-bulk. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/staging/emxx_udc/emxx_udc.c | 60

Re: [PATCH v3 07/46] usb: dwc3: gadget: add ep capabilities support

Hi, On Wed, Jul 15, 2015 at 08:31:54AM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

; @@ - SET_ETHTOOL_OPS(dev, ops); + dev-ethtool_ops = ops; Compile tested only, but I'd seriously wonder if this broke anything. Suggested-by: Dave Miller da...@davemloft.net Signed-off-by: Wilfried Klaebe w-l...@lebenslange-mailadresse.de for drivers/usb/gadget/: Acked-by: Felipe Balbi ba...@ti.com

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

callbacks, which may be called during the musb device probing. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi ba...@ti.com there's also the third option of me

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

Hi, On Fri, Sep 20, 2013 at 02:49:38PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: Hi, On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: Use platform_device_register_full() for those drivers which can, to avoid