Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc()
/atomisp_kernel_zalloc().
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 31 +-
.../media/atomisp/pci/atomisp2/atomisp_cmd.h | 2 --
.../a
Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fop
2:2:
note: (near initialization for ‘hmm_bo_type_strings’)
cc1: all warnings being treated as errors
scripts/Makefile.build:294: recipe for target
'drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o' failed
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
drivers/staging/media/atom
Use kvmalloc() and kvfree() instead of open-coding.
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/at
Since i_blocksize() helper has been defined in fs.h, use it instead
of open-coding.
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
drivers/staging/lustre/lustre/llite/file.c| 2 +-
drivers/staging/lustre/lustre/obdclass/obdo.c | 2 +-
2 files changed, 2 insertions(+), 2 del
Use rb_entry_safe() instead of container_of() to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@gmail.com>
---
drivers/staging/lustre/lustre/osc/osc_cache.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_cach
This patch drops the local definition of LIST_CONTAINOR(), and uses
container_of() instead of it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8712/osdep_service.h | 3 ---
drivers/staging/rtl8712/rtl8712_recv.c| 10 +-
drivers/staging/r
On Mon, Feb 22, 2016 at 09:39:15PM -0500, Jes Sorensen wrote:
> Geliang Tang <geliangt...@163.com> writes:
> > Use list_first_entry*() instead of container_of() to simplify the code.
> >
> > Signed-off-by: Geliang Tang <geliangt...@163.com>
> > ---
> &g
Use list_first_entry() instead of container_of() to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
Acked-by: Jes Sorensen <jes.soren...@redhat.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --g
Fix the following static checker warning:
drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a()
error: potential NULL dereference 'psta'.
Fixes: e280d71("staging: rtl8723au: use list_for_each_entry*()")
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
On Sun, Feb 07, 2016 at 07:55:09PM -0800, Greg Kroah-Hartman wrote:
> On Sun, Nov 08, 2015 at 10:17:54PM +0800, Geliang Tang wrote:
> > Use kmalloc_array instead of kmalloc to allocate memory for an array.
> >
> > Signed-off-by: Geliang Tang <geliangt...@163.com>
&
Use list_first_entry*() instead of container_of() to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c | 49 +--
drivers/staging/rtl8723au/core/rtw_xmit.c | 26 +---
2 files chang
This patch cleans whitespaces and blank lines involved with
previous two patchs in this patch set.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 33 +--
drivers/staging/rtl8723au/core/rtw_mlme.c
There are some useless codes in rtw_free_recvframe23a_queue() and
recvframe_defrag(), so remove them.
Signed-off-by: Geliang Tang <geliangt...@163.com>
Acked-by: Jes Sorensen <jes.soren...@redhat.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c | 9 ++---
1 file changed, 2 inse
Use list_for_each_entry*() instead of list_for_each*() to simplify
the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 59
drivers/staging/rtl8723au/core/rtw_mlme.c | 28 --
drivers/s
s applied to the wrong git tree, please drop us a note to
> > help improving the system]
> >
> > url:
> > https://github.com/0day-ci/linux/commits/Geliang-Tang/staging-rtl8723au-use-list_for_each_entry/20160217-220638
> > config: i386-randconfig-s1-201607 (attach
There are some useless codes in rtw_free_recvframe23a_queue() and
recvframe_defrag(), so remove them.
Signed-off-by: Geliang Tang <geliangt...@163.com>
Acked-by: Jes Sorensen <jes.soren...@redhat.com>
---
drivers/staging/rtl8723au/core/rtw_recv.c | 7 +--
1 file changed, 1 ins
This patch cleans whitespaces and blank lines involved with
previous two patchs in this patch set.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 33 +--
drivers/staging/rtl8723au/core/rtw_mlme.c
.
Geliang Tang (3):
staging: rtl8723au: use list_for_each_entry*()
staging: rtl8723au: core: rtw_recv: remove useless codes
staging: rtl8723au: whitespace and blank line cleaning
drivers/staging/rtl8723au/core/rtw_ap.c | 92 ++-
drivers/staging/rtl8723au/core/rtw_mlme.c
Use list_for_each_entry*() instead of list_for_each*() to simplify
the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 59
drivers/staging/rtl8723au/core/rtw_mlme.c | 28 --
drivers/s
Use list_for_each_entry*() instead of list_for_each*() to simplify
the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v3:
- split it into three patches.
Changes in v2:
- drop the coding style fixing in v1.
---
drivers/staging/rtl8723au/core/rtw_ap.c
There are some useless codes in rtw_free_recvframe23a_queue() and
recvframe_defrag(), so remove them.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v3:
- split it into three patches.
Changes in v2:
- drop the coding style fixing in v1.
---
drivers/staging/rtl8723a
This patch cleans whitespaces and blank lines surrounding
list_for_each_entry*().
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v3:
- split it into three patches.
Changes in v2:
- drop the coding style fixing in v1.
---
drivers/staging/rtl8723au/core/rtw_ap.c
Use list_for_each_entry*() instead of list_for_each*() to simplify
the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v2:
- drop the coding style fixing in v1.
---
drivers/staging/rtl8723au/core/rtw_ap.c | 92 ++-
drivers/staging/rtl
Use list_first_entry_or_null() instead of list_empty() + container_of()
to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 +---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 19 +++
drivers/staging/rtl8188e
Use list_first_entry_or_null() instead of list_empty() + LIST_CONTAINOR()
to simplify the code.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8712/rtl871x_cmd.c | 13 +---
drivers/staging/rtl8712/rtl871x_mlme.c| 15 +++---
drivers/s
Use to_platform_device() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
Use to_delayed_work() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8192e/rtllib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index 5
Use to_delayed_work() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 +++---
drivers/staging/rtl8192u/r8192U_core.c | 3 +--
drivers/staging/rtl8192u/r8192U_dm.c
Use to_pci_dev() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/vme/bridges/vme_ca91cx42.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42.c
b/drivers/vme/bridges/vme_ca91cx42.c
Use to_spi_device() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index 0
Simplify the code with list_first_entry_or_null().
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/s
Use kmalloc_array instead of kmalloc to allocate memory for an array.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v2:
- preserve the existing whitespace style.
---
drivers/staging/comedi/drivers/amplc_pci224.c | 11 +++
drivers/staging/comedi/drivers/ni_
Use kmalloc_array instead of kmalloc to allocate memory for an array.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/s
Use kmalloc_array instead of kmalloc to allocate memory for an array.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/amso1100/c2.c | 6 --
drivers/staging/rdma/ipath/ipath_file_ops.c | 8
2 files changed, 8 insertions(+), 6 deletions(-)
Use kmalloc_array instead of kmalloc to allocate memory for an array.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/
Use kmalloc_array instead of kmalloc to allocate memory for an array.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/comedi/drivers/amplc_pci224.c | 8
drivers/staging/comedi/drivers/ni_670x.c | 5 +++--
2 files changed, 7 insertions(+), 6 deletions(-)
Use comm[TASK_COMM_LEN] instead of comm[16] in ipath_kernel.h.
And add sched.h header in it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v2:
- split it into two patches.
---
drivers/staging/rdma/ipath/ipath_kernel.h | 3 ++-
1 file changed, 2 insertions(+), 1 de
sched.h header in ipath_*.c is now unnecessary, since I have added
sched.h in ipath_kernel.h. So remove it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
Changes in v2:
- split it into two patches.
---
drivers/staging/rdma/ipath/ipath_driver.c | 1 -
drivers/staging/rdma
This patch makes sptlrpc_flavor_has_bulk return boolean, since
this function only uses either one or zero as its return value.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/lustre/lustre/include/lustre_sec.h | 2 +-
drivers/staging/lustre/lustre/ptlrpc/sec.c
s/regsiter/register/
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/wilc1000/linux_wlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan.c
b/drivers/staging/wilc1000/linux_wlan.c
index ccab89f..6dc5faf
This patch makes XGIfb_has_VB return boolean, since this function
only uses either one or zero as its return value.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/xgifb/XGI_main_26.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
This patch makes ni_tio_has_gate2_registers return boolean, since
this function only uses either one or zero as its return value.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/comedi/drivers/ni_tio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Use comm[TASK_COMM_LEN] instead of comm[16].
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/hfi1/hfi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/hfi.h b/drivers/staging/rdma/hfi1/hfi.h
index 8ca171b..a35213e
Use comm[TASK_COMM_LEN] instead of comm[16]. Add linux/sched.h
header in ipath_kernel.h, and remove linux/sched.h header from
ipath_*.c which have included ipath_kernel.h.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/ipath/ipath_driver.c | 1 -
drivers/s
Use offset_in_page macro instead of (addr & ~PAGE_MASK).
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/ipath/ipath_user_sdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/ipath/ipath_user_sdma.c
b/drivers/st
Use offset_in_page macro instead of (addr & ~PAGE_MASK).
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/amso1100/c2_alloc.c| 2 +-
drivers/staging/rdma/amso1100/c2_provider.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
Use offset_in_page macro instead of (addr & ~PAGE_MASK).
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/hfi1/file_ops.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/file_ops.c
b/drivers/staging
/verbs.c:1202:
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/amso1100/c2_mq.c | 1 +
drivers/staging/rdma/hfi1/file_ops.c | 1 +
drivers/staging/rdma/hfi1/sdma.c | 1 +
drivers/staging/rdma/hfi1/verbs.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/d
Fixes the following sparse warning:
drivers/staging/rdma/hfi1/device.c:127:12:
warning: symbol 'class_name_user' was not declared. Should it be static?
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/hfi1/device.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Use kvfree() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/staging/rdma/hfi1/sdma.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c
index aecd1a7..9c02a3d
Use macro uip instead of unsigned int __force *, like vuip in
arch/alpha/include/asm/core_cia.h.
Signed-off-by: Geliang Tang geliangt...@163.com
---
drivers/staging/comedi/comedi_compat32.c | 3 +--
drivers/staging/comedi/comedi_compat32.h | 2 ++
drivers/staging/comedi/comedi_fops.c | 4
This patch fixes the following sparse warning:
drivers/staging/lustre/lnet/lnet/lib-socket.c:175:29:
warning: incorrect type in assignment (different address spaces)
expected char [noderef] asn:1*ifcu_buf
got char *noident
Signed-off-by: Geliang Tang geliangt...@163.com
---
drivers
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
Changes in v3:
- fix the 80 character line limit.
Changes in v2:
- compat_ptr
On Mon, Jun 22, 2015 at 10:43:38AM +0100, Ian Abbott wrote:
Now it removes the call to compat_ptr(), so it won't work. Your first patch
was better, apart from exceeding the 80 character line limit.
Thank you. I revised the patch again.
Geliang Tang (1):
staging: comedi: fix cast warning
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
drivers/staging/comedi/comedi_compat32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
This patch fixes the following sparse warning:
drivers/staging/comedi/drivers/ni_mio_common.c:573:26: warning: shift
too big (4294967295) for type int
Signed-off-by: Geliang Tang geliangt...@163.com
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1
. :(
and besides, this also introduces one new checkpatch warning of
line more than 80 char.
regards
sudip
Thank you for your review. I revised the patch as you suggested. Here it is.
Geliang Tang (1):
staging: comedi: fix cast warning in comedi_compat32.c
drivers/staging/comedi/comedi_compat32.c
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
Changes in v2:
- compat_ptr() is substituted by 'unsigned long'.
---
drivers/staging/comedi
:
- split it into two patches.
Changes in v2:
- remove the kernel version in the commit message.
---
Geliang Tang (2):
staging: comedi: fix checkpatch error
staging: comedi: keep the consistency
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
Signed-off-by: Geliang Tang geliangt...@163.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion
Changed register 0x%x to register=0x%x to keep the consistency
of this file.
Signed-off-by: Geliang Tang geliangt...@163.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote:
On 16/05/15 05:16, Geliang Tang wrote:
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed register 0x%x to register=0x%x to keep the consistency
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed register 0x%x to register=0x%x to keep the consistency
of this file.
3) The kernel version is next-20150515, 4.1.0-rc3.
Signed-off-by: Geliang Tang geliangt
64 matches
Mail list logo
