[PATCHv2] staging: rtl8192e: prefer using eth_broadcast_addr()

From: Hari Prasath Gujulan Elango Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango --- v2: From email address was missing as pointed by Greg. ---

[PATCHv2] staging: dgnc: convert to wait_event_interruptible_timeout

From: Hari Prasath Gujulan Elango This patch makes use of wait_event_interruptible_timeout to achieve timeout functionality.This is a TODO mentiond in the comment which is also removed.It also aligns with what the function is supposed to do as in the comments.

[PATCHv2] staging: rdma: use setup_timer() api

From: Hari Prasath Gujulan Elango Replace the timer API's to initialize a timer & then assign the callback function by the setup_timer() API. Signed-off-by: Hari Prasath Gujulan Elango --- v2: Unwanted text present in the commit comments

[PATCH] staging: rdma: use setup_timer() api

From: Hari Prasath Gujulan Elango Date: Thu, 4 Feb 2016 18:46:31 +0530 Replace the timer API's to initialize a timer & then assign the callback function by the setup_timer() API. Signed-off-by: Hari Prasath Gujulan Elango ---

[PATCH] staging: android: ion: use the manged version of DMA memory allocation

From: Hari Prasath Gujulan Elango Use the managed version of the dma_alloc_coherent() i.e. the dmam_alloc_coherent() & accordingly cleanup the error handling part.Also,remove the references to dma_free_coherent. Signed-off-by: Hari Prasath Gujulan Elango

[PATCHv2] staging: android: ion: use the manged version of DMA memory allocation

From: Hari Prasath Gujulan Elango Use the managed version of the dma_alloc_coherent() i.e. the dmam_alloc_coherent() & accordingly cleanup the error handling part.Also,remove the references to dma_free_coherent Signed-off-by: Hari Prasath Gujulan Elango

[PATCHv3] staging: iio: replace clk_get() with devm_clk_get()

This patch replaces the clk_get() with devm_clk_get().Accordingly,modified the error paths,rename error labels and removed clk_put() in probe() & remove functions. Signed-off-by: Hari Prasath Gujulan Elango --- v3: Rename error path labels to suite modified code as

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 12:45:59PM +0300, Dan Carpenter wrote: > On Thu, Jan 21, 2016 at 09:11:38AM +0000, Gujulan Elango, Hari Prasath (H.) > wrote: > > From: Hari Prasath Gujulan Elango > > > > Your email address is missing here. Hello Dan, Many thanks for not

[PATCH] staging: nvec: replace led_classdev_register

From: Hari Prasath Gujulan Elango Replace the led_classdev_register() with the platform managed version devm_led_classdev_register() & henceforth remove the redundant nvec_paz00_remove() function. Signed-off-by: Hari Prasath Gujulan Elango ---

[PATCH] staging: iio: replace clk_get() with devm_clk_get()

From: Hari Prasath Gujulan Elango This patch replaces the clk_get() with devm_clk_get(). Accordingly,modified the error paths and removed clk_put() as well. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/iio/adc/spear_adc.c | 6 ++ 1 file changed, 2

[PATCHv2] staging: iio: replace clk_get() with devm_clk_get()

From: Hari Prasath Gujulan Elango This patch replaces the clk_get() with devm_clk_get(). Accordingly,modified the error paths and removed clk_put() as well. Signed-off-by: Hari Prasath Gujulan Elango --- v2: email address was missing in the

Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote: > On Thu, Jan 21, 2016 at 1:11 AM, Gujulan Elango, Hari Prasath (H.) > <hguju...@visteon.com> wrote: > > From: Hari Prasath Gujulan Elango > > > > This patch replaces the clk_get() with devm_clk_g

[PATCH] staging: rtl8188eu: use eth_broadcast_addr() in place of memset

From: Hari Prasath Gujulan Elango Replace the memset of array to broadcast address 0xFF by using the eth_broadcast_addr() API Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] staging: rtl8192e: prefer using eth_broadcast_addr()

From: Hari Prasath Gujulan Elango Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] staging: wilc1000: Move Macro definition

From: Hari Prasath Gujulan Elango This patch move's a macro defined in the middle of a structure definition to make it more readable. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1

[PATCHv2] staging: most: replace multiple if..else with table lookup

From: Hari Prasath Gujulan Elango Replace multiple if..else if..statements with simple table lookup in two functions. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/most/mostcore/core.c | 41 +--- 1

[PATCH] staging: most: replace multiple if..else with table lookup

From: Hari Prasath Gujulan Elango Replace multiple if..else if..statements with simple table lookup in two functions. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/most/mostcore/core.c | 39 1

[PATCH] staging: dgnc: convert to wait_event_interruptible_timeout

This patch makes use of wait_event_interruptible_timeout to achieve timeout functionality.This is a TODO mentiond in the comment which is also removed. It also aligns with what the function is supposed to do as in the comments. Signed-off-by: Hari Prasath Gujulan Elango ---

[PATCH] staging: wilc1000: replace numerical constant with predefined MACRO

From: Hari Prasath Gujulan Elango Replace the pre-defined macro signifying the ethernet protocol type defined in the kernel headers instead of the numerical constant Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/wilc1000/wilc_wlan.c

[PATCH] staging: wilc1000: simplify 'memset' of 2D array

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch simplifies the 'memset' done on a static 2D array. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] staging: xgifb: prefer using the BIT macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch uses the BIT macro for bit shift operation. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/xgifb/XGI_main_26.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] staging: lustre: remove dead code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes commented code. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/lustre/lustre/osc/osc_cache.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH] staging: comedi: use BIT macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com Prefer using the BIT macro for shifting operation Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/comedi/comedi.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCHv2] staging: sm750fb: remove redundant __func__ in debug statement

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the redundant __func__ from dynamic debug prints as the pr_xxx set of functions can be dynamically controlled to include function name.Also fix a typo in debug statement. Signed-off-by: Hari Prasath Gujulan Elango

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

On Mon, Jun 22, 2015 at 06:15:06PM +0300, Dan Carpenter wrote: On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch modifies few debug prints from pr_err() to pr_info() as they fall under

Re: [PATCH v2 07/10] staging: wilc1000: remove ununsed variable

On Tue, Jun 23, 2015 at 11:49:24AM +0300, Dan Carpenter wrote: On Mon, Jun 22, 2015 at 01:13:58PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes ununsed variable 'len' Signed-off-by: Hari Prasath Gujulan

Re: [PATCH] staging: dgnc: free memory allocated

added this patch.I will ensure not to miss him next time. On Thu, Jun 18, 2015 at 01:27:28PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com The memory allocated in dgnc_tty_register() for two objects is not freed anywhere.This patch

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

On Monday 22 June 2015 08:46 PM, Dan Carpenter wrote: On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category

Re: [PATCH 2/2] staging: sm750fb: fix typo in debug statement

On Tuesday 23 June 2015 02:07 PM, Dan Carpenter wrote: On Mon, Jun 22, 2015 at 04:48:01AM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a typo in the debug statement Signed-off-by: Hari Prasath Gujulan Elango hguju

Re: [PATCH] staging: sm750fb: remove unused variables

On Tuesday 23 June 2015 02:16 PM, Dan Carpenter wrote: On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.) wrote: @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency) * Sometime, the chip cannot set up the exact clock required by User

[PATCH 04/10] staging: wilc1000: remove ununsed variable corresponding lines

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes a couple of ununsed variable.The lines in which these variables are assigned are also removed as they are not necessary. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH 07/10] staging: wilc1000: remove ununsed variable

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes ununsed variable 'ret'. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 06/10] staging: wilc1000: remove redundant assignment of variable

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch the removes the redundant assignement of the variable ret as its being overwritren before being used anywhere. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1

[PATCH 05/10] staging: wilc1000: remove unused variable

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes a unused variable timeout and the associated code. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/linux_wlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 03/10] staging: wilc1000: remove ununsed if..else.. code blocks

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes ununsed if..else... code blocks. Its actually some dead code. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/coreconfigurator.c | 22 -- 1 file changed, 22

[PATCH 01/10] staging: wilc1000: remove ununsed variable and associated line

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes a unused variable 'u16RespLen' that is assigned a value that is never used. The line that does the assignment is also removed. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH 09/10] staging: wilc1000: remove unused variable msg_len

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes a ununsed variable msg_len and its associated code. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wlan_cfg.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 08/10] staging: wilc1000: remove ununsed variable associated code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the ununsed variable 'priv' at multiple instances and all its associated code where its assigned a value. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH 10/10] staging: wilc1000: use BIT macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch addresses the checkpatch warning advising the usage of the BIT macro for Bit shift operation. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 1 file changed, 2

[PATCH] staging: sm750fb: remove unused variables

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes unused variables as reported by cppcheck Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- drivers/staging/sm750fb/ddk750_mode.c | 3 +--

Re: [PATCH 07/10] staging: wilc1000: remove ununsed variable

On Mon, Jun 22, 2015 at 06:12:11PM +0530, Sudip Mukherjee wrote: On Mon, Jun 22, 2015 at 07:05:04AM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes ununsed variable 'ret'. ret or len? :) regards sudip yes

[PATCH v2 07/10] staging: wilc1000: remove ununsed variable

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes ununsed variable 'len' Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 2/2] staging: sm750fb: fix typo in debug statement

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a typo in the debug statement Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/sm750fb/sm750_accel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] staging: sm750fb: remove redundant __func__ in debug statement

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the redundant __func__ from dynamic debug prints as the pr_xxx set of functions can be dynamically controlled to include function name as well Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH] staging: lustre: lnet: selftest: use min_t in place of min

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch silences the checkpatch warning 'min() should probably be min_t' Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/lustre/lnet/selftest/rpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] staging: sm750fb: convert pr_err to pr_info

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/sm750fb/sm750.c | 6 +++--- 1 file changed, 3

[PATCH] staging: dgnc: free memory allocated

From: Hari Prasath Gujulan Elango hguju...@visteon.com The memory allocated in dgnc_tty_register() for two objects is not freed anywhere.This patch addresses this by freeing the memory in dgnc_tty_uninit. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH] staging: dgnc: fix typo in comments secion

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a typo in the comments section as warned by checkpatch.pl Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/dgnc/dgnc_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: ste_rmi4: remove redundant __func__ from debug prints

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the redundant __func__ from dynamic debug prints as the pr_xxx set of functions can be dynamically controlled to include function name as well. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

Re: [PATCH] staging: wlan-ng: remove unused debug macro

On Wed, Jun 17, 2015 at 09:40:42PM -0700, gre...@linuxfoundation.org wrote: On Tue, Jun 16, 2015 at 05:09:35AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote: On Mon, Jun 15, 2015 at 11:44:24AM +, Gujulan

[PATCH] staging: wlan-ng: Remove ununsed debug print associated macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removed a undefined macro and debug prints associated with it. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wlan-ng/p80211wep.c | 14 -- 1 file changed, 14 deletions(-) diff

Re: [PATCH] staging: wlan-ng: remove unused debug macro

On Wed, Jun 17, 2015 at 09:40:42PM -0700, gre...@linuxfoundation.org wrote: On Tue, Jun 16, 2015 at 05:09:35AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote: On Mon, Jun 15, 2015 at 11:44:24AM +, Gujulan

Re: [PATCH] staging: comedi: fix warning to use BIT Macro

On Tue, Jun 16, 2015 at 05:07:22PM +0100, Ian Abbott wrote: On 16/06/15 15:22, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes the checkpatch warning that suggests to use the BIT macro for the shifting operation. Signed-off

[PATCH] staging: slicoss: remove unused macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes a couple of ununsed MACRO's in this header file Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/slicoss/slic.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] staging: comedi: fix warning to use BIT Macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes the checkpatch warning that suggests to use the BIT macro for the shifting operation. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/comedi/comedi.h | 10 +- 1 file changed, 5

Re: [PATCH] staging: comedi: use meaningful variable name

On Tue, Jun 16, 2015 at 02:04:21PM +0100, Ian Abbott wrote: On 16/06/15 06:34, Gujulan Elango, Hari Prasath (H.) wrote: On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote: On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com

Re: [PATCH] staging: comedi: use meaningful variable name

On Tue, Jun 16, 2015 at 02:04:21PM +0100, Ian Abbott wrote: On 16/06/15 06:34, Gujulan Elango, Hari Prasath (H.) wrote: On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote: On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com

[PATCH] staging: comedi: amplc_pci230: rename 'todo' variable

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch renames the very generic variable name 'todo' to nsamples. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- Subject line modified and variable name kept short as per suggestion from Ian Abbott. ---

[PATCH] staging: comedi: use BIT macro for bit shift operation

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch silences the Checkpatch.pl warning 'Prefer using the BIT macro' Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/comedi/comedidev.h | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCHv2] staging: wilc1000: remove unwanted code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes SIOCDEVPRIVATE + 1 ioctl. It currently is just a stub which does some useless printks and returns. In the original code, if the user passes priv_cmd.total_len == 0 then it will Oops. Also it leaks memory every time it's

[PATCH] staging: rtl8188eu: fix typo in comments section

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a typo in the comment section. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] staging: wlan-ng: Replace hard coded values with MACRO's

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch replaces hard coded values with global definitions for the Ethernet IEEE 802.3 interface defined in standard header file. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wlan-ng/p80211conv.c |

[PATCH] staging: emxx_udc: remove commented code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes commented code warned by checkpatch.pl Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/emxx_udc/emxx_udc.h | 10 -- 1 file changed, 10 deletions(-) diff --git

[PATCH] staging: comedi: remove commented code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes commented code.This was a checkpatch warning. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/comedi/comedi_fops.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH] staging: wlan-ng: remove unused debug macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com Thi patch removes ununsed debug macro and its references in this file.The macro is used around pr_debug which itself can be dynamically enabled/disabled. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com ---

[PATCH] staging: comedi: use meaningful variable name

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch renames the very generic variable name 'todo' to num_samples_to_read. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/comedi/drivers/amplc_pci230.c | 9 + 1 file changed, 5

Re: [PATCH] staging: comedi: use meaningful variable name

On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote: On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch renames the very generic variable name 'todo' to num_samples_to_read. Signed-off-by: Hari Prasath

Re: [PATCH] staging: comedi: use meaningful variable name

On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote: On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch renames the very generic variable name 'todo' to num_samples_to_read. Signed-off-by: Hari Prasath

Re: [PATCH] staging: wlan-ng: remove unused debug macro

On Mon, Jun 15, 2015 at 09:55:15PM -0700, gre...@linuxfoundation.org wrote: On Mon, Jun 15, 2015 at 11:44:24AM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com Thi patch removes ununsed debug macro and its references

[PATCH] staging: wilc1000: remove timer related OS wrapper functions

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the timer related wrapper functions WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and WILC_TimerDestroy() and uses kernel API's directly.In the process,the unused variables,files are also deleted. Signed-off-by:

Re: [PATCH] staging: wilc1000: remove timer related OS wrapper functions

On Thu, Jun 11, 2015 at 12:35:48PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the timer related wrapper functions WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and WILC_TimerDestroy() and uses kernel

[PATCH] staging: wilc1000: remove timer related OS wrapper functions

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes the timer related wrapper functions WILC_TimerCreate(),WILC_TimerStart(),WILC_TimerStop() and WILC_TimerDestroy() and uses kernel API's directly.In the process,the unused variables,files are also deleted. Signed-off-by:

[PATCH 1/2] staging: wilc1000: use memdup_user

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch replaces the kmalloc followed by copy_from_user by the wrapper routine memdup_user. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/linux_wlan.c | 12 +++- 1 file changed, 3

[PATCH 2/2] staging: wilc1000: remove unwanted code

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes code that is unused for any functionality in the ioctl SIOCDEVPRIVATE + 1.But since it is mentioned in the TODO list that it needs to be replaced with generic API functions,the debug print alone is left as it is.

Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote: I mean, yes, it doesn't seem to make much sense to continue polling after all the hardware has been removed. The problem is that we pass a pci_dev pointer to dgap_remove_one() and it ignores it and removes everything.

[PATCH] staging: dgap: do cleanup on module exit

From: Hari Prasath Gujulan Elango hguju...@visteon.com Cleanup the device entry,device class unregister the character device in the module exit.All this cleanup is done already in the dgap_stop() function.We need to call this in the cleanup module. Signed-off-by: Hari Prasath Gujulan Elango

[PATCH] staging: dgnc: do cleanup on module exit

From: Hari Prasath Gujulan Elango hguju...@visteon.com Cleanup the device entry,device class unregister the character device in the module exit.All this cleanup is done already in the dgap_stop() function.We need to call this in the cleanup module. Signed-off-by: Hari Prasath Gujulan Elango

Re: [PATCHv2 1/2] staging: dgnc: delete all references to 'flipbuf'

On Mon, Jun 08, 2015 at 01:29:30PM -0700, gre...@linuxfoundation.org wrote: On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch deletes all references to 'flipbuf'.Memory is allocated

[PATCH] staging: wilc1000: fix build warning related to time_after_eq macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a build warning related to the use of the time_after_eq macro.Adding a typecast to the second argument suppresses the warning.This warning was created by one my previous patch. Signed-off-by: Hari Prasath Gujulan Elango

Re: [PATCH] staging: dgap: move cleanup function to avoid redundancy

On Tue, Jun 09, 2015 at 04:51:02PM +0300, Dan Carpenter wrote: No. See my other email. Also this is super ugly and your instinct should have told you that ugly things are normally wrong. regards, dan carpenter Dan,I guess functionality wise this also does the job.Maybe this is uglier

Re: [PATCH] staging: dgap: do cleanup on module exit

On Tue, Jun 09, 2015 at 04:41:33PM +0300, Dan Carpenter wrote: On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote: On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H

[PATCH 2/2] staging: dgap: delete obvious comments

From: Hari Prasath Gujulan Elango hguju...@visteon.com Deleting obvious comments Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/dgap/dgap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

Re: [PATCH] staging: wilc1000: fix build warning related to time_after_eq macro

On Tue, Jun 09, 2015 at 10:41:18AM -0700, gre...@linuxfoundation.org wrote: On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a build warning related to the use of the time_after_eq

[PATCH 1/2] staging: dgap: cleanup driver module exit and remove function

From: Hari Prasath Gujulan Elango hguju...@visteon.com The driver remove function is not the right place to cleanup resources allocated in the driver module init.The cleanup is moved from remove function to module exit as appropriate. Signed-off-by: Hari Prasath Gujulan Elango

Re: [PATCH 2/2] staging: dgap: delete obvious comments

On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote: On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com Deleting obvious comments Signed-off-by: Hari Prasath Gujulan Elango hguju

[PATCHv2] staging: wilc1000: fix build warning related to time_after_eq macro

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch fixes a build warning related to the use of the time_after_eq macro.Adding a typecast to the second argument suppresses the warning.This warning was created by one my previous patch. Signed-off-by: Hari Prasath Gujulan Elango

Re: [PATCH 1/2] staging: dgap: cleanup driver module exit and remove function

On Tue, Jun 09, 2015 at 10:26:54PM +0300, Dan Carpenter wrote: On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Hari Prasath Gujulan Elango hguju...@visteon.com The driver remove function is not the right place to cleanup resources allocated

[PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

From: Hari Prasath Gujulan Elango hguju...@visteon.com The driver remove function is not the right place to cleanup resources allocated in the driver module init.The cleanup is moved from remove method to module exit as appropriate. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com

[PATCHv2 2/2] staging: dgap: delete obvious comments

From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch deletes the comments secion which is obvious and outdated Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- v2:Addrressed Dan carpenter review comments to remove the entire comments section as its

Re: [PATCH] staging: speakup: use kstrtoul instead of obsolete simple_strtoul

On Tue, Jun 02, 2015 at 05:45:14PM +0300, Dan Carpenter wrote: You didn't try to compile this. regards, dan carpenter I checked the build warnings. This is a false positive warning from checkpatch.pl.Please discard this and sorry for the inconvenience caused.Next time I would take extra

[PATCH 2/2] staging: wilc1000: remove commented code

From: Hari Prasath Gujulan Elango hguju...@visteon.com Remove commented code from this file. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 117 -- 1 file changed, 117 deletions(-) diff --git

[PATCH 1/2] staging: wilc1000: remove ununsed function

From: Hari Prasath Gujulan Elango hguju...@visteon.com The function WILC_WFI_InitPriv() is not used anywhere in the driver.Hence remove it. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 23 --- 1 file

Re: [PATCHv2] staging: dgnc: remove unwanted else block

On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote: On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.) wrote: From: Gujulan Elango Hari Prasath hguju...@visteon.com Remove the unwanted else block i think you need to refresh your tree

Re: [PATCHv2] staging: dgnc: remove unwanted else block

On Tue, Jun 02, 2015 at 12:38:26PM +0530, Sudip Mukherjee wrote: On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.) wrote: On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote: On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H

Re: [PATCH v2] staging: wilc1000: remove unwanted assignment

On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote: On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: From : Hari Prasath Gujulan Elango hguju...@visteon.com remove unwanted assignment to ih-check here as it will be overwritten.Its not used

Re: [PATCH v2] staging: wilc1000: remove unwanted assignment

On Tue, Jun 02, 2015 at 09:11:20PM +0900, gre...@linuxfoundation.org wrote: On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.) wrote: From : Hari Prasath Gujulan Elango hguju...@visteon.com You need to write this as From: not From :, otherwise git will not work

[PATCH] staging: wilc1000: remove unwanted assignment

From : Hari Prasath Gujulan Elango remove unwanted assignment to ih-check here as it will be overwritten.Its not used in the ip_fast_csum() function as well. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.c | 2 +- 1 file changed,

Re: [PATCH] staging: speakup: use kstrtoul instead of obsolete simple_strtoul

On Tue, Jun 02, 2015 at 05:45:14PM +0300, Dan Carpenter wrote: You didn't try to compile this. regards, dan carpenter sorry Dan,I overlooked the build warnings.I will fix and send a v2.Thanks for the comment. Regards, Hari Prasath ___ devel

[PATCH] staging: speakup: use kstrtoul instead of obsolete simple_strtoul

From: Hari Prasath Gujulan Elango hguju...@visteon.com Replace the obsolte simple_strtoul function with kstrtoul.This is a checkpatch warning. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/speakup/kobjects.c| 4 ++-- drivers/staging/speakup/main.c

[PATCH] staging: wilc1000: remove unnecessary typecast

From: Hari Prasath Gujulan Elango hguju...@visteon.com Remove ununecessary typecast for kzalloc.This patch was generated by coccinelle tool. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wilc1000/linux_wlan_spi.c | 8 1 file changed, 4

  1   2   3   >