Re: [PATCH] mtd: nand: Rename nand.h into rawnand.h

2017-08-07 Thread Harvey Hunt
Hi Boris, On 08/04/2017 04:29 PM, Boris Brezillon wrote: [...] drivers/mtd/nand/jz4780_nand.c | 2 +- [...] For JZ4780, Acked-By: Harvey Hunt <harveyhuntne...@gmail.com> ___ devel mailing list de...@linuxdriverproject.or

Re: [PATCH v3 39/52] mtd: nand: jz4780: switch to mtd_ooblayout_ops

2016-02-29 Thread Harvey Hunt
;ooblayout = _ooblayout_lp_ops; - chip->ecc.layout = layout; return 0; } With your patch applied [0] that you gave me earlier in the patchset, I am able to boot to userland on my Ci20 (jz4780_{nand,bch}) with a NAND rootfs. So, dependant upon that patch (or equival

Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate

2016-02-29 Thread Harvey Hunt
Hi Boris, On 26/02/16 18:33, Boris Brezillon wrote: Hi Harvey, On Fri, 26 Feb 2016 15:17:28 + Harvey Hunt <harvey.h...@imgtec.com> wrote: Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: Hi Harvey, On Fri, 26 Feb 2016 14:35:08 + Harvey Hunt <harvey.h...@imgtec.c

Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate

2016-02-26 Thread Harvey Hunt
Hi Boris, On 26/02/16 15:10, Boris Brezillon wrote: Hi Harvey, On Fri, 26 Feb 2016 14:35:08 + Harvey Hunt <harvey.h...@imgtec.com> wrote: [...] I'll look into this more later today, but wanted to run it by you in case you have any thoughts. Can you apply this patch [1], and let m

Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate

2016-02-26 Thread Harvey Hunt
Hi Boris, On 26/02/16 00:57, Boris Brezillon wrote: The mtd_ooblayout_xxx() helper functions have been added to avoid direct accesses to the ecclayout field, and thus ease for future reworks. Use these helpers in all places where the oobfree[] and eccpos[] arrays where directly accessed.

Re: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field

2015-12-08 Thread Harvey Hunt
Hi Boris, On 07/12/15 22:26, Boris Brezillon wrote: ->ecc_layout is not used by any board file. Kill this field to avoid any confusion. New boards are encouraged to use the default ECC layout defined in NAND core. Signed-off-by: Boris Brezillon ---