Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > wrote: > > Well, I used git. It says that as of today in Linus' tree we have > > 889 patches related to fall throughs and the first series went in > > in october 20

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote: > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley > wrote: > > Well, it seems to be three years of someone's time plus the > > maintainer review time and series disruption of nearly a thousand > > patches. Let's be

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 21:35 +0100, Miguel Ojeda wrote: > On Sun, Nov 22, 2020 at 7:22 PM James Bottomley > wrote: > > Well, it's a problem in an error leg, sure, but it's not a really > > compelling reason for a 141 patch series, is it? All that fixing > > this error w

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote: > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > > > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > > > Please tell me our re

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > Please tell me our reward for all this effort isn't a single > > missing error print. > > There were quite literally dozens of logical defects found > by t

Re: [PATCH 000/141] Fix fall-through warnings for Clang

On Sun, 2020-11-22 at 08:17 -0800, Kees Cook wrote: > On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 11:30:40 -0800 Kees Cook wrote: > > > On Fri, Nov 20, 2020 at 10:53:44AM -0800, Jakub Kicinski wrote: > > > > On Fri, 20 Nov 2020 12:21:39 -0600 Gustavo A.

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

On Sun, 2020-10-18 at 20:16 +0100, Matthew Wilcox wrote: > On Sun, Oct 18, 2020 at 12:13:35PM -0700, James Bottomley wrote: > > On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > > > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > > > cla

Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks

On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote: > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote: > > clang has a number of useful, new warnings see > >

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

On Fri, 2020-10-09 at 14:34 -0700, Eric Biggers wrote: > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kmap() calls in this FS are localized to a single thread. To > > avoid the over head of global PKRS updates use the new > > kmap_thread()

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Wed, 2020-08-19 at 21:54 +0530, Allen wrote: > > [...] > > > > Since both threads seem to have petered out, let me suggest in > > > > kernel.h: > > > > > > > > #define cast_out(ptr, container, member) \ > > > > container_of(ptr, typeof(*container), member) > > > > > > > > It does what you

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Wed, 2020-08-19 at 07:00 -0600, Jens Axboe wrote: > On 8/18/20 1:00 PM, James Bottomley wrote: [...] > > Since both threads seem to have petered out, let me suggest in > > kernel.h: > > > > #define cast_out(ptr, container, member) \ > > container_o

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Tue, 2020-08-18 at 13:10 -0700, Kees Cook wrote: > On Tue, Aug 18, 2020 at 01:00:33PM -0700, James Bottomley wrote: > > On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > > > On 8/17/20 12:48 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 12:4

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

On Mon, 2020-08-17 at 13:02 -0700, Jens Axboe wrote: > On 8/17/20 12:48 PM, Kees Cook wrote: > > On Mon, Aug 17, 2020 at 12:44:34PM -0700, Jens Axboe wrote: > > > On 8/17/20 12:29 PM, Kees Cook wrote: > > > > On Mon, Aug 17, 2020 at 06:56:47AM -0700, Jens Axboe wrote: > > > > > On 8/17/20 2:15 AM,

Re: exfat filesystem

On Tue, 2019-07-09 at 12:37 -0400, Sasha Levin wrote: > On Tue, Jul 09, 2019 at 08:48:34AM -0700, Matthew Wilcox wrote: > > On Tue, Jul 09, 2019 at 11:30:39AM -0400, Theodore Ts'o wrote: > > > On Tue, Jul 09, 2019 at 04:21:36AM -0700, Matthew Wilcox wrote: > > > > How does > > > >

Re: exfat filesystem

On Tue, 2019-07-09 at 08:48 -0700, Matthew Wilcox wrote: > On Tue, Jul 09, 2019 at 11:30:39AM -0400, Theodore Ts'o wrote: > > On Tue, Jul 09, 2019 at 04:21:36AM -0700, Matthew Wilcox wrote: > > > How does > > > https://www.zdnet.com/article/microsoft-open-sources-its-entire-p > > >

Re: [PATCH V2 08/15] staging: unisys: visorhba: use sg helper to operate sgl

On Thu, 2019-06-13 at 12:16 +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 06:04:11PM +0800, Ming Lei wrote: > > On Thu, Jun 13, 2019 at 11:52:14AM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Jun 13, 2019 at 03:13:28PM +0800, Ming Lei wrote: > > > > The current way isn't safe for

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

On Tue, 2017-03-14 at 12:29 +, Reshetova, Elena wrote: > > Elena Reshetova writes: > > > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid accidental > > >

Re: [PATCH v3] storvsc: use small sg_tablesize on x86

On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote: > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, > after > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set > the > tablesize based on the information given by the host") > > [5.567138] hv_storvsc

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

On Wed, 2016-03-16 at 18:34 -0400, Martin K. Petersen wrote: > > > > > > "KY" == KY Srinivasan writes: > > KY> How would I get the sysfs files under fc_host if I don't use the > FC > KY> transport. The customer scripts expect these sysfs files. > > Right, but I was

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

On Wed, 2016-03-16 at 23:15 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Wednesday, March 16, 2016 4:08 PM > > To: Martin K. Petersen <martin.peter.

[PATCH 2/2] storvsc_drv: make use of the lightweight FC transport class

Signed-off-by: James Bottomley <j...@linux.vnet.ibm.com> --- drivers/scsi/storvsc_drv.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3ddcabb..dcb7393 100644 --- a/drivers/scsi/storvsc_drv.c

Re: [PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

OK, like this? >From 7af7c428e7e04ddcc87fda12d6571e3dff8ae024 Mon Sep 17 00:00:00 2001 From: James Bottomley <james.bottom...@hansenpartnership.com> Date: Fri, 18 Mar 2016 15:35:45 -0700 Subject: scsi_transport_fc: introduce lightweight class for virtualization systems The FC transpor

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

On Fri, 2016-02-26 at 23:22 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, February 26, 2016 2:25 PM > > To: KY Srinivasan <k...@microsoft.com>; li

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

On Fri, 2016-02-26 at 15:45 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 >

Re: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

t; > With this commit, the storvsc driver depends on FC atttributes. Make > this > dependency explicit. > > Signed-off-by: K. Y. Srinivasan <k...@microsoft.com> > Reported-by: Fengguang Wu <fengguang...@intel.com> > --- > V2: Fixed the dependency based o

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

On Thu, 2016-01-28 at 19:07 +, KY Srinivasan wrote: > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Thursday, January 28, 2016 7:56 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > >

Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

On Wed, 2016-01-27 at 23:29 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 >

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

On Fri, 2016-01-08 at 18:58 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Thursday, January 7, 2016 3:49 PM > > To: KY Srinivasan <k...@microsoft.com>

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

On Fri, 2016-01-08 at 20:12 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, January 8, 2016 11:21 AM > > To: KY Srinivasan <k...@microsoft.com>

Re: [PATCH 1/1] scsi: scsi_transport_fc: Fix a bug in the error handling function

On Thu, 2016-01-07 at 16:40 -0800, K. Y. Srinivasan wrote: > The macro startget_to_rport() can return NULL; handle that case > properly. OK, can we unwind why you think you could possibly need this? It would mean that fc_timed_out was called for a non-FC device, which was thought to be an

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

On Sat, 2015-12-19 at 02:28 +, KY Srinivasan wrote: > > > -Original Message- > > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com > > ] > > Sent: Friday, December 18, 2015 8:48 AM > > To: KY Srinivasan <k...@microsoft.com&

Re: [PATCH V3 2/4] scsi: storvsc: Properly support Fibre Channel devices

On Fri, 2015-12-18 at 09:49 +0100, Hannes Reinecke wrote: > What I would like to see is a clear separation here: > - Disable FC disk handling if FC attributes are not configured > - Add a module parameter allowing to disable FC attributes even if > they are compiled in. Remember: this is a

Re: [PATCH V3 4/4] scsi: storvsc: Tighten up the interrupt path

On Fri, 2015-12-18 at 16:20 +, KY Srinivasan wrote: > > > -Original Message- > > From: Hannes Reinecke [mailto:h...@suse.de] > > Sent: Friday, December 18, 2015 12:52 AM > > To: KY Srinivasan ; gre...@linuxfoundation.org; > > linux- > > ker...@vger.kernel.org;

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: sta...@vger.kernel.org > --- >

Re: [PATCH RESEND V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

On Thu, 2015-08-13 at 08:43 -0700, K. Y. Srinivasan wrote: From: Keith Mange keith.ma...@microsoft.com Currently we are making decisions based on vmbus protocol versions that have been negotiated; use storage potocol versions instead. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by:

Re: [PATCH 1/1] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

On Thu, 2015-08-13 at 17:07 -0700, K. Y. Srinivasan wrote: From: Dexuan Cui de...@microsoft.com This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: Which tree is this in? upstream linus is giving me bad object on that id. Drivers: hv: vmbus: Further improve CPU

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

On Sat, 2014-10-11 at 10:39 -0700, Christoph Hellwig wrote: On Fri, Oct 10, 2014 at 08:49:01AM +0100, Sitsofe Wheeler wrote: Microsoft Hyper-V virtual disks currently only claim SPC-2 compliance even though they implement post SPC-2 features (such as thin provisioning) which means the Linux

Re: [PATCH 2/2] Drivers: scsi: storvsc: Force discovery of LUNs that may have been removed.

On Fri, 2014-08-29 at 10:13 +0200, Hannes Reinecke wrote: On 08/29/2014 09:39 AM, Bart Van Assche wrote: On 08/29/14 08:19, Hannes Reinecke wrote: On 08/29/2014 04:42 AM, Mike Christie wrote: How are distros handling 0x6/0x3f/0x0e (report luns changed) when it gets passed to userspace? Is

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote: -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Monday, July 28, 2014 12:03 PM To: KY Srinivasan Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig;

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Fri, 2014-07-25 at 16:47 +, KY Srinivasan wrote: -Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Thursday, July 24, 2014 8:54 AM To: Sitsofe Wheeler Cc: Martin K. Petersen; Christoph Hellwig; KY Srinivasan;

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: Microsoft Hyper-V targets currently only claim SPC-2 compliance / no compliance indicated even though they implement post SPC-2 features which means those features are not tested for. Add a blacklist flag to Hyper-V devices that forces

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) wrote: In sd_sync_cache: rq-timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER; Regardless of the baseline for the multiplication, a magic number of 2 is too arbitrary. That might work for an individual drive, but could be far

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote: We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. What kernel coding style? checkpatch isn't the arbiter of style, if that's the

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On Fri, 2014-07-18 at 16:44 +, KY Srinivasan wrote: -Original Message- From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org] Sent: Friday, July 18, 2014 8:11 AM To: KY Srinivasan Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph Hellwig

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

to you? Yes: Reviewed-by: James Bottomley jbottom...@parallels.com James ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage) wrote: From: James Bottomley [mailto:jbottom...@parallels.com] On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) wrote: ... Also, in both sd_setup_flush_cmnd and sd_sync_cache: cmd

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote: On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 04:01 -0700, h...@infradead.org wrote: On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote: KY == KY Srinivasan k...@microsoft.com writes: KY Windows hosts do support UNMAP and set the field in the KY EVPD. However, since the host advertises SPC-2

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 13:47 -0400, Martin K. Petersen wrote: Christoph == hch@infradead org h...@infradead.org writes: Christoph Oh, we actually have devices that support WRITE SAME with Christoph unmap, but not without? That's defintively a little strange. Yep :( There were several

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 14:45 -0400, Martin K. Petersen wrote: James == James Bottomley jbottom...@parallels.com writes: I don't have a problem with a BLIST_PREFER_UNMAP flag or something like that. But BLIST_TRY_VPD_PAGES seems more generally useful and it does fix the problem at hand

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 15:08 -0400, Martin K. Petersen wrote: James == James Bottomley jbottom...@parallels.com writes: James It's the code we identified in sd.c:read_capacity_16(): That's there to support devices that implement thin provisioning but which predate the LBP VPD page

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Thu, 2014-07-10 at 21:02 +, KY Srinivasan wrote: -Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Wednesday, July 9, 2014 3:27 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; m...@mkp.net; h...@infradead.org; de

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-09 at 19:52 +, KY Srinivasan wrote: -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, July 9, 2014 1:43 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-09 at 21:14 +, KY Srinivasan wrote: -Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Wednesday, July 9, 2014 12:57 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; h...@infradead.org; de...@linuxdriverproject.org

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

On Wed, 2014-06-04 at 09:33 -0700, K. Y. Srinivasan wrote: Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the basic I/O timeout of the device. Fix this bug. Signed-off-by: K. Y. Srinivasan

Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

On Thu, 2014-05-22 at 10:49 +, KY Srinivasan wrote: -Original Message- From: Andy Whitcroft [mailto:a...@canonical.com] Sent: Wednesday, May 21, 2014 7:25 AM To: Ian Abbott Cc: linux-s...@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan; Haiyang Zhang; James

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com Suggested-by: James Bottomley james.bottom...@hansenpartnership.com That is my patch, isn't it, just with a slightly modified comment: http://marc.info/?l=linux-scsim=137908428211951 Andy promised

Re: [PATCH 2/2] scsi: hyper-v storvsc -- host takes MAINTENANCE_IN commands badly -- elide them

On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com BugLink: http://bugs.launchpad.net/bugs/1234417 This is a pretty low quality bug report; where's the analysis that should be in your patch? The problem is, is it not, that when you turn on trim we

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote: On 2014-05-16 18:14, James Bottomley wrote: On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com Suggested-by: James Bottomley james.bottom...@hansenpartnership.com That is my patch, isn't

Re: [PATCH 1/2] scsi: hyper-v storvsc switch up to SPC-3

On Fri, 2014-05-16 at 19:18 +0100, Ian Abbott wrote: On 2014-05-16 18:58, James Bottomley wrote: On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote: On 2014-05-16 18:14, James Bottomley wrote: On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: From: Andy Whitcroft a...@canonical.com

Re: Drivers: scsi: FLUSH timeout

On Fri, 2013-10-04 at 15:02 +, KY Srinivasan wrote: -Original Message- From: Eric Seppanen [mailto:e...@purestorage.com] Sent: Thursday, October 03, 2013 1:49 PM To: Nicholas A. Bellinger Cc: KY Srinivasan; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

On Fri, 2013-10-04 at 12:38 -0700, K. Y. Srinivasan wrote: Rather than having a separate constant for specifying the timeout on FLUSH operations, use the basic I/O timeout value that is already configurable on a per target basis to derive the FLUSH timeout. Looking at the current definitions