chdev independant").
>
>Remove this unused code and update the documentation accordingly since.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
;unsupported configurations, we can effectively get rid of
>switchdev_port_attr_get() entirely since this was the only place where
>it was called.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
Thanks!
___
devel mailing list
de...@lin
E_FLAGS_SUPPORT therefore becomes unused.
>
>Reviewed-by: Ido Schimmel
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
and returns not
>supported for any flag set, since DSA does not currently support
>toggling those bridge port attributes (yet).
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@lin
off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
at attribute first, check the results and then do the actual setting.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
is
>used.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
he switchdev driver in order to return whether
>the operation is supported or not.
>
>This is entirely analoguous to how the BRIDGE_FLAGS_SUPPORT works,
>except it goes through a set() instead of get().
>
>Signed-off-by: Florian F
Tue, Feb 12, 2019 at 02:14:47PM CET, ido...@mellanox.com wrote:
>On Mon, Feb 11, 2019 at 11:09:52AM -0800, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series finishes by the removal of switchdev_ops. To get there
>> we convert the existing switchdev_port_attr_{set,get} switchdev_ops to
>>
Mon, Feb 11, 2019 at 10:17:48PM CET, f.faine...@gmail.com wrote:
>There is no code that attempts to get the
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute, remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
_
Mon, Feb 11, 2019 at 10:17:49PM CET, f.faine...@gmail.com wrote:
>There is no code that tries to get the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS, remove support for doing that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
_
Mon, Feb 11, 2019 at 10:17:47PM CET, f.faine...@gmail.com wrote:
>There is no code that will query the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
>attribute remove support for that.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
d
Mon, Feb 11, 2019 at 10:17:46PM CET, f.faine...@gmail.com wrote:
>Hi all,
>
>AFAICT there is no code that attempts to get the value of the attribute
>SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with
>switchdev_port_attr_set().
>
>This is effectively no doing anything and it can slow down
ce structure.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ort_attr_notify() that sends the switchdev
>notifications SWITCHDEV_PORT_ATTR_GET and _SET.
>
>Update switchdev_port_attr_get() to dispatch to this new function. Drop
>__switchdev_port_attr_set() and update switchdev_port_attr_set()
>likewise.
>
>Signed-off-by: Flo
70,6 +1591,9 @@ static int dsa_slave_switchdev_blocking_event(struct
>notifier_block *unused,
> case SWITCHDEV_PORT_OBJ_ADD: /* fall through */
> case SWITCHDEV_PORT_OBJ_DEL:
> return dsa_slave_switchdev_port_obj_event(event, dev, ptr);
>+ cas
V_PORT_ATTR_GET/SET and simply translate that into the existing
>swdev_port_attr_{set,get} calls.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
elot_switchdev_blocking_event(struct
>notifier_block *unused,
> ocelot_netdevice_dev_check,
> ocelot_port_obj_del);
> return notifier_from_errno(err);
>+ case SWITCHDEV_PORT_ATTR_SET:
V_PORT_ATTR_GET/SET and simply translate that into the existing
>mlxsw_sp_port_attr_{set,get} calls.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
ts targeting
>SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing
>rocker_port_attr_{set,get} calls.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproj
himmel
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
quot;net: Get rid of
>SWITCHDEV_ATTR_ID_PORT_PARENT_ID").
>
>Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject
Sat, Feb 09, 2019 at 01:36:18AM CET, f.faine...@gmail.com wrote:
>On 2/8/19 4:32 PM, Florian Fainelli wrote:
>> Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field
>> from all clients, which were migrated to use switchdev notification in
>> the previous patches.
>>
>> Add a
Sat, Feb 09, 2019 at 07:21:47PM CET, j...@resnulli.us wrote:
[...]
>>+static int
>>+rocker_switchdev_port_attr_event(unsigned long event, struct net_device
>>*netdev,
>>+ struct switchdev_notifier_port_attr_info
>>+ *port_attr_info)
>>+{
Sat, Feb 09, 2019 at 01:32:42AM CET, f.faine...@gmail.com wrote:
>Following patches will change the way we communicate getting or setting
Just "setting", no "getting".
>a port's attribute and use a blocking notifier to perform those tasks.
>
>Prepare rocker to support receiving notifier events
ext to SWITCHDEV_PORT_OBJ_ADD and
SWITCHDEV_PORT_OBJ_DEL. Up to you.
With or without that:
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
;unsupported configurations, we can effectively get rid of
>switchdev_port_attr_get() entirely since this was the only place where
>it was called.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@lin
flag through SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
E_FLAGS_SUPPORT therefore becomes unused.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nce DSA does not currently support toggling those
>bridge port attributes (yet).
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Sat, Feb 09, 2019 at 01:32:35AM CET, f.faine...@gmail.com wrote:
>In preparation for removing SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT,
>have ethsw check that the bridge port flags that are being set are
>supported.
>
>Signed-off-by: Florian Fainelli
Acked
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
does not need to be unique between switches on
>-different systems.
>+The switchdev driver must implement the net_device operation
>+ndo_get_port_parent_id for each port netdev, returning the same physical ID
Double space. Otherwise, this looks fine.
Acked-by: Jiri Pirko
>+f
Wed, Feb 06, 2019 at 12:53:26AM CET, f.faine...@gmail.com wrote:
>Now that we have a dedicated NDO for getting a port's parent ID, get rid
>of SWITCHDEV_ATTR_ID_PORT_PARENT_ID and convert all callers to use the
>NDO exclusively. This is a preliminary change to getting rid of
>switchdev_ops
t() would do.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t() would do.
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t;u.ppid.id_len = nfp_cpp_serial(port->app->cpp, );
>- memcpy(>u.ppid.id, serial, attr->u.ppid.id_len);
>- break;
>- }
>- default:
>- return -EOPNOTSUPP;
>- }
>+ /* N.B: attr->u.ppid.id is binary data */
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ivers/net/ethernet/mellanox/mlxsw/switchx2.c
Please remove net/switchdev.h inclusion from this file, you don't need
it any longer.
Otherwise, looks fine.
Acked-by: Jiri Pirko
[...]
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxd
mlx5e makes use of switchdev_port_parent_id() convert it to use
>netdev_port_same_parent_id().
>
>Signed-off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
off-by: Florian Fainelli
Acked-by: Jiri Pirko
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
his. Looks like a leftover.
Otherwise, looks fine.
Acked-by: Jiri Pirko
> #include
> #include
> #include
[...]
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
net_device *b);
One is "dev_" and the second is "netdev_". I see there is this
disconnect all over the code, but I wonder if we should not be
consistent for new things. But I don't insist. I see why both are named
differently (netdev_phys_item_id_same())
Acked-by: Jiri Pirko
__
Fri, Feb 01, 2019 at 11:06:44PM CET, f.faine...@gmail.com wrote:
>Hi all,
>
>This patch series converts SWITCHDEV_PORT_ATTR_{GET,SET} to use a
>blocking notifier, similar to how SWITCHDEV_PORT_OBJ_{ADD,DEL} has been
>changed recently by Petr.
>
>This was suggested by Ido to help with a particular
Fri, Feb 01, 2019 at 11:06:45PM CET, f.faine...@gmail.com wrote:
>In preparation for allowing switchdev enabled drivers to veto specific
>attribute settings from within the context of the caller, introduce a
>new switchdev notifier type for port attributes.
>
>Suggested-by: Ido Schimmel
Sun, Nov 12, 2017 at 09:02:14PM CET, step...@networkplumber.org wrote:
>Support for Decnet has been orphaned for many years.
>In the interest of reducing the potential bug surface and pre-holiday
>cleaning, move the decnet protocol into staging for eventual removal.
>
>Signed-off-by: Stephen
49 matches
Mail list logo
