Re: [PATCH v4 23/79] staging: media: ipu3: use pm_runtime_resume_and_get()

On Fri, Apr 30, 2021 at 06:03:38PM +0100, Jonathan Cameron wrote: > On Wed, 28 Apr 2021 16:51:44 +0200 > Mauro Carvalho Chehab wrote: > > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal > > with usage counter") > > added pm_runtime_resume_and_get() in order to

Re: [PATCH v4 00/79] Address some issues with PM runtime at media subsystem

On Thu, Apr 29, 2021 at 12:18:16PM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Apr 2021 17:50:08 +0200 > Johan Hovold escreveu: > > > On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote: > > > > 1. despite its name, this is actual

Re: [PATCH v4 00/79] Address some issues with PM runtime at media subsystem

On Wed, Apr 28, 2021 at 04:51:21PM +0200, Mauro Carvalho Chehab wrote: > During the review of the patches from unm.edu, one of the patterns > I noticed is the amount of patches trying to fix pm_runtime_get_sync() > calls. > > After analyzing the feedback from version 1 of this series, I noticed >

Re: [PATCH v4 20/79] staging: media: rkvdec: fix pm_runtime_get_sync() usage count

On Wed, Apr 28, 2021 at 04:51:41PM +0200, Mauro Carvalho Chehab wrote: > The pm_runtime_get_sync() internally increments the > dev->power.usage_count without decrementing it, even on errors. > Replace it by the new pm_runtime_resume_and_get(), introduced by: > commit dd8088d5a896 ("PM: runtime:

Re: [PATCH 17/78] staging: media: vde: use pm_runtime_resume_and_get()

On Tue, Apr 27, 2021 at 11:22:50AM +0200, Mauro Carvalho Chehab wrote: > Hi Dmitry, > > Em Sat, 24 Apr 2021 10:35:22 +0300 > Dmitry Osipenko escreveu: > > > 24.04.2021 09:44, Mauro Carvalho Chehab пишет: > > > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal > > > with

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

On Fri, Feb 12, 2021 at 03:25:29PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:52, Johan Hovold wrote: > > But what will the checkpatch crew then work on? > > Lol.. > > > Better staging than the rest of the kernel. > > [ /me wondering on who stops them

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote: > On 12-02-21, 10:17, Greg KH wrote: > > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote: > > > On 12-02-21, 13:48, Pritthijit Nath wrote: > > > > This change fixes a checkpatch CHECK style issue for "Alignment should > >

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote: > Fixed the spelling of 'transfered' to 'transferred'. > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/greybus/hid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

On Wed, Jan 06, 2021 at 01:04:04PM +0100, Johan Hovold wrote: > On Tue, Jan 05, 2021 at 04:19:02PM +0100, Greg Kroah-Hartman wrote: > > The correct user/kernel api for vibrator devices is the Input rumble > > api, not a random sysfs file like the greybus vibrator driver cur

Re: [PATCH 1/2] staging: greybus: vibrator: use proper API for vibrator devices

rator driver so that it > hooks up to the kernel and userspace correctly. > > Cc: Johan Hovold > Cc: Alex Elder > Signed-off-by: Greg Kroah-Hartman > --- > drivers/staging/greybus/vibrator.c | 59 ++ > 1 file changed, 59 insertions(+) > > di

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

On Mon, Jan 04, 2021 at 03:34:10PM +0300, Dan Carpenter wrote: > There is a Smatch warning for this, but I hadn't looked at the results > in a while. :/ I'm not sure how many are valid. Some kind of > annotation would be nice. > drivers/usb/class/usblp.c:593 usblp_ioctl() error: doing dma on

Re: [PATCH -next] greybus/audio_helper: Add missing unlock to avoid mismatched lock

On Mon, Dec 21, 2020 at 09:02:46PM +0800, Zheng Yongjun wrote: > Fix a missing unlock in the error branch. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/greybus/audio_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/audio_helper.c >

Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls

On Fri, Dec 11, 2020 at 08:29:22PM +0800, wanghai (M) wrote: > > 在 2020/12/8 17:35, Johan Hovold 写道: > > On Sat, Dec 05, 2020 at 06:38:27PM +0800, Wang Hai wrote: > >> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an > >> error > &g

Re: [PATCH v2] staging: greybus: Add TODO item about modernizing the pwm code

On Tue, Dec 08, 2020 at 11:16:07AM +0100, Uwe Kleine-König wrote: > drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers > should stick to the atomic API instead. > > Signed-off-by: Uwe Kleine-König > --- > On 12/8/20 10:39 AM, Johan Hovold wrot

Re: [PATCH] greybus: Add TODO item about modernizing the pwm code

On Fri, Dec 04, 2020 at 07:33:35PM +0100, Uwe Kleine-König wrote: > drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers > should stick to the atomic API instead. > --- No sign off? Please also add a staging prefix since this part of greybus still lives there. >

Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls

found\n", > widget->name); > - return -EINVAL; > + widget++; > + continue; > } > widget++; > #ifdef CONFIG_DEBUG_FS Not sure if

Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()

On Fri, Dec 04, 2020 at 05:19:25PM +0800, wanghai (M) wrote: > > 在 2020/12/4 16:40, Johan Hovold 写道: > > On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote: > >> Add the missing unlock before return from function > >> gbaudio_dapm_free_controls() in the error

Re: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()

On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote: > Add the missing unlock before return from function > gbaudio_dapm_free_controls() in the error handling case. > > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic > audio module") > Reported-by: Hulk Robot >

Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote: > This assignment is the more peculiar of the bunch as it assigns the parent > of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's > parent. > > It's unclear whether this is intentional or not. > Hence it

[PATCH] staging: greybus: uart: replace driver line-coding struct

the structures match again. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 55c51143bb09..84de56800a21 100644 --- a/drivers

Re: [greybus-dev] [PATCH] greybus: uart: fix uninitialized flow control variable

On Wed, Apr 29, 2020 at 03:00:44PM -0500, Alex Elder wrote: > On 4/29/20 2:00 PM, Arnd Bergmann wrote: > > gcc-10 points out an uninitialized variable use: > > Wow, nice, checking individual uninitialized fields within > the structure. > > The structure should really be zero-initialized anyway;

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

On Thu, Mar 12, 2020 at 05:51:11PM +0300, Dan Carpenter wrote: > On Wed, Mar 11, 2020 at 10:58:14AM +0100, Johan Hovold wrote: > > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote: > > > Since snprintf() returns the would-be-output size instead of the > &

[PATCH 3/3] staging: greybus: loopback_test: fix potential path truncations

86 ("greybus: tools: Add tools directory to greybus repo and add loopback") Signed-off-by: Johan Hovold --- drivers/staging/greybus/tools/loopback_test.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback_

[PATCH 2/3] staging: greybus: loopback_test: fix potential path truncation

~ Fix this by making sure the buffer is large enough the concatenated strings. Fixes: 6b0658f68786 ("greybus: tools: Add tools directory to greybus repo and add loopback") Fixes: 9250c0ee2626 ("greybus: Loopback_test: use poll instead of inotify") Signed-off-by: Johan Hovold

[PATCH 1/3] staging: greybus: loopback_test: fix poll-mask build breakage

A scripted conversion from userland POLL* to kernel EPOLL* constants mistakingly replaced the poll flags in the loopback_test tool, which therefore no longer builds. Fixes: a9a08845e9ac ("vfs: do bulk POLL* -> EPOLL* replacement") Cc: stable # 4.16 Signed-off-by: Johan Hovold

[PATCH 0/3] staging: greybus: loopback_test: fix build breakage

The loopback_test tool hasn't received much love lately. In fact, it has failed to build for the past two years after a scripted EPOLL* conversion. Newer GCC also started warning for potential string truncation of generated path names; the last two patches addresses that. Johan Johan Hovold (3

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

On Wed, Mar 11, 2020 at 05:45:31PM +0100, Takashi Iwai wrote: > On Wed, 11 Mar 2020 17:40:02 +0100, Johan Hovold wrote: > > But isn't the first snprintf() in such a sequence as much a part of the > > problem as the following ones? > > > > If the first pos = snprintf

Re: [PATCH RESEND] staging: greybus: loopback_test: Use scnprintf() for avoiding potential buffer overflow

On Wed, Mar 11, 2020 at 11:09:59AM +0100, Johan Hovold wrote: > On Wed, Mar 11, 2020 at 11:05:35AM +0100, Takashi Iwai wrote: > > Since snprintf() returns the would-be-output size instead of the > > actual output size, the succeeding calls may go beyond the given > &g

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

On Wed, Mar 11, 2020 at 12:01:26PM +0100, Takashi Iwai wrote: > On Wed, 11 Mar 2020 11:09:03 +0100, > Johan Hovold wrote: > > > > On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote: > > > On Wed, 11 Mar 2020 10:58:14 +0100, > > > Johan Hovold wrote: &

Re: [PATCH RESEND] staging: greybus: loopback_test: Use scnprintf() for avoiding potential buffer overflow

y: Takashi Iwai > --- > > Just corrected the subject prefix per request. Acked-by: Johan Hovold ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote: > On Wed, 11 Mar 2020 10:58:14 +0100, > Johan Hovold wrote: > > > > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote: > > > Since snprintf() returns the would-be-output size instead of t

Re: [PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote: > Since snprintf() returns the would-be-output size instead of the > actual output size, the succeeding calls may go beyond the given > buffer limit. Fix it by replacing with scnprintf(). > > Signed-off-by: Takashi Iwai > --- >

Re: [PATCH] staging: greybus: Replace zero-length array with flexible-array member

On Tue, Feb 11, 2020 at 03:12:19PM -0600, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced.

On Sun, Jan 26, 2020 at 02:01:30PM +0530, Saurav Girepunje wrote: > Fix the warning reported by cocci check. > > Changes: > > In queue_work fw dereference before it actually get assigned. > move queue_work before gb_bootrom_set_timeout. Nope. As I said yesterday, you need to verify the output

Re: [PATCH] staging: greybus: bootrom: fix uninitialized variables

On Sat, Jan 25, 2020 at 02:14:03PM +0530, Saurav Girepunje wrote: > fix uninitialized variables issue found using static code analysis tool Which tool is that? > (error) Uninitialized variable: offset > (error) Uninitialized variable: size > > Signed-off-by: Saurav Girepunje > --- >

Re: [PATCH] staging: rtl8192e: rtllib_module: Fix memory leak in alloc_rtllib

On Sun, Dec 15, 2019 at 08:42:47PM -0600, Navid Emamdoost wrote: > Hi Johan, > > On Sun, Dec 15, 2019 at 7:23 AM Johan Hovold wrote: > > > > On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote: > > > In the implementation of alloc_rtllib() the allocat

Re: [PATCH] staging: rtl8192e: rtllib_module: Fix memory leak in alloc_rtllib

On Sat, Dec 14, 2019 at 05:05:58PM -0600, Navid Emamdoost wrote: > In the implementation of alloc_rtllib() the allocated dev is leaked in > case of ieee->pHTInfo allocation failure. Release via free_netdev(dev). > > Fixes: 6869a11bff1d ("Staging: rtl8192e: Use !x instead of x == NULL") This is

[PATCH 0/2] staging: fix USB altsetting bugs

), I've marked these for stable as well. Johan Johan Hovold (2): staging: rtl8188eu: fix interface sanity check staging: rtl8712: fix interface sanity check drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- drivers/staging/rtl8712/usb_intf.c | 2 +- 2 files changed, 2 insertions

[PATCH 2/2] staging: rtl8712: fix interface sanity check

("staging: r8712u: Add the new driver to the mainline kernel") Cc: stable # 2.6.37 Signed-off-by: Johan Hovold --- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/

[PATCH 1/2] staging: rtl8188eu: fix interface sanity check

("staging: r8188eu: Add files for new driver - part 20") Cc: stable # 3.12 Signed-off-by: Johan Hovold --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging

[PATCH v2 1/3] staging: gigaset: fix general protection fault on probe

emens Gigaset drivers - M105 USB DECT adapter") Cc: stable # 2.6.17 Cc: Hansjoerg Lipp Cc: Tilman Schmidt Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c b/drive

[PATCH v2 3/3] staging: gigaset: add endpoint-type sanity check

Add missing endpoint-type sanity checks to probe. This specifically prevents a warning in USB core on URB submission when fuzzing USB descriptors. Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v2 2/3] staging: gigaset: fix illegal free on probe errors

dt Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c b/drivers/staging/isdn/gigaset/usb-gigaset.c index 5e393e7dde45..a84722d83bc6 100644 --- a/drivers/st

[PATCH v2 0/3] staging: gigaset: fix crashes on probe

the crashes have been fixed. Johan Changes in v2 - use usb_endpoint_is_bulk_out() and friends in patch 3/3, and drop patch 4/4 which only renamed an identifier. Johan Hovold (3): staging: gigaset: fix general protection fault on probe staging: gigaset: fix illegal free on probe errors

Re: [PATCH 1/4] staging: gigaset: fix general protection fault on probe

On Sun, Dec 01, 2019 at 01:41:56PM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 01, 2019 at 01:30:42PM +0100, Tilman Schmidt wrote: > > Hi Johan, > > > > this is probably caused by the move of the driver to staging in > > kernel release 5.3 half a year ago. If you want your patches to > > apply

Re: [PATCH 0/4] staging: gigaset: fix crashes on probe

On Fri, Nov 29, 2019 at 02:32:39PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 29, 2019 at 11:17:49AM +0100, Johan Hovold wrote: > > Syzbot has been reporting a GPF on probe in the gigaset ISDN driver, > > which have since been moved to staging. > > > > The f

[PATCH 4/4] staging: gigaset: rename endpoint-descriptor identifier

Rename an endpoint-descriptor pointer to shut up a checkpatch warning about a line being over 80 columns, which is bound to generate a bunch of clean up patches otherwise. Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 20 ++-- 1 file changed, 10

[PATCH 3/4] staging: gigaset: add endpoint-type sanity check

Add endpoint type-sanity checks to prevent a warning in USB core on URB submission. Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c b/drivers/staging/isdn

[PATCH 2/4] staging: gigaset: fix illegal free on probe errors

dt Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c b/drivers/staging/isdn/gigaset/usb-gigaset.c index 5e393e7dde45..a84722d83bc6 100644 --- a/drivers/st

[PATCH 1/4] staging: gigaset: fix general protection fault on probe

emens Gigaset drivers - M105 USB DECT adapter") Cc: stable # 2.6.17 Cc: Hansjoerg Lipp Cc: Tilman Schmidt Signed-off-by: Johan Hovold --- drivers/staging/isdn/gigaset/usb-gigaset.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/isdn/gigaset/usb-gigaset.c b/drive

[PATCH 0/4] staging: gigaset: fix crashes on probe

the crashes have been fixed. And while I hate playing checkpatch games, the final patch addresses a checkpatch warning introduced on purpose by the third patch. Johan Johan Hovold (4): staging: gigaset: fix general protection fault on probe staging: gigaset: fix illegal free on probe errors

Re: [PATCH] staging: greybus: loopback_test: remove multiple blank lines

On Wed, Sep 04, 2019 at 09:05:47PM +, Pedro Chinen wrote: > Fix following checkpath warnings in multiple lines: > CHECK: Please don't use multiple blank lines Checkpatch reports five instances of this CHECK, please fix them all in one go. > Signed-off-by: Pedro Chinen > --- >

Re: [PATCH] staging: greybus: Adding missing brackets into if..else block.

On Wed, Sep 04, 2019 at 08:32:09PM +, Julio Faracco wrote: > Inside a block of if..else conditional, else structure does not contain > brackets. This is not following regular policies of good coding style. s/good/kernel/ ? > All parts of this conditional blocks should respect brackets

Re: [PATCH] staging: greybus: remove blank line after an open brace '{'.

On Wed, Sep 04, 2019 at 08:55:58PM +, joahannes wrote: > Fix checkpatch error > "CHECK: Blank lines aren't necessary after an open brace '{'" > in loopback_test.c:742. Please fix up all of the blank lines before/after closing/opening brace checkpatch CHECKs in one go. There appears to be many

Re: [PATCH v2] staging: greybus: fix more header declarations

ed-off-by: Rui Miguel Silva > --- > v1->v2: > Johan Hovold: > - use forward declarations instead including all headers Reviewed-by: Johan Hovold > include/linux/greybus/operation.h | 2 +- > include/linux/greybus/svc.h | 2 ++ > 2 files changed, 3 insertions(+),

Re: [PATCH] staging: greybus: fix more header includes

On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: > More headers needed to be fixed when moving greybus out of staging and > enabling the COMPILE_TEST option. > > Reported-by: kbuild test robot > Signed-off-by: Rui Miguel Silva > --- > include/linux/greybus/operation.h | 1 + >

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

in v2: > - Rebase on top of 47830c1127ef ("staging: greybus: power_supply: fix > prop-descriptor request size") Thanks for rebasing. Reviewed-by: Johan Hovold Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On Wed, Apr 17, 2019 at 06:19:50AM -0500, Alex Elder wrote: > I'm not completely sure about the inline function, but on the no blank > lines thing (and many other minor issues) "checkpatch.pl" is to blame. > There are lots of examples of issues that checkpatch points out that are > matters of

Re: [PATCH] Staging: greybus: Cleanup in header file control.h

On Mon, Apr 15, 2019 at 05:40:16PM +0300, Dan Carpenter wrote: > What I'm saying is that if we just apply it then we avoid the long > discussion forever. The macro is OK, sure, but it's not like anyone is > going to come back later and argue that macros are better or preferred. That may be a

Re: [PATCH] Staging: greybus: Cleanup in header file control.h

On Mon, Apr 15, 2019 at 04:33:57PM +0300, Dan Carpenter wrote: > On Mon, Apr 15, 2019 at 03:10:02PM +0200, Johan Hovold wrote: > > On Fri, Apr 05, 2019 at 03:14:37PM -0500, Madhumitha Prabakaran wrote: > > > Fix a blank line after function/struct/union/enum > > >

Re: [PATCH] Staging: greybus: Cleanup in header file control.h

On Fri, Apr 05, 2019 at 03:14:37PM -0500, Madhumitha Prabakaran wrote: > Fix a blank line after function/struct/union/enum > declarations. Also, convert to_gb_control() macro into an inline > function in order to maintain Linux kernel coding style based > on which the inline function is

Re: [greybus-dev] [PATCH] Staging: greybus: Fix spinlock_t definition without comment

On Fri, Apr 05, 2019 at 05:50:10PM -0500, Alex Elder wrote: > On 4/5/19 3:53 PM, Dan Carpenter wrote: > > On Fri, Apr 05, 2019 at 03:00:46PM -0500, Madhumitha Prabakaran > > wrote: > >> Fix spinlock_t definition without comment. > >> > >> Signed-off-by: Madhumitha Prabakaran > > Madhumitha, the

Re: [PATCH] Staging: greybus: usb: Fixed a coding style error

On Sun, Mar 31, 2019 at 01:30:40AM -0400, Will Cunningham wrote: > Line was >80 characters. > > Signed-off-by: Will Cunningham > --- > drivers/staging/greybus/usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/usb.c

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

On Thu, Apr 04, 2019 at 08:09:51AM +0100, Rui Miguel Silva wrote: > Hi Gustavo, > Thanks a lot for the patch. > > On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded > > version > > in order to avoid any potential type

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

On Wed, Apr 03, 2019 at 03:58:01PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace code of the following

[PATCH] staging: greybus: power_supply: fix prop-descriptor request size

, but this could still cause trouble on the remote end due to the unexpected message size. Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors") Cc: stable # 4.9 Cc: Rui Miguel Silva Signed-off-by: Johan Hovold --- drivers/staging/greybus/power_supply.c | 2 +- 1 file

Re: [PATCH] tty: Fix WARNING in tty_set_termios

On Thu, Jan 31, 2019 at 04:18:33PM +0100, Marcel Holtmann wrote: > > I agree with Al that this change doesn't make much sense. The WARN_ON > > is there to catch any bugs leading to the termios being changed for a > > master side pty. Those should bugs should be fixed, and not worked > > around in

Re: [PATCH] tty: Fix WARNING in tty_set_termios

On Mon, Jan 28, 2019 at 02:29:22PM -0700, shuah wrote: > On 1/25/19 9:14 PM, Al Viro wrote: > > On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: > >> tty_set_termios() has the following WARMN_ON which can be triggered with a > >> syscall to invoke TIOCGETD __NR_ioctl. You meant

[PATCH] staging: speakup: fix tty-operation NULL derefs

hawaja Cc: Samuel Thibault Signed-off-by: Johan Hovold --- drivers/staging/speakup/spk_ttyio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c index c92bbd05516e..005de0024dd4 100644 --- a/drive

Re: [PATCH v7 0/3] greybus: gpio: Switch to the gpio descriptor interface

On Mon, Jan 14, 2019 at 08:25:07PM +0530, Nishad Kamdar wrote: > This patch series converts uses of the old GPIO API to the GPIO > descriptor API. It also converts the GPIO driver to use the > GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing > the same. > > Chnages in v7: > -

Re: [PATCH v6 0/2] greybus: gpio: Switch to the gpio descriptor interface

On Fri, Jan 11, 2019 at 09:03:16PM +0530, Nishad Kamdar wrote: > This patch series converts uses of the old GPIO API to the GPIO > descriptor API. It also converts the GPIO driver to use the > GPIO irqchip library GPIOLIB_IRQCHIP instead of repimplementing > the same. > > Changes in v6: > -

Re: [PATCH v5 3/3] staging: greybus: arche-platform: Switch to the gpio descriptor interface

s. The issues are there in the current code, but since you modify these messages anyway you might as well fix them up. Please fix that and resend with my Reviewed-by: Johan Hovold Really good job with this! > @@ -435,6 +428,7 @@ static int arche_platform_probe(struct platform_device > *

Re: [PATCH v5 2/3] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

d this patch in a patchset. > Changes in v2: > - Resolved compilation errors. > --- Also looks good now. You can add my Reviewed-by: Johan Hovold Found one really minor nit below, which doesn't really need to be fixed, but since you may need to update the third patch, you might as well con

Re: [PATCH v5 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

Combine patches as into a patch series. > Changes in v2: > - Retained irq.h and irqdomain.h headers. > - Dropped function gb_gpio_irqchip_add() and >called gpiochip_irqchip_add() from probe(). > - Referred > https://lkml.kernel.org/r/1476054589-28422-1-git-send-email-linus.wall...@lin

Re: [PATCH v4 4/4] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Sat, Dec 22, 2018 at 08:23:02PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Move 'gpio_desc *svc_sysboot' below the reset flag >as it is more logical to have

Re: [PATCH v4 3/4] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Sat, Dec 22, 2018 at 08:22:09PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Use gpiod_set_raw_value() for deassert_reset() and >assert_reset() as

Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller()

On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > This patch drops gpio_chip_to_gb_gpio_controller(), > and uses gpiochip_get_data() to retrieve the container > of struct gpio_chip. So this will break the driver, since gpiochip_add() sets the data pointer to NULL. These kind of

Re: [PATCH v4 1/4] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

On Sat, Dec 22, 2018 at 08:17:02PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. > > Signed-off-by: Nishad Kamdar > --- > Changes in v4: > - Remove changes related to conversion to gpiochip_get_data()

Re: [PATCH v3 3/3] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Thu, Nov 22, 2018 at 10:39:24PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v2: > - Move comment to the same line as to what it applies to. > --- >

Re: [PATCH v3 2/3] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Thu, Nov 22, 2018 at 10:38:18PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > Changes in v2: > - Resolved compilation errors. > --- > drivers/staging/greybus/arche-apb-ctrl.c | 159

Re: [PATCH v3 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

On Thu, Nov 22, 2018 at 10:37:16PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. > > Signed-off-by: Nishad Kamdar > --- > Changes in v2: > - Retained irq.h and irqdomain.h headers. > - Dropped

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Sat, Nov 17, 2018 at 12:41:11PM +0530, Nishad Kamdar wrote: > On Fri, Nov 16, 2018 at 05:06:22PM +0100, Johan Hovold wrote: > > On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated > > > o

Re: [PATCH] staging: greybus: arche-platform: Switch to the gpio descriptor interface

On Fri, Nov 16, 2018 at 08:47:44PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated > old non-descriptor interface. > > Signed-off-by: Nishad Kamdar > --- Always include a change log here after the cut-off line so we know what changed since previous versions.

Re: [PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

On Tue, Nov 13, 2018 at 11:48:09PM +0530, Nishad Kamdar wrote: > On Mon, Nov 12, 2018 at 04:15:09PM +0100, Johan Hovold wrote: > > On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote: > > > @@ -40,8 +38,6 @@ struct gb_gpio_controller { > > > s

Re: [PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

On Sun, Nov 11, 2018 at 11:14:14AM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar > --- > drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- > 1 file changed, 65 insertions(+),

Re: [PATCH] greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP

On Fri, Nov 09, 2018 at 01:17:41PM +0530, Nishad Kamdar wrote: > Convert the GPIO driver to use the GPIO irqchip library > GPIOLIB_IRQCHIP instead of reimplementing the same. Thanks for picking this up. Linus W took a stab at it a couple of years ago, but it was never completed. You may want to

Re: [PATCH] staging: greybus: Fix null pointer dereference

On Fri, Aug 24, 2018 at 12:07:11AM -0400, Ding Xiang wrote: > If fw is null then fw->size will trigger null pointer dereference > > Signed-off-by: Ding Xiang > --- > drivers/staging/greybus/bootrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] MAINTAINERS: update two greybus sections

Fix a file entry typo and drop the obsolete timesync entries, which were all caught by: scripts/get_maintainer.pl --self-test=patterns Reported-by: Joe Perches Signed-off-by: Johan Hovold --- This has been reported and at least partially fixed in the past, but due to various other

Re: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL

On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote: > On 03-06-18, 08:52, Janani Sankara Babu wrote: > > This patch replaces comparison of var to NULL with !var > > > > Signed-off-by: Janani Sankara Babu > > --- > > drivers/staging/greybus/core.c | 2 +- > > 1 file changed, 1

Re: [PATCH 01/13] staging: greybus: camera: no need to check debugfs return values

s camera driver by not caring about the value of > debugfs calls. This ends up removing a number of lines of code that > are not needed. > > Cc: Johan Hovold > Cc: Alex Elder > Cc: Greg Kroah-Hartman > Cc: greybus-...@lists.linaro.org > Signed-off-by: Greg

Re: [greybus-dev] [PATCH] staging: greybus: Remove unused local variable

't you get a new error after removing this, i.e "reset set but unused" ? Or > the sizeof() operation on that suppresses those warnings .. That was my initial reaction as well, but I failed to notice the sizeof which prevents the new warning. > Acked-by: Viresh Kumar <viresh.ku...@linaro.org> Acked-by: Johan Hovold <jo...@kernel.org> Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging: greybus: Use gpio_is_valid()

On Wed, May 02, 2018 at 03:15:05PM +0530, Arvind Yadav wrote: > On Wednesday 02 May 2018 02:13 PM, Johan Hovold wrote: > > On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote: > >> Replace the manual validity checks for the GPIO with the > >> gpio_is_va

Re: [PATCH v2] staging: greybus: Use gpio_is_valid()

On Sat, Apr 28, 2018 at 10:05:39AM +0530, Arvind Yadav wrote: > Replace the manual validity checks for the GPIO with the > gpio_is_valid(). > > Signed-off-by: Arvind Yadav > --- > chnage in v2 : > Returning invalid gpio as error instead of -ENODEV. > >

Re: [PATCH 3/9] staging: greybus: Add TODO file with GPIO work items

On Thu, Apr 19, 2018 at 10:41:15AM +0200, Linus Walleij wrote: > To make sure that these drivers do not leave staging before they > are properly converted to use the new GPIO descriptor API, and the > GPIOLIB_IRQCHIP helper library, create the TODO file with these work > items. &g

Re: [PATCH 47/61] staging: greybus: simplify getting .drvdata

On Thu, Apr 19, 2018 at 04:06:17PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Acked-by: Johan Hovold

Re: [PATCH 2/2] staging: irda: Replace mdelay with usleep_range in irda_usb_probe

alls mdelay() to busily wait. > This is not necessary and can be replaced with usleep_range() to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gma

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

; avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> This all looks good (also note the call to usb_control_msg(), which may sleep, just above th

Re: [PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers

le and description. Thanks for the update. Acked-by: Johan Hovold <jo...@kernel.org> Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers

On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote: > Fixes the following coding style issue as noted by checkpatch.pl > at multiple lines: > > Comparison to NULL could be written "!token" > > Signed-off-by: Sumit Pundir Since you're not really fixing

Re: [PATCH] Staging: greybus: audio_codec.h: Change uint32_t to u32

On Wed, Jan 03, 2018 at 03:07:33PM +0530, Sumit Pundir wrote: > This patch fixes the following checkpatch.pl issues: > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t format, rate; > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t

  1   2   3   >