Re: [greybus-dev] [PATCH 1/2] staging: greybus: loopback: use gb_loopback_async_wait_all don't spin

2016-12-20 Thread Johan Hovold
On Tue, Dec 20, 2016 at 01:12:08AM +, Bryan O'Donoghue wrote: > Currently the greybus-loopback thread logic spins around waiting for > send_count == iteration_max which on real hardware doesn't make a > difference to us but in simulation is excruciatingly slow, anti-social and > bad manners. Us

Re: [PATCH v2] staging: greybus: audio_module: remove redundant OOM message

2016-12-06 Thread Johan Hovold
On Tue, Dec 06, 2016 at 07:39:36PM +0530, Srikant Ritolia wrote: > All kmalloc-based functions print enough information on failure > > Signed-off-by: Srikant Ritolia Acked-by: Johan Hovold > --- > Changes in v2: > - Added driver name in the subject for better readabil

Re: [PATCH] staging: greybus: don't print on ENOMEM

2016-12-06 Thread Johan Hovold
module: remove redundant OOM message"). Fix that up and you can add my Acked-by: Johan Hovold Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

2016-11-22 Thread Johan Hovold
On Tue, Nov 22, 2016 at 01:18:21PM +, Bryan O'Donoghue wrote: > On Tue, 2016-11-22 at 13:17 +0100, Johan Hovold wrote: > > [ Resend with Greg's address fixed. ] > > > > On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > > > >

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

2016-11-22 Thread Johan Hovold
[ Resend with Greg's address fixed. ] On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > McCOY: You've got him, Jim! You've got him where you want him. Hey, I ended up watching this one last night. Funny coincidence. > This patchset adds async operations to greybus-core. Rather

Re: [PATCH 0/6] drivers/staging/greybus: add async operations

2016-11-22 Thread Johan Hovold
On Mon, Nov 21, 2016 at 05:22:13PM +, Bryan O'Donoghue wrote: > McCOY: You've got him, Jim! You've got him where you want him. Hey, I ended up watching this one last night. Funny coincidence. > This patchset adds async operations to greybus-core. Rather than have > different drivers do variat

Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

2016-11-18 Thread Johan Hovold
On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote: > This patch fixes the following checkpath.pl warning > WARNING: braces {} are not necessary for single statement blocks > > Fixed indentation error, noted by Dan Carpenter > > Signed-off-by: Rahul Krishnan > --- > drivers/staging/

[PATCH 1/2] staging: greybus: uart: fix invalid user-pointer check

2016-11-08 Thread Johan Hovold
Drop invalid user-pointer check from TIOCGSERIAL handler. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus

[PATCH 2/2] staging: greybus: use get_icount tty operation

2016-11-08 Thread Johan Hovold
Use the tty get_icount operation instead of implementing TIOCGICOUNT directly. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging

Re: Greybus Future

2016-11-01 Thread Johan Hovold
On Mon, Oct 31, 2016 at 08:50:53AM -0500, Alex Elder wrote: > I'm proposing below a few things, which I'll implement this week > unless I hear people express strong opposition (or clearly better > suggestions). If you have comments, please say something. > > Git repositories. Public git reposit

[PATCH] staging: greybus: arche-platform: fix device reference leak

2016-11-01 Thread Johan Hovold
) Signed-off-by: Johan Hovold --- drivers/staging/greybus/arche-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 34307ac3f255..d33d6fe078ad 100644 --- a/drivers/staging/greybus/arche-platform.

Re: [PATCH -next] greybus: es2: fix error return code in ap_probe()

2016-10-19 Thread Johan Hovold
ew bulk in endpoint for > APBridgeA RPC") > Signed-off-by: Wei Yongjun Thanks for the fix. This was clearly broken and would have led to havoc on disconnect as well. Reviewed-by: Johan Hovold Thanks, Johan ___ devel mailing list

Re: [PATCH] staging: greybus: es2: fix arpc request size

2016-10-19 Thread Johan Hovold
On Wed, Oct 19, 2016 at 01:44:25PM +0100, Rui Miguel Silva wrote: > Fix size field of arpc message request by using the header size and not > the pointer size. > > Signed-off-by: Rui Miguel Silva Good catch, Rui. Guess the firmware is missing some sanity checks. Reviewed-by:

Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change_state()

2016-10-17 Thread Johan Hovold
inelle semantic patch. > > Signed-off-by: Wei Yongjun This code is going away eventually, but still. Acked-by: Johan Hovold Thanks, Johan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: greybus: audio: Rename cport with intf_id

2016-10-17 Thread Johan Hovold
On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote: > gb_audio_manager_module_descriptor's cport field is actually used to > manage and pass interface id to user space. > > Thus rename gb_audio_manager_module_descriptor's 'cport' field and > few other things to avoid confusion. Plea

Re: [PATCH] staging: greybus: es2: Use kmemdup instead of kmalloc and memcpy

2016-10-17 Thread Johan Hovold
[+CC: staging list ] On Sun, Oct 16, 2016 at 02:19:48PM +0530, sayli karnik wrote: > This patch replaces kmalloc and memcpy with kmemdup for duplication of > memory. > > Signed-off-by: sayli karnik Acked-by: Johan Hovold > --- > drivers/staging/greybus/es2.c | 3 +-- &g

Re: [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev

2016-10-15 Thread Johan Hovold
On Wed, Oct 12, 2016 at 08:02:22AM +0530, Viresh Kumar wrote: > Some of the print messages are using the incorrect device pointer, fix > them. > > Signed-off-by: Viresh Kumar Acked-by: Johan Hovold ___ devel mailing list de...@linuxdrive

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-15 Thread Johan Hovold
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: > Some of the print messages are using the incorrect device pointer, fix > them. > > Signed-off-by: Viresh Kumar Acked-by: Johan Hovold ___ devel mailing list de...@linuxdrive

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-15 Thread Johan Hovold
On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote: > Greybus GPIO seems to reimplement the already existing generic > gpiolib irqchip. Also use gpiochip_get_data(). Also use > devm_gpiochip_add_data(). > > Cc: Viresh Kumar > Cc: Axel Haslam > Cc: Johan Hovold

Re: [PATCH] Staging: greybus: uart: constify tty_port_operations structure

2016-10-15 Thread Johan Hovold
5682142016 drivers/staging/greybus/uart.o > > File size after: >text data bss dec hex filename >7710 448 5682142016 drivers/staging/greybus/uart.o > > Signed-off-by: Bhumika Goyal Acked-by: Johan Hovold > --- >

Re: [patch] greybus: fix a leak on error in gb_module_create()

2016-10-15 Thread Johan Hovold
On Fri, Oct 14, 2016 at 10:18:21PM +0300, Dan Carpenter wrote: > We should release ->interfaces[0] as well. Indeed. Thanks for the fix. > Fixes: b15d97d77017 ("greybus: core: add module abstraction") > Signed-off-by: Dan Carpenter Acked-by

Re: [PATCH] staging: greybus: fix block comment

2016-10-04 Thread Johan Hovold
; + * and then enter FW flashing state > + */ > poweroff_seq(pdev); > ret = fw_flashing_seq(pdev); > } else { Patch looks fine, but note that someone just sent a patch for this second chunk the other day. Acked-by: Joha

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

2016-10-03 Thread Johan Hovold
On Mon, Oct 03, 2016 at 04:21:09PM +0530, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta Acked-by: Johan Hovold Thanks, Johan ___ devel

<    1   2   3