On Tue, 18 May 2021 13:16:26 +0300
Dan Carpenter wrote:
> On Tue, May 18, 2021 at 05:56:47PM +0800, Tang Bin wrote:
> > In the function ad7746_probe(), the initialized value of 'ret' is unused,
> > because it will be assigned by the function i2c_smbus_write_byte_data(),
> > thus remove it.
> >
On Tue, 18 May 2021 17:27:07 +0800
tangbin wrote:
> Hi Dan：
>
> On 2021/5/18 15:52, Dan Carpenter wrote:
> > On Mon, May 17, 2021 at 11:00:06PM +0800, Tang Bin wrote:
> >> @@ -730,11 +730,7 @@ static int ad7746_probe(struct i2c_client *client,
> >>if (ret < 0)
> >>return ret;
On Wed, 28 Apr 2021 16:52:39 +0200
Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> While there's
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
NOP patch so
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/tegra-video/csi.c | 3 +--
> drivers/staging/media/tegra-video/vi.c | 3 +--
&g
On Fri, 30 Apr 2021 18:08:36 +0100
Jonathan Cameron wrote:
> On Wed, 28 Apr 2021 16:51:46 +0200
> Mauro Carvalho Chehab wrote:
>
> > Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal
> > with usage counter")
> > added
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
LGTM
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/tegra-vde/vde.c | 19 ---
> 1 file changed, 16 insertions(+), 3 deletions(-)
On Wed, 28 Apr 2021 16:51:42 +0200
Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with
> usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new
errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Jonathan Cameron
> ---
> drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
place.
Otherwise reasonable cleanup.
Reviewed-by: Jonathan Cameron
> ---
> drivers/staging/media/ipu3/ipu3.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3.c
> b/drivers/staging/media/ipu3/ipu3.c
> index ee1bba6bdc
On Mon, 15 Mar 2021 19:07:11 +0530
Mugilraj Dhavachelvan wrote:
> Fixes a W=1 warning.
> -Added ``:`` to lock parameter in 'ad9832_state' description.
> -It's a reference comment so removed /**
>
> Signed-off-by: Mugilraj Dhavachelvan
Great. Thanks for tidying this up.
Applied to the togreg
On Wed, 10 Mar 2021 11:51:31 +0200
Alexandru Ardelean wrote:
> This change converts the driver to use device-managed functions in the
> probe function. For the clock and regulator disable, some
> devm_add_action_or_reset() calls are required, and then
> devm_iio_device_register() function can be
On Mon, 25 Jan 2021 15:08:17 +0100
Greg KH wrote:
> On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote:
> > On Sun, Jan 24, 2021 at 4:58 AM Greg KH wrote:
> >
> > >
> > > David Lechner (1):
> > > counter:ti-eqep: remove floor
> >
> > I'm not sure why that ti-eqep counter
On Tue, 15 Sep 2020 10:20:20 +
"Sa, Nuno" wrote:
> > -Original Message-
> > From: Jonathan Cameron
> > Sent: Tuesday, September 15, 2020 12:10 PM
> > To: Sa, Nuno
> > Cc: linux-...@vger.kernel.org; de...@driverdev.osuosl.org; Lar
On Tue, 15 Sep 2020 11:33:45 +0200
Nuno Sá wrote:
> Drop `adis_setup_buffer_and_trigger()`. All users were updated to use
> the devm version of this function. This avoids having almost the same
> code repeated.
>
> Signed-off-by: Nuno Sá
Good to see this cleanup, as long as we tidy up the few
On Tue, 15 Sep 2020 11:33:42 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/imu/adis16480.c | 7 ++-
> 1
On Tue, 15 Sep 2020 11:33:38 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/gyro/adis16136.c | 9 ++---
> 1
On Tue, 15 Sep 2020 11:33:36 +0200
Nuno Sá wrote:
> Use the adis managed device functions to setup the buffer and the trigger.
> The ultimate goal will be to completely drop the non devm version from
> the lib.
>
> Signed-off-by: Nuno Sá
> ---
> drivers/iio/accel/adis16201.c | 16
On Wed, 29 Jul 2020 13:38:28 +0300
Andy Shevchenko wrote:
> On Wed, Jul 29, 2020 at 11:12 AM Ankit Baluni
> wrote:
> >
> > Added a missing comma and changed 'it it useful' to 'it is useful'.
>
> Reviewed-by: Andy Shevchenko
Gah. I had kind of forgotten these docs existed and they have
On Fri, 22 May 2020 11:56:40 +0300
Andy Shevchenko wrote:
> On Fri, May 22, 2020 at 11:36 AM Alexandru Ardelean
> wrote:
> >
> > The change passes the parent device to the iio_device_alloc() call. This
> > also updates the devm_iio_device_alloc() call to consider the device object
> > as the
On Fri, 8 May 2020 13:57:46 +0100
Mark Brown wrote:
> On Fri, May 08, 2020 at 01:43:07PM +0100, Jonathan Cameron wrote:
> > Dan Carpenter wrote:
>
> > > It feels like we should just make a devm_ version of regulator_enable().
> > > Or potentially this is
On Thu, 7 May 2020 12:50:16 +0300
Dan Carpenter wrote:
> On Sat, May 02, 2020 at 07:25:42PM +0100, Jonathan Cameron wrote:
> > On Tue, 28 Apr 2020 12:31:28 +0300
> > Alexandru Ardelean wrote:
> > > +static void ad5933_cleanup(void *data)
> > > +{
>
On Wed, 29 Apr 2020 10:21:29 +0300
Alexandru Ardelean wrote:
> From: Dragos Bogdan
>
> If the serial interface is used, the 8-bit address should be latched using
> the rising edge of the WR/FSYNC signal.
>
> This basically means that a CS change is required between the first byte
> sent, and
On Tue, 28 Apr 2020 12:31:28 +0300
Alexandru Ardelean wrote:
> This change cleans up the driver's probe function to use only devm_
> function variants. This also gets rid of the remove function and moves the
> clock & regulator de-initializations to the 'ad5933_cleanup()' callback.
>
>
On Mon, 6 Apr 2020 08:12:42 +
"Ardelean, Alexandru" wrote:
> On Sun, 2020-04-05 at 11:46 +0100, Jonathan Cameron wrote:
> > [External]
> >
> > On Wed, 1 Apr 2020 15:59:34 +0300
> > Alexandru Ardelean wrote:
> >
> > > This change ad
On Wed, 1 Apr 2020 15:59:36 +0300
Alexandru Ardelean wrote:
> This driver calls iio_kfifo_allocate() vs devm_iio_kfifo_allocate(). But
> the conversion is still simpler here, and cleans-up/reduces some error
> paths.
>
> Signed-off-by: Alexandru Ardelean
This mixes devm managed stuff an
On Wed, 1 Apr 2020 15:59:34 +0300
Alexandru Ardelean wrote:
> This change adds the iio_device_attach_kfifo_buffer() helper/short-hand,
> which groups the simple routine of allocating a kfifo buffers via
> devm_iio_kfifo_allocate() and calling iio_device_attach_buffer().
>
> The mode_flags
On Wed, 1 Apr 2020 15:59:35 +0300
Alexandru Ardelean wrote:
> All drivers that already call devm_iio_kfifo_allocate() &
> iio_device_attach_buffer() are simple to convert to
> iio_device_attach_kfifo_buffer() in a single go/patch/.
>
> This change does that.
>
> For drivers max30100 & max30102
On Sat, 29 Feb 2020 19:35:45 +0530
Rohit Sarkar wrote:
> Since there are no uses of the old GPIO API, remove the item from
> the TODO.
>
> Changelog
> v3: Remove new items added.
> v2: Add work item mentioned by Alexandru in
> https://marc.info/?l=linux-iio=158261515624212=2
Change log belongs
On Thu, 6 Feb 2020 10:19:09 +
"Sa, Nuno" wrote:
> On Thu, 2020-02-06 at 09:45 +0000, Jonathan Cameron wrote:
> > On Wed, 5 Feb 2020 16:44:13 +
> > "Sa, Nuno" wrote:
> >
> > > On Wed, 2020-02-05 at 14:59 +, Jonathan Cameron
On Wed, 5 Feb 2020 16:44:13 +
"Sa, Nuno" wrote:
> On Wed, 2020-02-05 at 14:59 +0000, Jonathan Cameron wrote:
> > On Wed, 5 Feb 2020 12:25:40 +
> > "Sa, Nuno" wrote:
> >
> > > On Mon, 2020-02-03 at 12:03 +, Jonathan Cameron
On Wed, 5 Feb 2020 12:25:40 +
"Sa, Nuno" wrote:
> On Mon, 2020-02-03 at 12:03 +0000, Jonathan Cameron wrote:
> >
> > On Mon, 3 Feb 2020 10:31:30 +0100
> > Nuno Sá wrote:
> >
> > > Hi Jonathan,
> > >
> > >
On Mon, 3 Feb 2020 10:31:30 +0100
Nuno Sá wrote:
> Hi Jonathan,
>
>
> On Sat, 2020-02-01 at 17:08 +0000, Jonathan Cameron wrote:
> > On Mon, 20 Jan 2020 16:20:49 +0200
> > Alexandru Ardelean wrote:
> >
> > > From: Nuno Sá
> > >
> > &g
On Mon, 20 Jan 2020 16:20:49 +0200
Alexandru Ardelean wrote:
> From: Nuno Sá
>
> All the ADIS devices perform, at the beginning, a self test to make sure
> the device is in a sane state. Furthermore, some drivers also do a call
> to `adis_reset()` before the test which is also a good practice.
On Fri, 13 Dec 2019 13:10:36 -0600
Rob Herring wrote:
> On Sat, 7 Dec 2019 01:53:39 -0300, Rodrigo Carvalho wrote:
> > This patch add device tree binding documentation for ADIS16240.
> >
> > Signed-off-by: Rodrigo Carvalho
> > ---
> > V6:
> > - Update SPDX license identifier
> >
> >
On Thu, 5 Dec 2019 09:21:29 -0600
Rob Herring wrote:
> On Sat, Nov 23, 2019 at 08:35:10PM -0300, Rodrigo Carvalho wrote:
> > This patch add device tree binding documentation for ADIS16240.
> >
> > Signed-off-by: Rodrigo Ribeiro Carvalho
>
> checkpatch.pl complains about a mismatch between
On Tue, 3 Dec 2019 16:38:50 +
Mark Brown wrote:
> On Sun, Dec 01, 2019 at 11:40:32AM +0000, Jonathan Cameron wrote:
>
> > +CC Mark as we probably need a more general view point on
> > the question of whether SPI mode should be enforced by binding
> > or in the drive
On Mon, 25 Nov 2019 07:55:39 +
"Ardelean, Alexandru" wrote:
> On Sat, 2019-11-23 at 20:35 -0300, Rodrigo Carvalho wrote:
> > [External]
> >
> > According to the datasheet, this driver supports only SPI mode 3,
> > so we should enforce it and call spi_setup() on probe function.
> >
> >
+CC Mark as we probably need a more general view point on
the question of whether SPI mode should be enforced by binding
or in the driver.
On Mon, 25 Nov 2019 07:51:30 +
"Ardelean, Alexandru" wrote:
> On Sat, 2019-11-23 at 11:41 +0000, Jonathan Cameron wrote:
> > On Sat
On Mon, 25 Nov 2019 11:26:27 +
"Ardelean, Alexandru" wrote:
> On Tue, 2019-10-29 at 18:29 +0200, Beniamin Bia wrote:
> > [External]
> >
> > From: Paul Cercueil
> >
> > AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC.
> >
> > Datasheet:
> > Link:
> >
On Sat, 23 Nov 2019 02:19:27 -0300
Rodrigo Carvalho wrote:
> This patch add device tree binding documentation for ADIS16240.
>
> Signed-off-by: Rodrigo Ribeiro Carvalho
No problem with this patch, but I definitely want to see an accompanying
one enforcing the SPI mode in the driver.
Right now
On Fri, 15 Nov 2019 15:57:20 +0200
Beniamin Bia wrote:
> From: Paul Cercueil
>
> AD7091R5 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC.
>
> This driver will also support AD7091R2/4/8 in the future.
>
> Datasheet:
> Link:
>
On Fri, 15 Nov 2019 15:57:21 +0200
Beniamin Bia wrote:
> From: Paul Cercueil
>
> The scale can now be obtained with the "in_voltage_scale" file.
> By default, the scale returned corresponds to the internal VREF of 2.5V.
>
> It is possible to use an external VREF (through the REFIN/REFOUT pin
On Fri, 15 Nov 2019 15:57:23 +0200
Beniamin Bia wrote:
> Add Beniamin Bia as a maintainer for AD7091R5 ADC.
>
> Signed-off-by: Beniamin Bia
Applied,
Thanks,
Jonathan
> ---
> Changes in v5:
> -nothing changed
>
> MAINTAINERS | 8
> 1 file changed, 8 insertions(+)
>
> diff --git
On Fri, 15 Nov 2019 15:57:22 +0200
Beniamin Bia wrote:
> Documentation for AD7091R5 ADC was added.
>
> Signed-off-by: Beniamin Bia
> Reviewed-by: Rob Herring
Applied.
Thanks,
Jonathan
> ---
> Changes in v5:
> -nothing changed
>
> .../bindings/iio/adc/adi,ad7091r5.yaml| 54
On Tue, 12 Nov 2019 17:35:50 +0200
Beniamin Bia wrote:
> From: Michael Hennerich
>
> ADM1177 is a Hot Swap Controller and Digital Power Monitor with
> Soft Start Pin.
>
> Datasheet:
> Link:
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1177.pdf
>
> Signed-off-by:
On Thu, 7 Nov 2019 17:07:57 +0200
Beniamin Bia wrote:
> From: Paul Cercueil
>
> The scale can now be obtained with the "in_voltage_scale" file.
> By default, the scale returned corresponds to the internal VREF of 2.5V.
>
> It is possible to use an external VREF (through the REFIN/REFOUT pin
On Thu, 7 Nov 2019 17:07:56 +0200
Beniamin Bia wrote:
> From: Paul Cercueil
>
> AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC.
>
I'd like to see a bit of info here about what other ad7091r parts exist
to explain the current split in files.
> Datasheet:
> Link:
>
On Sat, 9 Nov 2019 16:17:28 +0100
Pedro Ortega wrote:
> Add spaces around the minus math operator to increase readability.
>
> Signed-off-by: Pedro Ortega
Hi Pedro,
Afraid not. Look at what that macro is actually doing. That's not a maths
operator at all. I'm fairly sure we had a plan to
On Tue, 5 Nov 2019 14:19:32 -0600
Rob Herring wrote:
> On Thu, Oct 31, 2019 at 09:03:01PM -0300, Rodrigo Carvalho wrote:
> > This patch add device tree binding documentation for ADIS16240.
> >
> > Signed-off-by: Rodrigo Ribeiro Carvalho
> > ---
> > V3:
> >- Remove spi-cpol and spi-cpha
On Mon, 21 Oct 2019 20:06:06 +0300
Beniamin Bia wrote:
> From: Paul Cercueil
>
> The scale can now be obtained with the "in_voltage_scale" file.
> By default, the scale returned corresponds to the internal VREF of 2.5V.
>
> It is possible to use an external VREF (through the REFIN/REFOUT pin
On Mon, 21 Oct 2019 20:06:05 +0300
Beniamin Bia wrote:
> From: Paul Cercueil
>
> AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC.
>
> Datasheet:
> Link:
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf
>
> Signed-off-by: Paul Cercueil
>
On Thu, 17 Oct 2019 12:56:33 +
"Ardelean, Alexandru" wrote:
> On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote:
> > ad9834_probe misses a check for devm_clk_get and may cause problems.
> > Add a check like what ad9832 does to fix it.
> >
>
> This could also use a Fixes tag, but not
On Sat, 14 Sep 2019 02:06:27 +0530
Rohit Sarkar wrote:
> Bcc:
> Subject: [PATCH] staging: iio: adis16240: remove unused include
> Reply-To:
Something odd happened here with patch formatting. I fixed it up and
applied to the togreg branch of iio.git and pushed out as testing
for the
On Fri, 6 Sep 2019 16:58:52 +0800
"Chen, Rong A" wrote:
> On 9/5/2019 5:08 PM, Jonathan Cameron wrote:
> > On Wed, 4 Sep 2019 15:37:11 +0300
> > Andy Shevchenko wrote:
> >
> >> On Wed, Sep 04, 2019 at 11:33:50AM +0800, kbuild test r
On Wed, 4 Sep 2019 15:37:11 +0300
Andy Shevchenko wrote:
> On Wed, Sep 04, 2019 at 11:33:50AM +0800, kbuild test robot wrote:
> > tree:
> > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging.git
> > staging-testing
> > head: 74eb9c06b1d722468db397595ac6834b9e4ac235
> >
On Wed, 21 Aug 2019 17:16:56 +0300
Beniamin Bia wrote:
> Documentation for AD7606B Analog to Digital Converter and software
> mode was added.
>
> Signed-off-by: Beniamin Bia
Tweaked as per Peter's comment and added Rob's Reviewed-by from v2
Seems everyone decided to review this one just as you
On Wed, 21 Aug 2019 17:16:55 +0300
Beniamin Bia wrote:
> The documentation for ad7606 was migrated to yaml.
>
> Signed-off-by: Beniamin Bia
make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
3 things needed fixing beyond the tweak Rob mentioned
On Wed, 21 Aug 2019 17:16:54 +0300
Beniamin Bia wrote:
> Add Beniamin Bia as maintainer for AD7606 driver.
>
> Signed-off-by: Beniamin Bia
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to probably ignore it.
Thanks,
Jonathan
> ---
> Changes in v3:
>
On Wed, 21 Aug 2019 17:16:53 +0300
Beniamin Bia wrote:
> From: Stefan Popa
>
> The AD7606B is a 16-bit ADC that supports simultaneous sampling of 8
> channels. It is pin compatible to AD7606, but adds extra modes by
> writing to the register map.
>
> The AD7606B can be configured to work in
On Wed, 14 Aug 2019 06:56:18 +
"Ardelean, Alexandru" wrote:
> On Tue, 2019-08-13 at 16:31 -0300, Rodrigo Ribeiro wrote:
> > [External]
> >
> > Replace shift and minus operation by GENMASK macro and remove the local
> > variables used to store intermediate data.
> >
>
> Reviewed-by:
On Sun, 11 Aug 2019 13:47:04 -0300
Rodrigo Ribeiro wrote:
> Em dom, 11 de ago de 2019 às 05:43, Jonathan Cameron
> escreveu:
> >
> > On Sat, 10 Aug 2019 12:00:58 -0300
> > Rodrigo wrote:
> >
> > > From: Rodrigo Carvalho
> > >
> > > Im
On Sat, 10 Aug 2019 12:00:58 -0300
Rodrigo wrote:
> From: Rodrigo Carvalho
>
> Improve readability by using GENMASK macro, changing switch statement
> by if statement and removing unnecessary local variables.
>From your description it sounds like multiple changes in one patch.
Always
On Fri, 2 Aug 2019 13:03:01 +0300
Beniamin Bia wrote:
> From: Stefan Popa
>
> The AD7606B is a 16-bit ADC that supports simultaneous sampling of 8
> channels. It is pin compatible to AD7606, but adds extra modes by
> writing to the register map.
>
> The AD7606B can be configured to work in
On Fri, 26 Jul 2019 12:36:08 +
"Ardelean, Alexandru" wrote:
> On Fri, 2019-07-26 at 19:07 +0800, Chuhong Yuan wrote:
> > [External]
> >
> > Use device-managed API to simplify the code.
> > The remove function is redundant now and can
> > be deleted.
>
> Reviewed-by: Alexandru Ardelean
On Fri, 26 Jul 2019 14:59:16 -0300
Matheus Tavares Bernardino wrote:
> On Fri, Jul 26, 2019 at 2:30 AM Ardelean, Alexandru
> wrote:
> >
> > On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote:
> > > Add the of_device_id struct and the respective
> > > of_match_device entry to complete
On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed by: Wilson Sales
> ---
Patch is fine and applied to the
On Mon, 17 Jun 2019 11:40:34 +0300
Dan Carpenter wrote:
> On Sun, Jun 16, 2019 at 11:15:16AM +0100, Jonathan Cameron wrote:
> > On Fri, 14 Jun 2019 13:50:59 -0300
> > Melissa Wen wrote:
> >
> > > Remove idiom and use ternary operator for consistently trigg
On Sat, 8 Jun 2019 12:30:39 +0100
Jonathan Cameron wrote:
> On Mon, 27 May 2019 15:56:49 +0300
> Beniamin Bia wrote:
>
> > Support for ad7616 running in software was added. In order
> > to activate the software mode, HW_RNGSEL pins must be pulled low.
> > Oversampli
On Mon, 17 Jun 2019 13:09:20 +0200
Arnd Bergmann wrote:
> When building without CONFIG_GPIOLIB, we get a compile-time failure:
>
> drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of
> function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
>
On Fri, 14 Jun 2019 13:43:02 -0600
Rob Herring wrote:
> On Fri, 24 May 2019 22:26:30 -0300, Renato Lui Geh wrote:
> > This patch adds a YAML binding for the Analog Devices AD7780/1 and
> > AD7170/1 analog-to-digital converters.
> >
> > Signed-off-by: Renato Lui Geh
> > ---
> > Changes in v2:
>
On Fri, 14 Jun 2019 23:28:46 +0800
YueHaibing wrote:
> Fix build error:
>
> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
> drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
> function gpiod_set_value; did you mean gpio_set_value?
>
On Fri, 14 Jun 2019 13:32:54 -0300
Melissa Wen wrote:
> Since i2c_smbus_write_byte_data returns no-positive value, this commit
> making the treatment of its return value less verbose.
>
> Signed-off-by: Melissa Wen
Applied to the togreg branch of iio.git and pushed out as testing for
the
On Fri, 14 Jun 2019 13:33:19 -0300
Melissa Wen wrote:
> General cleaning of comments to remove useless information or improve
> description.
>
> Signed-off-by: Melissa Wen
Applied,
Thanks,
Jonathan
> ---
> drivers/staging/iio/cdc/ad7150.c | 11 ++-
> 1 file changed, 2
On Fri, 14 Jun 2019 13:32:21 -0300
Melissa Wen wrote:
> Use the bitfield macro FIELD_GET, and GENMASK to do the shift and mask in
> one go. This makes the code more readable than explicit masking followed
> by a shift.
>
> Signed-off-by: Melissa Wen
Applied to the togreg branch of iio.git and
On Fri, 14 Jun 2019 13:50:59 -0300
Melissa Wen wrote:
> Remove idiom and use ternary operator for consistently trigger 0/1 value
> on variable declaration.
>
> Signed-off-by: Melissa Wen
Hi Melissa,
In general I would consider this unnecessary churn as, whilst
it's no longer a favoured idiom,
On Wed, 5 Jun 2019 20:24:09 -0700
Randy Dunlap wrote:
> On 6/5/19 7:05 PM, Fabio Estevam wrote:
> > On x86_64 when GPIOLIB is not set the following build errors
> > are seen:
> >
> > drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of
> > function 'gpiod_set_value'
On Mon, 27 May 2019 15:56:50 +0300
Beniamin Bia wrote:
> Support for register access was added for spi devices.
>
> Signed-off-by: Beniamin Bia
> Acked-by: Jonathan Cameron
Applied.
Thanks,
Jonathan
> ---
> Changes in v2:
> -nothing changed
>
> dr
On Mon, 27 May 2019 15:56:49 +0300
Beniamin Bia wrote:
> Support for ad7616 running in software was added. In order
> to activate the software mode, HW_RNGSEL pins must be pulled low.
> Oversampling and input ranges are now configured in corresponding
> registers. Ad7616 has multiple scale
On Mon, 27 May 2019 15:56:48 +0300
Beniamin Bia wrote:
> Because this driver will support multiple configurations for software,
> the software configuration was made generic.
>
> Signed-off-by: Beniamin Bia
> Acked-by: Jonathan Cameron
Applied to the togreg branch of iio.git
more devices by the driver. Also, it is an intermediate
> step of adding support for ad7616 in software mode.
>
> Signed-off-by: Beniamin Bia
> Acked-by: Jonathan Cameron
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonatha
On Fri, 24 May 2019 22:26:55 -0300
Renato Lui Geh wrote:
> This patch adds a MAINTAINERS entry for the AD7780 ADC driver.
>
> Signed-off-by: Renato Lui Geh
Applied to the togreg branch of iio.git and pushed out as testing
to be completely ignored by the autobuilders.
Thanks,
Jonathan
> ---
On Thu, 6 Jun 2019 16:52:14 +0100
Jonathan Cameron wrote:
> On Thu, 6 Jun 2019 11:13:52 +
> "Ardelean, Alexandru" wrote:
>
> > On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote:
> > > [External]
> > >
> > >
> > > On 0
On Thu, 6 Jun 2019 11:13:52 +
"Ardelean, Alexandru" wrote:
> On Wed, 2019-06-05 at 17:35 -0300, Renato Lui Geh wrote:
> > [External]
> >
> >
> > On 05/26, Jonathan Cameron wrote:
> > > On Fri, 24 May 2019 22:26:30 -0300
> > > Renato
On Fri, 24 May 2019 21:28:02 -0300
Renato Lui Geh wrote:
> Hi Jonathan, Alex,
>
> Thanks for the review. Some comments inline.
>
> Thanks,
> Renato
>
> On 05/20, Ardelean, Alexandru wrote:
> >On Sun, 2019-05-19 at 12:32 +0100, Jonathan Cameron wrote:
> &g
On Fri, 24 May 2019 22:26:30 -0300
Renato Lui Geh wrote:
> This patch adds a YAML binding for the Analog Devices AD7780/1 and
> AD7170/1 analog-to-digital converters.
>
> Signed-off-by: Renato Lui Geh
Looks good to me, but I'm still finding my feet with these so will
leave it for a few days
On Fri, 24 May 2019 13:54:49 +
"Ardelean, Alexandru" wrote:
> On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote:
> > [External]
> >
> >
> > Hi Alexandru,
> >
> > On 05/24, Alexandru Ardelean wrote:
> > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro
> > > wrote:
> > > >
>
On Sat, 18 May 2019 19:41:12 -0300
Renato Lui Geh wrote:
> This patch adds a YAML binding for the Analog Devices AD7780/1 and
> AD7170/1 analog-to-digital converters.
>
> Signed-off-by: Renato Lui Geh
One comment inline. I'll also be needing an ack from Analog on this,
preferably Michael's.
On Sat, 18 May 2019 17:48:25 -0300
João Seckler wrote:
> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
>
> Signed-off-by: João Seckler
> Signed-off-by: Anderson Reis
> Co-developed-by: Anderson Reis
> Signed-off-by: Andre Tadeu
On Sat, 18 May 2019 19:15:58 -0300
Tallys Martins wrote:
> The driver currently has no devicetree documentation. This commit adds a
> devicetree folder and documentation for it. Documentation must be moved
> as well when the driver gets out of staging.
>
> Signed-off-by: Tallys Martins
>
On Sat, 18 May 2019 19:15:57 -0300
Tallys Martins wrote:
> Ensure the mutex will be destroyed on drive removal.
> Also adds mutex comment description.
>
> Signed-off-by: Tallys Martins
> Signed-off-by: Souza Guilherme
> Co-developed-by: Souza Guilherme
Hi.
This particular 'issue' is never a
On Sun, 19 May 2019 12:02:50 +0100
Jonathan Cameron wrote:
> On Sat, 18 May 2019 19:27:33 -0300
> João Seckler wrote:
>
> > Add a of_device_id struct variable and subsequent call to
> > MODULE_DEVICE_TABLE macro to support device tree.
> >
> > Signed-off
On Sat, 18 May 2019 19:27:33 -0300
João Seckler wrote:
> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
>
> Signed-off-by: João Seckler
> Signed-off-by: Lucas Oshiro
> Co-developed-by: Lucas Oshiro
Applied to the togreg branch of
On Sat, 18 May 2019 18:44:34 -0300
Lucas Oshiro wrote:
> Add a of_device_id struct and MODULE_DEVICE_TABLE call, in order to add
> device-tree support for this driver.
>
> Signed-off-by: Lucas Oshiro
> Signed-off-by: Rodrigo Ribeiro
> Co-developed-by: Rodrigo Ribeiro
Hi Lucas, Rodrigo,
The
On Sat, 18 May 2019 19:44:35 -0300
Bárbara Fernandes wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed by: Wilson Sales
Hi Bárbara, Wilson,
One minor issue
On Sat, 18 May 2019 19:43:33 -0300
Bárbara Fernandes wrote:
> Create structure of type of_device_id in order to register all devices
> the driver is able to manage.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed-by: Wilson Sales
Looks good to me.
Applied
On Sat, 18 May 2019 19:42:13 -0300
Thiago Estrela wrote:
> Accomplish device tree compatibility to driver ADIS16203
> by adding of_device_id table and making a subsequent call to
> MODULE_DEVICE_TABLE.
>
> Signed-off-by: Thiago Estrela
> Signed-off-by: Tiago Napoli
> Co-developed-by: Tiago
On Sat, 18 May 2019 19:47:20 -0300
João Victor Marques de Oliveira wrote:
> Add a of_device_id struct array of_match_table variable and subsequent
> call to MODULE_DEVICE_TABLE macro to device tree support.
>
> Co-developed-by: Thiago L. A. Miller
> Signed-off-by: Thiago L. A. Miller
On Sat, 18 May 2019 22:04:56 -0300
Melissa Wen wrote:
> According to the AD7150 configuration register description, bit 7 assumes
> value 1 when the threshold mode is fixed and 0 when it is adaptive,
> however, the operation that identifies this mode was considering the
> opposite values.
>
>
On Sat, 18 May 2019 19:41:36 -0300
Bárbara Fernandes wrote:
> Create macro for capacitance channels in order to remove the repeated
> code and improve its readability.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Wilson Sales
> Co-developed-by: Wilson Sales
Not a totally clear cut
On Sat, 18 May 2019 19:41:35 -0300
Bárbara Fernandes wrote:
> Create structure of type of_device_id in order to register all devices
> the driver is able to manage.
>
> Signed-off-by: Bárbara Fernandes
> Signed-off-by: Melissa Wen
> Co-developed-by: Melissa Wen
> Signed-off-by: Wilson Sales
1 - 100 of 1045 matches
Mail list logo
