+ stephen
Greg Kroah-Hartman writes:
> On Wed, Apr 06, 2022 at 10:06:33AM +0300, Kalle Valo wrote:
>> Jakub Kicinski writes:
>>
>> > On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote:
>> >> Sure, that would technically work. But I just think it's
Jakub Kicinski writes:
> On Tue, 05 Apr 2022 10:16:58 +0300 Kalle Valo wrote:
>> Sure, that would technically work. But I just think it's cleaner to use
>> -rc1 (or later) as the baseline for an immutable branch. If the baseline
>> is an arbitrary commit somewhere within
Jakub Kicinski writes:
> On Mon, 4 Apr 2022 23:22:47 -0700 Jakub Kicinski wrote:
>> On Mon, 04 Apr 2022 13:49:18 +0300 Kalle Valo wrote:
>> > Dave, once you guys open net-next will it be based on -rc1?
>>
>> Not normally. We usually let net feed net-next so
Jérôme Pouiller writes:
> On Saturday 26 February 2022 14:15:33 CEST Kalle Valo wrote:
>> Greg Kroah-Hartman writes:
>>
>> > That sounds great to me, let's plan on that happening after 5.18-rc1 is
>> > out.
>>
>> Very good, we have a plan then. I
Greg Kroah-Hartman writes:
> On Sat, Feb 26, 2022 at 12:41:41PM +0200, Kalle Valo wrote:
>> + jakub
>>
>> Jerome Pouiller writes:
>>
>> > The firmware and the PDS files (= antenna configurations) are now a part of
>> > the linux-firmware reposit
+ jakub
Jerome Pouiller writes:
> The firmware and the PDS files (= antenna configurations) are now a part of
> the linux-firmware repository.
>
> All the issues have been fixed in staging tree. I think we are ready to get
> out from the staging tree for the kernel 5.18.
[...]
> rename
Ulf Hansson writes:
> On Thu, 17 Feb 2022 at 10:59, Kalle Valo wrote:
>>
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Until now, the SDIO quirks are applied directly from the driver.
>> > However, i
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Until now, the SDIO quirks are applied directly from the driver.
> However, it is better to apply the quirks before driver probing. So,
> this patch relocate the quirks in the MMC framework.
It would be good to know how this is better, what's
Jérôme Pouiller writes:
>> > There is also the patch 01/24 about the SDIO IDs.
>> >
>> > I think the v10 could contain only 3 patches:
>> >
>> > 1. mmc: sdio: add SDIO IDs for Silabs WF200 chip
>> > 2. dt-bindings: introduce silabs,wfx.yaml
>> > 3. [all the patches 3 to 24 squashed]
Jérôme Pouiller writes:
> On Thursday 10 February 2022 15:51:03 CET Kalle Valo wrote:
>> Jérôme Pouiller writes:
>> > On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote:
>> >> Jérôme Pouiller writes:
>> >>
>> >> > Kalle, is this
Jérôme Pouiller writes:
> On Thursday 10 February 2022 15:20:56 CET Kalle Valo wrote:
>>
>> Jérôme Pouiller writes:
>>
>> > Kalle, is this function what you expected? If it is right for you, I am
>> > going to send it to the staging tree.
&
Jérôme Pouiller writes:
> Hi Kalle,
>
> On Tuesday 11 January 2022 18:14:05 CET Jerome Pouiller wrote:
>> From: Jérôme Pouiller
>>
>> Signed-off-by: Jérôme Pouiller
>> ---
>> drivers/net/wireless/silabs/wfx/main.c | 485 +
>> drivers/net/wireless/silabs/wfx/main.h |
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Apache-2.0 is not allowed in the kernel.
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/staging/wfx/hif_api_cmd.h | 2 +-
> drivers/staging/wfx/hif_api_general.h | 2 +-
> drivers/staging/wfx/hif_api_mib.h | 2 +-
> 3 files
Jérôme Pouiller writes:
> On Wednesday 12 January 2022 08:49:54 CET Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Signed-off-by: Jérôme Pouiller
>> > ---
>> > .../bindings/net/wireless/sil
Ulf Hansson writes:
> On Tue, 11 Jan 2022 at 18:14, Jerome Pouiller
> wrote:
>>
>> From: Jérôme Pouiller
>>
>> Note that the values used by Silabs are uncommon. A driver cannot fully
>> rely on the SDIO PnP. It should also check if the device is declared in
>> the DT.
>>
>> So, to apply the
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> .../bindings/net/wireless/silabs,wfx.yaml | 125 ---
> drivers/staging/wfx/Kconfig | 8 -
> drivers/staging/wfx/Makefile | 25 -
> drivers/staging/wfx/bh.c
Jérôme Pouiller writes:
> On Thursday 7 October 2021 12:49:47 CEST Kalle Valo wrote:
>> CAUTION: This email originated from outside of the organization. Do
>> not click links or open attachments unless you recognize the sender
>> and know the content is safe.
>>
Kalle Valo writes:
> Jérôme Pouiller writes:
>
>>> >> >> I'm not really fond of having this kind of ASCII based parser in the
>>> >> >> kernel. Do you have an example compressed file somewhere?
>>> >> >
>>> >> >
Jérôme Pouiller writes:
>> >> >> I'm not really fond of having this kind of ASCII based parser in the
>> >> >> kernel. Do you have an example compressed file somewhere?
>> >> >
>> >> > An example of uncompressed configuration file can be found here[1]. Once
>> >> > compressed with [2], you get:
Jérôme Pouiller writes:
> Hi Kalle,
>
> On Friday 1 October 2021 14:18:04 CEST Kalle Valo wrote:
>> Jérôme Pouiller writes:
>>
>> > On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
>> >> Jerome Pouiller writes:
>> >>
>
Jérôme Pouiller writes:
> On Wednesday 6 October 2021 17:02:07 CEST Ulf Hansson wrote:
>> On Tue, 5 Oct 2021 at 10:14, Jérôme Pouiller
>> wrote:
>> > On Friday 1 October 2021 17:23:16 CEST Ulf Hansson wrote:
>> > > On Thu, 30 Sept 2021 at 19:06, Pali Rohár wrote:
>> > > > On Thursday 30
Jérôme Pouiller writes:
> On Tuesday 5 October 2021 16:20:19 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
> [...]
>> >
>> > v8:
>> > - Change the way the DT is handled. The user can now specify th
Jérôme Pouiller writes:
> On Friday 1 October 2021 18:08:32 CEST Pali Rohár wrote:
>> On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote:
>> > On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
>> > > Jerome Pouiller writes:
>>
Pali Rohár writes:
> On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote:
>> On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
>> > Jerome Pouiller writes:
>> >
>> > > From: Jérôme Pouiller
>> > >
>> > > Signed-off
Jérôme Pouiller writes:
> On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Signed-off-by: Jérôme Pouiller
>>
>> [...]
>>
>>
Jérôme Pouiller writes:
> On Tuesday 5 October 2021 16:15:22 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
> [...]
>> > v8:
>> > - Change the way the DT is handled. The user can now specify the name of
>> &
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Hello,
>
> I think the wfx driver is now mature enough to be accepted in the
> drivers/net/wireless directory.
>
> The firmware is now a part of the linux-firmware repository since relase
> 20210315[1]. It had taken a bit of time because I
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Hello,
>
> I think the wfx driver is now mature enough to be accepted in the
> drivers/net/wireless directory.
>
> The firmware is now a part of the linux-firmware repository since relase
> 20210315[1]. It had taken a bit of time because I
Pali Rohár writes:
> On Friday 01 October 2021 17:17:52 Jérôme Pouiller wrote:
>> On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
>> > CAUTION: This email originated from outside of the organization.
>> > Do not click links or open attachments unless yo
Ulf Hansson writes:
>> > > +static const struct sdio_device_id wfx_sdio_ids[] = {
>> > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS,
>> > > SDIO_DEVICE_ID_SILABS_WF200) },
>> > > + { },
>> > > +};
>> > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);
>> > > +
>> > > +struct sdio_driver
Jérôme Pouiller writes:
> On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
>> CAUTION: This email originated from outside of the organization. Do
>> not click links or open attachments unless you recognize the sender
>> and know the content is safe.
>>
>
Jérôme Pouiller writes:
> On Friday 1 October 2021 13:41:55 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Signed-off-by: Jérôme Pouiller
>>
>> [...]
>>
>> > --- /dev/null
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Hello,
>
> I think the wfx driver is now mature enough to be accepted in the
> drivers/net/wireless directory.
>
> The firmware is now a part of the linux-firmware repository since relase
> 20210315[1]. It had taken a bit of time because I
Kalle Valo writes:
>> --- /dev/null
>> +++ b/drivers/net/wireless/silabs/wfx/hwio.h
>> @@ -0,0 +1,79 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Low-level I/O functions.
>> + *
>> + * Copyright (c) 2017-2020, Silicon Laborator
Hi Ulf,
sorry for the late reply, my Gnus tells me it took me 24 weeks to reply :)
Ulf Hansson writes:
> On Wed, 7 Apr 2021 at 14:00, Kalle Valo wrote:
>>
>> Ulf Hansson writes:
>>
>> >> If I follow what has been done in other drivers I would write something
Jérôme Pouiller writes:
> On Friday 1 October 2021 11:22:08 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Signed-off-by: Jérôme Pouiller
>>
>> [...]
>>
>> > +/* The devi
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +static int wfx_ps_timeout_set(void *data, u64 val)
> +{
> + struct wfx_dev *wdev = (struct wfx_dev *)data;
> + struct wfx_vif *wvif;
> +
> + wdev->force_ps_timeout = val;
> + wvif =
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip,
> + const struct firmware **fw, int *file_offset)
> +{
> + int keyset_file;
> + char filename[256];
> +
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h
> @@ -0,0 +1,256 @@
> +/* SPDX-License-Identifier: Apache-2.0 */
> +/*
> + * WF200 hardware interface definitions
> + *
> + *
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +#define HIF_STATUS_SUCCESS (cpu_to_le32(0x))
> +#define HIF_STATUS_FAIL(cpu_to_le32(0x0001))
> +#define HIF_STATUS_INVALID_PARAMETER
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/hif_api_cmd.h
> @@ -0,0 +1,555 @@
> +/* SPDX-License-Identifier: Apache-2.0 */
I don't how I missed this earlier:
hif_api_cmd.h:/*
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +static int hif_startup_indication(struct wfx_dev *wdev,
> + const struct hif_msg *hif, const void *buf)
> +{
> + const struct hif_ind_startup *body = buf;
> +
> +
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/hif_tx_mib.h
> @@ -0,0 +1,49 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Implementation of the host-to-chip MIBs of the hardware
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/net/wireless/silabs/wfx/hwio.c | 340 +
> drivers/net/wireless/silabs/wfx/hwio.h | 79 ++
[...]
> +static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr,
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +/* It is not really necessary to run scan request asynchronously. However,
> + * there is a bug in "iw scan" when ieee80211_scan_completed() is called
> before
> + * wfx_hw_scan() return
> + */
>
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +/* The device needs data about the antenna configuration. This information in
> + * provided by PDS (Platform Data Set, this is the wording used in WF200
> + * documentation) files. For hardware
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/Makefile
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: GPL-2.0
All other files use GPL-2.0-only:
bh.c:// SPDX-License-Identifier: GPL-2.0-only
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/net/wireless/silabs/wfx/Kconfig | 12 +++
> drivers/net/wireless/silabs/wfx/Makefile | 26
> 2 files changed, 38 insertions(+)
> create mode 100644
Ulf Hansson writes:
>> If I follow what has been done in other drivers I would write something
>> like:
>>
>> static int wfx_sdio_suspend(struct device *dev)
>> {
>> struct sdio_func *func = dev_to_sdio_func(dev);
>> struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
>>
Jérôme Pouiller writes:
> On Tuesday 22 December 2020 16:27:01 CET Greg Kroah-Hartman wrote:
>>
>> On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote:
>> > Jerome Pouiller writes:
>> >
>> > > +/*
>> > > + * Intern
Jérôme Pouiller writes:
> On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > From: Jérôme Pouiller
>> >
>> > Signed-off-by: Jérôme Pouiller
>>
>> [...]
>>
>> > +wfx-$(CONFIG
Jerome Pouiller writes:
> +/* NOTE: wfx_send_pds() destroy buf */
> +int wfx_send_pds(struct wfx_dev *wdev, u8 *buf, size_t len)
> +{
> + int ret;
> + int start, brace_level, i;
> +
> + start = 0;
> + brace_level = 0;
> + if (buf[0] != '{') {
> + dev_err(wdev->dev, "valid PDS
Jerome Pouiller writes:
> +void wfx_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control,
> + struct sk_buff *skb)
> +{
> + struct wfx_dev *wdev = hw->priv;
> + struct wfx_vif *wvif;
> + struct ieee80211_sta *sta = control ? control->sta : NULL;
> + struct
Jerome Pouiller writes:
> +static bool ieee80211_is_action_back(struct ieee80211_hdr *hdr)
> +{
> + struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)hdr;
> +
> + if (!ieee80211_is_action(mgmt->frame_control))
> + return false;
> + if (mgmt->u.action.category !=
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> I think the wfx driver is now mature enough to be accepted in the
> drivers/net/wireless directory.
What's the status with firmware images? Can anyone take the latest
kernel and linux-firmware and use this driver normally?
--
Jerome Pouiller writes:
> --- /dev/null
> +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h
> @@ -0,0 +1,267 @@
> +/* SPDX-License-Identifier: Apache-2.0 */
> +/*
> + * WFx hardware interface definitions
> + *
> + * Copyright (c) 2018-2020, Silicon Laboratories Inc.
> + */
> +
> +#ifndef
Jerome Pouiller writes:
> +/*
> + * Internal helpers.
> + *
> + * About CONFIG_VMAP_STACK:
> + * When CONFIG_VMAP_STACK is enabled, it is not possible to run DMA on stack
> + * allocated data. Functions below that work with registers (aka functions
> + * ending with "32") automatically
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +static const struct ieee80211_supported_band wfx_band_2ghz = {
> + .channels = wfx_2ghz_chantable,
> + .n_channels = ARRAY_SIZE(wfx_2ghz_chantable),
> + .bitrates = wfx_rates,
> +
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> drivers/net/wireless/silabs/wfx/Kconfig | 8
> drivers/net/wireless/silabs/wfx/Makefile | 25
> 2 files changed, 33 insertions(+)
> create mode 100644
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Add Silabs SDIO ID to sdio_ids.h.
>
> Note that the values used by Silabs are uncommon. A driver cannot fully
> rely on the SDIO PnP. It should also check if the device is declared in
> the DT.
>
> Signed-off-by: Jérôme Pouiller
> ---
>
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
[...]
> +wfx-$(CONFIG_SPI) += bus_spi.o
> +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o
Why this subst? And why only for MMC?
--
https://patchwork.kernel.org/project/linux-wireless/list/
Ulf Hansson writes:
> On Thu, 15 Oct 2020 at 16:03, Jérôme Pouiller
> wrote:
>>
>> On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote:
>> > On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote:
>> > > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote:
>> > > > On Monday
Jérôme Pouiller writes:
> On Tuesday 13 October 2020 18:49:35 CEST Rob Herring wrote:
>> On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote:
>> > From: Jérôme Pouiller
> [...]
>> > + Note that in add of the properties below, the WFx driver also supports
>> > + `mac-address` and
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Smatch complains:
>
>drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn:
> potential NULL parameter dereference 'wvif'
>drivers/staging/wfx/data_tx.c:576 wfx_flush() warn: potential NULL
> parameter dereference
Jerome Pouiller writes:
> From: Jérôme Pouiller
>
> Smatch complains:
>
>main.c:228 wfx_send_pdata_pds() warn: potential NULL parameter dereference
> 'tmp_buf'
>227 tmp_buf = kmemdup(pds->data, pds->size, GFP_KERNEL);
>228 ret = wfx_send_pds(wdev, tmp_buf,
Jérôme Pouiller writes:
> On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote:
> [...]
>> Yes, the driver needs to be reviewed in linux-wireless list. I recommend
>> submitting the whole driver in a patchset with one file per patch, which
>> seems to be the easi
Kalle Valo writes:
> Greg Kroah-Hartman writes:
>
>> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote:
>>> From: Jérôme Pouiller
>>>
>>> I think the wfx driver is now mature enough to be accepted in the
>>> drivers/net/wire
Greg Kroah-Hartman writes:
> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote:
>> From: Jérôme Pouiller
>>
>> I think the wfx driver is now mature enough to be accepted in the
>> drivers/net/wireless directory.
>>
>> There is still one item on the TODO list. It is an idea to
writes:
> On 02/07/20 12:30 pm, Kalle Valo wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> writes:
>>
>>> From: Ajay Singh
>>>
>>> WILC1000 is an IEEE 802.11 b/g/n IoT li
Greg KH writes:
> On Fri, Jun 26, 2020 at 08:34:48AM +0300, Kalle Valo wrote:
>
>> And Ajay already submitted that the simple rename patch proposed, thanks
>> Ajay!
>>
>> https://patchwork.kernel.org/patch/11625025/
>>
>> And indeed the patch is
writes:
> From: Ajay Singh
>
> WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The
> WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other
> processors with minimal resource requirements with a simple
> SPI/SDIO-to-Wi-Fi interface.
>
> WILC1000 driver has been part
writes:
> Luc,
>
> Thanks for your patch...
>
> On 28/06/2020 at 20:32, Luc Van Oostenryck wrote:
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type defining 'NETDEV_TX_OK' but this
>> driver returns '0' instead of 'NETDEV_TX_OK'.
>>
writes:
> From: Ajay Singh
>
> WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The
> WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other
> processors with minimal resource requirements with a simple
> SPI/SDIO-to-Wi-Fi interface.
>
> WILC1000 driver has been part
Greg KH writes:
> On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote:
>> Greg KH writes:
>>
>> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> >> writes:
>> >>
>> >> > From: Ajay Singh
>> >
Greg KH writes:
> On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote:
>> writes:
>>
>> > From: Ajay Singh
>> >
>> > This patch series is to review and move wilc1000 driver out of staging.
>> > Most of the review comments received
writes:
> From: Ajay Singh
>
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code.
> Please review and provide your inputs.
>
> [1].
>
Jérôme Pouiller writes:
> On Wednesday 27 May 2020 14:34:37 CEST Kalle Valo wrote:
>> Jerome Pouiller writes:
>>
>> > This series introduces some nl80211 vendor extensions to the wfx driver.
>> >
>> > This series may lead to some discussions:
>>
Jerome Pouiller writes:
> This series introduces some nl80211 vendor extensions to the wfx driver.
>
> This series may lead to some discussions:
>
> 1. Patch 7 allows to change the dynamic PS timeout. I have found
> an API in wext (cfg80211_wext_siwpower()) that do more or less the
>
George Spelvin writes:
> On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote:
>> On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote:
>> > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote:
>> > > I don't know how this patch made it through two versions without
writes:
> From: Ajay Singh
>
> This patch series is to review and move wilc1000 driver out of staging.
> Most of the review comments received in [1] & [2] are addressed in the
> latest code. Please review and provide your inputs.
>
> [1].
>
writes:
> From: Ajay Singh
>
> Remove labels and not relevant property from DT binding documentation
> examples as suggested in [1].
>
> 1. https://patchwork.ozlabs.org/patch/1252837
Just a nitpick but patchwork links are not that reliable in the long
run. Instead using a lore link is better
t; @@ -18,8 +18,6 @@ struct wilc_wfi_radiotap_cb_hdr {
> u16 tx_flags;
> } __packed;
>
> -static struct net_device *wilc_wfi_mon; /* global monitor netdev */
> -
> static u8 srcadd[6];
> static u8 bssid[6];
I hope you are working on moving srcadd an
me time.
>>
>
> Thanks for the update.
> Btw I could see our driver was added to the pending branch. Just
> curious, could you please share details about how the pending branch is
> used ?
I use pending branch mainly for testing bigger patches with kbuild bot,
Ajay Singh writes:
> Hi Kalle,
>
> On Thu, 23 Aug 2018 16:37:45 +0530
> Kalle Valo wrote:
>
>> Ajay Singh writes:
>>
>> >> >>> We need help to review and identify if there are any pending
>> >> >>> items for wilc1000 drive
t; ---
>> drivers/staging/rtlwifi/wifi.h | 4
>
> Presumably the equivalent uses in
> drivers/net/wireless/realtek/rtlwifi/wifi.h
> should be removed as well.
But if it's needed, just do it in separate patch as the patches go via
different trees.
--
Kalle Valo
__
might cause conflicts etc.
> And the fixes will be submitted to staging tree in parallel. right?
I don't think the fixes matter in the initial review. So yeah, Greg can
apply fixes as he sees fit for now. At some point we need to do a cut
off period and freeze the driver for the last review ro
Arend van Spriel writes:
> On 8/17/2018 9:49 AM, Kalle Valo wrote:
>> Ajay Singh writes:
>>
>>> On Thu, 16 Aug 2018 13:53:50 +0300
>>> Kalle Valo wrote:
>>>
>>>> Kalle Valo writes:
>>>>
>>>>> From wireless
Ajay Singh writes:
> On Thu, 16 Aug 2018 13:53:50 +0300
> Kalle Valo wrote:
>
>> Kalle Valo writes:
>>
>> > Ajay Singh writes:
>> >
>> >> Hi Greg,
>> >>
>> >> We all are working on submitting and reviewing patche
Kalle Valo writes:
> Ajay Singh writes:
>
>> Hi Greg,
>>
>> We all are working on submitting and reviewing patches for wilc1000 in
>> staging driver for quite some time.
>>
>> We would like to have feedback on the next steps to bring wilc1000
read from DT
> -replace SIOCDEVPRIVATE commands with generic API functions
> -use wext-core handling instead of private SIOCSIWPRIV implementation
>From wireless point of view: if I see wext mentioned anywhere in the
driver I stop right t
e in net-next now.
Yup, I see it in net-next:
d17504b16ea2 wireless/lib80211: Convert from ahash to shash
--
Kalle Valo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg KH writes:
> On Mon, Jun 18, 2018 at 10:29:43AM +0300, Kalle Valo wrote:
>> Greg KH writes:
>>
>> > On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote:
>> >> The BIT macro uses unsigned long which some architectures handle as 32 bit
>>
ibutes by mistake.
>>
>> This commit cleans up all usages of BIT macro with the above field
>> in cfg80211 by changing it to BIT_ULL instead.
>>
>> Signed-off-by: Omer Efrat
>
> Acked-by: Greg Kroah-Hartman
Via which tree is this supposed to go
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +-
> drivers/net/ethernet/renesas/Kconfig| 2 --
> drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 -
> drivers/net/wireless/quantenna/qtnfmac/Kconfig | 2 +-
> 12 files changed, 12 insertions(+), 19 deletions(-)
F
ew driver some people split the driver to one file per
patch for easier review but the final commit needs to be one big patch
with all files included. If you are adding big files to rtlwifi I think
you could try to follow the same model.
--
Kalle Valo
Intel's iwlwifi has support for hardware which have not reached
customers yet.
> On the way, I'll attend netdev workshop in Korea, so we can meet there
> if you attend too.
I'm also attending Netdev 2.2, looking forward to meeting you there.
--
Kalle Valo
rstand it
> any way" is nor really helpful :)
> Please don't repeat bad experience of Broadcom.
I agree with Oleksij here, but I want to still point out that there are
cases when using magic numbers are ok, for example look at
ar5008_initvals.h from ath9k. So it depends on case by case.
--
more
reasonable, like 10-12 patches per set. I think Dave also has a similar
rule for net patches.
I wrote a FAQ entry about this:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#too_many_patches
--
Kalle Valo
_
Larry Finger <larry.fin...@lwfinger.net> writes:
> On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote:
>
>> On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote:
>> I think it's horrid too. But, if no one is able to do the real work
>> here, we hurt users who j
months or something) for the
drivers/staging/rtlwifi and after that you refuse to take any patches
for it. Hopefully this makes it clear for everyone that this fork is
just temporary. I think Larry is trying to do this, which is great.
2) We move the whole rtlwifi driver to staging. A very bad option but
still better than forking the drivers.
--
Kalle Valo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
1 - 100 of 162 matches
Mail list logo
