Re: [PATCH v2 0/2] staging: rtl8723bs: Fix multiple trailing semicolons

On 01/11/2018 01:19 AM, Joe Perches wrote: > On Wed, 2018-01-10 at 17:01 +0000, Luis de Bethencourt wrote: >> On 01/10/2018 04:51 PM, Luis de Bethencourt wrote: >>> Hi, >>> >>> Removing the last patch from the original series after Dan's comment. >&

Re: [PATCH v2 0/2] staging: rtl8723bs: Fix multiple trailing semicolons

On 01/10/2018 04:51 PM, Luis de Bethencourt wrote: > Hi, > > Removing the last patch from the original series after Dan's comment. > > Tomorrow, I will send a new patch that removes the commented out code. This > will > replace that last patch. > > Thanks for the rev

[PATCH v2 0/2] staging: rtl8723bs: Fix multiple trailing semicolons

Hi, Removing the last patch from the original series after Dan's comment. Tomorrow, I will send a new patch that removes the commented out code. This will replace that last patch. Thanks for the review, Luis Luis de Bethencourt (2): staging: rtl8723bs: Fix trailing semicolon staging

[PATCH v2 2/2] staging: rtl8723bs: Fix trailing semicolon

The trailing semicolon is an empty statement that does nothing. Removing it since it has no purpose. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

[PATCH v2 1/2] staging: rtl8723bs: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 0/3] staging: rtl8723bs: Fix multiple trailing semicolons

, Luis [0] Sorry I don't have a link, LKML is down Luis de Bethencourt (3): staging: rtl8723bs: Fix trailing semicolon staging: rtl8723bs: Fix trailing semicolon staging: rtl8723bs: Fix trailing semicolon in comment drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging

[PATCH 1/3] staging: rtl8723bs: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 3/3] staging: rtl8723bs: Fix trailing semicolon in comment

Even though the code is commented out, it has a small bug. The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file chan

[PATCH 2/3] staging: rtl8723bs: Fix trailing semicolon

The trailing semicolon is an empty statement that does nothing. Removing it since it has no purpose. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

Re: [PATCH v2] staging: rtl8723bs: Fix trailing semicolon

On 01/09/2018 04:46 PM, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 04:17:01PM +0000, Luis de Bethencourt wrote: >> Fix trailing semicolon. > > Please be more explicit. That says what it does, but not _why_ :) > After walking around with my head down in shame I

[PATCH v3] staging: rtl8723bs: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- Hi all, Testing the waters with this cleanup patch. If it is OK to send these there are two very similar ones, plu

[PATCH v2] staging: rtl8723bs: Fix trailing semicolon

Fix trailing semicolon. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- Changes since v1: - Added a changelog body to the commit message drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

On 01/09/2018 04:11 PM, Hans de Goede wrote: > Hi, > > On 09-01-18 17:02, Luis de Bethencourt wrote: >> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: >>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote: >>>> Signed-off-by: Lu

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote: >> Signed-off-by: Luis de Bethencourt <lui...@kernel.org> >> --- > > I can't take patches without any changelog text, sorry :( > Hi Greg, I

[PATCH] staging: rtl8723bs: Fix trailing semicolon

Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- Hi all, Testing the waters with this cleanup patch. If it is OK to send these there are two very similar ones, plus more in general. Happy to send them. I have a C.H.I.P. board, which is why this driver is interesting for me t

[PATCH 3/3] staging: lustre: llite: Remove redundant else keyword

There is no need to use 'else' if in main branch 'return' is present. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_i

[PATCH 1/3] staging: lustre: llite: Remove else after goto

If an "if" branch is terminated by a "goto", there's no need to have an "else" statement and an indented block of code. Remove the "else" statement to simplify the code flow. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- Hi, The

[PATCH 2/3] staging: lustre: llite: Remove redundant else keyword

There is no need to use 'else' if in main branch 'goto' is present. Signed-off-by: Luis de Bethencourt <lui...@kernel.org> --- drivers/staging/lustre/lustre/llite/llite_lib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_li

Re: Greybus Future

On 01/11/16 11:18, Bryan O'Donoghue wrote: > On Mon, 2016-10-31 at 08:50 -0500, Alex Elder wrote: >> My suggestion is to create a majordomo list: >> grey...@kernel.org > > I think this is a great idea. We need a forum where we can discuss > changes to the specification and the firmware - it

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

On 11/07/16 23:46, Markus Mayer wrote: > On 9 July 2016 at 08:30, Markus Mayer <markus.ma...@broadcom.com> wrote: >> On 9 July 2016 at 05:04, Luis de Bethencourt <lui...@osg.samsung.com> wrote: >>> On 08/07/16 23:43, Markus Mayer wrote: >>>> Add a collecti

Re: [PATCH v3 1/7] lib: string: add functions to case-convert strings

On 08/07/16 23:43, Markus Mayer wrote: > Add a collection of generic functions to convert strings to lowercase > or uppercase. > > Changing the case of a string (with or without copying it first) seems > to be a recurring requirement in the kernel that is currently being > solved by several

Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.

On 08/07/16 20:32, Samuele Baisi wrote: > > > Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt > <lui...@osg.samsung.com> ha scritto: >> On 05/07/16 12:33, Samuele Baisi wrote: >>> Removed a blankline after an opening bracket. >>> >>>

Re: [PATCH] Staging: rtl8712: Fixed brace and comment style issue

On 03/07/16 04:54, Anuradha Weeraman wrote: > Fixed issues with coding style. > > Signed-off-by: Anuradha Weeraman > --- > drivers/staging/rtl8712/xmit_linux.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.

int j; > > for (i = 0; i < TTY_MAX_COUNT; i++) { > - > gdm = kmalloc(sizeof(*gdm), GFP_KERNEL); > if (!gdm) > return -ENOMEM; > Patch applies cleanly and removes the checkpath issue. Acked-by: Luis de Bethencourt <

Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

On 04/07/16 12:36, Daeseok Youn wrote: > The dgnc_block_til_ready() is only used in dgnc_tty_open(). > The unit data(struct un_t) was stored into tty->driver_data in > dgnc_tty_open(). > And also tty and un were tested about NULL so these variables doesn't > need to check for NULL in

Re: [PATCH] MAINTAINERS: Update maintainer entry for wilc1000

00 driver > but change it with the patch below. > After the Microchip - Atmel merger, Aditya and Ganesh will take over the > maintenance of this driver and will continue the work that our former > colleagues started. > > Thanks, bye. > Nice :) This is good news I am happy

[PATCH v3] MAINTAINERS: remove unreachable people that have left Atmel

Bo_moon Kim is no longer with Atmel Corporation." "Min_su Kim is no longer with Atmel Corporation." "Jun_hyuk Lee is no longer with Atmel Corporation." Removing this entry since none of the maintainers are reachable. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.c

Re: [PATCH v2 1/2] staging: wilc1000: fix error handling in wilc_debugfs_init()

On 25/06/16 23:16, Greg KH wrote: > On Sat, Jun 25, 2016 at 10:43:33PM +0100, Luis de Bethencourt wrote: >> On 25/06/16 22:36, Greg KH wrote: >>> On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote: >>>> The common format to check if a func

[PATCH v3] staging: wilc1000: fix error handling in wilc_debugfs_init()

We can just ignore the return value from debugfs_create_dir() and debugfs_create_file(). The second one already interanlly checks the dentry created by the first before creating the file. debugfs was written so it would be easy to use, no need for error checking. Signed-off-by: Luis de

Re: [PATCH v2 1/2] staging: wilc1000: fix error handling in wilc_debugfs_init()

On 25/06/16 22:36, Greg KH wrote: > On Thu, Jun 23, 2016 at 01:36:17PM +0100, Luis de Bethencourt wrote: >> The common format to check if a function returned an error pointer is to >> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. >> >> Signed-

Re: [PATCH] staging: wilc1000: arrays can't be NULL

On 24/06/16 00:54, Julian Calaby wrote: > Hi Luis, > > On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt > <lui...@osg.samsung.com> wrote: >> On 24/06/16 00:15, Julian Calaby wrote: >>> Hi Joe, >>> >>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Per

Re: [PATCH] staging: wilc1000: arrays can't be NULL

On 24/06/16 00:15, Julian Calaby wrote: > Hi Joe, > > On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches <j...@perches.com> wrote: >> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote: >>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info str

Re: [PATCH] staging: wilc1000: arrays can't be NULL

On 23/06/16 20:24, Joe Perches wrote: > On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote: >> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs >> which have the following element: >> u8 bssid[6]; > [] >> I am aware this patch gives a

[PATCH] staging: wilc1000: arrays can't be NULL

et_info[hif_drv->usr_scan_req.rcvd_ch_cnt].bssid' drivers/staging/wilc1000/host_interface.c:1254 Handle_RcvdNtwrkInfo() warn: this array is probably non-NULL. 'pstrNetworkInfo->bssid' Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, I am aware this patch gives a few checkpa

[PATCH v2 2/2] staging: wilc1000: fix error values in wilc_debugfs_init()

If there was an error, returning -EINVAL is more appropriate than -1. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> --- drivers/staging/wilc1000/wilc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 1/2] staging: wilc1000: fix error handling in wilc_debugfs_init()

The common format to check if a function returned an error pointer is to use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> --- drivers/stag

Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

On 23/06/16 02:29, Julian Calaby wrote: > Hi All, > > On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt > <lui...@osg.samsung.com> wrote: >> The common format to check if a function returned an error pointer is to >> use PTR_ERR(). Instead of ERR_PTR() which

[RESEND PATCH v2 2/2] staging: iio: accel: add error check

Go to error_ret if sca3000_read_ctrl_reg() failed. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/iio/accel/sca3000_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_

[RESEND PATCH v2 1/2] staging: iio: accel: fix error check

sca3000_read_ctrl_reg() returns a negative number on failure, check for this instead of zero. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: Andrew F. Davis <a...@ti.com> Reviewed-by: Jonathan Cameron <ji...@kernel.org> --- drivers/staging/iio/accel/

[RESEND PATCH] staging: gdm724x: gdm_usb: Remove ignored value

The value assigned to ret will be overwritten before it could be read in a future iteration of the loop. Removing the unnecessary assignment. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/gdm724x/gdm_usb.c | 8 1 file changed, 4 insertions

[PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

The common format to check if a function returned an error pointer is to use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors. Also, if there was an error returning -EINVAL instead of -1 is more appropriate. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

On 18/06/16 04:51, Greg KH wrote: > On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote: >> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: >>> This is a patch to the s626.c file that fixes up a line over 80 >>> characters issues foun

Re: [PATCH 1/6] staging: i4l: icn: do not use return as a function

On 11/06/16 22:10, Sudip Mukherjee wrote: > return is not a function so no need to use the parenthesis. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/i4l/icn/icn.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > All the

Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

On 11/06/16 21:08, Rithvik Patibandla wrote: > Fix "Block comments use * on subsequent lines" and "Block comments use > */ on trailing lines" warnings thrown by checkpatch.pl > > Signed-off-by: Rithvik Patibandla > --- > drivers/staging/vt6656/card.c | 3 ++- > 1 file

Re: [PATCH 0/8] Lustre: Multiple assignments removal.

On 10/06/16 03:35, Oleg Drokin wrote: > These patches remove multiple assignments in Lustre, that makes > checkpatch (somewhat understandably) unhappy. > > Nathaniel Clark (8): > staging/lustre/osc: Fix Multiple Assignment Warnings > staging/lustre/fid: Fix Multiple Assignments >

Re: [PATCH] vme: Update documentation to match api

On 05/06/16 21:35, Martyn Welch wrote: > The vme_register_driver() api changed in commit 5d6abf379d73 ("staging: > vme: make match() driver specific to improve non-VME64x support") but the > documentation wasn't updated. Update the documentation to match the API. > > Signed-off-by: Martyn Welch

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

On 08/06/16 13:25, Parth Sane wrote: > No mate, that aint just cutting it. > I tried putting it, maybe i’m doing something wrong? > Regards, > Parth >> On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt <lui...@osg.samsung.com> >> wrote: >> >> On 08/06/

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

On 08/06/16 12:58, Parth Sane wrote: > I’m trying to fix line 224 but its simply not happening. Can you help me with > this? > Regards, > Parth >> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt <lui...@osg.samsung.com> >> wrote: >> >> On 08/06/16 12:37,

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

On 08/06/16 12:37, Parth Sane wrote: > >> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <lui...@osg.samsung.com> >> wrote: >> >> On 08/06/16 12:27, Parth Sane wrote: >>> Multiple parenthesis alignment warnings were thrown by checkpatch in >&g

Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c

On 08/06/16 12:27, Parth Sane wrote: > Multiple parenthesis alignment warnings were thrown by checkpatch in > ieee80211.c > This patch effectively fixes that. > > Signed-off-by: Parth Sane > > --- > drivers/staging/rtl8712/ieee80211.c | 25 - >

Re: [PATCH] staging: iio: ad5933: fix handling of settling time cycles

On 01/06/16 17:22, Lars-Peter Clausen wrote: > On 06/01/2016 05:55 PM, Luis de Bethencourt wrote: >> Correctly handle the settling time cycles value. The else branch was an >> impossible condition (> 1022 in the else branch of > 511) and the handling >> of the val

[PATCH] staging: iio: ad5933: fix handling of settling time cycles

Sheet: http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, I decided to use the hexadecimal values instead of (1 << 10) and (1 << 9), for briefness, I could resend using those instead if

Re: [PATCH 1/2] staging: iio: accel: fix error check

On 31/05/16 22:08, Luis de Bethencourt wrote: > sca3000_read_ctrl_reg() returns a negative number on failure, check for > this instead of zero. > > Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> > Reviewed-by: Andrew F. Davis <a...@ti.com> > Rev

[PATCH 1/2] staging: iio: accel: fix error check

sca3000_read_ctrl_reg() returns a negative number on failure, check for this instead of zero. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: Andrew F. Davis <a...@ti.com> Reviewed-by: Jonathan Cameron <ji...@kernel.org> --- Patch corrected thanks to co

[PATCH 2/2] staging: iio: accel: add error check

Go to error_ret if sca3000_read_ctrl_reg() failed. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Noticed this while inspecting the code for the 1/2 patch. Thanks, Luis drivers/staging/iio/accel/sca3000_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

Re: [PATCH] staging: iio: accel: remove impossible condition

On 31/05/16 21:23, Jonathan Cameron wrote: > > > On 31 May 2016 20:47:50 BST, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: >> val is set to the value of ret right after ret is checked. If ret is >> not >> zero it goes to error_ret. So only value

[PATCH] staging: iio: accel: remove impossible condition

Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/iio/accel/sca3000_core.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index a8f533a..94656f6 100644 ---

[PATCH] staging: gdm724x: gdm_usb: Remove ignored value

The value assigned to ret will be overwritten before it could be read in a future iteration of the loop. Removing the unnecessary assignment. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/gdm724x/gdm_usb.c | 8 1 file changed, 4 insertions

Re: [PATCH 2/2] staging: slicoss: fix camel case check

On 29/05/16 14:31, Jaime Arrocha wrote: > From: Jaime Arrocha > > Fixed several checks about camel case use provided by checkpatch.pl. > CHECK: Avoid CamelCase > Changes verified to work by compiling module. > > Signed-off-by: Jaime Arrocha Purpose of

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a line over 80 > characters issues found by the checkpatch.pl tool. > > Signed-off-by: Ravishankar Karkala Mallikarjunayya Looks good :) This is the only

Re: [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned issue in s626.c

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > found by the checkpatch.pl tool > > Signed-off-by: Ravishankar Karkala Mallikarjunayya The

Re: [PATCH v2 2/4] Staging: comedi: Fix WARNING issue in s626.c

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a Block comments > issues found by the checkpatch.pl tool. > > i.e. Block comments use a trailing */ on a separate line > > Signed-off-by: Ravishankar Karkala Mallikarjunayya

Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a type issues like > i.e Prefer kernel type 'u8' over 'uint8_t' > Prefer kernel type 'u16' over 'uint16_t' > Prefer kernel type 'u32' over 'uint32_t' > Prefer kernel type

Re: [PATCH 7/7] staging: dgnc: remove useless variable 'ch_intr_rx'

On 27/05/16 07:55, Daeseok Youn wrote: > The 'ch_intr_rx' variable was used only for increasing. > So the 'ch_intr_rx' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 1 - >

Re: [PATCH 2/7] staging: dgnc: remove unused variable 'intr_modem'

On 27/05/16 07:53, Daeseok Youn wrote: > The 'intr_modem' variable was used only for increasing. > So the 'intr_modem' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 1 - >

Re: [PATCH 1/7] staging: dgnc: remove useless variable 'intr_count'

On 27/05/16 07:52, Daeseok Youn wrote: > The 'intr_count' variable was used only for increasing. > So the 'intr_count' variable is not useful for this driver. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_cls.c| 2 -- >

Re: [PATCH 2/2 V2] staging: dgnc: remove redundant null check in

On 27/05/16 02:43, Daeseok Youn wrote: > the "brd" was already checked for NULL before calling dgnc_do_remap(). > > the dgnc_do_remap() function was called only > from the dgnc_found_board() and the DGNC_BOARD_MAGIC value > was assigned to "brd->magic" in dgcn_found_board(). So it doesn't > need

Re: [PATCH 1/2 v2] staging: dgnc: remove redundant NULL check for brd

On 27/05/16 02:42, Daeseok Youn wrote: > the "brd" value cannot be NULL in dgnc_finalize_board_init(). > Because "brd" as a parameter of this function was already > checked for NULL. > > the dgnc_finalize_board_init() as a static function was called > only from dgnc_found_board() function and

Re: [PATCH 0/3] fix issues in prism2usb.c.

On 26/05/16 13:32, Kevin wrote: > On Thu, May 26, 2016 at 01:24:28PM +0100, Luis de Bethencourt wrote: >> On 26/05/16 04:22, Kevin McKinney wrote: >>> This patchset will address issues reported by checkpatch.pl tool >>> for file prism2usb.c. >>> >>> Ke

Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

On 26/05/16 09:01, Shubham Bansal wrote: > Fixed a coding style issue. Issue reported by checkpatch.pl. > > Signed-off-by: Shubham Bansal > --- > drivers/staging/android/ion/ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

On 26/05/16 05:56, DaeSeok Youn wrote: > 2016-05-26 6:48 GMT+09:00 Luis de Bethencourt <lui...@osg.samsung.com>: >> On 20/05/16 10:51, Daeseok Youn wrote: >>> the "brd" value cannot be NULL in dgnc_finalize_board_init(). >>> Because "brd" as

Re: [PATCH 0/3] fix issues in prism2usb.c.

On 26/05/16 04:22, Kevin McKinney wrote: > This patchset will address issues reported by checkpatch.pl tool > for file prism2usb.c. > > Kevin McKinney (3): > Staging: wlan-ng: fix alignment not matching. > Staging: wlan-ng: fix unnecessary parentheses. > Staging: wlan-ng: fix comparison to

Re: [PATCH 0/3] fix wlan-ng/prism2usb.c

On 20/05/16 19:04, Kevin McKinney wrote: > This patchset will fix the below issues reported checkpatch.pl tool. > > Kevin McKinney (3): > Staging: wlan-ng: fix Alignment should match open parenthesis. > This patch fixes alignment of parenthesis found by checkpatch.pl > tool. >

Re: [PATCH] staging/vme: explicitly use `unsigned int` instead of `unsigned`

On 20/05/16 17:27, Daniel Lockyer wrote: > Kernel code style is to prefer the former so add `int` to the method > parameters. > > Signed-off-by: Daniel Lockyer > --- > drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 2/2] staging: dgnc: remove redundant null check in

On 20/05/16 10:51, Daeseok Youn wrote: > the "brd" was already checked for NULL before calling dgnc_do_remap(). > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_driver.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd

On 20/05/16 10:51, Daeseok Youn wrote: > the "brd" value cannot be NULL in dgnc_finalize_board_init(). > Because "brd" as a parameter of this function was already > checked for NULL. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_driver.c | 3 --- > 1

Re: [PATCH v2 1/1] staging: unisys: remove unused struct members

On 06/05/16 02:05, David Kershner wrote: > From: Erik Arfvidson > > The following struct members were never used: > putfile_active_buffer::pnext > putfile_request::file_request_number > putfile_request::data_sequence_number > > Signed-off-by: Erik Arfvidson

Re: [PATCH] staging: unisys: visorchannel: correct variable misspelling

On 05/05/16 05:54, David Kershner wrote: > From: David Binder > > Fixes the spelling of a global variable passed into a kernel macro. > > Signed-off-by: David Binder > Signed-off-by: David Kershner > --- >

Re: [PATCH] staging: unisys: remove unused struct members

On 05/05/16 05:52, David Kershner wrote: > From: Erik Arfvidson > > The following struct members were never used: > putfile_active_buffer::pnext > putfile_request::file_request_number > putfile_request::data_sequence_number > > Signed-off-by: Erik Arfvidson

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

a tip. Please keep submitting fixes. Appreciated. Luis >> On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt <lui...@osg.samsung.com> >> wrote: >> >> On 26/04/16 15:33, Parth Sane wrote: >>> Hi, >>> Thanks for the feedback. I did find this issue with t

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

el/git/torvalds/linux.git/commit/?id=5f10ef7dce02d8e36665974aca0977cda58c1122 Verbosity in the commit message is a good thing :) I have tested that your patch still applies cleanly to Greg's staging-testing branch. Thanks, Luis >> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt <lui...@os

Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis

On 25/04/16 16:43, Parth Sane wrote: > Fixed alignment to match open parenthesis. > > Signed-off-by: Parth Sane > > --- > Changes in v6: > -Added line before Signed-off message > This last version looks good to me. Did you find this issue with checkpatch.pl?

Re: [PATCH] staging: speakup: (coding style) Add spaces around operands (checkpatch checks)

Hi al, Looks good and silences the checkpatch warnings. Christian, There are more checkpatch warnings in this file. Could you fix them as well? Reviewed-by: Luis de Bethencourt <lui...@osg.samsung.com> On Thu, Nov 19, 2015 at 02:40:59PM +0100, Christian Colic wrote: > Fix checkpa

Re: [PATCH] staging: ft1000: Remove boolean comparisons

On 25/10/15 02:20, Greg KH wrote: > On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote: >> Boolean tests do not need explicit comparison to true or false. >> >> Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> >> --- >> drivers/s

[RESEND PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Fixes smatch warning and similars: drivers/staging/wilc1000/host_interface.c:1757 Handle_Key() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <

[PATCH] staging: rtl8188eu: fix misleading indentation

intended? Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rf_cfg.c b/drivers/staging/rtl8188eu/hal/rf_cfg.c index 067649a..a3f1aba

[PATCH] staging: lustre: o2iblnd: fix misleading indentation

The code is correct, the indentation is misleading. Only the the return rc is part of the conditional statement if rc != 0. Fix a smatch warning: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157 kiblnd_hdev_setup_mrs() warn: curly braces intended? Signed-off-by: Luis de Bethencourt <

[PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Fixes smatch warning and similars: drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <

[PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

For loop is outside of the else branch of the above conditional statement. Fixing misleading indentation. Fix a smatch warning: drivers/staging/rtl8723au/core/rtw_wlan_util.c:528 WMMOnAssocRsp23a() warn: curly braces intended? Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.

[PATCH v2 0/3] staging: code cleanup

it cover all rtl8712. In other words, these are a series of recursive cleanup changes. Thanks for the review Mike, Luis Luis de Bethencourt (3): staging: rtl8712: Remove boolean comparisons staging: rtl8712: braces should be used on all arms staging: rtl8712: spaces preferred around operands

[PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/rtl8712/os_intfs.c| 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 9 +- drivers/staging/rtl8712/rtl8712_efuse.c

[PATCH v2 2/3] staging: rtl8712: braces should be used on all arms

Fix all instances of the following checkpatch.pl check: CHECK: braces {} should be used on all arms of this statement Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/rtl8712/hal_init.c| 11 +++--- drivers/staging/rtl8712/ieee80211.c

[PATCH v2 3/3] staging: rtl8712: spaces preferred around operands

Clean up all instances of checkpatch.pl checks: CHECK: spaces preferred around that '+' (and other operands) Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/rtl8712/ieee80211.c | 21 ++--- drivers/staging/rtl8712/mlme_linux.c | 2 +- d

[PATCH] staging: ft1000: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++-- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c| 2 +- 2 files changed, 3 insertions(+), 3 del

[PATCH] staging: emxx_udc: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/emxx_udc/emxx_udc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/d

[PATCH] staging: rtl8712: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/rtl8712/os_intfs.c| 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 9 +- drivers/staging/rtl8712/rtl8712_efuse.c

[PATCH v3] staging: rtl8192u: simplify conditional

The code can be much cleaner and readable by simplifying the conditional statement. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, Dan Carpenter pointed out that the check needs to be >= and not just > because ieee->state can change between the two if stat

[PATCH v2] staging: rtl8192u: simplify conditional statement

The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt <lui...@

[PATCH] staging: wilc1000: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wi

[PATCH] staging: rtl8192u: simplify conditional statement

The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt <lui...@

  1   2   >