Re: [PATCH 2/7] staging/android: display sync_pt name on debugfs

Op 08-08-16 om 21:59 schreef Gustavo Padovan: > 2016-08-08 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Op 20-06-16 om 17:53 schreef Gustavo Padovan: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>> >>> When creati

Re: [PATCH 2/7] staging/android: display sync_pt name on debugfs

Op 20-06-16 om 17:53 schreef Gustavo Padovan: > From: Gustavo Padovan > > When creating a sync_pt the name received wasn't used anywhere. > Now we add it to the sync info debug output to make it easier to indetify > the userspace name of that sync pt. > >

Re: [PATCH] MAINTAINERS: add entry for the Sync File Framework

Cc: Sumit Semwal <sumit.sem...@linaro.org> > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Acked-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

tavo Padovan <gustavo.pado...@collabora.co.uk> > Acked-by: Rob Clark <robdcl...@gmail.com> > Looking much better. Acked-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v10 RESEND 2/3] kernel.h: add u64_to_user_ptr()

Op 19-04-16 om 22:42 schreef Gustavo Padovan: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. > > Cc: Joe Perches > Cc: Andrew Morton > Cc: David Airlie

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

> call SYNC_IOC_FILE_INFO again, but now with the actual value of num_fences > in the sync_file. > > Also, info->sync_fence_info was converted to __u64 pointer to prevent > 32bit compatibility issues. For this patch and 6/6: Reviewed-by: Maarten Lankhorst <maarten.lankho...@lin

Re: [PATCH v6 5/6] staging/android: refactor SYNC_IOC_FILE_INFO

nfo)); > > err = ioctl(fd, SYNC_IOC_FILE_INFO, info); > } > > v2: fix fence_info memory leak > > v3: Comments from Emil Velikov > - improve commit message > - remove __u64 cast > - remove check for output fields in file_info >

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

Op 29-02-16 om 23:08 schreef Gustavo Padovan: > Hi Maarten, > > 2016-02-29 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Op 26-02-16 om 22:00 schreef Gustavo Padovan: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>>

Re: [PATCH v4 3/5] staging/android: remove redundant comments on sync_merge_data

> - __s32 fence; /* fd on newly created fence */ > + __s32 fd2; > + charname[32]; > + __s32 fence; > }; > > /** For the first 3 patches: Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> _

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

Op 26-02-16 om 19:31 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > > v2: check if flags are

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

Op 26-02-16 om 22:00 schreef Gustavo Padovan: > From: Gustavo Padovan > > Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and > optimize buffer allocation. In the new approach the ioctl needs to be called > twice to retrieve the array of fence_infos

Re: [PATCH v3 06/11] staging/android: turn fence_info into a __u64 pointer

Op 03-02-16 om 21:09 schreef Gustavo Padovan: > Hi Maarten, > > 2016-02-03 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Op 03-02-16 om 14:25 schreef Gustavo Padovan: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>> &g

Re: [PATCH v3 06/11] staging/android: turn fence_info into a __u64 pointer

Op 04-02-16 om 14:05 schreef Gustavo Padovan: > 2016-02-04 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Op 03-02-16 om 21:09 schreef Gustavo Padovan: >>> Hi Maarten, >>> >>> 2016-02-03 Maarten Lankhorst <maarten.lankho...@linux.i

Re: [PATCH v2 06/11] staging/android: turn fence_info into a __u64 pointer

Op 02-02-16 om 21:28 schreef Gustavo Padovan: > Hi Maarten, > > 2016-02-02 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Op 02-02-16 om 14:23 schreef Gustavo Padovan: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>> >

Re: [PATCH v3 06/11] staging/android: turn fence_info into a __u64 pointer

Op 03-02-16 om 14:25 schreef Gustavo Padovan: > From: Gustavo Padovan > > Turn sync_fence_info into __u64 type enable us to extend the struct in the > future without breaking the ABI. > > v2: use type __u64 for fence_info > > v3: fix commit message to reflect the

Re: [PATCH v2 02/11] staging/android: rename sync_pt_info to fence_info

Op 02-02-16 om 14:23 schreef Gustavo Padovan: > From: Gustavo Padovan > > As struct sync_pt doesn't exist anymore it is a good idea remove any > reference to it in the sync_framework. sync_pts were replaced directly by > fences. > rename it to sync_fence_info to

Re: [PATCH v2 06/11] staging/android: turn fence_info into a __u64 pointer

Op 02-02-16 om 14:23 schreef Gustavo Padovan: > From: Gustavo Padovan > > Making fence_info a pointer enables us to extend the struct in the future > without breaking the ABI. > > v2: use type __u64 for fence_info > Signed-off-by: Gustavo Padovan

Re: [PATCH v2 08/11] staging/android: make info->len return only the size of fence_infos

Op 02-02-16 om 14:23 schreef Gustavo Padovan: > From: Gustavo Padovan > > The len member of struct sync_file_info was returning the size of the whole > buffer (struct sync_file_info + fence_infos at the of it). This commit > change it to return only the size of

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > This only helps if you reject

Re: [PATCH 06/10] staging/android: turn fence_info into a __64 pointer

Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Making fence_info a pointer enables us to extend the struct in the future > without breaking the ABI. > > Signed-off-by: Gustavo Padovan > --- >

Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file

Hey, Op 27-01-16 om 14:30 schreef Gustavo Padovan: > From: Gustavo Padovan > > sync_file is useful to connect one or more fences to the file. The file is > used by userspace to track fences. > > Signed-off-by: Gustavo Padovan >

Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up

ntless sync_timeline_signal at destroy > phase > staging/android: remove sync_fence_create_dma() > For whole series: Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Renaming sync_fence to sync_file makes sense, it should hopefully reduce confusion. ___

Re: [RFC 00/29] De-stage android's sync framework

Op 20-01-16 om 15:32 schreef Gustavo Padovan: > 2016-01-20 Maarten Lankhorst <maarten.lankho...@linux.intel.com>: > >> Hey, >> >> Op 15-01-16 om 15:55 schreef Gustavo Padovan: >>> From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> >>

Re: [RFC 00/29] De-stage android's sync framework

Hey, Op 15-01-16 om 15:55 schreef Gustavo Padovan: > From: Gustavo Padovan > > This patch series de-stage the sync framework, and in order to accomplish that > a bunch of cleanups/improvements on the sync and fence were made. > > The sync framework contained some

Re: [PATCH] android: fix warning when releasing active sync point

Op 15-12-15 om 18:19 schreef Dmitry Torokhov: > On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst > <maarten.lankho...@linux.intel.com> wrote: >> Op 15-12-15 om 02:29 schreef Dmitry Torokhov: >>> Userspace can close the sync device while there are still active fenc

Re: [PATCH] android: fix warning when releasing active sync point

Op 15-12-15 om 02:29 schreef Dmitry Torokhov: > Userspace can close the sync device while there are still active fence > points, in which case kernel produces the following warning: > > [ 43.853176] [ cut here ] > [ 43.857834] WARNING: CPU: 0 PID: 892 at >

Re: [RFC 02/12] staging/android/sync: add sync_fence_create_dma

Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com: > From: Maarten Lankhorst <maarten.lankho...@canonical.com> > > This allows users of dma fences to create a android fence. > > v2: Added kerneldoc. (Tvrtko Ursulin). > > Signed-off-by: Maarten Lankhorst <m

Re: [Intel-gfx] [RFC 02/12] staging/android/sync: add sync_fence_create_dma

Op 23-11-15 om 14:44 schreef Tvrtko Ursulin: > > On 23/11/15 13:38, John Harrison wrote: >> On 23/11/2015 13:27, Maarten Lankhorst wrote: >>> Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com: >>>> From: Maarten Lankhorst <maarten.lankho...@canonical.com

Re: [PATCH 2/2] android: add sync_fence_create_dma

Hey, Op 28-08-14 om 13:57 schreef Dan Carpenter: On Thu, Aug 28, 2014 at 08:54:05AM +0200, Maarten Lankhorst wrote: Hey, On 15-08-14 08:46, Greg Kroah-Hartman wrote: On Thu, Aug 14, 2014 at 11:54:52AM +0200, Maarten Lankhorst wrote: This allows users of dma fences to create a android fence

[PATCH] android: fix reference leak in sync_fence_create

According to the documentation sync_fence_create takes ownership of the point, not a reference on the point. This fixes a memory leak introduced in 3.17's android fence rework. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com Cc: Colin Cross ccr...@google.com Cc: Dan Carpenter

Re: [PATCH 1/2] android: fix reference leak in sync_fence_create

Hey, Op 18-08-14 om 14:57 schreef Dan Carpenter: On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote: According to the documentation sync_fence_create takes ownership of the point, not a reference on the point. What are the user visible effects of this bug? I assume

[PATCH 1/2] android: fix reference leak in sync_fence_create

According to the documentation sync_fence_create takes ownership of the point, not a reference on the point. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com Cc: Colin Cross ccr...@google.com --- drivers/staging/android/sync.c | 1 - 1 file changed, 1 deletion(-) diff --git