Re: [PATCH] somedriver: remove the initialization of static pointers.

2017-02-06 Thread Mathieu Poirier
On Sun, Feb 05, 2017 at 08:12:26AM +0100, AbdAllah MEZITI wrote: > On Sun, 5 Feb 2017 01:29:43 +0100 > Greg Kroah-Hartman wrote: > > > On Sat, Feb 04, 2017 at 08:39:21PM +0100, AbdAllah-MEZITI wrote: > > > In C a static pointer will be initialized to NULL (e.g: draft C99 > > > standard $6.7.8): "

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.

2015-12-15 Thread Mathieu Poirier
On 14 December 2015 at 17:08, Sanidhya Solanki wrote: > The original code defined macros in the source code, making it > harder to read. Moved them to the header file, as per the TODO file. > > Updated the TODO file. > > Signed-off-by: Sanidhya Solanki > --- > drivers/staging/skein/TODO

Re: [PATCH] staging: skein: macros moved to header file

2015-12-04 Thread Mathieu Poirier
On 4 December 2015 at 00:09, Sanidhya Solanki wrote: > Staging: Skein: Moved macros from skein_block.c to header file. > > The original code defined macros in the source code, making it harder to > read. Move them to the header file. The patch didn't end up mangled on my side but definitely did n

Re: [PATCH 1/4] staging: vt6655: correcting function declaration sparse error

2015-01-27 Thread Mathieu Poirier
On 25 January 2015 at 04:39, Greg KH wrote: > On Sat, Jan 17, 2015 at 07:04:23PM -0700, mathieu.poir...@linaro.org wrote: >> From: Mathieu Poirier >> >> mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ >> LD drivers/staging/vt6655/built-in.o &

[PATCH 1/4] staging: vt6655: correcting function declaration sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be st

[PATCH 4/4] staging: vt6655: correcting parameter related sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces

[PATCH 0/4] staging: vt6655: fixing various sparse problems

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier >From a v3.19-rc4 baseline sparse finds the following errors: LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) driv

[PATCH 3/4] staging: vt6655: fix wrong parameter as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c CC [M] drivers/staging/vt6655/device_main.o CHECK drivers/staging/vt6655/card.c CC [M] drivers/staging

[PATCH 2/4] staging: vt6655: removing dead function as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ CHECK drivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? CC [M] drivers/staging/vt6655/mac

[PATCH v2 2/2] staging: skein: Fixing single statement macro checkpatch warning

2014-12-22 Thread mathieu . poirier
From: Mathieu Poirier WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Mathieu Poirier --- drivers/staging/skein/skein_block.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b

[PATCH v2 1/2] staging: skein: Fixing trailing whitespace error

2014-12-22 Thread mathieu . poirier
From: Mathieu Poirier Signed-off-by: Mathieu Poirier --- drivers/staging/skein/skein_generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 85bd7d0168b0..899078f1b8bc 100644 --- a/drivers/staging/skein

[PATCH v2 0/2] staging: skein: Fixing various coding style problems

2014-12-22 Thread mathieu . poirier
From: Mathieu Poirier This patchset is fixing miscellaneous coding style problems as reported by checkpatch. More interesting is the removal of 'do {} while (0) loop' statements for single line macros. The following provides a guarantee the semantic of the object code hasn't

Re: [PATCH] staging: skein: Fixing various coding style problems

2014-12-21 Thread Mathieu Poirier
On 21 December 2014 at 18:57, Jason Cooper wrote: > Mathieu, > > On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote: >> From: Mathieu Poirier >> >> Fixing errors related to the usage of do {} while (0) loop >> in single statement macros,

[PATCH] staging: skein: Fixing various coding style problems

2014-12-21 Thread mathieu . poirier
From: Mathieu Poirier Fixing errors related to the usage of do {} while (0) loop in single statement macros, trailing semicolon in macros and trailing whitespace. Signed-off-by: Mathieu Poirier --- drivers/staging/skein/skein_block.c | 17 - drivers/staging/skein