* Ian Abbott [2017-11-20 10:46:36 +]:
On 20/11/17 10:29, Ian Abbott wrote:
On 20/11/17 07:50, Jesse Chan wrote:
This change resolves a new compile-time warning
when built as a loadable module:
WARNING: modpost: missing MODULE_LICENSE() in
() in
drivers/staging/comedi//drivers/ni_atmio.o
see include/linux/module.h for more information.
No longer present after change.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/comedi/drivers/ni_atmio.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/
* Greg KH <gre...@linuxfoundation.org> [2017-10-18 16:12:16 +0200]:
On Thu, Oct 05, 2017 at 04:38:23PM -0700, Matthew Giassa wrote:
Explicitly casting pci_power_t types to resolve sparse warnings (shown
below).
Also fixing a related logging bug where pci_power_t is cast to unsigne
Removing a comment that duplicates definitions for pci_power_t
enumeration, and pointing to the relevant header file (current comment
is also missing PCI_POWER_ERROR).
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/rtlwifi/pci.c | 7 +--
1 file changed, 1 ins
pci_power_t [usertype] current_state
drivers/staging/irda/drivers//vlsi_ir.c:1748:29:got int [signed]
[usertype] event
Warnings no longer present.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/irda/drivers/vlsi_ir.c | 10 ++
1 file changed, 6 insertions
] [usertype] link_status_new
drivers/staging//wlan-ng/prism2sta.c:1450:29:got restricted __le16
[usertype] linkstatus
Error no longer present.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/wlan-ng/prism2sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
* Greg KH <gre...@linuxfoundation.org> [2017-05-12 11:30:08 +0200]:
On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
+#defineREG_INT_MIG_8723B 0x0304 /* Interrupt Migration
*/
+#defineREG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Desc
Resolving checkpatch issue:
CHECK: 'Regsiter' may be misspelled - perhaps 'Register'?
CHECK: 'Interrup' may be misspelled - perhaps 'Interrupt'?
All instances resolved.
---
drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Resolving checkpatch issue:
WARNING: line over 80 characters
Consolidated indentation so local blocks of macros are column-aligned.
Slight slight change to make indentation more readable, assuming a
8-space hard-tab indentation style.
---
drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 262
This set of patches resolves a large number of non-functional issues
reported by checkpatch for the following header:
drivers/staging/rtl8723bs/include/rtl8723b_spec.h
*Typos in comments
*Indentation consistency (original code not formatted for 8-wide
hard-tabs) and 80+ column width lines.
Resolving checkpatch issue:
WARNING: please, no space before tabs
All instances resolved.
---
drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 30 +++
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h
Resolving checkpatch issue:
CHECK: Please don't use multiple blank lines
All instances resolved.
---
drivers/staging/rtl8723bs/include/rtl8723b_spec.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_spec.h
,
+unsigned long size)
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
b/drivers/staging/a
* Matthew Giassa <matt...@giassa.net> [2017-05-06 15:46:53 -0700]:
Included is a set of small fixes to resolve all outstanding checkpatch
warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic
(training whitespace and 80+ character comment), and the other is
functional
Modified comment to resolve 80+ characters warning from checkpatch. ie:
WARNING: line over 80 characters
Warnings no longer present after change.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Removing trailing newlines reported by checkpatch.pl. ie:
ERROR: trailing whitespace (lines 3, 7, 12).
Warnings no longer present after change.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Included is a set of small fixes to resolve all outstanding checkpatch
warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic
(training whitespace and 80+ character comment), and the other is
functional (macro argument previously not wrapped in parentheses).
Wrapping "offset" in macro definition to resolve checkpatch issue, ie:
CHECK: Macro argument 'offset' may be better as '(offset)' to avoid
precedence issues
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ccree/cc_hal.h | 5 +++--
1 file changed, 3
* Dan Carpenter <dan.carpen...@oracle.com> [2017-03-21 15:55:52 +0300]:
On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
Resolving 2 checkpatch warnings generated due to:
CHECK: spaces preferred around that '-'
Signed-off-by: Matthew Giassa <matt...@giassa.net>
Resolving 2 checkpatch warnings generated due to:
CHECK: spaces preferred around that '-'
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/vt6656/rf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/s
These patches address a few outstanding checkpatch warnings/errors in
rf.c, mainly due to space/indentation (style) issues.
---
drivers/staging/vt6656/rf.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
---
___
devel mailing
Resolving 5 instances of checkpatch error/warning statements generated
due to:
ERROR: code indent should use tabs where possible
CHECK: Alignment should match open parenthesis
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/vt6656/rf.c | 11 ++-
1 file chan
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_i
Removing trailing white space characters in comments to resolve
a checkpatch warning.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioct
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
The following patches address all outstanding checkpatch warnings/errors
present in drivers/staging/ks7010/ks_wlan_ioctl.h.
This change set has been rebased off of the current master
(69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request,
and the change log formatting has been
* Tobin C. Harding <m...@tobin.cc> [2017-03-15 14:14:08 +1100]:
On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote:
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all chec
Re-aligning function parameters in function prototypes by inserting
additional hard-tabs to resolve a checkpatch warning.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
Wrapping all complex macros with parentheses to resolve checkpatch
errors. This change, along with the preceding changes in this change
set, resolves all checkpatch warnings and errors for the file.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_i
Removing trailing white space characters in comments to resolve
a checkpatch warning.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioct
Removing mixed spaces/hard-tabs used to create a "column alignment" of
macro names and macro values.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
Implementing some minor formatting changes to remove checkpatch warnings.
Removing space-hardtab instances. Removing C++-style line comments in favor of
C-style equivalent. Re-aligning function prototype arguments to remove related
checkpatch warning.
Signed-off-by: Matthew Giassa <m
Updating macros to be wrapped in parentheses to accomodate checkpatch errors
throughout the header. This change, combined with the previous patch, resolves
all outstanding warnings/errors produce by checkpatch.
Signed-off-by: Matthew Giassa <matt...@giassa.net>
---
drivers/staging/
Assembling a set of patches to address all outstanding checkpatch issues in
staging/drivers/ks7010/ks_wlan_ioctl.h to replace my earlier v2 work which
attempted to do all of this in a single patch. This includes wrapping macros
with complex values in parentheses, removing extraneous/mixed
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 9f71f01..adc935d 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 47c8015..0aa402d 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 0aa402d..9f71f01 100644
--- a/drivers/staging/ks7010/ks_wlan_ioctl.h
+++
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +-
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index 8e62b10..47c8015 100644
---
39 matches
Mail list logo