Re: A review of dm-writeboost

2013-10-15 Thread Mikulas Patocka
On Mon, 14 Oct 2013, Akira Hayakawa wrote: > Hi, DM Guys > > I suppose I have finished the tasks to > answer Mikulas's pointing outs. > So, let me update the progress report. > > The code is updated now on my Github repo. > Checkout the develop branch to avail > the latest source code. > > Co

Re: A review of dm-writeboost

2013-10-07 Thread Mikulas Patocka
On Sun, 6 Oct 2013, Akira Hayakawa wrote: > Mikulas, > > Thank you for your reviewing. > > I will reply to polling issue first. > For the rest, I will reply later. > > > Polling for state > > - > > > > Some of the kernel threads that you spawn poll for data in one-second > >

A review of dm-writeboost

2013-10-05 Thread Mikulas Patocka
Hi I looked at dm-writeboost source code and here I'm sending the list of problems I found: Polling for state - Some of the kernel threads that you spawn poll for data in one-second interval - see migrate_proc, modulator_proc, recorder_proc, sync_proc. flush_proc correctly co

Re: [dm-devel] dm-writeboost testing

2013-10-05 Thread Mikulas Patocka
On Sat, 5 Oct 2013, Akira Hayakawa wrote: > Mikulas, > > > nvidia binary driver, but it may happen in other parts of the kernel too. > > The fact that it works in your setup doesn't mean that it is correct. > You are right. I am convinced. > > As far as I looked around the kernel code, > it s

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Mikulas Patocka
On Fri, 4 Oct 2013, Akira Hayakawa wrote: > Mikulas, > > Thanks for your pointing out. > > > The problem is that you are using workqueues the wrong way. You submit a > > work item to a workqueue and the work item is active until the device is > > unloaded. > > > > If you submit a work item

Re: [dm-devel] dm-writeboost testing

2013-10-04 Thread Mikulas Patocka
On Fri, 4 Oct 2013, Akira Hayakawa wrote: > Hi, Mikulas, > > I am sorry to say that > I don't have such machines to reproduce the problem. > > But agree with that I am dealing with workqueue subsystem > in a little bit weird way. > I should clean them up. > > For example, > free_cache() routi

dm-writeboost testing

2013-10-02 Thread Mikulas Patocka
Hi I tested dm-writeboost and I found these problems: Performance problems: I tested dm-writeboost with disk as backing device and ramdisk as cache device. When I run mkfs.ext4 on the dm-writeboost device, it writes data to the cache on the first time. However, on next mkfs.ext4 invocations,

Re: [dm-devel] Reworking dm-writeboost [was: Re: staging: Add dm-writeboost]

2013-10-02 Thread Mikulas Patocka
On Tue, 1 Oct 2013, Joe Thornber wrote: > > Alternatively, delaying them will stall the filesystem because it's > > waiting for said REQ_FUA IO to complete. For example, journal writes > > in XFS are extremely IO latency sensitive in workloads that have a > > signifincant number of ordering cons