Thanks, Martijn,
Greg, could you have a look to pick up?
On Mon, Aug 27, 2018 at 03:35:24PM +0200, Martijn Coenen wrote:
> Thanks Minchan!
>
> On Thu, Aug 23, 2018 at 7:29 AM, Minchan Kim wrote:
> > Signed-off-by: Todd Kjos
> > Signed-off-by: Minchan Kim
> Rev
On Thu, Aug 23, 2018 at 07:03:34PM +0900, Dae R. Jeong wrote:
> > Could you test this patch? I found that bug a month ago but didn't submit
> > yet.
>
> I don't have a reproducer now. I manually analzed a root cause of the
> crash using a fuzzer's log. The log reported a race on 'alloc->vma'.
> Be
bug). This is
> because, while RaceFuzzer precisely interleaves the scheduling at the
> kernel's instruction level when finding this bug, C repro cannot fully
> utilize such a feature. Please disregard all code related to
> "should_hypercall" in the C repro, as this is only for
Hello Rashika,
On Fri, Oct 25, 2013 at 7:10 PM, Minchan Kim wrote:
> Hello Rashika,
>
> First of all, thanks for looking this!
>
> On Tue, Oct 22, 2013 at 07:00:57PM +0530, Rashika Kheria wrote:
>> This patch fixes the following Smatch warning in zram_drv.c-
>> driv
Hey Rashika,
And please Cc LKML in next.
Thanks!
On Fri, Oct 25, 2013 at 7:13 PM, Minchan Kim wrote:
> On Tue, Oct 22, 2013 at 07:04:37PM +0530, Rashika Kheria wrote:
>> As suggested by Jerome Marchand "The code in reset_store get the block device
>> (bdget_disk()) bu
k);
>
> - if (zram->disk) {
> - del_gendisk(zram->disk);
> - put_disk(zram->disk);
> - }
> -
> - if (zram->queue)
> - blk_cleanup_queue(zram->queue);
> + blk_cleanup_queue(zram->queue);
> }
>
> static int __init zram_init(void)
> --
> 1.7.9.5
>
--
Kind regards,
Minchan Kim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; fsync_bdev(bdev);
> + bdput(bdev);
We should handle error case, too.
And please put this bug fix patch ahead of [1/2] because this patch is
more real bug fix than [1/2] which is just warning of smatch.
Thanks.
--
Kind regards,
Minchan Kim
__
code roughly, it seems to be not necessary but need double check.
If so, please remove the check code.
> del_gendisk(zram->disk);
> put_disk(zram->disk);
> }
> --
> 1.7.9.5
>
--
Kind regards,
Minchan Kim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
del_gendisk(zram->disk);
> > put_disk(zram->disk);
> > }
> > --
> > 1.7.9.5
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "opw-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to opw-kernel+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
--
Kind regards,
Minchan Kim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Sep 17, 2013 at 08:24:45PM +0300, Sergey Senozhatsky wrote:
>
> Hello,
>
> On (09/16/13 09:02), Minchan Kim wrote:
> > Hello Sergey,
> >
> > Sorry for really slow response. I was really busy by internal works
> > and Thanks for pointing the BUG, Dan
size_t index;
struct zram_meta *meta;
- flush_work(&zram->free_work);
down_write(&zram->init_lock);
if (!zram->init_done) {
@@ -560,6 +562,7 @@ static void zram_reset_device(struct zram *zram, bool
reset_capacity
wn problem and it should be fixed by [1] in recent linux-next.
[1] a0c516cbfc, zram: don't grab mutex in zram_slot_free_noity
Thanks for the report!
>
> Regards,
> Michael Wang
--
Kind regards,
Minchan Kim
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
we could put zsmalloc with zram in driver/block. Of course, we should
discuss it with akpm.
Okay. I think it's good time to promote zram again and I will retry
soon.
Thanks.
>
> Signed-off-by: Piotr Sarna
> Acked-by: Bartlomiej Zolnierkiewic
13 matches
Mail list logo
