[PATCH] Staging: slicoss: Fix smatch warning in slicoss.c

This patch fixes following smatch warning: slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/slicoss/slicoss.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

Reg: Staging Driver: lustre/lustre/lov

above but i that case what will be the allocation pattern? Regards, Monam Agarwal ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Staging driver: drivers/staging/vt6656/

On Sat, Mar 1, 2014 at 5:37 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Mar 01, 2014 at 03:37:17PM +0530, Monam Agarwal wrote: Hello all, I have a confusion regarding functions in aes_ccmp.c. It seems none of these functions are currently being used. So Is fine if we can remove

Staging driver: drivers/staging/vt6656/

Hello all, I have a confusion regarding functions in aes_ccmp.c. It seems none of these functions are currently being used. So Is fine if we can remove this file or should we keep it. Regards, Monam Agarwal ___ devel mailing list de

[PATCH] Staging: comedi: Fix line length exceeding 80 characters

Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/comedi/comedi_fops.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index ac1edd9..7da8566 100644 --- a/drivers/staging

Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

the function interval_erase_color() in /lustre/ldlm/interval_tree.c Date: January 11, 2014 at 1:33:58 PM MST To: Monam Agarwal monamagarwal...@gmail.com Cc: Dan Carpenter dan.carpen...@oracle.com, de...@driverdev.osuosl.org, andreas.dil...@intel.com, peter.p.waskiewicz...@intel.com, linux-ker

[PATCH 1/2] Staging: media: Fix quoted string split across line in as102_fe.c

This patch fixes the following checkpatch.pl issues in as102/as102_fe.c WARNING: quoted string split across lines Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_fe.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] Staging: media: Fix line length exceeding 80 characters in as102_fe.c

This patch fixes the following checkpatch.pl issues in as102/as102_fe.c WARNING: line over 80 characters Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_fe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] Staging: media: Fix line length exceeding 80 characters in as102_drv.c

This patch fixes the following checkpatch.pl warning in as102/as102_drv.c WARNING: line over 80 characters in the file Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/media/as102/as102_drv.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

/ldlm/interval_tree.c WARNING: line over 80 characters in the file Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- Changes since version 1: * Incorrect fixing * Incorrect Signed-off-by line --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 128 +++- 1 file

[PATCH v2 2/2] Staging: lustre: Fix return does not need parantheses

This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c ERROR: return is not a function, parentheses are not required Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/interval_tree.c |4 ++-- 1 file changed, 2

[PATCH v3 2/2] Staging: lustre: Fix return does not need parantheses

This patch fixes the following checkpatch.pl warning in lustre/ldlm/interval_tree.c ERROR: return is not a function, parentheses are not required Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- Changes since version 1: * Incoorect signed-off-by line Changes since version 2: * Forgot

Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

I took n as a flag to decide whether parent-in_left == node is true or not in the called function. Should I use some other name for the flag. On Sat, Jan 11, 2014 at 4:49 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote

[PATCH 1/2] Staging: lustre: Removal of Unnecessary white spaces

This fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_extent.c WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/2] Staging: lustre : Fix trailing statements should be on next line

The patch fixes the following checkpatch.pl error in lustre/ldlm/ldlm_extent.c ERROR: trailing statements should be on next line Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH v3 1/2] Staging: lustre: Refactor the function interval_erase_color() in /lustre/ldlm/interval_tree.c

On Sat, Jan 11, 2014 at 5:09 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote: I took n as a flag to decide whether parent-in_left == node is true or not in the called function. So n stands for node? Should I use some other name

[PATCH 1/3] Staging: lustre: Fix return does not need parantheses

This fixes the following checkpatch error in lustre/ldlm/ldlm_flock.c ERROR: return is not a function, parentheses are not required Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |8 1 file changed, 4 insertions(+), 4

[PATCH 2/3] Staging: lustre: :Fix line over 80 character warning

This patch fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_flock.c WARNING: line over 80 characters in the file Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 3/3] Staging: lustre: Fix warning on quoted string on multiple lines

his patch fixes the following type of checkpatch.pl errors in lustre/ldlm/ldlm_flock.c ERROR: trailing statements should be on next line Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2] Staging: lustre: Use of fls to find last set bit

: trailing statements should be on next line Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- Changes since v1: *Incorrect commit message *Use of fls function drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 1/3] Staging: lustre: Fix return does not need parantheses

The patch fixes the following checkpatch.pl error in lustre/ldlm/ldlm_flock.c ERROR: return is not a function, parentheses are not required Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |8 1 file changed, 4 insertions

[PATCH v2 3/3] Staging: lustre: Fix warning on quoted string on multiple lines

This patch fixes the following checkpatch.pl warning in lustre/ldlm/ldlm_flock.c WARNING: quoted string split across lines Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 2/3] Staging: lustre: :Fix line over 80 character warning

The patch fixes the following checkpatch.pl error in lustre/ldlm/ldlm_flock.c WARNING: line over 80 characters in the file Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v3] Staging: lustre: Use of fls to find last set bit

This introduces fls in lustre/ldlm/ldlm_extent.c to find the last set bit. Signed-off-by: Monam Agarwal monamagarwal...@gmail.com --- Changes since v1: * Incorrect commit message * Use of fls function Changes since v2: * Removal of extra variable drivers/staging/lustre/lustre/ldlm/ldlm_extent.c