Re: [PATCH V3] Staging: rtl8712 removed unnecessary else after return

with (--in-reply-to) and [PATCH V4] ? OR 2) Create new PATCH and start new mail chain done on latest code. Regards, Nitin On Thu, Oct 9, 2014 at 4:14 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote: Removed unnecessary else after return

Re: [PATCH] Staging: rtl8712 removed unnecessary else after return

Perhaps a more common style is to use: if (!padapter-halpriv.hal_bus_init || padapter-halpriv.hal_bus_init(padapter) != _SUCCESS) return _FAIL; Agreed. I will send updated patch. Regards, Nitin ___ devel mailing

[PATCH V2] Staging: rtl8712 removed unnecessary else after return

Removed unnecessary else after return to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/rtl8712/hal_init.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging

[PATCH] Staging: rtl8712 removed unnecessary else after return

Removed unnecessary else after return to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/rtl8712/hal_init.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging

[PATCH V3] Staging: rtl8712 removed unnecessary else after return

Removed unnecessary else after return to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/rtl8712/hal_init.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging

[PATCH] Staging: rtl8712 removed unnecessary else after return

Removed unnecessary else after return to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/rtl8712/hal_init.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging

[PATCH] Staging: rtl8712:ieee80211 remove unnecessary else

Removed unnecessary else after return/break to solve checkpatch.pl warning Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/rtl8712/ieee80211.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b

[PATCH] Staging: octeon-hcd: removed dummy label

This is a patch to the octeon-hcd.c file that removes dummy label i.e. label followed by return of void function Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/octeon-usb/octeon-hcd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH] Staging: octeon-hcd: removed dummy label

Hi Dan, Sorry for that. While doing some last movement changes related to indentation I accidentally removed the brace and did not build it after :-( I am sending PATCH with correction. Regards, Nitin Wat? Does this still compile without the curly brace? regards, dan carpenter

[PATCH V2] Staging: octeon-hcd: removed dummy label

This is a patch to the octeon-hcd.c file that fixes removes dummy label i.e. label followed by return of void function Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/octeon-usb/octeon-hcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH] Staging: octeon-hcd: removed unwanted return from void functions

This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by removing return statement from void functions. Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/octeon-usb/octeon-hcd.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers

Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

Hi Aaro, Thanks for review. I will correct the commit log length and resend the patch. About the __cvmx_usb_perform_complete(): Here return statement has associated label. Due to which it will add compilation warning. So I am not handling this. Note: Also checkpatch.pl does not complain about

[PATCH V2] Staging: octeon-hcd: removed unwanted return from void

This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by removing return statement from void functions. Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com --- drivers/staging/octeon-usb/octeon-hcd.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers