Re: [PATCH 0/6] Intel Secure Guard Extensions

> But... that will mean that my ssh will need to be SGX-aware, and that > I will not be able to switch to AMD machine in future. ... or to other > Intel machine for that matter, right? I'm not privy to AMD's CPU design plans. However I think for the ssl/ssh case you'd use the same interfaces

Re: [PATCH 0/6] Intel Secure Guard Extensions

> > Storing your ssh private key encrypted such that even someone who > > completely compromises your system can't get the actual private key > > Well, if someone gets root on my system, he can get my ssh private > key right? Potentially not. If you are using a TPM or other TEE (such as

Re: [PATCH 0/6] Intel Secure Guard Extensions

> Replay Protected Memory Block. It's a device that allows someone to > write to it and confirm that the write happened and the old contents > is no longer available. You could use it to implement an enclave that > checks a password for your disk but only allows you to try a certain > number of

Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

> +* Implement ACPI hot-lug for SGX. hot-plug Also with an upstream hat on I would add being able to check the keys on the enclave against a kernel keychain because not everyone will want to solely trust whatever keys the hardware thinks it wants to trust. Alan

Re: [PATCH] staging: goldfish: use div64_s64 instead of do_div

On Mon, 01 Feb 2016 11:33 +0100 Arnd Bergmann wrote: > The goldfish nand driver divides a signed 64-bit number (loff_t) > in multiple places using the do_div() function. This has always > been unreliable but now produces a compiler warning (since 4.5-rc1): > >

Re: [PATCH] staging: goldfish: use div64_s64 instead of do_div

On Mon, 01 Feb 2016 11:33 +0100 Arnd Bergmann wrote: > The goldfish nand driver divides a signed 64-bit number (loff_t) > in multiple places using the do_div() function. This has always > been unreliable but now produces a compiler warning (since 4.5-rc1): > >

Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout

> These results for Toeplitz are not plausible. Given random input you > cannot expect any hash function to produce such uniform results. I > suspect either your input data is biased or how your applying the hash > is. > > When I run 64 random IPv4 3-tuples through Toeplitz and Jenkins I get >

Re: [PATCH] Staging: speakup: read scrolled-back VT

On Fri, 1 Jan 2016 18:20:39 +0100 Samuel Thibault wrote: > Previously, speakup would always read the bottom part of the screen, > even when the VT is scrolled back with shift-page. This patch makes > vt.c export screen_pos so that speakup can use it to properly

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

On Fri, 11 Dec 2015 00:47:38 +0100 Wim de With <nauxu...@wimdewith.com> wrote: > On Thu, Dec 10, 2015 at 02:44:45PM +0000, One Thousand Gnomes wrote: > > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > > moment! > > Oops, sloppy mistake. Co

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

> if (cmd != SIOCWMIOCTL) > return -EOPNOTSUPP; > @@ -482,8 +483,16 @@ static int gdm_wimax_ioctl(struct net_device *dev, > struct ifreq *ifr, int cmd) > /* NOTE: gdm_update_fsm should be called >* before

Re: [PATCH] staging: comedi: replace ENOSYS by proper error codes

On Fri, 12 Jun 2015 13:43:27 -0700 Greg KH gre...@linuxfoundation.org wrote: On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.de...@gmail.com wrote: From: Julien Dehee julien.de...@gmail.com comedi/comedi_fops.c use ENODEV following open manual That should probably be ENXIO by a

Re: [PATCH 6/6] MAINTAINERS: maintain parport

On Wed, 20 May 2015 17:46:44 +0200 Richard Weinberger richard.weinber...@gmail.com wrote: On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: Lets give the parport subsystem a proper name and start maintaining the files. Excuse me, but usually someone takes

Re: [PATCH] staging: i2o: Remove unwanted semicolon

On Thu, 30 Apr 2015 16:14:06 +0200 gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.) wrote: This patch removes unwanted semicolon around close braces

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Thu, 15 Jan 2015 22:54:46 +0200 Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Alan, On Jan 15, 2015, at 22:45 , One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: On Thu, 15 Jan 2015 11:47:26 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Wed, 14 Jan 2015 11:12:58 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Wed, Jan 14, 2015 at 04:06:17PM +, One Thousand Gnomes wrote: and I think you effectively have the user usage covered here for such things. It much like GPIO pins - we can describe them but we

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Thu, 15 Jan 2015 11:47:26 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: It is a novel idea, my concern would be that embedding the FPGA in the DT makes it permanent unswappable kernel memory. Not having the kernel hold the FPGA is best for many uses. If you have a filesysytem

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

Those people have failed to show up and provide input and/or code. That doesn't excuse failing to design the code properly. It is one thing to context switch a maths algorithm that is built to be stateless, it is quite another to context switch between, say an ethernet core with an

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

The request_firmware interface should be for the DT overlay path, and other schemes shouldn't use it. The name should come from the DT and no place else. For the static bindings agreed (or ACPI but that's a detail) or other dynamic discovery post boot. 2) The bootloader starts the kernel

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Mon, 12 Jan 2015 11:06:08 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Sun, Jan 11, 2015 at 10:29:00AM -0600, atull wrote: the FPGA image. If someone wants there to be only one FPGA image on the FGPA forever, they will probably not be using this framework; their FPGA

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Mon, 12 Jan 2015 14:43:14 -0700 Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Jan 12, 2015 at 09:01:34PM +, One Thousand Gnomes wrote: There are plenty of people today who treat the FPGA as an entirely dynamic resource. It's not like flashing a controller, its near

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

Then configure udev to load right firmware for you, or ln -s image-i-want-now socfpga-fpga-image to select the one to read...? Your conceptual model is wrong. FPGA firmware is dynamic. There are already people who lazy reload FPGA firmware on taskswitches. This proposed fpga manager is broken

Re: [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style)

On Sat, 13 Dec 2014 11:46:47 -0800 Jeremiah Mahler jmmah...@gmail.com wrote: Loïc, On Sat, Dec 13, 2014 at 07:22:38PM +0100, Loic Pefferkorn wrote: Whose convention is this? I can't find any mention in Documention/CodingStyle. checkpatch.pl doesn't complain about them. And there are

Re: staging: goldfish: Fix minor coding style

On Sat, 13 Dec 2014 22:20:52 +0100 Loic Pefferkorn l...@loicp.eu wrote: On Sat, Dec 13, 2014 at 07:07:05PM +, One Thousand Gnomes wrote: Pointless churn. It makes it less readable if anything, and it removes the type safety as you are now checking against 0 not (void *)0 NAK

Re: [PATCH] staging: goldfish: Fix minor coding style

On Sat, 13 Dec 2014 17:29:26 +0100 Loic Pefferkorn l...@loicp.eu wrote: Hello, The convention for checking for NULL pointers is !ptr and not ptr == NULL. This patch fixes such occurences in goldfish driver, it applies against next-20141212 Signed-off-by: Loic Pefferkorn l...@loicp.eu

Re: [PATCH socfpga-nex] staging: fpga manager: socfpga_fpga_ops can be static

On Thu, 11 Dec 2014 09:43:24 +0800 kbuild test robot fengguang...@intel.com wrote: drivers/staging/fpga/socfpga.c:655:25: sparse: symbol 'socfpga_fpga_ops' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com Ought to be const as well by the look of it

Re: [PATCH 1/3] tools: hv: fcopy_daemon: Check buffer limits

On Tue, 21 Oct 2014 13:49:00 +0200 Matej Mužila mmuz...@redhat.com wrote: From: Matej Mužila mmuz...@redhat.com Check if cpmsg-size is in limits of DATA_FRAGMENT Signed-off-by: Matej Mužila mmuz...@redhat.com Acked-by: K. Y. Srinivasan k...@microsoft.com --- If corrupted data are read

Re: [PATCH 3/6] staging: goldfish: document spinlock usage

On Wed, 3 Sep 2014 13:13:44 +0200 Loic Pefferkorn l...@loicp.eu wrote: Coding style: document spinlock usage Signed-off-by: Loic Pefferkorn l...@loicp.eu --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH -next] staging/goldfish/goldfish_audio: fix a sparse warning

On Wed, 23 Jul 2014 08:16:39 +0200 Robin Schroer sulamiificat...@gmail.com wrote: Fix a pointer check to use NULL instead of 0 Warning: drivers/staging/goldfish/goldfish_audio.c:300:34: warning: Using plain integer as NULL pointer Signed-off-by: Robin Schroer sulamiificat...@gmail.com

Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

Reviewed-by: John L. Hammond john.hamm...@intel.com Reviewed-by: Isaac Huang he.hu...@intel.com Signed-off-by: Oleg Drokin oleg.dro...@intel.com --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] staging: goldfish: Call free_irq in error path

On Tue, 8 Apr 2014 09:15:22 +0300 Tuomas Tynkkynen tuomas.tynkky...@iki.fi wrote: If misc_register failed in goldfish_audio_probe, the already requested IRQ wouldn't get freed. Add a call to free_irq() like there is in goldfish_audio_remove(). Signed-off-by: Tuomas Tynkkynen

Re: [PATCH] et131x: fix allocation failures

On Fri, 7 Feb 2014 09:15:40 + Mark Einon mark.ei...@gmail.com wrote: On Wed, Feb 05, 2014 at 09:56:41PM +0800, Zhao, Gang wrote: @@ -2124,7 +2124,11 @@ static int et131x_rx_dma_memory_alloc(struct et131x_adapter *adapter) /* Alloc memory for the lookup table */

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

On Wed, 4 Dec 2013 10:35:54 -0800 Greg KH gre...@linuxfoundation.org wrote: On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote: +#define size_helper(x) ({ \ + size_t __size;

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

None of this (the patch series or the original code) is mine. My Sorry mistraced the attribution sequence question was more of a general one on designing ioctls, as well as concerns with changing the existing 32-bit api. I think in general my advice would be: If its already been screwed up