Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Philipp Zabel
On Mon, 2017-02-20 at 16:18 -0800, Steve Longerbeam wrote: > > On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > >> On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > >>> From: Russell King > >>> > >>> Sett

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > Hi Philipp, Steve and Russell, > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell K

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 11:47 +0100, Philipp Zabel wrote: > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > > for sensors with a MIPI CSI2 interface. > > > > Signed-off-by: Steve Longe

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > >> In version 4: > > > > With this version, I get: > > > > [28762.892053] imx6-mipi-csi2: LP-11 timeout, ph

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 11:06 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > > +static void csi2_dphy_init(struct csi2_dev *csi2) > > > +{ > >

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 10:56 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:39:11AM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > > > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Stev

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile | 1 + > drivers/staging/media/imx/imx6-

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > >On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > > >>In version 4: > >

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 17:33 -0800, Steve Longerbeam wrote: > > On 02/16/2017 05:02 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > >> + > >> +- Clean up and move the ov5642 subdev driver to drivers/media/i2c, and >

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-16 Thread Philipp Zabel
640 > +-- > + > +Similarly to SabreLite, the SabreSD supports a parallel interface > +OV5642 module on IPU1 CSI0, and a MIPI CSI-2 OV5640 module. The OV5642 > +connects to i2c bus 1 and the OV5640 to i2c bus 2. > + > +The device tree for SabreSD includes

Re: [PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 66 > + > 1 file changed, 66 insertions(+) > create mode 1006

Re: [PATCH v4 17/36] media: Add userspace header file for i.MX

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > --- > inc

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > The previous API and negotiation of mbus codes and pixel formats > was broken, and has been completely redone. > > The negotiation of media bus codes should be as follows: > > CSI: > > sink pad direct src pad IDMAC src pad > -

Re: [PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: [...] > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c > b/drivers/staging/media/imx/imx-ic-prpencvf.c > index dd9d499..c43f85f 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-p

Re: [PATCH v4 30/36] media: imx: update capture dev format on IDMAC output pad set_fmt

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > When configuring the IDMAC output pad formats (in ipu_csi, > ipu_ic_prpenc, and ipu_ic_prpvf subdevs), the attached capture > device format must also be updated. > > Signed-off-by: Steve Longerbeam > Suggested

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-15 Thread Philipp Zabel
Hi Steve, On Tue, 2017-02-14 at 18:27 -0800, Steve Longerbeam wrote: [...] > > > > # Provide an EDID to the HDMI source > > v4l2-ctl -d /dev/v4l-subdev2 --set-edid=file=edid-1080p.hex > > I can probably generate this Intel hex file myself from sysfs > edid outputs, but for convenience do you mind

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-14 Thread Philipp Zabel
Hi Steve, On Mon, 2017-02-13 at 15:20 -0800, Steve Longerbeam wrote: [...] > > It seems the OV5640 driver never puts its the CSI-2 lanes into stop > > state while not streaming. > > Yes I found that as well. > > But good news, I finally managed to coax the OV5640's clock lane > into LP-11 state!

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-13 Thread Philipp Zabel
oes) only if the sensor can still be configured in step 6. Also, 3./4./5. are csi2 code, 6. is sensor code, and 7. is csi2 code again. For reliable startup we need csi2 receiver code to be called on both sides of the sensor enabling its clock lane. --8<-- >From f12758caa3e

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Philipp Zabel
On Wed, 2017-02-08 at 15:23 -0800, Steve Longerbeam wrote: [...] > >> + > >> +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, > >> + struct v4l2_subdev_pad_config *cfg, > >> + struct v4l2_subdev_format *sdformat) > >> +{ > >> + struct imxcsi2_dev *csi2 =

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-08 Thread Philipp Zabel
Hi Sakari, On Tue, 2017-02-07 at 22:46 +0200, Sakari Ailus wrote: > Hi Steve, > > On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > >

[PATCH] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-02-07 Thread Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel --- This is a patch against the current imx-media-staging-md-wip branch. S_FMT wouldn't update the cropping rectangle d

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-07 Thread Philipp Zabel
017 04:48 PM, Laurent Pinchart wrote: > > >>> On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: > > >>>> On 01/24/2017 04:02 AM, Philipp Zabel wrote: > > >>>>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > > >>>>

Re: [PATCH v3 12/24] add mux and video interface bridge entity functions

2017-02-06 Thread Philipp Zabel
On Sun, 2017-02-05 at 17:36 +0200, Laurent Pinchart wrote: > Hi Steve, > > Thank you for the patch > > On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > --- > > Documenta

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-02 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + > drivers/staging/media/imx/imx-mi

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Wed, 2017-02-01 at 10:11 +, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 10:30:57AM +0100, Philipp Zabel wrote: > > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > > [...] > > > right, need to fix that. Probably by poking the attached >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] > > # Set pad formats > > media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" > > media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]" > > media-ctl --set-v4l2 "'ipu1_csi0_mux':2[fmt:UYVY2X8/1920x1080]" > > medi

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: > On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > [...] > > +static int csi_set_fmt(struct v4l2_subdev *sd, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] > +static int csi_set_fmt(struct v4l2_subdev *sd, > +struct v4l2_subdev_pad_config *cfg, > +struct v4l2_subdev_format *sdformat) > +{ > + struct csi_priv *priv = v4l2_get_subdevdata(sd); > +

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 14:54 +0100, Philipp Zabel wrote: > Hi Steve, > > I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X > with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some > observations: > > # Link pipeline > media-ctl -l &qu

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6-mipi-csi2':0[1]" media-ctl -l "'imx6-mipi-csi2':1->'ipu1_csi0_mux':0[1]" m

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 13:14 +, Russell King - ARM Linux wrote: > On Tue, Jan 31, 2017 at 11:09:24AM +0100, Philipp Zabel wrote: > > On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > > To help illustrate my point, consider the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > The central issue seems to be that I think media pad links / media bus > > formats should describe physical links, such as parallel or serial > > buses, and the formats of pixels flowing through them, whereas Steve > > would lik

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 17:22 -0800, Steve Longerbeam wrote: > > On 01/30/2017 04:45 PM, Russell King - ARM Linux wrote: > > > > Hi, > > > > Trying this driver with an imx219 camera (which works with Philipp's > > driver) results in not much happening... no /dev/media* node for it, > > no subdevs, n

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 00:01 +, Russell King - ARM Linux wrote: [...] > The iMX6 manuals call for a very specific seven sequence of initialisation > for CSI2, which begins with: > > 1. reset the D-PHY. > 2. place MIPI sensor in LP-11 state > 3. perform D-PHY initialisation > 4. configure CSI2 l

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Philipp Zabel
Hi Hans, On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
On Wed, 2017-01-18 at 17:44 -0800, Steve Longerbeam wrote: > > On 01/14/2017 02:42 PM, Steve Longerbeam wrote: > > > >>> +/* parse inputs property from a sensor node */ > >>> +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, > >>> +struct imx_media_subdev

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-23 at 17:45 -0800, Steve Longerbeam wrote: > > On 01/23/2017 05:38 PM, Steve Longerbeam wrote: > > > >> > >>> Second, ignoring the above locking issue for a moment, > >>> v4l2_pipeline_pm_use() > >>> will call s_power on the sensor _first_, then the mipi csi-2 s_power, >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
On Mon, 2017-01-23 at 12:08 +0100, Hans Verkuil wrote: > On 01/23/2017 12:00 PM, Philipp Zabel wrote: > > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > As long as it is mentioned in the TODO, and ideally in the Kconfig as well, > then I'm fine with it. >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
Hi Steve, Hans, [added Laurent to Cc: who I believe might have an opinion on the media bus formats, too. Sorry for the wall of text, I have put a marker where the MEDIA_BUS argument starts] The central issue seems to be that I think media pad links / media bus formats should describe physical lin

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-23 Thread Philipp Zabel
Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: > > On 01/16/2017 05:47 AM, Philipp Zabel wrote: > > On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: > > [...] > >>>> +Unprocessed Video Capture: > >>>> +---

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-23 Thread Philipp Zabel
On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > > There is a VDIC entity in the i.MX IPU that performs de-interlacing with > > hardware filters for motion compensation. Some of the motion compensation > > modes ("low" and "medium" motion) require that the VDIC receive video > > frame

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-20 Thread Philipp Zabel
from a requirement of a customer and is not > > necessary here. > > > > - The FIM must be explicitly enabled in the fim child node under the CSI > > port nodes, using the status property. If not enabled, FIM v4l2 controls > > will not appear in the vide

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. s/Serial/Sensor/ > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Kconfig | 13 + > drivers/staging/media/imx/Makefile | 2 + > d

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-16 Thread Philipp Zabel
On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] > >> +Unprocessed Video Capture: > >> +-- > >> + > >> +Send frames directly from sensor to camera interface, with no > >> +conversions: > >> + > >> +-> ipu_smfc -> camif > > I'd call this capture interface, thi

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 15:04 -0800, Steve Longerbeam wrote: > > On 01/13/2017 04:03 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > >> Both

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 11:03 -0800, Steve Longerbeam wrote: > > On 01/13/2017 03:55 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Add bindings documentation for the i.MX media driver. > >> > &

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/media/v4l-drivers/imx.rst | 443 ++ > drivers/staging/media/Kconfig | 2 + > drivers/stagi

Re: [PATCH v3 15/24] media: Add userspace header file for i.MX

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > ---

Re: [PATCH v3 02/24] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add to the MIPI CSI2 receiver node: compatible string, interrupt sources, > clocks. > > Signed-off-by: Steve Longerbeam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 57 > + > 1 file changed, 57 insertions(+) > create mo

Re: [PATCH v3 05/24] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > There is a pin conflict with GPIO_6. This pin functions as a power > input pin to the OV5642 camera sensor, but ENET uses it as the h/w > workaround for erratum ERR006687, to wake-up the ARM cores on normal > RX and TX packet done

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input

Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2015-01-06 Thread Philipp Zabel
Hi Heiko, Am Dienstag, den 06.01.2015, 12:49 +0100 schrieb Heiko Stübner: > Hi Philipp, > > Am Samstag, 6. Dezember 2014, 00:31:46 schrieb Andy Yan: > > > I am happy with the series so far. Pending Acks from the device tree > > > maintainers for the new binding documents, I'd like to apply either

Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-12-05 Thread Philipp Zabel
Hi Andy, Am Freitag, den 05.12.2014, 14:22 +0800 schrieb Andy Yan: > We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they also have some > lightly differences, such as phy pll configuration, register width(imx hdmi

Re: [PATCH v18 06/12] dt-bindings: add document for dw_hdmi

2014-12-05 Thread Philipp Zabel
Am Freitag, den 05.12.2014, 14:27 +0800 schrieb Andy Yan: > Signed-off-by: Andy Yan This binding is mostly a copy of the existing Documentation/devicetree/bindings/drm/imx/hdmi.txt, but there is a new reg-io-width property to configure the register access bus width and we have added new compatibl

Re: [PATCH v17 06/12] dt-bindings: add document for dw_hdmi

2014-12-04 Thread Philipp Zabel
Hi Andy, Am Donnerstag, den 04.12.2014, 18:06 +0800 schrieb Andy Yan: > Signed-off-by: Andy Yan > > --- > > Changes in v17: None > Changes in v16: > - describe ddc-i2c-bus as optional > - add common clocks bindings > > Changes in v15: None > Changes in v14: None > Changes in v13: None > Change

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-04 Thread Philipp Zabel
Hi Russell, Am Mittwoch, den 03.12.2014, 16:30 + schrieb Russell King - ARM Linux: > On Wed, Dec 03, 2014 at 05:20:15PM +0100, Philipp Zabel wrote: > > Hi Andy, > > > > It would be better if the bind function would not have to care about > > platform resources, th

Re: [PATCH v16 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Donnerstag, den 04.12.2014, 00:04 +0800 schrieb Andy Yan: > On 2014年12月03日 23:38, Russell King - ARM Linux wrote: > > On Wed, Dec 03, 2014 at 11:29:26PM +0800, Andy Yan wrote: > >> +int imx_hdmi_bind(struct device *dev, struct device *master, > >> +void *data, struct drm_en

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Mittwoch, den 03.12.2014, 20:32 +0800 schrieb Andy Yan: > > My question is not about the available gates at the SoC level, but about > > the actual clock inputs from point of view of the HDMI TX IP. > > > > It could be that the hdmi_ctrl_clk gates all inputs to the module and > > bus c

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Philipp Zabel
Am Mittwoch, den 03.12.2014, 17:46 +0800 schrieb Andy Yan: > On 2014年12月03日 02:23, Philipp Zabel wrote: > > Hi Andy, > > > > Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: > >> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt &

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-03 Thread Philipp Zabel
Hi Andy, Am Mittwoch, den 03.12.2014, 08:54 +0800 schrieb Andy Yan: > >> +Required properities: > >> +- compatible: platform specific such as: > >> + * "fsl,imx6q-hdmi" > >> + * "fsl,imx6dl-hdmi" > >> + * "rockchip,rk3288-dw-hdmi" > > I think we should add a common compatible value "snps,dw-

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > new file mode 100644 > index 000..107c1ca > --- /dev/null > +++ b/Documentation/devicetree

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 20:34 +0800 schrieb Andy Yan: > Hi Philipp: > On 2014年12月02日 18:24, Philipp Zabel wrote: > > Hi Andy, > > > > Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: > > [...] > >> +static int dw_hdmi_rockchip

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: [...] > +static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > + void *data) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + const struct dw_hdmi_pl

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-12-01 Thread Philipp Zabel
Am Sonntag, den 09.11.2014, 16:51 +0100 schrieb Guennadi Liakhovetski: > On Sun, 9 Nov 2014, Philipp Zabel wrote: > > > Hi Guennadi, > > > > On Fri, Nov 07, 2014 at 11:06:21PM +0100, Guennadi Liakhovetski wrote: > > > Hi Philipp, > > > > > >

Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access

2014-12-01 Thread Philipp Zabel
Am Freitag, den 28.11.2014, 17:43 +0800 schrieb Andy Yan: > Hi Zabel: > On 2014年11月27日 00:34, Philipp Zabel wrote: > > Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan: > >> On rockchip rk3288, only word(32-bit) accesses are > >> permitted for hdmi registers

Re: [PATCH v14 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi

2014-12-01 Thread Philipp Zabel
Hi Andy, Am Montag, den 01.12.2014, 19:24 +0800 schrieb Andy Yan: [...] > diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h > new file mode 100644 > index 000..1bbf3ca > --- /dev/null > +++ b/include/drm/bridge/dw_hdmi.h > @@ -0,0 +1,57 @@ > +/* > + * Copyright (C) 2011

Re: [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-28 Thread Philipp Zabel
Am Freitag, den 28.11.2014, 17:57 +0800 schrieb Andy Yan: > Hi Philipp: [...] >Very sorry about this trouble. Because I have no imx board, we do all > the test on > RK3288 board. > I had sent a mail with a debug patch to you directly yesterday, hope > it will helpful. > If you have receiv

Re: [PATCH v2 1/2] drm: imx: Move imx-drm driver out of staging

2014-11-26 Thread Philipp Zabel
Am Mittwoch, den 26.11.2014, 09:43 +1000 schrieb Dave Airlie: > On 25 November 2014 at 01:33, Philipp Zabel wrote: > > The imx-drm driver was put into staging mostly for the following reasons, > > all of which have been addressed or superseded: > > - convert the irq dri

Re: [PATCH v13 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access

2014-11-26 Thread Philipp Zabel
Am Mittwoch, den 26.11.2014, 21:32 +0800 schrieb Andy Yan: > On rockchip rk3288, only word(32-bit) accesses are > permitted for hdmi registers. Byte width accesses (writeb, > readb) generate an imprecise external abort. > > Signed-off-by: Andy Yan > > --- > > Changes in v13: None > Changes in v

Re: [PATCH v13 08/12] drm: bridge/dw_hdmi: add mode_valid support

2014-11-26 Thread Philipp Zabel
Am Mittwoch, den 26.11.2014, 21:33 +0800 schrieb Andy Yan: > some platform may not support all the display mode, > add mode_valid interface check it > > also add drm_connector_register which add a debugfs > interface for dump display modes and edid information > > Signed-off-by: Andy Yan > --- >

Re: [PATCH v13 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-26 Thread Philipp Zabel
Hi Andy, I have yet to look at this in more detail, but from a quick test starting with patch 3, the HDMI display stays black on Nitrogen6X, and starting with patch 8 I get the following error. imx-drm display-subsystem: [CONNECTOR:21:HDMI-A-1] drm_connector_register failed: -12 [ cu

[PATCH v2 1/2] drm: imx: Move imx-drm driver out of staging

2014-11-24 Thread Philipp Zabel
functions, this mostly resulted in the component framework and drm of_graph helpers. Before adding new fixes, and certainly before adding new features, move it into its proper place below drivers/gpu/drm. Signed-off-by: Philipp Zabel --- .../{staging/imx-drm => drm/imx}/fsl-imx-drm.

[PATCH v2 2/2] MAINTAINERS: add maintainer for i.MX DRM driver

2014-11-24 Thread Philipp Zabel
Add myself as the maintainer of the i.MX DRM driver. Signed-off-by: Philipp Zabel Acked-by: Shawn Guo --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3c69a3c7..b29325d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3202,6 +3202,13 @@ F

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-09 Thread Philipp Zabel
Hi Guennadi, On Fri, Nov 07, 2014 at 11:06:21PM +0100, Guennadi Liakhovetski wrote: > Hi Philipp, > > Thanks for the patch and sorry for a late reply. I did look at your > patches earlier too, but maybe not attentively enough, or maybe I'm > misunderstanding something now. In the scan_of_host()

Re: [PATCH v3 09/10] gpu: ipu-v3: Make use of media_bus_format enum

2014-11-07 Thread Philipp Zabel
> Reference new definitions in the ipu-v3 driver. > > Signed-off-by: Boris Brezillon Acked-by: Philipp Zabel regards Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Philipp Zabel
Hi Andy, I think separating the core from the SoC specific part is a good step into the right direction. Am Mittwoch, den 05.11.2014, 20:55 +0800 schrieb Andy Yan: > imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) > use the interface compatible Designware HDMI IP, but they > also have s

Re: [PATCH 2/3] drm: imx: Move imx-drm driver out of staging

2014-11-04 Thread Philipp Zabel
Am Dienstag, den 04.11.2014, 16:19 + schrieb Emil Velikov: > Hi Philipp, > > Just a flyby question > > On 04/11/14 10:52, Philipp Zabel wrote: > > The imx-drm driver was put into staging mostly for the following reasons, > > all of which have been addressed or sup

Re: [PATCH 2/3] drm: imx: Move imx-drm driver out of staging

2014-11-04 Thread Philipp Zabel
Am Dienstag, den 04.11.2014, 11:52 +0100 schrieb Philipp Zabel: > The imx-drm driver was put into staging mostly for the following reasons, > all of which have been addressed or superseded: > - convert the irq driver to use linear irq domains > - work out the device tree bindings,

[PATCH 2/3] drm: imx: Move imx-drm driver out of staging

2014-11-04 Thread Philipp Zabel
functions, this mostly resulted in the component framework and drm of_graph helpers. Before adding new fixes, and certainly before adding new features, move it into its proper place below drivers/gpu/drm. Signed-off-by: Philipp Zabel --- Since this patch is generated with --find-renames, it

[PATCH 1/3] staging: imx-drm: remove old FSF address from license text

2014-11-04 Thread Philipp Zabel
Linux already includes a copy of the GPL, checkpatch compains about the address. Remove it from the license text. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-ldb.c | 5 - drivers/staging/imx-drm/imx-tve.c | 5 - drivers/staging/imx-drm/ipuv3-crtc.c

[PATCH 3/3] MAINTAINERS: add maintainer for i.MX DRM driver

2014-11-04 Thread Philipp Zabel
Add myself as the maintainer of the i.MX DRM driver. Signed-off-by: Philipp Zabel --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index df2aecf..ddf191d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3183,6 +3183,13 @@ F: drivers/gpu

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-11-03 Thread Philipp Zabel
Hi Mauro, Guennadi, Am Dienstag, den 30.09.2014, 10:06 +0200 schrieb Philipp Zabel: > Am Montag, den 29.09.2014, 18:10 -0400 schrieb Greg Kroah-Hartman: > > On Mon, Sep 29, 2014 at 08:03:34PM +0200, Philipp Zabel wrote: > > > Decrementing the reference count of the previous en

[PATCH] imx-drm: currently only IPUv3 is supported, make it mandatory

2014-10-09 Thread Philipp Zabel
As long as only IPUv3 is supported in imx-drm, hide the separate DRM_IMX_IPUV3 option and make DRM_IMX depend on IMX_IPUV3_CORE. Reported-by: Michael Olbrich Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/Kconfig | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH v3 1/4] imx-drm: ipuv3-plane: allow local alpha in ipu_plane_mode_set()

2014-10-08 Thread Philipp Zabel
For the overlay plane scanning out a framebuffer with an alpha component, enable the DP local alpha feature on the partial plane. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-plane.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 4/4] imx-drm: ipuv3-plane: fix plane updates for active planes

2014-10-08 Thread Philipp Zabel
While the DMA channel is running, it is not allowed to change anything but the inactive (double) buffer base address, so resizing a plane or changing to a frame buffer with different pixel format is not possible. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/ipuv3-plane.c | 15

[PATCH v3 3/4] imx-drm: ipuv3-plane: enable double buffering

2014-10-08 Thread Philipp Zabel
This allows to update the buffer base address while the DMA channel is running. It is needed to flip the frame buffer of an active plane. Signed-off-by: Philipp Zabel --- Changes since v2: - Rebased onto 7d2691da901d (gpu: ipu-v3: Add ipu-cpmem unit) --- drivers/staging/imx-drm/ipuv3-plane.c

[PATCH v3 2/4] imx-drm: ipuv3-plane: move stride setting out of base setup

2014-10-08 Thread Philipp Zabel
Setting the stride can only be done on inactive channels, while the buffer base address can also be updated for running channels using the hardware double buffering feature. Signed-off-by: Philipp Zabel --- Changes since v2: - Rebased onto 7d2691da901d (gpu: ipu-v3: Add ipu-cpmem unit

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-30 Thread Philipp Zabel
Am Montag, den 29.09.2014, 18:10 -0400 schrieb Greg Kroah-Hartman: > On Mon, Sep 29, 2014 at 08:03:34PM +0200, Philipp Zabel wrote: > > Decrementing the reference count of the previous endpoint node allows to > > use the of_graph_get_next_endpoint function in a for_each_... style

[PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-29 Thread Philipp Zabel
argument's refcount themselves. Signed-off-by: Philipp Zabel --- Changes since v4: - Folded patches 1-3 into this one --- drivers/media/platform/soc_camera/soc_camera.c | 3 ++- drivers/of/base.c | 9 + drivers/staging/imx-drm/imx-drm-core.c

[PATCH v5 6/6] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of

2014-09-29 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. Since we can break out of the loop, we keep the call to of_node_put after the loop. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH v5 4/6] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-09-29 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm

[PATCH v5 2/6] of: Add for_each_endpoint_of_node helper macro

2014-09-29 Thread Philipp Zabel
Note that while of_graph_get_next_endpoint decrements the reference count of the child node passed to it, of_node_put(child) still has to be called manually when breaking out of the loop. Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart --- include/linux/of_graph.h | 11 +++ 1

[PATCH v5 5/6] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

2014-09-29 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. This patch also properly decrements the endpoint node reference count before returning out of the loop. Signed-off-by: Philipp Zabel --- drivers/staging/imx-drm/imx-drm-core.c | 9 +++-- 1 file changed, 3

[PATCH v5 3/6] of: Add of_graph_get_port_by_id function

2014-09-29 Thread Philipp Zabel
This patch adds a function to get a port device tree node by port id, or reg property value. Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart --- drivers/of/base.c| 26 ++ include/linux/of_graph.h | 7 +++ 2 files changed, 33 insertions(+) diff

[PATCH v5 0/6] Add of-graph helpers to loop over endpoints and find ports by id

2014-09-29 Thread Philipp Zabel
point. Changes since v4: - Combined patches 1-3 into one The previous version can be found here: https://lkml.org/lkml/2014/9/29/78 regards Philipp Philipp Zabel (6): of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint of: Add for_each_endpoint_of_node helper macro

Re: [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-29 Thread Philipp Zabel
Am Montag, den 29.09.2014, 12:13 +0300 schrieb Dan Carpenter: > On Mon, Sep 29, 2014 at 10:15:44AM +0200, Philipp Zabel wrote: > > In preparation for a following patch, stop decrementing the endpoint node > > refcount in the loop. This temporarily leaks a reference to the end

[PATCH v4 8/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of

2014-09-29 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. Since we can break out of the loop, we keep the call to of_node_put after the loop. Signed-off-by: Philipp Zabel --- Changes since v3: - Kept of_node_put after the loop, as in the earlier soc_camera patch. This

[PATCH v4 3/8] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-29 Thread Philipp Zabel
prev argument's refcount themselves. Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart --- drivers/of/base.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index d8574ad..a49b5628 100644 --- a/drivers/of/base.c +++ b/dr

[PATCH v4 6/8] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-09-29 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel Acked-by: Laurent Pinchart --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm

<    1   2   3   4   >