[PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-29 Thread Philipp Zabel
argument's refcount themselves. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Folded patches 1-3 into this one --- drivers/media/platform/soc_camera/soc_camera.c | 3 ++- drivers/of/base.c | 9 + drivers/staging/imx-drm/imx-drm

Re: [PATCH v3 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-25 Thread Philipp Zabel
Hi Guennadi, Am Samstag, den 20.09.2014, 09:24 +0200 schrieb Guennadi Liakhovetski: Hi Philippe, On Thu, 11 Sep 2014, Philipp Zabel wrote: In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint

Re: [GIT PULL] IPUv3 CPMEM API change across staging and drm

2014-09-11 Thread Philipp Zabel
Am Mittwoch, den 10.09.2014, 11:32 -0700 schrieb Greg Kroah-Hartman: On Wed, Sep 10, 2014 at 11:35:29AM +0200, Philipp Zabel wrote: Hi Greg, I have asked Dave to pull Steve Longerbeam's preparation series for capture support. It starts off with the following two commits that also touch

[PATCH v3 2/8] imx-drm: Do not decrement endpoint node refcount in the loop

2014-09-11 Thread Philipp Zabel
In preparation for the following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel

[PATCH v3 5/8] of: Add of_graph_get_port_by_id function

2014-09-11 Thread Philipp Zabel
This patch adds a function to get a port device tree node by port id, or reg property value. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v2: - Fixed and simplified of_graph_get_port_by_id function --- drivers/of/base.c| 26 ++ include

[PATCH v3 4/8] of: Add for_each_endpoint_of_node helper macro

2014-09-11 Thread Philipp Zabel
Note that while of_graph_get_next_endpoint decrements the reference count of the child node passed to it, of_node_put(child) still has to be called manually when breaking out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Laurent Pinchart laurent.pinch

[PATCH v3 6/8] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-09-11 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

[PATCH v3 7/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

2014-09-11 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. This patch also properly decrements the endpoint node reference count before returning out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 9

[PATCH v3 8/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of

2014-09-11 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm

[PATCH v3 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-11 Thread Philipp Zabel
In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel p.za

[PATCH v3 3/8] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-11 Thread Philipp Zabel
prev argument's refcount themselves. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/of/base.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index d8574ad

[PATCH v3 0/8] Add of-graph helpers to loop over endpoints and find ports by id

2014-09-11 Thread Philipp Zabel
macro instead of of_graph_get_next_endpoint. Changes since v2: - Fixed and simplified of_graph_get_port_by_id function - More acks The previous version can be found here: https://lkml.org/lkml/2014/9/10/252 regards Philipp Philipp Zabel (8): [media] soc_camera: Do not decrement endpoint

[GIT PULL] IPUv3 CPMEM API change across staging and drm

2014-09-10 Thread Philipp Zabel
Hi Greg, I have asked Dave to pull Steve Longerbeam's preparation series for capture support. It starts off with the following two commits that also touch the staging driver. Could you pull this into the staging tree to avoid conflicts later on? The following changes since commit

[PATCH v2 3/8] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-10 Thread Philipp Zabel
prev argument's refcount themselves. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index d8574ad..a49b5628 100644 --- a/drivers/of/base.c +++ b/drivers

[PATCH v2 0/8] Add of-graph helpers to loop over endpoints and find ports by id

2014-09-10 Thread Philipp Zabel
by Laurent, making use of port id defaulting to 0 if no reg property is given. - Added Laurent's ack to drm_of_find_possible_crtcs patch The previous version can be found here: https://lkml.org/lkml/2014/8/19/280 regards Philipp Philipp Zabel (8): [media] soc_camera: Do not decrement endpoint

[PATCH v2 5/8] of: Add of_graph_get_port_by_id function

2014-09-10 Thread Philipp Zabel
This patch adds a function to get a port device tree node by port id, or reg property value. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Fixed whitespace in comment - Changed id parameter to of_graph_get_port_by_id to u32 - Simplified of_graph_get_port_by_id

[PATCH v2 7/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

2014-09-10 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. This patch also properly decrements the endpoint node reference count before returning out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 9

[PATCH v2 8/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of

2014-09-10 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm

[PATCH v2 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-10 Thread Philipp Zabel
In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel p.za

[PATCH v2 2/8] imx-drm: Do not decrement endpoint node refcount in the loop

2014-09-10 Thread Philipp Zabel
In preparation for the following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel

[PATCH v2 6/8] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-09-10 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

[PATCH v2 4/8] of: Add for_each_endpoint_of_node helper macro

2014-09-10 Thread Philipp Zabel
Note that while of_graph_get_next_endpoint decrements the reference count of the child node passed to it, of_node_put(child) still has to be called manually when breaking out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Added a comment about the child

Re: [PATCH 1/4] imx-drm: ipuv3-plane: allow local alpha in ipu_plane_mode_set()

2014-09-09 Thread Philipp Zabel
Am Montag, den 08.09.2014, 12:50 -0700 schrieb Greg Kroah-Hartman: On Tue, Jul 29, 2014 at 11:57:06AM +0200, Philipp Zabel wrote: For the overlay plane scanning out a framebuffer with an alpha component, enable the DP local alpha feature on the partial plane. Signed-off-by: Philipp Zabel

[PATCH v2 4/4] imx-drm: ipuv3-plane: fix plane updates for active planes

2014-09-09 Thread Philipp Zabel
While the DMA channel is running, it is not allowed to change anything but the inactive (double) buffer base address, so resizing a plane or changing to a frame buffer with different pixel format is not possible. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm

[PATCH v2 1/4] imx-drm: ipuv3-plane: allow local alpha in ipu_plane_mode_set()

2014-09-09 Thread Philipp Zabel
For the overlay plane scanning out a framebuffer with an alpha component, enable the DP local alpha feature on the partial plane. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-plane.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

[PATCH v2 2/4] imx-drm: ipuv3-plane: move stride setting out of base setup

2014-09-09 Thread Philipp Zabel
Setting the stride can only be done on inactive channels, while the buffer base address can also be updated for running channels using the hardware double buffering feature. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-plane.c | 3 +-- 1 file changed, 1

Re: [PATCH 5/8] of: Add of_graph_get_port_by_id function

2014-08-22 Thread Philipp Zabel
Hi Laurent, Thank you for the comments. Am Mittwoch, den 20.08.2014, 22:13 +0200 schrieb Laurent Pinchart: [...] + struct device_node *port = NULL; + int port_id; + + while (true) { + port = of_get_next_child(node, port); + if (!port) +

[PATCH 0/5] Add of-graph helpers to loop over endpoints and find ports by id

2014-08-19 Thread Philipp Zabel
macro instead of of_graph_get_next_endpoint. regards Philipp Philipp Zabel (8): [media] soc_camera: Do not decrement endpoint node refcount in the loop imx-drm: Do not decrement endpoint node refcount in the loop of: Decrement refcount of previous endpoint

[PATCH 4/8] of: Add for_each_endpoint_of_node helper macro

2014-08-19 Thread Philipp Zabel
Note that while of_graph_get_next_endpoint decrements the reference count of the child node passed to it, of_node_put(child) still has to be called manually when breaking out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- include/linux/of_graph.h | 4 1 file changed, 4

[PATCH 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-08-19 Thread Philipp Zabel
In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel p.za

[PATCH 6/8] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-08-19 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c

[PATCH 3/8] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-08-19 Thread Philipp Zabel
prev argument's refcount themselves. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index d8574ad..a49b5628 100644 --- a/drivers/of/base.c +++ b/drivers

[PATCH 5/8] of: Add of_graph_get_port_by_id function

2014-08-19 Thread Philipp Zabel
This patch adds a function to get a port device tree node by port id, or reg property value. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c| 30 ++ include/linux/of_graph.h | 7 +++ 2 files changed, 37 insertions(+) diff --git

[PATCH 2/8] imx-drm: Do not decrement endpoint node refcount in the loop

2014-08-19 Thread Philipp Zabel
In preparation for the following patch, stop decrementing the endpoint node refcount in the loop. This temporarily leaks a reference to the endpoint node, which will be fixed by having of_graph_get_next_endpoint decrement the refcount of its prev argument instead. Signed-off-by: Philipp Zabel

[PATCH 7/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

2014-08-19 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. This patch also properly decrements the endpoint node reference count before returning out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 9

[PATCH 8/8] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_parse_of

2014-08-19 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm

Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Philipp Zabel
Am Dienstag, den 19.08.2014, 16:59 +0300 schrieb Yannis Damigos: This is a patch to the ipuv3-crtc.c file that fixes up two lines over 80 characters warnings found by the checkpatch.pl tool. Signed-off-by: Yannis Damigos giannis.dami...@gmail.com --- drivers/staging/imx-drm/ipuv3-crtc.c |

Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.

2014-08-19 Thread Philipp Zabel
, ipu_crtc-plane[0]-y); + ipu_plane_set_base(plane, ipu_crtc-base.primary-fb, +plane-x, plane-y); ipu_crtc_handle_pageflip(ipu_crtc); } Yes, that does look better. Acked-by: Philipp Zabel p.za...@pengutronix.de regards Philipp

[PATCH 2/4] imx-drm: ipuv3-plane: move stride setting out of base setup

2014-07-29 Thread Philipp Zabel
Setting the stride can only be done on inactive channels, while the buffer base address can also be updated for running channels using the hardware double buffering feature. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-plane.c | 3 +-- 1 file changed, 1

[PATCH 3/4] imx-drm: ipuv3-plane: enable double buffering

2014-07-29 Thread Philipp Zabel
This allows to update the buffer base address while the DMA channel is running. It is needed to flip the frame buffer of an active plane. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-plane.c | 14 +++--- 1 file changed, 11 insertions(+), 3

[PATCH 4/4] imx-drm: ipuv3-plane: fix plane updates for active planes

2014-07-29 Thread Philipp Zabel
While the DMA channel is running, it is not allowed to change anything but the inactive (double) buffer base address, so resizing a plane or changing to a frame buffer with different pixel format is not possible. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm

[PATCH 1/4] imx-drm: ipuv3-plane: allow local alpha in ipu_plane_mode_set()

2014-07-29 Thread Philipp Zabel
For the overlay plane scanning out a framebuffer with an alpha component, enable the DP local alpha feature on the partial plane. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-plane.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions

Re: [PATCH RFC] imx-drm: convert imx-drm to use the generic DRM OF helper

2014-07-04 Thread Philipp Zabel
issue in the patch mentioned above, but I'd like to fix this in of_graph_get_next_endpoint instead. For both patches, Acked-by: Philipp Zabel p.za...@pengutronix.de regards Philipp ___ devel mailing list de...@linuxdriverproject.org http

[PATCH 5/5] imx-drm: use for_each_endpoint_of_node macro in imx_drm_encoder_get_mux_id

2014-07-04 Thread Philipp Zabel
Using the for_each_... macro should make the code bit shorter and easier to read. This patch also properly decrements the endpoint node reference count before returning out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 9

[PATCH 3/5] of: Add for_each_endpoint_of_node helper macro

2014-07-04 Thread Philipp Zabel
Note that while of_graph_get_next_endpoint decrements the reference count of the child node passed to it, of_node_put(child) still has to be called manually when breaking out of the loop. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- include/linux/of_graph.h | 4 1 file changed, 4

[PATCH 2/5] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-07-04 Thread Philipp Zabel
Decreasing the reference count of the previous endpoint node allows to use the of_graph_get_next_endpoint function in a for_each_... style macro. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/of/base.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

[PATCH 4/5] drm: use for_each_endpoint_of_node macro in drm_of_find_possible_crtcs

2014-07-04 Thread Philipp Zabel
Using the for_each_... macro should make the code a bit shorter and easier to read. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/gpu/drm/drm_of.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c

[PATCH 0/5] Iterate of_graph endpoints using a for_each_... style macro

2014-07-04 Thread Philipp Zabel
to it. It builds upon Russell's patches: drm: add of_graph endpoint helper to find possible CRTCs and imx-drm: convert imx-drm to use the generic DRM OF helper regards Philipp Philipp Zabel (5): imx-drm: Drop imx_drm_of_get_next_endpoint wrapper of: Decrement refcount of previous endpoint

[PATCH 1/5] imx-drm: Drop imx_drm_of_get_next_endpoint wrapper

2014-07-04 Thread Philipp Zabel
We will decrease the prev node reference count in of_graph_get_next_endpoint instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm

Re: [PATCH RFC v2 3/8] component: add support for component match array

2014-06-26 Thread Philipp Zabel
Hi Russell, On Tue, Jun 24, 2014 at 9:29 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: [...] +/* + * Add a component to be matched. + * + * The match array is first created or extended if necessary. + */ +void component_match_add(struct device *dev, struct component_match

[PULL] Move IPUv3 core out of staging, add CSI support

2014-06-04 Thread Philipp Zabel
V4L2 support in parallel. I have rebased the series back to v3.15-rc3, the tag closest to the common ancestor of drm-next and staging-next, and verified that merging the two produces the correct result. regards Philipp Philipp Zabel (5

Re: [PATCH v2 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2014-06-02 Thread Philipp Zabel
Am Mittwoch, den 28.05.2014, 14:13 -0700 schrieb Greg Kroah-Hartman: On Mon, May 26, 2014 at 04:19:39PM +0200, Philipp Zabel wrote: The i.MX Image Processing Unit (IPU) contains a number of image processing blocks that sit right in the middle between DRM and V4L2. Some of the modules

[PATCH v2 5/5] gpu: ipu-v3: Register the CSI modules

2014-05-26 Thread Philipp Zabel
This patch registers the two CSI platform devices per IPU. Signed-off-by: Lucas Stach l.st...@pengutronix.de Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since RFC: - Rebased onto current staging-next --- drivers/gpu/ipu-v3/ipu-common.c | 37

[PATCH v2 2/5] gpu: ipu-v3: Add SMFC code

2014-05-26 Thread Philipp Zabel
The Sensor Multi Fifo Controller (SMFC) is used as a buffer between the two CSIs (writing simultaneously) and up to four IDMAC channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/gpu/ipu-v3/Makefile | 2 +- drivers/gpu/ipu-v3/ipu-common.c | 10 + drivers/gpu/ipu-v3

[PATCH v2 0/5] Move IPUv3 core out of staging, add CSI support

2014-05-26 Thread Philipp Zabel
unchanged. I hope we can get this move in before the approaching merge window so that we have a base for submitting the CSI V4L2 patches in the following round. regards Philipp --- Changes since RFC: - Rebased onto current staging-next - Streamlined destaging patch a bit --- Philipp Zabel (5): gpu

[PATCH v2 1/5] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2014-05-26 Thread Philipp Zabel
framework, but others, such as the dma controller (IDMAC) and image converter (IC) can be used by both. The IPUv3 core driver provides an internal API to access the modules, to be used by both DRM and V4L2 IPUv3 drivers. Signed-off-by: Lucas Stach l.st...@pengutronix.de Signed-off-by: Philipp Zabel

[PATCH v2 4/5] gpu: ipu-v3: Add CSI and SMFC module enable wrappers

2014-05-26 Thread Philipp Zabel
IPU_CONF_..._EN bits are implementation details, not to be made public. Add wrappers around ipu_module_enable/disable, so the CSI V4L2 driver can enable/disable the CSI and SMFC modules. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/gpu/ipu-v3/ipu-common.c | 24

Re: [PATCH v2 0/5] Move IPUv3 core out of staging, add CSI support

2014-05-26 Thread Philipp Zabel
On Mon, May 26, 2014 at 4:19 PM, Philipp Zabel p.za...@pengutronix.de wrote: [...] Cc: drm-de...@vger.kernel.org Sorry about this unfortunate combination of me misremembering dri-devel, noticing something is wrong, looking up and inserting the correct address, and then, after a context switch

[PATCH] imx-drm: imx-hdmi: move memory and resource allocation into probe function

2014-05-14 Thread Philipp Zabel
the irq only after the interrupt handler mutes are set up, to avoid spurious interrupts. Signed-off-by: Philipp Zabel philipp.za...@gmail.com --- drivers/staging/imx-drm/imx-hdmi.c | 163 +++-- 1 file changed, 83 insertions(+), 80 deletions(-) diff --git a/drivers

[PATCH 7/7] imx-drm: ipuv3-crtc: Change display enable/disable order

2014-04-14 Thread Philipp Zabel
would not correctly start, leading to non-working LVDS displays. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-crtc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm

[PATCH 5/7] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module

2014-04-14 Thread Philipp Zabel
The former has to be done before disabling the DMFC, the latter has to be done afterwards. Otherwise the DMFC FIFOs never get cleared properly. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-dp.c

[PATCH 1/7] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts

2014-04-14 Thread Philipp Zabel
This allows to request the DC related interrupts. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 19 +-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Philipp Zabel
to finish processing the current frame, then stop the DI and IDMAC, and only then disable clocks to the submodules. Also from now on we disable the DC when it is not in use. regards Philipp Philipp Zabel (7): imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts imx-drm: ipu-common

[PATCH 6/7] imx-drm: imx-dp: When disabling the DP foreground channel, wait until the DP background channel is finished before disabling the IDMAC channel

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c index 6980fa1..d90f82a 100644 --- a/drivers/staging/imx-drm/ipu

[PATCH 2/7] imx-drm: ipu-common: Add helpers to check for a busy IDMAC channel and to busywait for an interrupt

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 22 ++ drivers/staging/imx-drm/ipu-v3/ipu-prv.h| 3 +++ 2 files changed, 25 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx

[PATCH 3/7] imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling

2014-04-14 Thread Philipp Zabel
Disabling the DMFC module while there is still data in the FIFOs could cause the new frame before end of frame error state when the DMFC is enabled again. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 25 +++-- 1 file

[PATCH v2 3/8] imx-drm: ipu-dmfc: Wait for FIFOs to run empty before disabling

2014-04-14 Thread Philipp Zabel
Disabling the DMFC module while there is still data in the FIFOs could cause the new frame before end of frame error state when the DMFC is enabled again. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 25 +++-- 1 file

[PATCH v2 6/8] imx-drm: imx-dp: When disabling the DP foreground channel, wait until the DP background channel is finished before disabling the IDMAC channel

2014-04-14 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c index 6980fa1..d90f82a 100644 --- a/drivers/staging/imx-drm/ipu

[PATCH v2 4/8] imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt

2014-04-14 Thread Philipp Zabel
Wait for the DC Frame Complete or DP Sync Flow End interrupts before disabling DC channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Moved disable_irq() out of dc_irq_handler() --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 71

[PATCH v2 5/8] imx-drm: ipu-dp: Split disabling the DP foreground channel from disabling the DP module

2014-04-14 Thread Philipp Zabel
The former has to be done before disabling the DMFC, the latter has to be done afterwards. Otherwise the DMFC FIFOs never get cleared properly. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu-dp.c

[PATCH v2 1/8] imx-drm: ipu-common: add ipu_map_irq to request non-IDMAC interrupts

2014-04-14 Thread Philipp Zabel
This allows to request the DC related interrupts. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 19 +-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH] imx-drm: imx-drm-core: Fix imx_drm_encoder_get_mux_id

2014-04-07 Thread Philipp Zabel
The decoder mux id is equal to the port id of the encoder's input port that is connected to the given crtc, not to the endpoint id (which is arbitrary and usually zero). Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 2 +- 1 file changed, 1

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-07 Thread Philipp Zabel
Hi Shawn, Am Montag, den 07.04.2014, 12:23 +0800 schrieb Shawn Guo: On Tue, Mar 11, 2014 at 11:46:11AM +0800, Shawn Guo wrote: I just came across a couple problems when testing the series on my imx6dl-sabresd board in dual display case - HDMI + LVDS. I tested it using Russell's branch

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-07 Thread Philipp Zabel
Am Montag, den 07.04.2014, 12:05 +0200 schrieb Philipp Zabel: Hi Shawn, Am Montag, den 07.04.2014, 12:23 +0800 schrieb Shawn Guo: On Tue, Mar 11, 2014 at 11:46:11AM +0800, Shawn Guo wrote: I just came across a couple problems when testing the series on my imx6dl-sabresd board in dual

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-11 Thread Philipp Zabel
Hi Shawn, Am Dienstag, den 11.03.2014, 11:46 +0800 schrieb Shawn Guo: On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT binding patches applies on top of staging-next and also depends on the OF graph binding patchset that moves

Re: [PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support

2014-03-07 Thread Philipp Zabel
Hi Russell, Am Freitag, den 07.03.2014, 17:22 + schrieb Russell King - ARM Linux: On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote: This patch allows to optionally attach the lvds-channel to a panel supported by a drm_panel driver instead of supplying the modes via device

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Philipp Zabel
[Added Shawn to Cc:] On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT

Re: [PATCH v5 06/11] imx-drm: imx-tve: Fix DDC I2C bus property

2014-03-06 Thread Philipp Zabel
Hi Russell, Am Donnerstag, den 06.03.2014, 13:03 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:57AM +0100, Philipp Zabel wrote: This patch fixes the TV Encoder DDC I2C bus property to use the common 'ddc-i2c-bus' property name instead of 'ddc'. Looking at both hdmi

[PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support

2014-03-06 Thread Philipp Zabel
-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-ldb.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index 4576830..38a0795 100644 --- a/drivers/staging/imx-drm/imx-ldb.c

[PATCH 2/2] imx-drm: imx-ldb: Use OF graph to find connected panel

2014-03-06 Thread Philipp Zabel
This patch depends on the OF graph parsing helper and imx-drm-dt series. It allows to connect the panel to the output port (port@1 on i.MX53, port@4 on i.MX6) via the OF graph bindings. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-ldb.c | 19

Re: [PATCH 2/2] imx-drm: imx-ldb: Use OF graph to find connected panel

2014-03-06 Thread Philipp Zabel
Am Donnerstag, den 06.03.2014, 14:54 +0100 schrieb Philipp Zabel: This patch depends on the OF graph parsing helper and imx-drm-dt series. It allows to connect the panel to the output port (port@1 on i.MX53, port@4 on i.MX6) via the OF graph bindings. If we postpone this until the imx-drm-dt

Re: [PATCH v9][ 7/8] ARM: dts: mbimx51sd: Add display support.

2014-03-06 Thread Philipp Zabel
Hi Denis, Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli: [...] +display { + status = okay; + display-timings { + model = DVI-SVGA; Does this board really have a DVI connector and no I2C bus routed to the DDC pins? + bits-per-pixel = 16; +

Re: [PATCH v9][ 6/8] staging: imx-drm: parallel display: add regulator support.

2014-03-06 Thread Philipp Zabel
Hi Denis, Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli: diff --git a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt index 2d24425..4dd7ce5 100644 ---

Re: [PATCH v9][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-06 Thread Philipp Zabel
Hi Denis, Am Donnerstag, den 06.03.2014, 17:01 +0100 schrieb Denis Carikli: The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli de...@eukrea.com patches 1 to 3 Acked-by: Philipp Zabel

[PATCH v5 05/11] imx-drm: imx-hdmi: Fix DDC I2C bus property

2014-03-05 Thread Philipp Zabel
This patch fixes the DDC I2C bus property to use the common 'ddc-i2c-bus' property name instead of 'ddc'. This is already documented in Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-hdmi.c | 2 +- 1

[PATCH v5 00/11] imx-drm dt bindings

2014-03-05 Thread Philipp Zabel
by the simple-panel binding instead of the custom but very generic 'ddc'. regards Philipp Philipp Zabel (11): staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs staging: imx-drm-core: use of_graph_parse_endpoint staging: imx-drm: Document

[PATCH v5 09/11] ARM: dts: imx53: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
-by: Philipp Zabel p.za...@pengutronix.de --- - Changed DT compatible string to 'fsl,imx-display-subsystem' instead of Linux specific 'fsl,imx-drm', changed DT node name from 'imx-drm' to 'display-subsystem'. --- arch/arm/boot/dts/imx53-m53evk.dts | 17 +- arch/arm/boot/dts/imx53-mba53.dts

[PATCH v5 10/11] ARM: dts: imx6qdl: Add IPU DI ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
to the display interfaces, it can be moved to the SoC dtsi level. At the board level, only connections between the display interface ports and encoders or panels have to be added. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- - Changed DT compatible string to 'fsl,imx-display-subsystem

[PATCH v5 03/11] staging: imx-drm: Document updated imx-drm device tree bindings

2014-03-05 Thread Philipp Zabel
This patch updates the device tree binding documentation for i.MX IPU/display nodes using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - changed DT compatible string

[PATCH v5 08/11] ARM: dts: imx51: Add IPU ports and endpoints, move imx-drm node to dtsi

2014-03-05 Thread Philipp Zabel
node now only needs to contain links to the display interfaces, it can be moved to the SoC dtsi level. At the board level, only connections between the display interface ports and panels have to be added. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Changed DT

[PATCH v5 11/11] staging: imx-drm: Update TODO

2014-03-05 Thread Philipp Zabel
The device tree bindings are updated regardless of the common display framework and in the meantime the HDMI driver was included. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/TODO | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/imx-drm

[PATCH v5 07/11] ARM: dts: imx53-mba53: Fix TVE DDC I2C bus property

2014-03-05 Thread Philipp Zabel
This patch fixes the Television Encoder node's DDC I2C bus property to use the common property name of 'ddc-i2c-bus' instead of just 'ddc'. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- arch/arm/boot/dts/imx53-mba53.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com This patch adds support to find the involved components connected to the IPU display interface ports using the OF graph bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. It makes use of the of_graph (formerly v4l2_of

Re: [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Philipp Zabel
Am Mittwoch, den 05.03.2014, 10:05 + schrieb Russell King - ARM Linux: On Wed, Mar 05, 2014 at 10:20:52AM +0100, Philipp Zabel wrote: +struct imx_drm_component { + struct device_node *of_node; + struct list_head list; +}; + The only thing this structure appears to be doing

Re: [PATCH v5 1/2] imx-drm: ipu-dmfc: Remove unneeded 'dmfc' check

2014-02-28 Thread Philipp Zabel
of moving it earlier Acked-by: Philipp Zabel p.za...@pengutronix.de I'll resend the move-out-of-staging patch rebased on top of this. thanks Philipp ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo

Re: [PATCH v5 2/2] imx-drm: imx-ldb: Use snprintf()

2014-02-28 Thread Philipp Zabel
-drm/imx-ldb.c @@ -334,12 +334,12 @@ static int imx_ldb_get_clk(struct imx_ldb *ldb, int chno) { char clkname[16]; - sprintf(clkname, di%d, chno); + snprintf(clkname, sizeof(clkname), di%d, chno); Acked-by: Philipp Zabel p.za...@pengutronix.de regards Philipp

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Philipp Zabel
Am Donnerstag, den 27.02.2014, 13:06 +0200 schrieb Tomi Valkeinen: On 25/02/14 16:23, Philipp Zabel wrote: +Freescale i.MX DRM master device + + +The freescale i.MX DRM master device is a virtual device needed to list all +IPU or other display interface

[PATCH] imx-drm: parallel-display: Add drm_panel support

2014-02-25 Thread Philipp Zabel
; ... }; panel: panel { compatible = edt,etm0700g0dh6, simple-panel; }; Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/Kconfig| 1 + drivers/staging/imx-drm/parallel-display.c | 23 +++ 2

[PATCH 0/3] Move IPUv3 core out of staging

2014-02-25 Thread Philipp Zabel
versions with and without --find-renames. To move the remaining DRM part out of staging, I'd like to get the device tree bindings sorted out. This is currently pending on the move of OF graph parsing helpers and review of the imx-drm dt bindings patch series. regards Philipp Philipp Zabel (3): imx-drm

[PATCH 1/3] imx-drm: Move IPU_PIX_FMT_GBR24 definition into imx-ipu-v3.h

2014-02-25 Thread Philipp Zabel
that both the IPU display interface driver and the TVE encoder driver can access it. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm.h | 4 drivers/staging/imx-drm/imx-tve.c | 1 + drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 ++ 3

<    1   2   3   4   >