Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

2018-10-01 Thread Pkshih
On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > >> The following: > >>  bool efuse_re_pg_sec1flag; > >>  u8 efuse_re_pg_data[8]; > >> are not referenced anywhere in the rtlwifi code. > >>  > >> Signed-off-by:

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

2018-07-05 Thread Pkshih
On Thu, 2018-07-05 at 12:06 -0500, Larry Finger wrote: > On 07/05/2018 02:36 AM, Pkshih wrote: > > On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: > >> On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger > >> wrote: > >>> We will have to agree to di

Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP

2018-07-05 Thread Pkshih
On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: > On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger > wrote: > > We will have to agree to disagree. > > > > I have no idea what the vendors are doing that cause some motherboards to > > need a different aspm value. What I do know is that we have

Re: [PATCH] staging: rtlwifi: remove redundant initialization of 'cfg_cmd'

2018-01-28 Thread Pkshih
On Fri, 2018-01-26 at 13:52 +, Colin King wrote: > From: Colin Ian King >  > The initialization of cfg_cmd is redundant as the value is never read > and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a > loop, hence it can be removed. >  > Cleans up

RE: Two rtlwifi drivers?

2017-10-16 Thread Pkshih
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Monday, October 16, 2017 9:23 PM > To: Pkshih > Cc: Larry Finger; Greg Kroah-Hartman; Dan Carpenter; 莊彥宣; Johannes Berg; > Souptick Joarder; > de...@driverdev.osuosl.org; linux-wir

RE: Two rtlwifi drivers?

2017-10-16 Thread Pkshih
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, October 16, 2017 3:50 PM > To: Pkshih > Cc: Larry Finger; Kalle Valo; Dan Carpenter; 莊彥宣; Johannes Berg; Souptick > Joarder; > de...@driverdev.osuosl.org; linux-wir

RE: Two rtlwifi drivers?

2017-10-15 Thread Pkshih
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Thursday, October 12, 2017 6:35 PM > To: Kalle Valo > Cc: Larry Finger; Dan Carpenter; Pkshih; 莊彥宣; Johannes Berg; Souptick Joarder; > de...@driverdev.osuosl.org; linux-wirel.