Re: [PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

On Sat, Apr 1, 2017 at 12:40 AM, Prasant Jalan <prasant.ja...@gmail.com> wrote: > checkpatch gives WARNING: Avoid line continuations in quoted strings. > > Trivial fix by removing line continuations and adding another quote at > the start of next line. > > Signed-off-by: P

[PATCH v2] staging: rtl8712: fixed multiple line derefence issue

Checkpatch emits WARNING: Avoid multiple line dereference. Checkpatch warning is fixed by: * Trivial indentation improvement and * Using += instead of + helps shortening the statement. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- v2: * Used += instead of + (point

Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

On Mon, Apr 3, 2017 at 10:27 AM, Joe Perches <j...@perches.com> wrote: > On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote: >> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.ja...@gmail.com> >> wrote: >> > Checkpatch emits WARNING: Avoid multiple

Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.ja...@gmail.com> wrote: > Checkpatch emits WARNING: Avoid multiple line dereference. > > Trivial indentation improvement helps fix the checkpatch warning. > > Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com&g

[PATCH 2/2] staging: sm750fb: removed line continuations in quoted strings

checkpatch gives WARNING: Avoid line continuations in quoted strings. Trivial fix by removing line continuations and adding another quote at the start of next line. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/sm750fb/sm750.c | 18 +- 1 file c

[PATCH 1/2] staging: sm750fb: fixing function return with lock held

lynxfb_suspend() & lynxfb_resume() return on errors while holding console_lock. Adding 'goto' such that proper cleanups can be done before returning from function and therefore console_lock can be released before returning. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --

[PATCH] staging: rtl8712: fixed multiple line derefence issue

Checkpatch emits WARNING: Avoid multiple line dereference. Trivial indentation improvement helps fix the checkpatch warning. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue

On Sat, Mar 25, 2017 at 6:28 PM, Prasant Jalan <prasant.ja...@gmail.com> wrote: > On Sat, Mar 25, 2017 at 6:01 PM, Arushi Singhal > <arushisinghal19971...@gmail.com> wrote: >> >> >> On Sat, Mar 25, 2017 at 5:40 PM, Prasant Jalan <prasant.ja...@gmail.com&

Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue

On Sat, Mar 25, 2017 at 6:01 PM, Arushi Singhal <arushisinghal19971...@gmail.com> wrote: > > > On Sat, Mar 25, 2017 at 5:40 PM, Prasant Jalan <prasant.ja...@gmail.com> > wrote: >> >> >> Replacing spaces with tabs for indetation to fix checkpatch.pl e

[PATCH v2] staging: vt6656: fixed an indentation coding style issue

Replacing spaces with tabs for indetation to fix checkpatch.pl error "code indent should use tabs where possible". Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- v2: - improved changelog comments - fixed only one issue drivers/staging/vt

Re: [PATCH] staging: vt6656: removed coding style errors

On Thu, Mar 23, 2017 at 1:02 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Wed, Mar 22, 2017 at 09:39:24PM +0530, Prasant Jalan wrote: > > The patch replaces spaces with tabs as required by kernel coding > > standards. > > > > Signed-off-by: Pr

[PATCH] staging: vt6656: removed coding style errors

The patch replaces spaces with tabs as required by kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rxtx.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/s

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/d

[PATCH v2] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/d

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/d

[PATCH] drivers: staging: vt6656: fxed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/s

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch fixes the following: - Replace spaces with tabs for indentation - adds spaces around symbol '-' - uses __func__ macro to print function name - truncated the line such that it is within 80 char limit as per kernel coding standards. Signed-off-by: Prasant Jalan <prasant.ja...@gmail.

[PATCH] drivers: staging: vt6656: fixed coding style errors

Fixed coding style errors. No errors with checkpatch.pl Signed-off-by: Prasant Jalan <prasant.ja...@gmail.com> --- drivers/staging/vt6656/rf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c