[PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic

2017-09-06 Thread Pushkar Jambhlekar
crc32_init is using unnecessary else condition. Cleaningup this function Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_security.c | 42 +-- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/s

[PATCH] drivers/staging/media: Prefer using __func__ instead

2017-06-29 Thread Pushkar Jambhlekar
Function name is hardcoded. replacing with __func__ Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/media/cxd2099/cxd2099.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging

[PATCH] drivers/staging/ccree: Replacing spaces by tab

2017-05-16 Thread Pushkar Jambhlekar
Fixing 'checkpatch.pl' ERROR: code indent should use tabs where possible Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/ccree/ssi_aead.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging

[PATCH] drivers/staging/ccree: Fixing coding guideline errors

2017-05-16 Thread Pushkar Jambhlekar
Fixing coding guideline errors reported by 'checkpatch.pl' Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/ccree/ssi_cipher.c | 158 +++-- 1 file changed, 80 insertions(+), 78 deletions(-) diff --git a/drivers/staging

[PATCH] drivers/staging/ccree: Removing trailing whitespaces

2017-05-14 Thread Pushkar Jambhlekar
Fixing 'checkpatch.pl' warnings: Trailing whitespaces Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/ccree/ssi_cipher.c | 110 ++--- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/staging/ccree/ssi_ci

[PATCH] drivers/staging/iio: braces {} are not necessary for single statement blocks

2017-04-09 Thread Pushkar Jambhlekar
Handling checkpatch.pl warning for if block. For single if statement block, braces are not neccessary. Making code consistent with linux kernel coding guidelines. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/iio/accel/adis16203.c | 4 ++-- 1 file chan

Re: [PATCH] drivers/staging/lustre: Coding-guideline: Missing a blank line after declarations

2017-04-04 Thread Pushkar Jambhlekar
((void)sizeof !!(exp)) => I believe it is for compiler to unflag "unused variable" warning. On Tue, Apr 4, 2017 at 3:08 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote: >> diff --git a/drivers/st

[PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int'

2017-04-04 Thread Pushkar Jambhlekar
Replacing 'unsigned' with 'unsigned int' Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/lustre/lustre/llite/namei.c | 2 +- drivers/staging/lustre/lustre/llite/rw26.c | 2 +- drivers/staging/lustre/lustre/llite/vvp_dev.c

[PATCH] drivers/staging: lustre: Avoiding multiple line dereference

2017-04-04 Thread Pushkar Jambhlekar
Making references in single line Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 3 +-- drivers/staging/lustre/lustre/llite/llite_lib.c | 6 ++ drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +-- drivers/s

[PATCH] drivers/staging/lustre: Coding-guideline: Missing a blank line after declarations

2017-04-04 Thread Pushkar Jambhlekar
Adding a blank line after declaration Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/lustre/lustre/llite/dcache.c | 1 + drivers/staging/lustre/lustre/llite/namei.c | 1 + drivers/staging/lustre/lustre/llite/symlink.c| 1 + drivers/staging/

[PATCH] drivers/staging/wilc1000: Removing explicit function tracing using dev_dbg/info

2017-03-24 Thread Pushkar Jambhlekar
ftrace can be used to trace functions. Removing function tracing using dev_dbg/info Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/wilc1000/wilc_sdio.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/s

[PATCH] drivers/staging/wilc1000: Using __func__ instead of hardcoded function name

2017-03-24 Thread Pushkar Jambhlekar
dev_err: replacing hardcoded function name with '%s' and __func__ Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/wilc1000/wilc_sdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/s

[PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err

2017-03-23 Thread Pushkar Jambhlekar
Removing hardcoded function name as code is already using __func__ Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/at

[PATCH] drivers/staging/wilc1000: Fixing dev_err and removing dev_dbg calls for tracing

2017-03-23 Thread Pushkar Jambhlekar
dev_err: replacing function name with '%s' and __func__ dev_dbg: Removing calls which are used for tracing a function. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/wilc1000/wilc_sdio.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

[PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg

2017-03-23 Thread Pushkar Jambhlekar
Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 4 1 file changed, 4 deletions(-) diff --git a/d

[PATCH] drivers/staging/dgnc: Updating dev_dbg function

2017-03-22 Thread Pushkar Jambhlekar
Making use of __func__ instead of using function name directly in dev_dbg. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/stagin

Re: [PATCH] vc04_services: Fixing coding guideline error

2017-03-15 Thread Pushkar Jambhlekar
Any comment? On Wed, Mar 15, 2017 at 12:01 PM, Pushkar Jambhlekar <pushkar@gmail.com> wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> > --- > drivers/staging/vc04_s

[PATCH] vc04_services: Fixing coding guideline error

2017-03-15 Thread Pushkar Jambhlekar
Fixing 'if' block coding style. '{' should follow 'if' for multiline block Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s

Re: [PATCH] vc04_services: Fixing coding and logical guidelines

2017-03-14 Thread Pushkar Jambhlekar
Thanks. I will rewrite patch according to the suggestions. On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote: >> Description: > > No need for that line. > >&

[PATCH] vc04_services: Fixing coding and logical guidelines

2017-03-14 Thread Pushkar Jambhlekar
Description: in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'. Also, fixing logical issue, i.e. removing break after goto statement. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- .../vc04_services/int

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
Your concerns were valid. Since 'do' is defined on the new-line, git did not include it in diff. On Tue, Mar 14, 2017 at 5:22 PM, Alexander Kapshuk <alexander.kaps...@gmail.com> wrote: > On Tue, Mar 14, 2017 at 1:44 PM, Pushkar Jambhlekar > <pushkar@gmail.com> wrot

Re: [PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^ rk[4 * i + 3]; \ } while (0) On Tue, Mar 14, 2017 at 5:02 PM, Alexander Kapshuk <alexander.kaps...@gmail.com> wrote: > On Tue, Mar 14, 2017 at 1:26 PM, Pushkar Jambhlekar > <pushkar@gmail.com> wrote: >> Description: >> Th

[PATCH] rtl8188eu: Correcting macro ROUND macro defination

2017-03-14 Thread Pushkar Jambhlekar
Description: There should not be ';' after do ... while(0) in macro defination Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188e

Re: [PATCH] ks7010: adding parenthesis to macro argument

2017-03-14 Thread Pushkar Jambhlekar
Hi Dan, I am trying to fix warnings by "checkpatch.pl". Even though it is not super exciting, no harm to follow correct way. On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wr

[PATCH] ks7010: adding parenthesis to macro argument

2017-03-13 Thread Pushkar Jambhlekar
Description: In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis around macro params. Also, removing extra line. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/ks7010/ks7010_sdio.c | 13 ++--- 1 file changed, 6

[PATCH] Minor coding guideline Fix in lusture module

2017-03-09 Thread Pushkar Jambhlekar
Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id. Checkpath.pl passed. Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/

[PATCH] Minor Fix to please checkpatch Declaring 'unsigned int' instead of 'unsigned'

2017-03-09 Thread Pushkar Jambhlekar
Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c index 12c