On 05/26, Jonathan Cameron wrote:
On Fri, 24 May 2019 22:26:30 -0300
Renato Lui Geh wrote:
This patch adds a YAML binding for the Analog Devices AD7780/1 and
AD7170/1 analog-to-digital converters.
Signed-off-by: Renato Lui Geh
Looks good to me, but I'm still finding my feet with these so
This patch adds a MAINTAINERS entry for the AD7780 ADC driver.
Signed-off-by: Renato Lui Geh
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 54c8e14fae98..d12685c5b09a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -880,6 +880,15 @@ S
This patch adds a YAML binding for the Analog Devices AD7780/1 and
AD7170/1 analog-to-digital converters.
Signed-off-by: Renato Lui Geh
---
Changes in v2:
- vref-supply to avdd-supply
- remove avdd-supply from required list
- include adc block in an spi block
.../bindings/iio/adc/adi,ad7780
This patchset converts the old ad7780 device-tree binding to
the new YAML format, and adds an entry to MAINTAINERS.
Renato Lui Geh (2):
dt-bindings: iio: adc: add adi,ad7780.yaml binding
MAINTAINERS: add entry for ad7780 adc driver
.../bindings/iio/adc/adi,ad7780.txt | 48
Hi Jonathan, Alex,
Thanks for the review. Some comments inline.
Thanks,
Renato
On 05/20, Ardelean, Alexandru wrote:
On Sun, 2019-05-19 at 12:32 +0100, Jonathan Cameron wrote:
[External]
On Sat, 18 May 2019 19:41:12 -0300
Renato Lui Geh wrote:
> This patch adds a YAML bind
This patch adds a YAML binding for the Analog Devices AD7780/1 and
AD7170/1 analog-to-digital converters.
Signed-off-by: Renato Lui Geh
---
.../bindings/iio/adc/adi,ad7780.txt | 48 ---
.../bindings/iio/adc/adi,ad7780.yaml | 85 +++
2 files changed, 85
On 03/16, Jonathan Cameron wrote:
On Fri, 15 Mar 2019 23:15:55 -0300
Renato Lui Geh wrote:
Move ad7780 ADC driver out of staging and into the mainline.
The ad7780 is a sigma-delta analog to digital converter. This driver provides
reading voltage values and status bits from both the ad778x
Adds a device tree binding for the ad7780 driver.
Signed-off-by: Renato Lui Geh
---
.../bindings/iio/adc/adi,ad7780.txt | 48 +++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
diff --git a/Documentation
on the
ad778x.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Changes unrelated to moving the driver to main tree were resent as
individual patches
Changes in v4:
- Removed line warning it was safe to build the ad7780 driver
This patch adds a new copyright holder to the ad7780 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index ff61ffa0da9f..23b731a92e32 100644
To maintain consistency between ad7780_probe and ad7780_remove orders,
regulator initialization has been moved to after GPIO initializations.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff
Add SPDX identifier (GPL-2.0) to the AD7780 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 568c5b4472ff..ff61ffa0da9f 100644
The AD7780 driver contains status pattern bits designed for checking
whether serial transfers have been correctly performed. Pattern macros
were previously generated through bit fields. This patch sets good
pattern values directly and masks through GENMASK.
Signed-off-by: Renato Lui Geh
The ad7780 supports both the ad778x and ad717x families. Each chip has
a corresponding ID. This patch provides a mask for extracting ID values
from the status bits and also macros for the correct values for the
ad7170, ad7171, ad7780 and ad7781.
Signed-off-by: Renato Lui Geh
---
Changes in v5
only shares the relevant info mask for the
ad778x family.
Signed-off-by: Renato Lui Geh
---
Changes in v4:
- As mentioned in the previous patch, this was originally as part of
the 'add gain & filter gpio support' patch
Changes in v5:
- Moved ad778x_odr_avail declaration from GPIO p
This patch adds a new functionality of reading gain values from the
ad778x chips. This value is stored in the chip's state struct and is
updated whenever a read or write call is performed on the driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 5 +
1 file changed
This patch simply adds a missing switch default case in read_raw.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 07e5e35c92a3..f4cd7bc3e02f 100644
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Renamed ad7780_chip_info's filter
of staging to the mainline;
- Adds device tree binding for the ad7780 driver.
Renato Lui Geh (11):
staging: iio: ad7780: add gain & filter gpio support
staging: iio: ad7780: add missing switch default case
staging: iio: ad7780: add gain reading to ad778x
staging: iio: ad7780: add filter rea
On 03/04, Ardelean, Alexandru wrote:
On Sun, 2019-03-03 at 14:53 +, Jonathan Cameron wrote:
[External]
On Sun, 3 Mar 2019 11:01:09 -0300
Renato Lui Geh wrote:
> On 03/01, Ardelean, Alexandru wrote:
> > On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
> > >
>
On 03/01, Ardelean, Alexandru wrote:
On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
The ad7780 supports both the ad778x and ad717x families. Each chip has
a corresponding ID. This patch provides a mask for extracting ID values
from the status bits and also macros for the correct
Hi Alexandru,
Thanks for the review. Some questions inline.
Thanks,
Renato
On 03/01, Ardelean, Alexandru wrote:
On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote:
The patch-series is a bit big.
I guess that the intent is to move this out-of-staging, but various patches
are holding
Adds a device tree binding for the ad7780 driver.
Signed-off-by: Renato Lui Geh
---
.../bindings/iio/adc/adi,ad7780.txt | 48 +++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
diff --git a/Documentation
on the
ad778x.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Changes unrelated to moving the driver to main tree were resent as
individual patches
Changes in v4:
- Removed line warning it was safe to build the ad7780 driver
This patch adds a new copyright holder to the ad7780 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index b1d4909ba025..aa1ddd0c45ee 100644
Add SPDX identifier (GPL-2.0) to the AD7780 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 12aef0f101bc..b1d4909ba025 100644
To maintain consistency between ad7780_probe and ad7780_remove orders,
regulator initialization has been moved to after GPIO initializations.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions
The ad7780 supports both the ad778x and ad717x families. Each chip has
a corresponding ID. This patch provides a mask for extracting ID values
from the status bits and also macros for the correct values for the
ad7170, ad7171, ad7780 and ad7781.
Signed-off-by: Renato Lui Geh
---
drivers/staging
The AD7780 driver contains status pattern bits designed for checking
whether serial transfers have been correctly performed. Pattern macros
were previously generated through bit fields. This patch sets good
pattern values directly and masks through GENMASK.
Signed-off-by: Renato Lui Geh
only shares the relevant info mask for the
ad778x family.
Signed-off-by: Renato Lui Geh
---
Changes in v4:
- As mentioned in the previous patch, this was originally as part of
the 'add gain & filter gpio support' patch
drivers/staging/iio/adc/ad7780.c | 12 ++--
1 file changed
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Renamed ad7780_chip_info's filter
.
Renato Lui Geh (9):
staging: iio: ad7780: add gain & filter gpio support
staging: iio: ad7780: add filter reading to ad778x
staging: iio: ad7780: set pattern values and masks directly
staging:iio:ad7780: add chip ID values and mask
staging: iio: ad7780: move regulator to after GPIO
On 02/09, Jonathan Cameron wrote:
On Tue, 5 Feb 2019 15:14:03 -0200
Renato Lui Geh wrote:
Move ad7780 ADC driver out of staging and into the mainline.
The ad7780 is a sigma-delta analog to digital converter. This driver provides
reading voltage values and status bits from both the ad778x
Hi Jonathan,
Thanks for the review. Comments inline.
Renato
On 02/09, Jonathan Cameron wrote:
On Tue, 5 Feb 2019 15:13:00 -0200
Renato Lui Geh wrote:
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin
on the
ad778x.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Changes unrelated to moving the driver to main tree were resent as
individual patches
drivers/iio/adc/Kconfig | 13 ++
drivers/iio/adc/Makefile
Add SPDX identifier (GPL-2.0) to the AD7780 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index 7804cd2b273e..163e3c983598 100644
To maintain consistency between ad7780_probe and ad7780_remove orders,
regulator initialization has been moved to after GPIO initializations.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v3:
- Renamed ad7780_chip_info's
This series of patches adds user input to ad7780 'gain' & 'filter' gpio
pins, moves regulator initialization to after gpio initialization to
maintain consistency between probe and remove, adds SPDX to the driver's
license, and moves the ad7780 to the mainline.
Renato Lui Geh (4):
staging:
On 02/01, Popa, Stefan Serban wrote:
Adding support for gpios, normally doesn't have anything to do with
the information stored in the iio_chan_spec struct.
Also, we need to try to work with the already defined attributes. In your
case, setting the gain GPIO is equivalent to modifying the
On 01/30, Popa, Stefan Serban wrote:
On Du, 2019-01-27 at 18:30 -0200, Renato Lui Geh wrote:
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
On 01/28, Dan Carpenter wrote:
On Sun, Jan 27, 2019 at 06:33:52PM -0200, Renato Lui Geh wrote:
+ st->reg = devm_regulator_get(>dev, "avdd");
+ if (IS_ERR(st->reg))
+ return PTR_ERR(st->reg);
+
+ ret = regulator_enable(st-
on the
ad778x.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v2:
- Added information on the ad7780 driver in commit message
- SPDX GPLv2 license
- GPIO inits now come before regulator in probe
drivers/iio/adc
This series of patches add user input to ad7780 'gain' & 'filter' gpio
pins. It also includes a patch to move ad7780 out of staging and to the
main tree.
Renato Lui Geh (2):
staging: iio: ad7780: add gain & filter gpio support
staging: iio: ad7780: moving ad7780 out of staging
drivers
Previously, the AD7780 driver only supported gpio for the 'powerdown'
pin. This commit adds suppport for the 'gain' and 'filter' pin.
Signed-off-by: Renato Lui Geh
Signed-off-by: Giuliano Belinassi
Co-developed-by: Giuliano Belinassi
---
Changes in v2:
- Filter reading changed to mHz
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi,
Sorry for the (extremely) late reply.
Comments inline.
Renato
On 12/01, Jonathan Cameron wrote:
On Thu, 29 Nov 2018 11:02:46 -0200
Giuliano Augusto Faulin Belinassi wrote:
Hi
A few follow ups from me having read the result in patch 2.
Jonathan
On Thu, Nov 29, 2018 at 9:18 AM
This patch removes the unnecessary field int_vref_mv in ad7780_state
referring to the device's voltage.
Signed-off-by: Renato Lui Geh
---
Changes in v3:
- removed unnecessary int_vref_mv from ad7780_state
Changes in v4:
- removed voltage reading on probe
drivers/staging/iio/adc
The ad7780 driver previously did not read the correct device output, as
it read an outdated value set at initialization. It now updates its
voltage on read.
Signed-off-by: Renato Lui Geh
---
Changes in v3:
- removed initialization (int voltage_uv = 0)
- returns error when
go first
- removed unnecessary initialization
- removed unnecessary voltage field variable
- dropped reading voltage on probe
- returns -EINVAL error on null voltage
*v4
- removed voltage reading from probe
- fixed voltage error handling
Renato Lui
On Thu, 1 Nov 2018 15:20:55 +
"Ardelean, Alexandru" wrote:
This looks wrong.
I admit this was done in the same way in the probe function, but that looks
a bit wrong as well.
Typically, the return value of `regulator_get_voltage()` would get checked
with:
ret =
Hi,
On Thu, 1 Nov 2018 15:02:32 +
"Ardelean, Alexandru" wrote:
Good catch.
That was actually Jonathan's catch. :)
Acked-by: Alexandru Ardelean
I read up on Acked-by on the kernel docs, as I didn't know exactly what
it meant, but I'm not so sure on how to proceed once the patch has
This patch removes the unnecessary field int_vref_mv in ad7780_state
referring to the device's voltage.
Signed-off-by: Renato Lui Geh
---
Changes in v3:
- removed unnecessary int_vref_mv from ad7780_state
drivers/staging/iio/adc/ad7780.c | 5 +
1 file changed, 1 insertion(+), 4
The ad7780 driver previously did not read the correct device output, as
it read an outdated value set at initialization. It now updates its
voltage on read.
Signed-off-by: Renato Lui Geh
---
Changes in v3:
- removed initialization (int voltage_uv = 0)
- returns error when
Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET.
This was fixed by assigning the correct value instead.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b
go first
- removed unnecessary initialization
- removed unnecessary voltage field variable
- dropped reading voltage on probe
- returns -EINVAL error on null voltage
Renato Lui Geh (3):
staging: iio: ad7780: fix offset read value
staging: iio: ad7780: update
Hi Jonathan,
Thank you for the review.
+ voltage_uv = regulator_get_voltage(st->reg);
+ if (voltage_uv)
+ st->int_vref_mv = voltage_uv/1000;
*val = st->int_vref_mv * st->gain;
Is there actually a reason (now) to have the
The ad7780 driver previously did not read the correct device output, as
it read an outdated value set at initialization. It now updates its
voltage on read.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging
Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET.
This was fixed by assigning the correct value instead.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b
The purpose of this series is to correct two issues in the driver's raw
read function.
Changelog:
* v2
- separated original patch into two patches
(https://marc.info/?l=linux-iio=154047435605492)
Renato Lui Geh (2):
staging: iio: ad7780: update voltage on read
staging: iio
Hi,
Thanks for the quick review. :)
But please create one patch per issue and do not put unrelated changes into
the same patch.
Should I resend this patch as a patchset containing the two changes?
Also your mail client seems to have replaced tabs in the patch with spaces,
this means the
the correct value
instead.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/adc/ad7780.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index b67412db0318..06700fe554a2 100644
--- a/drivers/staging/iio
This patch fixes most "Alignment should match open parenthesis" check
warnings found by checkpatch.pl in the addac/adt7316 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/addac/adt7316.c | 462 ++--
drivers/staging/iio/addac/adt7316.h | 2
This patch fixes most "Alignment should match open parenthesis" check
warnings found by checkpatch.pl in the addac/adt7316 driver.
---
drivers/staging/iio/addac/adt7316.c | 462 ++--
drivers/staging/iio/addac/adt7316.h | 2 +-
2 files changed, 233 insertions(+), 231
This patch fixes all "Alignment should match open parenthesis" check
warnings found by checkpatch.pl in the addac/adt7316 driver.
Signed-off-by: Renato Lui Geh
---
drivers/staging/iio/addac/adt7316.c | 462 ++--
drivers/staging/iio/addac/adt7316.h | 2 +-
2 fil
65 matches
Mail list logo
