Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-23 Thread Robert Perry Hooker
ert Perry Hooker wrote: > > I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer > > allocated at wilc_wlan.c:1417. > > > > The rx_buffer is going to end up filled with endian data, right? > > regards, > dan carpenter > __

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-22 Thread Robert Perry Hooker
I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer allocated at wilc_wlan.c:1417. Regards, Perry On Wed, 2017-03-22 at 12:24 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote: > > Thanks for taking a look, Dan. S

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-21 Thread Robert Perry Hooker
Thanks for taking a look, Dan. Sorry if I missed the mark here. Can you tell me a bit more about the bug this would introduce? I see that ieee80211_is_action is defined like this: static inline bool ieee80211_is_action(__le16 fc) ...and that buff[FRAME_TYPE_ID]is a u8 (since FRAME_TYPE_ID =