Remove many macros from wifi.h and ieee80211.h because they are unused.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/ieee80211.h | 5 -
drivers/staging/rtl8723bs/include/wifi.h | 15 ---
2 files changed, 20 deletions(-)
diff --git a/drivers/staging
Replace unique _EXT_SUPPORTEDRATES_IE_ macro with kernel provided
WLAN_EID_EXT_SUPP_RATES from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +-
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
drivers/staging/rtl8723bs/core
Replace unique EID_EXTCapability constant with kernel provided
WLAN_EID_EXT_CAPABILITY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
2 files changed, 3 insertions(+), 3
Replace unique _CHLGETXT_IE_ macro with kernel provided WLAN_EID_CHALLENGE
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8
drivers/staging/rtl8723bs/include/wifi.h | 1 -
2 files changed, 4 insertions(+), 5 deletions
Replace unique EID_BSSIntolerantChlReport constant with kernel provided
WLAN_EID_BSS_INTOLERANT_CHL_REPORT from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
The ELEMENT_ID enum is no longer used, remove it.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/wifi.h | 76
1 file changed, 76 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h
b/drivers/staging/rtl8723bs/include/wifi.h
index
Replace unique _SUPPORTEDRATES_IE_ macro with kernel provided
WLAN_EID_SUPP_RATES from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
.../staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++--
drivers/staging/rtl8723bs/core
Replace unique _WAPI_IE_ macro with kernel provided
WLAN_EID_BSS_AC_ACCESS_DELAY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
drivers/staging/rtl8723bs/include/wifi.h | 1 -
2 files changed, 2 insertions(+), 3 deletions
Replace unique _IBSS_PARA_IE_ macro with kernel provided
WLAN_EID_IBSS_PARAMS from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
Replace unique EID_BSSCoexistence constant with kernel provided
WLAN_EID_BSS_COEX_2040 from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core
Replace unique _DSSET_IE_ macro with kernel provdied WLAN_EID_DS_PARAMS
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +-
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10
Replace unique _MME_IE_ macro with kernel provided WLAN_EID_MMIE from
linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
drivers/staging/rtl8723bs/include/wifi.h | 1 -
3 files
Replace unique _ERPINFO_IE_ macro with kernel provided WLAN_EID_ERP_INFO
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 12 ++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++---
drivers/staging/rtl8723bs/core
Replace unique _COUNTRY_IE_ macro with kernel provided WLAN_EID_COUNTRY
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8723bs/include/wifi.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
Replace unique _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ macros with kernel
provided WLAN_EID_HT_OPERATION from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 10 +-
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
drivers
Replace unique _SSID_IE_ macro with kernel provided WLAN_EID_SSID from
linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
.../staging/rtl8723bs/core/rtw_ieee80211.c| 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20
Replace unique _TIM_IE_ macro with kernel provided WLAN_EID_DS_PARAMS
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 10 +-
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_recv.c | 4
Replace unique WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and
_VENDOR_SPECIFIC_IE_ macros with kernel provided WLAN_EID_VENDOR_SPECIFIC
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
.../staging/rtl8723bs/core/rtw_ieee80211.c
Replace unique WLAN_EID_VHT_OP_MODE_NOFITY macro with kernel provided
WLAN_EID_OPMODE_NOTIF from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
drivers/staging/rtl8723bs/include/ieee80211.h | 1 -
2 files changed, 1 insertion(+), 2
Replace unique _WPA2_IE_ID_, EID_WPA2, and _RSN_IE_2_ with kernel provided
WLAN_EID_RSN from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++--
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++---
drivers/staging/rtl8723bs/core
Replace unique WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability
with kernel provided WLAN_EID_HT_CAPABILITY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 8
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2
divided into per-constant replacement patches
v1 can be found here:
https://lore.kernel.org/driverdev-devel/20201206034517.4276-10-ross.schm@gmail.com/
Ross Schmidt (21):
staging: rtl8723bs: use WLAN_EID_HT_CAPABILITY
staging: rtl8723bs: use WLAN_EID_VENDOR_SPECIFIC
staging: rtl8723bs
are replaced by WLAN_EID_RSN.
_HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ are replaced by
WLAN_EID_HT_OPERATION.
WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and _VENDOR_SPECIFIC_IE_ are
replaced by WLAN_EID_VENDOR_SPECIFIC.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c
Remove many macros from wifi.h because they are unused.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/wifi.h | 33
1 file changed, 33 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h
b/drivers/staging/rtl8723bs/include/wifi.h
The WLAN_HT_CAP_SM_PS_* macro family is already defined in
linux/ieee80211.h, remove them.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/wifi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wifi.h
b/drivers/staging/rtl8723bs
Replace unique cap_* macros with kernel provided WLAN_CAPABILITY_*
macros.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c| 2 +-
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 +++---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
drivers
Remove unnecessary macro for container_of and call it directly.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 16 +++---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme.c | 18 +++
drivers
Replace unique OP_MODE_* and HT_INFO_OPERATION_MODE_* macro families
with kernel provided IEEE80211_HT_OP_MODE_* macros.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 30
drivers/staging/rtl8723bs/include/wifi.h | 13 --
2 files
Replace unique macro RTW_IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK with kernel
provided IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK. The other
IEEE80211_ADDBA_* and IEEE_DELBA_* macros are duplicates already defined
in linux/ieee80211.h, remove them.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs
Replace unique HT_CAP_AMPDU_FACTOR enum with kernel provided
ieee80211_max_ampdu_length_exp enum.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 ++--
drivers/staging/rtl8723bs/hal
Replace unique macros and WIFI_REASON_CODE enum with the kernel provided
ieee80211_reasoncode.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 +--
drivers/staging/rtl8723bs/include/wifi.h | 36 ---
2 files changed, 2 insertions(+), 38
Replace many unique macros and WIFI_STATUS_CODE enum with kernel
provided ieee80211_statuscode. A duplicate
WLAN_STATUS_ASSOC_DENIED_NOSHORT macro is also removed.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 54 +--
drivers/staging/rtl8723bs
Move operators to fix coding style issues and clear checkpatch checks.
CHECK: Logical continuations should be on the previous line
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 41 +++
drivers/staging/rtl8723bs/core/rtw_recv.c | 27
Move cases to align with switch indentation to fix coding style issues
and clear checkpatch errors.
ERROR: switch and case should be at the same indent
Signed-off-by: Ross Schmidt
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 219 +-
drivers/staging/rtl8723bs/os_dep
Move trailing statements to the next line to fix coding style issues and
clear checkpatch errors.
ERROR: trailing statements should be on next line
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 ++-
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c| 9
Move pointer locations to fix coding style issues and clear checkpatch
errors.
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/rtw_io.h| 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme.h | 14 +++
Remove spaces before tabs to fix coding style issues and clear
checkpatch warnings.
WARNING: please, no space before tabs
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 16 +++
drivers/staging/rtl8723bs/core/rtw_recv.c | 42 +-
drivers
Move braces to fix coding style issues and clear checkpatch errors.
Some braces are removed for single statements.
ERROR: open brace '{' following function definitions go on the next line
ERROR: that open brace { should be on the previous line
Signed-off-by: Ross Schmidt
---
.../staging
Convert spaces to tabs to fix coding style issues and clear checkpatch
warnings.
WARNING: please, no spaces at the start of a line
Signed-off-by: Ross Schmidt
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 80 +--
.../staging/rtl8723bs/os_dep/osdep_service.c | 2 +-
2
Move declarations to fix coding style issues and clear checkpatch
checks.
CHECK: Lines should not end with a '('
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_efuse.c| 44 +--
.../staging/rtl8723bs/core/rtw_ieee80211.c| 13 +-
.../staging/rtl8723bs/core
on all arms of this statement
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_security.c | 42 ++-
drivers/staging/rtl8723bs/core
Add or remove lines to fix coding style issues and clear checkpatch.
WARNING: Missing a blank line after declarations
CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Please don't use multiple blank lines
Signed-off-by: Ross Schmidt
---
drivers/staging
Replace the unique rtw_ieee80211_mgmt_actioncode enum with the provided
standard ieee80211_spectrum_mgmt_actioncode.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +-
drivers/staging/rtl8723bs/include/ieee80211.h | 10 --
2 files changed, 5
Replace the unique rtw_ieee80211_ht_actioncode enum with the provided
standard ieee80211_ht_actioncode.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8723bs/include/ieee80211.h | 12
2 files changed, 1 insertion(+), 13
Replace the unique rtw_ieee80211_ht_cap struct with the provided standard
ieee80211_ht_cap.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
.../staging/rtl8723bs/core/rtw_ioctl_set.c| 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme.c | 20
Remove unnecessary macro for %s and call it directly.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c| 4 ++--
drivers/staging/rtl8723bs/core/rtw_security.c| 4 ++--
drivers/staging
Replace the unique rtw_ieee80211_back_actioncode with the standard
provided ieee80211_back_actioncode.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16
drivers/staging/rtl8723bs/include/ieee80211.h | 7 ---
2 files changed, 8 insertions
Remove unnecessary macro for %pI4 and call it directly.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 4 ++--
drivers/staging/rtl8723bs/include/ieee80211.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
Remove unnecessary macro for %s and call it directly.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/include/osdep_service_linux.h | 1 -
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging
Remove unnecessary macro for %pM and call it directly.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 39 +--
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
.../staging/rtl8723bs/core/rtw_ieee80211.c| 2 +-
.../staging/rtl8723bs/core
Use %pM format instead of custom printing code.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal
Replace _cancel_timer with API function del_timer_sync.
One instance of del_timer_sync is moved and an unnecessary pair of spin
locks are removed.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 +--
drivers/staging/rtl8723bs/core/rtw_mlme.c| 16
Replace RTW_GET_BE16 macro with get_unlaligned_be16.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++--
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
drivers/staging/rtl8723bs/os_dep
Remove several macros in osdep_service.h because they are not used.
Signed-off-by: Ross Schmidt
---
.../staging/rtl8723bs/include/osdep_service.h | 57 ---
1 file changed, 57 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h
b/drivers/staging
Replace RTW_GET_BE24 macro with get_unaligned_be24.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 3 ++-
drivers/staging/rtl8723bs/include/osdep_service.h | 3 ---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core
Replace RTW_GET_LE16 macro with get_unaligned_le16.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 5 +++--
drivers/staging/rtl8723bs/core/rtw_ieee80211.c| 4 ++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 ---
drivers/staging/rtl8723bs
Use round_up instead of inline _RND4.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 +-
drivers/staging/rtl8723bs/include/osdep_service.h | 11 ---
3 files changed, 2 insertions(+), 13
Use round_up instead of define RND4.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/core/rtw_security.c | 6 +++---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++--
drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 +++---
drivers/staging/rtl8723bs/include
Use round_up instead of inline _RND8.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c| 2 +-
drivers/staging/rtl8723bs/include/osdep_service.h | 11 ---
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
Fixed a coding style issue by removing unnecessary braces in
sdio_ops_linux.c to fix checkpatch warnings.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
Fixed a coding style issue by adding spaces around operators in
sdio_ops_linux.c to fix checkpatch checks.
Signed-off-by: Ross Schmidt
---
.../staging/rtl8723bs/os_dep/sdio_ops_linux.c| 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging
Fixed a coding style issue by moving trailing statements to new lines in
sdio_ops_linux.c to fix checkpatch errors.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
Fixed a coding style issue by merging split quoted strings in qlge_main.c
to fix checkpatch warnings.
Signed-off-by: Ross Schmidt
---
drivers/staging/qlge/qlge_main.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers
Fixed a coding style issue by adding a blank line after declarations in
sdio_intf.c to fix a checkpatch warning.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b
Fixed some coding style issues.
Signed-off-by: Ross Schmidt
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index f1e2829a19a7..2b2f4505b98b 100644
65 matches
Mail list logo