Re: [PATCH] staging: clocking-wizard: Fix incorrect type of speed grade

2016-10-18 Thread Sören Brinkmann
> Signed-off-by: Xavier Roumegue <xroume...@gmail.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: clocking-wizard: add blank line after struct declaration.

2015-12-01 Thread Sören Brinkmann
On Tue, 2015-12-01 at 01:56PM +0100, Christian Colic wrote: > Add blank line after struct declaration to fix checkpatch check. > > Signed-off-by: Christian Colic <colic.christ...@gmail.com> Reviewed-by: Sören Brinkmann <soren.brinkm...@xilinx.com>

[PATCH 1/2] staging: lustre: libcfs/nidstrings: Declare internal symbols static

2014-12-25 Thread Sören Brinkmann
declarations are removed and the implementations are declared static and moved into a location that doesn't require forward declarations. Signed-off-by: Sören Brinkmann soeren.brinkm...@gmail.com --- drivers/staging/lustre/lustre/libcfs/nidstrings.c | 146 ++ 1 file changed, 66

[PATCH 2/2] staging: lustre: libcfs/nidstrings: Avoid forward declarations

2014-12-25 Thread Sören Brinkmann
Avoid forward declaratoins by moving functions to a location before they are referenced. Signed-off-by: Sören Brinkmann soeren.brinkm...@gmail.com --- drivers/staging/lustre/lustre/libcfs/nidstrings.c | 77 +++ 1 file changed, 37 insertions(+), 40 deletions(-) diff --git

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Sören Brinkmann
Hi Mohammad, On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote: Fix the coding style issue by adding blank line after declaration Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com --- .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + 1 file changed, 1

Re: [PATCH] Clocking-wizard: Fixed missing blank line warning

2014-12-08 Thread Sören Brinkmann
On Sun, 2014-12-07 at 02:35PM +0530, Athira Lekshmi wrote: Added a new line after declaration to remove the warning 'Missing a blank line after declarations' Signed-off-by: Athira Lekshmi andnlnb...@gmail.com Acked-by: Soren Brinkmann soren.brinkm...@xilinx.com Soren

[PATCH] staging: vt6655: Declare vnt_init() static

2014-12-04 Thread Sören Brinkmann
Fix sparse warning: drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? Signed-off-by: Sören Brinkmann soeren.brinkm...@gmail.com --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard provides an AXI interface to dynamically reconfigure the clocking resources of Xilinx

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Wed, 2014-10-01 at 10:57AM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 01, 2014 at 10:46:16AM -0700, Sören Brinkmann wrote: On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: Add a driver for the Xilinx

Re: [PATCH v2] staging: Add Xilinx Clocking Wizard driver

2014-10-01 Thread Sören Brinkmann
On Thu, 2014-10-02 at 02:19AM +0300, Laurent Pinchart wrote: Hi Sören, Thank you for the patch. On Wednesday 01 October 2014 14:02:32 Soren Brinkmann wrote: Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard provides an AXI interface to dynamically reconfigure the

[PATCH] staging: ad7606_core: Fix checkpatch warning

2014-08-31 Thread Sören Brinkmann
Fix the checkpatch complaint regarding unnecessary line continuation. WARNING: Avoid unnecessary line continuations #143: FILE: ad7606_core.c:143: Signed-off-by: Sören Brinkmann soeren.brinkm...@gmail.com --- drivers/staging/iio/adc/ad7606_core.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] checkpatch: Remove unnecessary + after {8,8}

2014-08-31 Thread Sören Brinkmann
Hi Joe, On Fri, 2014-07-11 at 07:09PM -0700, Joe Perches wrote: There's a useless + use that needs to be removed as perl 5.20 emits a Useless use of greediness modifier '+' message each time it's hit. I saw this Perl warning today as well and wondered whether this patch is coming or not.