feedback

Hi Greg, I sent you, on May 4, a patchset entitled '[PATCH V6 0/9] staging: rtl8192u: Checking return value/propagating errors', and I don't get any feedbacks. Should I resend you the patchset ? best regards, salah triki ___ devel mailing list de

[PATCH V6 9/9] staging: rtl8192u: propagate errors in write_nic_dword

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 10 +++--- 2 files chan

[PATCH V6 7/9] staging: rtl8192u: propagate errors in write_nic_byte_E

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH V6 2/9] staging: rtl8192u: propagate errors in eprom_read

Propagate error from eprom_r and change the return type of eprom_read from u32 to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 9 +++-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-)

[PATCH V6 3/9] staging: rtl8192u: check return value eprom_read

The call of eprom_read may fail, therefore its return value must be checked Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 112 ++--- 1 file changed, 76 insertions(+), 36 deletions(-) diff --git a/drivers/s

[PATCH V6 8/9] staging: rtl8192u: propagate errors in write_nic_word

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 10 +++--- 2 files chan

[PATCH V6 4/9] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-)

[PATCH V6 1/9] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

[PATCH V6 0/9] staging: rtl8192u: Checking return value/propagating errors

These patchs check the return value/propagate error of the functions read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_* Salah Triki (9): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: propagate errors in eprom_read staging: rtl8192u

[PATCH V5 7/9] staging: rtl8192u: propagate errors in write_nic_byte_E

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH V5 9/9] staging: rtl8192u: propagate errors in write_nic_dword

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH V5 6/9] staging: rtl8192u: propagate errors in write_nic_byte

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 10 ++ 2 files chan

[PATCH V5 5/9] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH V5 4/9] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-)

[PATCH V5 8/9] staging: rtl8192u: propagate errors in write_nic_word

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 inse

[PATCH V5 2/9] staging: rtl8192u: propagate errors in eprom_read

Propagate error from eprom_r and change the return type of eprom_read from u32 to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 9 +++-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-)

[PATCH V5 0/9] staging: rtl8192u: Checking return value/propagating errors

These patchs check the return value/propagate error of the functions read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_* Salah Triki (9): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: propagate errors in eprom_read staging: rtl8192u

[PATCH V5 1/9] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

[PATCH V5 3/9] staging: rtl8192u: check return value eprom_read

The call of eprom_read may fail, therefore its return value must be checked Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 145 +++-- 1 file changed, 103 insertions(+), 42 deletions(-) diff --git a/drivers/s

[PATCH 4/8] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 8/8] staging: rtl8192u: propagate errors in write_nic_dword

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH 5/8] staging: rtl8192u: propagate errors in write_nic_byte

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 12 +++- 2 files chan

[PATCH 6/8] staging: rtl8192u: propagate errors in write_nic_byte_E

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH 2/8] staging: rtl8192u: check return value eprom_read

The call of eprom_read may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 147 +++-- 1 file changed, 104 insertions(+), 43 deletions(-) diff --git a/drivers/s

[PATCH 7/8] staging: rtl8192u: propagate errors in write_nic_word

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 inse

[PATCH 3/8] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-)

[PATCH 1/8] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 -- drivers/staging/rtl8192u/r8180_93cx6.h | 2

[PATCH V3 0/8] staging: rtl8192u: Checking return value/propagating errors

These patchs check the return value/propagate error of the functions read_nic_word_E, eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_*. Salah Triki (8): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: check return value eprom_read staging: rtl8192u

[PATCH V2 4/9] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-)

[PATCH V2 9/9] staging: rtl8192u: propagate errors in write_nic_dword

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH V2 8/9] staging: rtl8192u: propagate errors in write_nic_word

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 inse

[PATCH V2 5/9] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH V2 7/9] staging: rtl8192u: propagate errors in write_nic_byte_E

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH V2 6/9] staging: rtl8192u: propagate errors in write_nic_byte

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 12 +++- 2 files chan

[PATCH V2 0/9] staging: rtl8192u: Checking return value/propagating errors

These patchs check the return value/propagate error of the functions read_nic_word_E,eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_*. Salah Triki (9): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: eprom_read: check return value of eprom_r staging

[PATCH V2 2/9] staging: rtl8192u: eprom_read: check return value of eprom_r

Check the return value from eprom_r and propagate it in the case of error. The error code is a negative value, therefore change the return type of eprom_read from u32 to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 9 +++-- d

[PATCH V2 1/9] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-)

[PATCH V2 3/9] staging: rtl8192u: check return value eprom_read

The call of eprom_read may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 147 +++-- 1 file changed, 104 insertions(+), 43 deletions(-) diff --git a/drivers/s

[PATCH 8/9] staging: rtl8192u: propagate errors in write_nic_word

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_word from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files changed, 7 inse

[PATCH 9/9] staging: rtl8192u: propagate errors in write_nic_dword

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_dword from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH 6/9] staging: rtl8192u: propagate errors in write_nic_byte

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 12 +++- 2 files chan

[PATCH 7/9] staging: rtl8192u: propagate errors in write_nic_byte_E

Propagate errors from kzalloc and usb_control_msg and change the return type of write_nic_byte_E from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c | 9 ++--- 2 files chan

[PATCH 4/9] staging: rtl8192u: propagate errors in rtl8192_read_eeprom_info

Propagate error from eprom_read and change the return type of rtl8192_read_eeprom_info from void to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 37 +- 1 file changed, 19 insertions(+), 18 deletions(-)

[PATCH 1/9] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-)

[PATCH 5/9] staging: rtl8192u: check return value of rtl8192_read_eeprom_info

The call of rtl8192_read_eeprom_info may fail, therefore its return value must be checked and propagated in the case of error. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH 2/9] staging: rtl8192u: eprom_read: check return value of eprom_r

Check the return value from eprom_r and propagate it in the case of error. The error code is a negative value, therefore change the return type of eprom_read from u32 to int. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 9 +++-- d

[PATCH 3/9] staging: rtl8192u: check return value eprom_read

The call of eprom_read may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8192U_core.c | 147 +++-- 1 file changed, 104 insertions(+), 43 deletions(-) diff --git a/drivers/s

[PATCH 0/9] staging: rtl8192u: Checking return value/propagating errors

These patchs check the return value/propagate error of the functions read_nic_word_E,eprom_r, eprom_read, rtl8192_read_eeprom_info, write_nic_*. Salah Triki (9): staging: rtl8192u: check return value of read_nic_word_E staging: rtl8192u: eprom_read: check return value of eprom_r staging

[PATCH V4] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 +-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c

[PATCH V3] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 +-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c

[PATCH V2] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 ++-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c

[PATCH] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 30 ++-- drivers/staging/rtl8192u/r8180_93cx6.h | 2 +- drivers/staging/rtl8192u/r8192U_core.c

[PATCH] staging: rtl8192u: check return value of read_nic_word_E

The call of read_nic_word_E may fail, therefore its return value must be checked. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/rtl8192u/r8180_93cx6.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rt

Cleaning dgnc driver

Hi, Is it useful to clean staging/dgnc, since it supports the same adapters that those of serial/jsm ? best regards, salah triki ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev

Re: [PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

Hi, How to decide if an information should be exported or not to user space ? best regards -- salah triki On Mon, Dec 21, 2015 at 03:52:26PM -0800, Greg KH wrote: > On Fri, Dec 18, 2015 at 11:57:18AM +0100, Salah Triki wrote: > > Delegate creation and destruction of sysfs files

[PATCH] staging:dgnc:Creating and destroying sysfs files properly

Delegate creation and destruction of sysfs files to device and driver layers in order to eliminate races. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 11 ++-- drivers/staging/dgnc/dgnc_sysfs.c | 118 ++--- d

[PATCH V2] staging: dgnc: Creating and destroying sysfs files properly

Delegate creation and destruction of sysfs files to device and driver layers in order to eliminate races. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 11 ++-- drivers/staging/dgnc/dgnc_sysfs.c | 118 ++--- d

Re: [PATCH V2] staging: dgnc: Remove dgnc_ports_state_show

On Thu Oct 8 07:22:58 UTC 2015, dan carpenter wrote: >On Thu, Oct 08, 2015 at 07:26:37AM +0100, Salah Triki wrote: >> dgnc_ports_state_show is removed, since it exposes ports status which >> help an adversary to >> plan an attack. > >No. It doesn't export anything harm

[PATCH V2] staging: dgnc: Remove dgnc_ports_state_show

dgnc_ports_state_show is removed, since it exposes ports status which help an adversary to plan an attack. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_sysfs.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/stagin

[PATCH V5] staging: dgnc: take a lock when storing value in dgnc_poll_tick

Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write to dgnc_poll_tick is not. It could theoretically race. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/stagin

[PATCH V4] staging: dgnc: take lock when storing value in dgnc_poll_tick

dgnc_driver_pollrate_store needs to take a lock before modifying the shared variable dgnc_poll_tick. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_sysfs.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/stagin

Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

On Wed, Sep 23, 2015 at 11:37:37AM +0530, Sudip Mukherjee wrote: > On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to > > take the > > lock dgnc_poll_lock before modifying this var

[PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

not static and extern in order to be visible for dgnc_driver_pollrate_store. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/staging/dgnc/dgnc_sysfs.c | 9 - 3 files changed, 10 insertions

Re: [PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

On Mon, Sep 21, 2015 at 07:17:08PM +0300, Dan Carpenter wrote: > On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote: > > On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote: > > > poll_tick is declared global, so dgnc_driver_pollrate_* need to > > > take the

Re: [PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

I'm sorry for wasting your time. best regards, salah triki ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

>On Sun, 6 Sep 2015 20:00:10 -0700, Greg KH wrote: >>On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote: >> poll_tick is declared global, so dgnc_driver_pollrate_* need to >> take the lock dgnc_poll_lock before accessing to this variable. > >Really? The scope o

Re: [PATCH v3] staging: dgnc: take lock when storing value in dgnc_poll_tick

>On Wed, 2 Sep 2015 18:15:29 -0700, Greg KH wrote: >>On Tue, Aug 25, 2015 at 08:09:47PM +0100, Salah Triki wrote: >> poll_tick is declared global, so dgnc_driver_pollrate_store needs to >> take >> the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock

Re: [PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

On Mon, Sep 21, 2015 at 07:17:08PM +0300, Dan Carpenter wrote: > On Sun, Sep 06, 2015 at 08:00:10PM -0700, Greg KH wrote: > > On Sat, Sep 05, 2015 at 01:12:01PM +0100, Salah Triki wrote: > > > poll_tick is declared global, so dgnc_driver_pollrate_* need to > > > take the

[PATCH 2/2] staging: dgnc: remove useless spinlock

dgnc_poll_stop is a local variable in dgnc_driver.c, so it is useless to take dgnc_poll_lock before accessing to this variable. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/stagin

[PATCH 1/2] staging: dgnc: take lock when accessing to dgnc_poll_tick

and extern in order to be visible for dgnc_driver_pollrate_*. Signed-off-by: Salah Triki <salah.tr...@acm.org> --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/staging/dgnc/dgnc_sysfs.c | 18 -- 3 files changed, 18 insertions

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Mon, Aug 24, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate

[PATCH v3] staging: dgnc: take lock when storing value in dgnc_poll_tick

and extern in order to be visible for dgnc_driver_pollrate_store. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/staging/dgnc/dgnc_sysfs.c | 9 - 3 files changed, 10 insertions(+), 2 deletions

[PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

not static and extern in order to be visible for dgnc_driver_pollrate_store. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/staging/dgnc/dgnc_sysfs.c | 9 - 3 files changed, 10 insertions(+), 2

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Wed, Aug 19, 2015 at 10:36:14PM +0300, Dan Carpenter wrote: On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the appropriate

[PATCH] staging: dgnc: take lock when storing value in dgnc_poll_tick

not static and extern in order to be visible for dgnc_driver_pollrate_store. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- drivers/staging/dgnc/dgnc_driver.h | 1 + drivers/staging/dgnc/dgnc_sysfs.c | 10 -- 3 files changed, 10 insertions

Re: [PATCH] staging: dgnc: take mutex when storing value in dgnc_poll_tick

On Mon, Aug 17, 2015 at 09:26:15PM +0300, Dan Carpenter wrote: On Mon, Aug 17, 2015 at 04:19:12PM +0100, Salah Triki wrote: Since dgnc_poll_trick is a global variable. Signed-off-by: Salah Triki salah.tr...@acm.org Does this changelog even mean? Why is Mark not on the CC list? Use

[PATCH] staging: dgnc: take mutex when storing value in dgnc_poll_tick

Since dgnc_poll_trick is a global variable. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index

Re: [PATCH] zram: Replace pr_* with dev_*

Hi Sanjeev, thanx for comments. best regards, salah triki On Wed, Aug 05, 2015 at 10:10:58AM +0530, sanjeev sharma wrote: Hello Salah, It would be good,if you provide some information why you are doing so like messages that are associated with a particular device should be tagged

Re: [PATCH] zram: Replace pr_* with dev_*

On Thu, Aug 06, 2015 at 09:26:02AM +0900, Sergey Senozhatsky wrote: On (08/06/15 01:24), Dan Carpenter wrote: On Tue, Aug 04, 2015 at 07:19:01PM +0100, Salah Triki wrote: @@ -508,14 +509,15 @@ static struct zram_meta *zram_meta_alloc(int device_id, u64 disksize) num_pages = disksize

[PATCH] zram: Replace pr_* with dev_*

This patch replaces pr_info/pr_warn/pr_err with dev_info/dev_warn/dev_err. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/block/zram/zram_drv.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/block/zram/zram_drv.c

[PATCH] [dgnc] Remove dgnc_ports_state_show

dgnc_ports_state_show exposes ports status which help an adversary to plan an attack. Thus, the function is removed. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH v3] Staging: dgnc: Remove sysfs file

This sysfs file is not useful for anything. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index a72e353

Contribute using the wrong branch

-- Salah Triki ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] Staging: dgnc: Fix checking return value of register_chrdev

The failure code is negative. So check 0 instead of =0. Return the failure code instead of -ENXIO. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b

[PATCH] Staging: dgnc: Fix return value code of dgnc_start

Return the failure code from register_chrdev instead of -ENXIO. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index

[PATCH] Staging: dgnc: Fix checking return value of register_chrdev

The failure code is negative. So check 0 instead of =0. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index f177d3a

[PATCH v2] staging: dgnc: Remove sysfs file

sysfs file is not useful for anything. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/Makefile | 3 +- drivers/staging/dgnc/dgnc_driver.c | 10 +- drivers/staging/dgnc/dgnc_driver.h | 2 - drivers/staging/dgnc/dgnc_sysfs.c | 713

[PATCH] Staging: dgnc: use goto for error handling in dgnc_start()

The error handling for register_chrdev is taken care by goto statement. The failure code from register_chrdev is returned. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: dgnc: fix braces {} are not necessary for single statement blocks

This patch fixes the following checkpatch.pl warning: braces {} are not necessary for single statement blocks Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_tty.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers

[PATCH] staging: dgnc: Remove unnecessary checks

This patch removes unnecessary checks of unit magic, channel magic, board magic and board state. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers

[PATCH v2] staging: dgnc: Warn on macro with flow control statements

This fixes the following checkpatch.pl warnings: WARNING: Macros with flow control statements should be avoided. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 38 -- 1 file changed, 12 insertions(+), 26 deletions

[PATCH] staging: dgnc: use min_t instead of min

This fixes the following checkpatch.pl warnings: WARNING: min() should probably be min_t() Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc

[PATCH] staging: dgnc: Warn on macro with flow control statements

This fixes the following checkpatch.pl warnings: WARNING: Macros with flow control statements should be avoided. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_sysfs.c | 64 --- 1 file changed, 39 insertions(+), 25 deletions

[PATCH] staging: dgnc: use min_t instead of min

This fixes the following checkpatch.pl warnings: WARNING: min() should probably be min_t() --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index c9a8a98..1268aa9 100644 ---

[PATCH] staging: dgnc: use min_t instead of min

This fixes the following checkpatch.pl warnings: WARNING: min() should probably be min_t() --- drivers/staging/dgnc/dgnc_neo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index c9a8a98..1268aa9 100644 ---

[PATCH 1/1] dgnc: Cleanup coding style

Hi, Greg and others, Is that patch ok ? The last time I messed up with git. Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc

[PATCH 1/1] dgnc: Cleanup coding style

This fixes the following checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b

[PATCH 2/2] dgnc: Cleanup coding style

Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 0a05ed2..45c584c 100644 --- a/drivers/staging/dgnc/dgnc_driver.c

[PATCH 1/2] dgnc: Cleanup coding style

This fixes the following checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b

[PATCH 1/1] dgnc: Cleanup coding style

This fixes the following checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level Signed-off-by: Salah Triki salah.tr...@acm.org --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b

  1   2   >