Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned

> On Jan 15, 2017, at 10:30 PM, Derek Robson wrote: > > Changed bare use of 'unsigned' to the prefered us of 'unsigned int' > found using checkpatch Just wondering if you compiled? This patch looks exactly like a patch I tried, but it didn't compile. > Signed-off-by:

[PATCH 1/7] staging:wlan-ng:cfg80211.c Aligned code with open parenthesis

Fixed Alignment should match open parenthesis checkpatch CHECK. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wlan-ng/cfg80211.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/w

[PATCH 3/7] staging:wilc1000:linux_wlan.c Align code to match open parenthesis

Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wi

[PATCH 4/7] staging:wilc1000:wilc_debugfs.c Aligns code to match open parenthesis

Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/wilc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wi

[PATCH 2/7] staging:wilc1000:host_interface.c Added braces {} on else statemement

Fixes checkpatch warning: braces {} should be used on all arms of this statement Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/host_interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interfac

[PATCH 7/7] staging:wilc1000:wilc_sdio.c Deleted un-needed blank lines

Fixes checkpatch CHECK: Blank lines aren't necessary before a close brace '}' Please don't use multiple blank lines Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/wilc_sdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wi

[PATCH 6/7] staging:wilc1000:wilc_sdio.c Aligns code match open parenthesis

Fixes checkpatch CHECK: Alignment should match open parenthesis Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_sdio.c b/drivers/staging/wi

[PATCH 5/7] staging:wilc1000:wilc_debugfs.c Removes multiple blank lines

Fixes checkpatch CHECK: Please don't use multiple blank lines Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/wilc1000/wilc_debugfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_deb

[PATCH] staging:vt6656:mac.c Aligned to match open parenthesis

Fixes checkpatch warning: Alignment should match open parenthesis Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/vt6656/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c index 8

[PATCH 1/4] staging:vt6656:key.c Aligned code with open parenthesis

Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/vt6656/key.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6656/key.c b/drivers/staging/vt6656/key.c

[PATCH 4/4] staging:vt6656:main_usb.c Removed un-needed blank lines

Fixed the following checkpatch warnings by deleting blank lines Blank lines aren't necessary before a close brace '}' Blank lines aren't necessary after an open brace '{' Please don't use multiple blank lines Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/

[PATCH 3/4] staging:vt6656:main_usb.c Aligned code to match open parenthesis

Fixed Alignment should match open parenthesis from checkpatch Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/vt6656/main_usb.c | 59 --- 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/drivers/staging/vt6656/main

[PATCH 2/4] staging:vt6656:mac.c Aligned code to match open parenthesis

Fixed Alignment should match open parenthesis checkpatch CHECK Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/vt6656/mac.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/vt6656/m

[PATCH 1/2] staging:sm750fb:ddk750_chip.c Adds braces to last arm of statement

Fixes absence of braces on last arm of statement, identified by checkpatch Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/sm750fb/ddk750_chip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/s

[PATCH 2/2] staging:sm750fb:ddk750_chip.c removes un-necessary blank lines

Fixes checkpatch warning - Please don't use multiple blank lines Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/sm750fb/ddk750_chip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c

[PATCH 1/2] staging:rtl8192u:r819xU_cmdpkt.c Fix Alignment should match open parenthesis

Fixes Alignment should match open parenthesis in checkpatch Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/s

[PATCH 2/2] staging:rtl8192u:r819xU_cmdpkt.c Removes un-necessary blank lines

Fixes checkpatch.pl warning - Blank lines aren't necessary before a close brace '}' & Please don't use multiple blank lines Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 - 1 file changed, 25 deletions(-)

[PATCH 2/2] staging/media/s5p-cec/exynos_hdmi_cecctrl.c Fixed blank line before closing brace '}'

Fixed checkpatch check blank line before closing brace '}' Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c b/drivers/staging

[PATCH 1/2] staging:media:s5p-cec:exynos_hdmi_cecctrl.c Fixed Alignment should match open parenthesis

Fixed Checkpatch check "Alignment should match open parenthesis" Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/s5p-cec/exyno

[PATCH 1/2] staging:rtl8712: Removed unnecessary parentheses

Removed unnecessary parentheses identified by checkpatch Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8712/ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee8

[PATCH 2/2] staging:rtl8712 Aligned code with open parenthesis

Aligned code with open parenthesis to fix a checkpatch warning Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8712/mlme_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/r

[PATCHv2 2/2] staging:rtl8188eu:core Fixes Alignment should match opening brace

Fixed style issue: Alignment should match open brace Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 38 - 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_a

[PATCHv2 1/2] staging:rwl8188eu:rtw_ap.c remove unnecessary braces

Removed unnecessary braces Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 106 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl

[PATCH 1/2] drivers/staging/rtl8188eu/core/rtw_ap.c un-necessary parenthesis

Fixed coding style issue, un-necessary parenthesis present Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 106 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/drivers/staging/rtl8188e

[PATCH 2/2] drivers/staging/rtl8188eu/core/rtw_ap.c Alignment should match open parenthesis

Fixed style issue: Alignment should match open parenthesis throughout file Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 38 - 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/s

[PATCH 0/2] Fixes coding style

The patch series addresses some coding style issues contained within the file. Scott Matheina (2): drivers/staging/rtl8188eu/core/rtw_ap.c un-necessary parenthesis drivers/staging/rtl8188eu/core/rtw_ap.c Alignment should match open parenthesis drivers/staging/rtl8188eu/core/rtw_ap.c

[PATCH] staging:iio:addac Fixes Alignment should match open parenthesis

Fixes style issue where Alignment doesn't match open parenthesis Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316-i2c.c b/drivers/staging/iio

[PATCHv4 7/8] Changed code to align with coding style of using octat

The permmission code was changed to reflect octat (0644/0444) for required permissions. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 264 ++-- 1 file changed, 101 insertions(+), 163 deletions(-) diff

[PATCHv4 8/8] Fixes style issues due to mis-aligned carry over lines

Lines were not aligned with (, this patch simply changes the indention, no substantive changes function of driver. Signed-Off-By: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 415 ++-- 1 file changed, 210 insertions(+

[PATCHv4 6/8] Fixed code wrap alignment with preceding (.

The code wasn't aligned with preceding ( on following lines, fixes this coding style issue. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/d

[PATCHv4 5/8] Remove line after closing braces

There was an additional line which was un-needed, removed that line. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

[PATCHv4 4/8] Fix braces not present on all arms of if else statement

Adds braces to second arm of if else statement. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

[PATCHv4 3/8] Fix camel case issues

Cases of camel case were fixed by making variables lower case throughout the file. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/d

[PATCHv4 2/8] Fixed variables not being consistently lower case

Across the file, variables were sometimes upper case, some times lower case, this fix addresses a few of the instances with this inconsistency. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 48 ++--- 1 file c

[PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac

*** BLURB HERE *** Scott Matheina (8): fixed long description text exceeding 80 characters Fixed variables not being consistently lower case Fix camel case issues Fix braces not present on all arms of if else statement Remove line after closing braces Fixed code wrap alignment

[PATCHv4 1/8] fixed long description text exceeding 80 characters

The description was split into 2 lines due to the line greatly exceeding the 80 character soft limit. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/a

[PATCHv4 7/8] Changed code to align with coding style of using octat

The permmission code was changed to reflect octat (0644/0444) for required permissions. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 264 ++-- 1 file changed, 101 insertions(+), 163 deletions(-) diff

[PATCHv4 2/8] Fixed variables not being consistently lower case

Across the file, variables were sometimes upper case, some times lower case, this fix addresses a few of the instances with this inconsistency. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 48 ++--- 1 file c

[PATCHv4 3/8] Fix camel case issues

Cases of camel case were fixed by making variables lower case throughout the file. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/d

[PATCHv4 5/8] Remove line after closing braces

There was an additional line which was un-needed, removed that line. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

[PATCHv4 4/8] Fix braces not present on all arms of if else statement

Adds braces to second arm of if else statement. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

[PATCHv4 1/8] fixed long description text exceeding 80 characters

The description was split into 2 lines due to the line greatly exceeding the 80 character soft limit. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/addac/a

[PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac

*** BLURB HERE *** Scott Matheina (8): fixed long description text exceeding 80 characters Fixed variables not being consistently lower case Fix camel case issues Fix braces not present on all arms of if else statement Remove line after closing braces Fixed code wrap alignment

[PATCH] fixed spelling error in TODO file for dgnc driver

fixed a missing letter in the TODO file 'unneeded' Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/dgnc/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..6c91bbd

Re: [PATCH] indention and space fixes to align with linux style

On 12/20/2016 09:23 PM, Joe Perches wrote: On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote: Fixed indention and space issues to align the code with the linux style guide. [] diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c [] @@ -176,16

Re: [PATCH] indention and space fixes to align with linux style

> On Dec 20, 2016, at 9:23 PM, Joe Perches <j...@perches.com> wrote: > >> On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote: >> Fixed indention and space issues to align the code with the linux style >> guide. > [] >> diff --git a/drivers/staging/ii

[PATCH] indention and space fixes to align with linux style

Fixed indention and space issues to align the code with the linux style guide. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/iio/addac/adt7316.c | 603 1 file changed, 266 insertions(+), 337 deletions(-) diff --git a/drivers/s

[PATCH v3] fix code alignment with open parenthesis

These changes where identified by checkpatch.pl as needed changes to align the code with the linux development coding style. The several lines of text where aligned with the precending parenthesis. Signed-off-by: Scott Matheina <sc...@matheina.com> --- drivers/staging/fbtft/fb_agm1264k-fl.

Re: [PATCH v2] fix code alignment with open parenthesis

On 12/19/2016 12:35 AM, Greg KH wrote: On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: These changes where identified by checkpatch.pl as needed changes to align the code with the linux development coding style. The several lines of text where aligned with the precending

[PATCH v2] fix code alignment with open parenthesis

These changes where identified by checkpatch.pl as needed changes to align the code with the linux development coding style. The several lines of text where aligned with the precending parenthesis. Signed-off-by: Scott Matheina <sc...@matheina.com> Changes to be committed: mo

Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

On 12/18/2016 01:46 AM, Greg KH wrote: On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote: Signed-off-by: Scott Matheina <sc...@matheina.com> I can't take patches without any changelog text :( Yah. Forgot to add the description. Added for v2. --- drivers/staging