Re: [PATCH 00/34] treewide: simplify getting the adapter of an I2C client

Hi, On Sat, Jun 08, 2019 at 12:55:39PM +0200, Wolfram Sang wrote: > While preparing a refactoring series, I noticed that some drivers use a > complicated way of determining the adapter of a client. The easy way is > to use the intended pointer: client->adapter > > These drivers do: >

Re: [PATCH v2 01/17] power: supply: olpc_battery: correct the temperature units

Hi, On Fri, Nov 16, 2018 at 05:23:47PM +0100, Lubomir Rintel wrote: > According to [1] and [2], the temperature values are in tenths of degree > Celsius. Exposing the Celsius value makes the battery appear on fire: > > $ upower -i /org/freedesktop/UPower/devices/battery_olpc_battery > ... >

Re: [PATCH v2 16/17] power: supply: olpc_battery: Avoid using platform_info

if (ec_byte & BAT_STAT_DISCHARGING) > @@ -608,14 +607,32 @@ static int olpc_battery_probe(struct platform_device > *pdev) > struct power_supply_config psy_cfg = {}; > struct olpc_battery_data *data; > uint8_t status; > + uint8_t ecver; > + int ret;

Re: [PATCH v2 15/17] power: supply: olpc_battery: Use devm_power_supply_register()

Hi, On Fri, Nov 16, 2018 at 05:24:01PM +0100, Lubomir Rintel wrote: > This simplifies the error handling. > > Signed-off-by: Lubomir Rintel > > --- Reviewed-by: Sebastian Reichel -- Sebastian > Changes since v1: > - This was split off the "power: supply: ol

Re: [PATCH v2 14/17] power: supply: olpc_battery: Move priv data to a struct

On Fri, Nov 16, 2018 at 05:24:00PM +0100, Lubomir Rintel wrote: > The global variables for private data are not too nice. I'd like some > more, and that would clutter the global name space even further. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Andy Shevchenko > > --- > Changes since

Re: [PATCH v2 13/17] power: supply: olpc_battery: Use DT to get battery version

d-by: Pavel Machek > > --- Reviewed-by: Sebastian Reichel I assume this patch cannot be applied to power-supply without patch 12 having been merged to avoid breaking XO1.5 devices temporarily? -- Sebastian > Changes since v1: > - Sort the new include a bit higher > > driv

Re: [PATCH v2 11/17] dt-bindings: olpc_battery: Add XO-1.5 battery

Hi, On Fri, Nov 16, 2018 at 05:23:57PM +0100, Lubomir Rintel wrote: > The XO-1 and XO-1.5 batteries apparently differ in an ability to report > ambient temperature. > > Signed-off-by: Lubomir Rintel > Reviewed-by: Rob Herring > Acked-by: Pavel Machek > > --- Review

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

Hi, On Wed, Oct 10, 2018 at 07:22:45PM +0200, Lubomir Rintel wrote: > Hi. > > This patchset adds support for the Embedded Controller on an OLPC XO > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into > the existing OLPC platform infrastructure, currently used by the x86 > based

Re: [PATCH 01/15] power: supply: olpc_battery: correct the temperature units

Hi, On Fri, Oct 19, 2018 at 04:00:32PM +0300, Andy Shevchenko wrote: > On Wed, Oct 10, 2018 at 8:23 PM Lubomir Rintel wrote: > > > > According to [1] and [2], the temperature values are in tenths of degree > > Celsius. Exposing the Celsius value makes the battery appear on fire: > > > > $

Re: [PATCH v3 09/11] power: supply: bq24190_charger: Get input_current_limit from our supplier

Hi, On Wed, Aug 30, 2017 at 07:47:46AM -0700, Tony Lindgren wrote: > * Hans de Goede [170830 02:49]: > > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > > done by a separate port-controller IC, while the current limit is > > controlled through another

Re: [PATCH v3 08/11] power: supply: bq24190_charger: Export 5V boost converter as regulator

Hi, On Wed, Aug 30, 2017 at 07:46:50AM -0700, Tony Lindgren wrote: > * Hans de Goede [170830 02:49]: > > Register the 5V boost converter as a regulator named "usb_otg_vbus". > > > > This commit also adds support for bq24190_platform_data, through which > > non device-tree

Re: [PATCH v2 11/14] power: supply: bq24190_charger: Get input_current_limit from our supplier

Hi, On Tue, Aug 29, 2017 at 01:53:24PM +0200, Hans de Goede wrote: > Hi, > > Thank you for your reviews / queuing! > > On 29-08-17 13:40, Sebastian Reichel wrote: > > Hi, > > > > On Tue, Aug 15, 2017 at 10:04:59PM +0200, Hans de Goede wrote: > > > On s

Re: [PATCH v2 11/14] power: supply: bq24190_charger: Get input_current_limit from our supplier

Hi, On Tue, Aug 15, 2017 at 10:04:59PM +0200, Hans de Goede wrote: > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > done by a separate port-controller IC, while the current limit is > controlled through another (charger) IC. > > It has been decided to model this by

Re: [PATCH v2 10/14] power: supply: bq24190_charger: Add input_current_limit property

Hi, On Tue, Aug 15, 2017 at 10:04:58PM +0200, Hans de Goede wrote: > Export the input current limit of the charger as a > POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT property on the charger > power_supply class device. > > Signed-off-by: Hans de Goede > --- Thanks, queued. --

Re: [PATCH v2 09/14] power: supply: bq24190_charger: Export 5V boost converter as regulator

Hi, On Tue, Aug 15, 2017 at 10:04:57PM +0200, Hans de Goede wrote: > Register the 5V boost converter as a regulator named "usb_otg_vbus". > > This commit also adds support for bq24190_platform_data, through which > non device-tree platforms can pass the regulator_init_data (containing > mappings

Re: [PATCH v2 08/14] power: supply: Add power_supply_set_input_current_limit_from_supplier helper

Hi, On Tue, Aug 15, 2017 at 10:04:56PM +0200, Hans de Goede wrote: > On some devices the USB Type-C port power (USB PD 2.0) negotiation is > done by a separate port-controller IC, while the current limit is > controlled through another (charger) IC. > > It has been decided to model this by

Re: [PATCH] staging: iio: isl29028: add isl29030 support

Hi, On Sun, Apr 30, 2017 at 05:27:07PM +0100, Jonathan Cameron wrote: > On 28/04/17 17:17, Brian Masney wrote: > > On Fri, Apr 28, 2017 at 05:55:58PM +0200, Sebastian Reichel wrote: > >> isl29030 is basically the same chip. The only difference > >> is the chip's first

[PATCH] staging: iio: isl29028: add isl29030 support

for the Linux driver. This has been tested on Motorola Droid 4. Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + drivers/staging/iio/light/isl29028.c | 6 ++ 2 files chan

Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM

Hi, On Thu, Mar 03, 2016 at 12:00:14PM +0100, Arnd Bergmann wrote: > On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote: > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > > index 0a6408a39c66..0f34846ae80d 100644 > > --- a/drivers/power/reset/Kconfig > > +++

Re: [PATCH V2] goldfish: add goldfish match node for dt driver probe

Hi, On Fri, Nov 06, 2015 at 03:12:40PM +0800, yalin wang wrote: > qemu use device tree to bootup linux kernel, > we need add device node match table to plaftorm driver, > so that can probe the goldfish driver correctly. > test by this qemu: > git clone

Re: [PATCH v4 11/20] power_supply: Change ownership from driver to core

Hi, On Mon, Feb 23, 2015 at 12:47:32PM +0100, Krzysztof Kozlowski wrote: Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are