Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
Changes in v3: Removed leading space from debug message.
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++
drivers/staging/lustre/lustre
On Tue, Aug 12, 2014 at 02:17:07AM +, Drokin, Oleg wrote:
On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote:
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c
b/drivers/staging
On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote:
On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote:
On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote:
On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote:
That looks silly before and after
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4
Fixes the following checkpatch warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre
Fixes the following checkpatch error:
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++-
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++-
2 files
Fixes the following checkpatch error:
ERROR: do not use C99 // comments
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c
Fixes the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 +
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++
drivers/staging/lustre/lustre
Fixes the following checkpatch error:
ERROR: (foo*) should be (foo *)
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
b
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers/staging/lustre/lustre
Fixes the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 --
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++---
drivers/staging/lustre/lustre/mdc
Fixes the following checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 +
drivers/staging
Fix the following checkpatch error:
ERROR: else should follow close brace '}'
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc
Fixes the following checkpatch error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 18 +++---
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers
Changes:
- move const union vars to the top
- move rc to bottom
- do not initialize req
- set lvb_type to enum member instead of 0
- change __u64 to u64
- fix inconsistant columnization
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
These changes were suggested by Dan Carpenter
On Sat, Aug 09, 2014 at 09:32:22PM -0700, Greg KH wrote:
On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote:
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik srikrishanma
On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote:
On Wed, Aug 06, 2014 at 10:43:00PM +0530, Srikrishan Malik wrote:
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
b/drivers/staging/lustre/lustre/mdc/mdc_locks.c
index c03d77c9c5b8..09209171b50c 100644
Fixes the following checkpatch error:
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++-
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++-
2 files
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4
Fixes the following checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 +
drivers/staging
Fixes the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 --
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++---
drivers/staging/lustre/lustre/mdc
Fixes the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 +
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++
drivers/staging/lustre/lustre
Fixes the following checkpatch error:
ERROR: do not use C99 // comments
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c
Fix the following checkpatch error:
ERROR: else should follow close brace '}'
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc
Fixes the following checkpatch error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 12 ++--
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Fixes the following checkpatch error:
ERROR: (foo*) should be (foo *)
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
b
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik srikrishanma...@gmail.com
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers/staging/lustre/lustre
29 matches
Mail list logo