numvgamodes was only used in one place, so remove the #define
and use its defined value.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xx.h | 2 --
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git
Fix the checkpatch warning about CamelCase.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers
reduce code indention keeping the logic same.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 173 ++
1 file changed, 82 insertions(+), 91 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers
move vgamode table from the header file to the C file and mark it
as const.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xx.h | 660 --
drivers/staging/sm7xxfb/sm7xxfb.c | 660 ++
2
Fix the alignment.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index c832399..6bdcd5b
On Mon, Jun 15, 2015 at 03:00:34PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
This patch shall replaces user defined timer setup function with
standard timer setup macro. Also removes init_timer, because timer can
be initialized in setup_timer macro as well.
Signed-off-by: Gnanachandran
On Tue, Jun 16, 2015 at 03:46:04PM +0900, Dean Lee wrote:
modify message warning: cast from pointer to integer of different size.
add type cast 'uintptr_t'.
---
[]
@@ -620,7 +621,7 @@ static s32 Handle_SetChannel(void *drvHandler,
tstrHostIFSetChan *pstrHostIFSetC
On Tue, Jun 16, 2015 at 07:33:42AM +, Abdul, Hussain (H.) wrote:
From: Abdul Hussain hab...@visteon.com
This patch removes unwanted true and false from boolean tests.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
snip
diff --git a/drivers/staging/wilc1000/host_interface.c
On Mon, Jun 15, 2015 at 11:30:41AM +0200, Daniele Alessandrelli wrote:
On June 15, 2015 7:47:41 AM GMT+02:00, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
- u16 Signature; /* 92C0: test chip; 92C
On Mon, Jun 15, 2015 at 12:58:50AM +0200, Mateusz Kulikowski wrote:
This function was declared but never unused.
After this patch we are getting two build warnings:
warning: ‘dequeue_mgmt’ defined but not used
warning: ‘rtllib_resume_tx’ defined but not used
regards
sudip
On Mon, Jun 15, 2015 at 08:41:17AM +0200, Mateusz Kulikowski wrote:
On June 15, 2015 8:38:01 AM GMT+02:00, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Mon, Jun 15, 2015 at 12:58:50AM +0200, Mateusz Kulikowski wrote:
This function was declared but never unused.
After this patch
On Sat, Jun 13, 2015 at 09:57:05AM -0700, Joe Perches wrote:
It seems ready to me.
As far as I can tell, there's just a few niggles
that could be done:
Something like (too lazy to separate them into multiple patches)
Thanks. I will break into patches. Call me lazy for not having it done
On Sun, Jun 14, 2015 at 05:17:43PM +, Dighe, Niranjan (N.) wrote:
From: Niranjan Dighe ndi...@visteon.com
This patch removes spaces at the start of the line and replaces it
by tabs
You are also removing blank lines, adding blank lines, moving a ')' to
next line.
regards
sudip
On Sun, Jun 14, 2015 at 11:26:35PM +0200, Daniele Alessandrelli wrote:
This patch makes field in struct rt_8723a_firmware_hdr use endianness-aware
types (__leXX), thus fixing the following sparse warnings:
snip
Signed-off-by: Daniele Alessandrelli daniele.alessandre...@gmail.com
---
On Sat, Jun 13, 2015 at 02:50:06PM +0300, Anton Gerasimov wrote:
Comments are rearranged for readability, one long function call is
split into several lines.
you are splitting long functions calls in the previous patch. It could
have been in that one. why here?
regards
sudip
On Sat, Jun 13, 2015 at 03:39:29PM +0300, Anton Gerasimov wrote:
Added spaces after commas in initialization sequences.
and you are also removing the line continuations.
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
On Sat, Jun 13, 2015 at 03:27:16PM +0300, Anton Gerasimov wrote:
Placed comments to register writes before the function call to
eliminate long strings and make code more readable.
Signed-off-by: Anton Gerasimov anton.gerasi...@openmailbox.org
---
snip
/* -- Set GRAM
On Fri, Jun 12, 2015 at 05:18:49PM -0700, Greg KH wrote:
On Tue, Jun 09, 2015 at 04:59:01PM -0500, J. German Rivera wrote:
This patch series includes new functionality for the Freescale fsl-mc
bus driver.
Why are people working on new functionality instead of working on
getting this out
On Sat, Jun 13, 2015 at 02:50:05PM +0300, Anton Gerasimov wrote:
The patch splits long function calls and declarations into several shorter
lines.
Signed-off-by: Anton Gerasimov anton.gerasi...@openmailbox.org
---
snip
@@ -232,10 +242,12 @@ static int flexfb_verify_gpios_db(struct
The CONFIGs, the enum and the function declaration was not being
used anywhere.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/include/odm.h | 8
drivers/staging/rtl8188eu/include/odm_HWConfig.h | 3 ---
2 files changed, 11 deletions(-)
diff
On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote:
remove complete OS wrapper functions.
just a minor thing. It will be easy if you send your patches in series
instead of separate patches. your patch remove oswrapper type file
is dependent on one of the previous patch that you have sent
The function rtw_mfree_all_stainfo() is just holding the lock,
traversing the list, and then unlocking. It is not doing anything else.
So removed the function and modified the places from where it was called.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/core
These variables were being set but not used afterwards.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 3 ---
drivers/staging/rtl8188eu/hal/phy.c | 10 ++
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2
On Thu, Jun 11, 2015 at 09:51:15AM +, Abdul, Hussain (H.) wrote:
This patch removes unwnated true from boolean tests.
did u mean unwanted?
and for all your four patches the email header From: line is not matching
the Signed-off-by: line. Please add an extra From: line like others of
your
The CONFIGs, the enum and the function declaration was not being
used anywhere.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/include/odm.h | 8
drivers/staging/rtl8188eu/include/odm_HWConfig.h | 3 ---
2 files changed, 11 deletions(-)
diff
These variables were being set but not used afterwards.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8188eu/core/rtw_mlme.c| 3 ---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 6 +-
drivers/staging/rtl8188eu/hal/phy.c | 10
On Thu, Jun 11, 2015 at 06:39:09PM +0530, Sudip Mukherjee wrote:
These variables were being set but not used afterwards.
snip
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -147,18 +147,14 @@ inline struct sta_info
On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
Also this driver has active maintainers but somehow we have CC'd the
ATMEL people who maintain a different staging driver...
The original patch had put the maintainers of WILC1000 WIFI DRIVER in the
cc list. Now ccing the actual
On Wed, Jun 10, 2015 at 04:54:47AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
snip
@@ -7159,8 +7144,9 @@ err_stop:
*/
static void dgap_cleanup_module(void)
{
- if (dgap_numboards)
-
On Tue, Jun 09, 2015 at 08:34:55PM +0100, Daniel Lockyer wrote:
Fixed the issues with curly braces either needing to be on the line above or
below in several files.
please rebase your patch against staging-testing. It will not apply.
da295041a811adc2 (Staging: sm750fb: ddk750_display.c: Insert
On Wed, Jun 10, 2015 at 12:41:22AM -0400, gr...@linuxhacker.ru wrote:
From: Oleg Drokin gr...@linuxhacker.ru
It uses getname in unsafe manner and since it's to deal with corrupted
or inconsistent filesystem, we are probably better to deal with
it from lfsck anyway.
I am not sure but will it
On Thu, Jun 11, 2015 at 12:42:23PM +0900, Chris Park wrote:
size_t should print using %zu, but here it was use %lu.
we were getting warning while printing.
thanks, I made it to %lu seeing warning in x86_64 but that started
warning in i386. Not this solves warning in both.
regards
sudip
while building on i386 it gives a build warning about msg undeclared.
Fixes: e6ffd1ba55a4931c (staging: fbtft: fix out of bound access)
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
It was my mistake that I missed removing msg
On Thu, Jun 04, 2015 at 10:46:51PM -0700, Joe Perches wrote:
On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote:
On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote:
[]
snip
I looked at it a bit more and there's a macro that calls
write_register so there are actually many more
On Thu, Jun 04, 2015 at 11:37:01AM -0700, Kees Cook wrote:
Calling kthread_run with a single name parameter causes it to be handled
as a format string. Since the uisthread interface lacks format parameters,
use %s to avoid any potential accidents from callers passing in dynamic
string content.
On Thu, Jun 04, 2015 at 09:22:36AM -0400, Benjamin Romer wrote:
This patch set contains the remaining changes from our driver cleanup
efforts. No functional changes have been made, only a rebase so that the
patches would apply.
Hi,
its not related to your this patchset, but one of your previous
On Fri, Jun 05, 2015 at 01:17:32PM +0200, Mariusz Masztalerczuk wrote:
Fixed a coding style issue.
Signed-off-by: Mariusz Masztalerczuk mmasztalerc...@gmail.com
---
drivers/staging/unisys/virthba/virthba.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
i think you need to
On Fri, Jun 05, 2015 at 04:27:48PM -0700, Dennis Chen wrote:
From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001
From: Dennis Chen barracks...@gmail.com
Date: Fri, 5 Jun 2015 15:42:37 -0700
Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style
issue
On Thu, Jun 04, 2015 at 09:22:45AM -0400, Benjamin Romer wrote:
From: David Kershner david.kersh...@unisys.com
Diagchannel.h is used primarily for the diagnostics channel. The
diagnostics channel is not being used by linux guests currently, so
the majority of the file is not needed. What is
On Thu, Jun 04, 2015 at 10:34:20AM +0300, Dan Carpenter wrote:
On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote:
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote:
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c
looks like you have not just renamed
On Wed, Jun 03, 2015 at 04:43:27PM -0400, James Simmons wrote:
Point to the right place for GNU license. Update Intel copyright.
Signed-off-by: James Simmons jsimm...@infradead.org
closing is missing
regars
sudip
___
devel mailing list
On Wed, Jun 03, 2015 at 03:57:12PM -0400, James Simmons wrote:
Handle all the style issues reported by checkpatch.pl.
Remove general white spaces, spaces in function calls,
etc.
Signed-off-by: James Simmons jsimm...@infradead.org
---
snip
@@ -167,13 +164,14 @@ lnet_ipif_enumerate (char
On Thu, Jun 04, 2015 at 05:12:23AM -0700, Joe Perches wrote:
On Thu, 2015-06-04 at 17:12 +0530, Sudip Mukherjee wrote:
size of str is 16, but in snprintf the size was mentioned as 128.
[]
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/staging/fbtft/fbtft-core.c
[]
@@ -1096,7
On Thu, Jun 04, 2015 at 03:36:31PM +0300, Dan Carpenter wrote:
On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote:
size of str is 16, but in snprintf the size was mentioned as 128.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
snip
Good eye. How did you find
str was 16 bytes but was mentioned as 128 in snprintf.
again msg is 128 bytes but not sufficient to hold the complete debug
message of register values.
Now removed the use of str, msg and print the register values from the
loop.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2
On Wed, Jun 03, 2015 at 09:56:11AM +, Sharma, Abhishek (A.) wrote:
Removing the commented static variable declerations.
Signed-off-by: Abhishek Sharma ashar...@visteon.com
Your email header From: name is not matching with Signed-off-by: name.
If you cannot fix your email client then please
On Wed, Jun 03, 2015 at 03:43:47PM +0530, Aparna Karuthodi wrote:
Added a space before the open paranthesis '('
this patch is 2/2, but where is your 1/2 patch?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
On Tue, Jun 02, 2015 at 12:57:20PM -0700, Tolga Ceylan wrote:
In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
warning due its inability to detect the noreturn attribute in
lbug_with_lock() function inside LBUG macro. Adding a never reached
return statement suppresses
On Wed, Jun 03, 2015 at 08:23:54AM +, Mutharaju, Prasanna (P.) wrote:
From: Prasanna Karthik mkart...@visteon.com
Fix reported by coccinelle compressing last two lines with single return
call
Signed-off-by: Prasanna Karthik mkart...@visteon.com
---
On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
dig_t::dbg_mode is initialized to one value and checked only once in code.
This patch throws it away, and deletes always-true condition.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
On Wed, Jun 03, 2015 at 04:38:36PM +, Simmons, James A. wrote:
On Wed, Jun 03, 2015 at 10:32:31AM -0400, James Simmons wrote:
With all the TCPIP handling done in the lnet layer we should
rename all the functions with the prefix lnet_*. One other
change done was changing the remove
On Wed, Jun 03, 2015 at 10:32:31AM -0400, James Simmons wrote:
With all the TCPIP handling done in the lnet layer we should
rename all the functions with the prefix lnet_*. One other
change done was changing the remove argument of lnet_sock_getaddr
from a int to a bool.
Signed-off-by: James
On Wed, Jun 03, 2015 at 08:47:38AM -0700, Tolga Ceylan wrote:
The second patch is better (it also keeps the lock locked shorter.) Do
I need to resend?
yes, please, it was not formally submitted.
regards
sudip
___
devel mailing list
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote:
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c
looks like you have not just renamed the file, but there was also a change
in the #include which is not mentioned in the commit message.
---
On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote:
On 03.06.2015 09:26, Sudip Mukherjee wrote:
On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote:
No, I missed that - this one should also be removed - probably because of
similar naming (DbgMode, dbg_mode
On Wed, Jun 03, 2015 at 03:57:10PM -0400, James Simmons wrote:
With all the TCPIP handling done in the lnet layer we should
rename all the functions with the prefix lnet_*. One other
change done was changing the remove argument of lnet_sock_getaddr
from a int to a bool.
thats two different
On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Gujulan Elango Hari Prasath hguju...@visteon.com
On Tue, Jun 02, 2015 at 10:58:40AM +0200, Konrad Zapalowicz wrote:
On 06/02, Sudip Mukherjee wrote:
On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
On 06/02, Sudip Mukherjee wrote:
size_t should print using %zu, but here it was using %d and hence we
were getting
On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
On 06/02, Sudip Mukherjee wrote:
size_t should print using %zu, but here it was using %d and hence we
were getting warning while printing.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
I think
size_t should print using %zu and unsigned long int should use %lu
but here it was using %d and hence we were getting warning while
printing.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: missed mentioning unsigned long int in commit message.
drivers/staging/wilc1000/wilc_spi.c
On Wed, Jun 03, 2015 at 10:22:33AM +0530, aparnak wrote:
Added a new line
Signed-off-by: aparnak kdasapa...@gmail.com
Please use your full name in From header and Signed-off-by.
and subject should have been:
[PATCH] staging: lustre: llite: Fix No space after the declaration
regards
sudip
On Tue, Jun 02, 2015 at 11:32:19AM -0400, Chris Hanna wrote:
Signed-off-by: Chris Hanna han...@iu.edu
Minor changes to remove excessive whitespace and improve
readability of functions.
this description should come above your Signed-off-by line.
regards
sudip
On Sun, May 31, 2015 at 10:01:11PM -0700, Isaac Assegai wrote:
Insert Spaces after commas to rectify the following
checkpatch errors in ddk750_help.c and ddk750_mode.c:
ERROR: space required after that ','
Signed-off-by: Isaac Assegai isaac.a.trav...@gmail.com
---
snip
-
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Gujulan Elango Hari Prasath hguju...@visteon.com
Remove the unwanted else block
i think you need to refresh your tree. This was already removed by
86b4e7e270d9c08b ('staging: dgnc: remove some dead code
On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
Insert Spaces after commas to rectify the following checkpatch
errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
ERROR: space required after that ','
Signed-off-by: Isaac Assegai isaac.a.trav...@gmail.com
---
On Sun, May 31, 2015 at 10:01:04PM -0700, Isaac Assegai wrote:
Insert Spaces after commas to rectify the
following checkpatch errors in sm750.h:
ERROR: space required after that ','
Signed-off-by: Isaac Assegai isaac.a.trav...@gmail.com
---
drivers/staging/sm750fb/sm750.h | 35
On Sun, May 31, 2015 at 10:01:03PM -0700, Isaac Assegai wrote:
Insert Spaces after commas to rectify the
following checkpatch errors in sm750_help.h:
ERROR: space required after that ','
Signed-off-by: Isaac Assegai isaac.a.trav...@gmail.com
---
drivers/staging/sm750fb/sm750_help.h | 12
On Mon, Jun 01, 2015 at 12:39:31PM +, Dhere, Chaitanya (C.) wrote:
From: Chaitanya Dhere cvija...@visteon.com
This change was detected with help of coccinelle tool.
Hi,
can you please let me know how to use coccinelle to detect indention
issues. I never knew coccinelle can be used to check
On Mon, Jun 01, 2015 at 03:18:11PM +0900, Greg Kroah-Hartman wrote:
On Mon, Jun 01, 2015 at 11:16:51AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 07:05:30AM +0900, Greg Kroah-Hartman wrote:
On Wed, May 20, 2015 at 08:56:56PM +0530, Sudip Mukherjee wrote:
snip
On Mon, Jun 01, 2015 at 01:26:39PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote:
Really both patches should have been folded together.
regards,
dan carpenter
Yes Dan they can very well be a single patch.I have
On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote:
Fix the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
On Mon, Jun 01, 2015 at 07:05:30AM +0900, Greg Kroah-Hartman wrote:
On Wed, May 20, 2015 at 08:56:56PM +0530, Sudip Mukherjee wrote:
After 5 versions of WIP, finally a patch submission.
parport subsystem is now in the transition stage and supports the old
model and the new device model. 3
On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
The various semaphore functions all directly translate into
sema_init(), down() and up(), so we can just remove the API.
This is a mostly automated conversion using simple sed scripts,
plus some manual changes to account for
On Fri, May 29, 2015 at 04:00:53PM -0700, Colin Cronin wrote:
Fixed a few spelling errors in commented code, helpline text, and a TODO list
Files changed:
snip
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
index 2b2c6ea..cbc679d 100644
--- a/drivers/staging/dgnc/TODO
On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote:
The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
iio_dummy_evgen_release_irq() were changed to return void instead of int,
because these functions always return 0.
Signed-off-by: Vladimirs
On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
The abstraction for time in this driver is completely
unused, so remove it.
Signed-off-by: Arnd Bergmann a...@arndb.de
---
drivers/staging/wilc1000/wilc_osconfig.h | 1 -
drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
On Fri, May 29, 2015 at 07:17:37AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.
after your patch MYFLIPLEN becomes
On Wed, May 27, 2015 at 11:37:19AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 01:29:31PM +0530, Sudip Mukherjee wrote:
tested again.
strange behaviour.
if i send your patch to checkpatch from mutt via pipe I am getting these
errors but if i save your patch to a file
On Wed, May 27, 2015 at 05:38:42AM -0700, gre...@linuxfoundation.org wrote:
On Wed, May 27, 2015 at 11:49:47AM +0530, Sudip Mukherjee wrote:
May i know whats wrong with the patch ? I am able to apply it without
any issue.
ERROR: patch seems to be corrupt (line wrapped?)
#74: FILE
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The Kconfig dependency for this driver should include the kernel
configuration FB_MODE_HELPERS which defines the vesa_modes
structure.Without this dependency,the driver build generates a linker
error if build
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
this can be in the comments but should not be there in the commit message.
regards
sudip
The removed option and
On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing
On Wed, May 27, 2015 at 12:07:06PM +, Harisangam, Sharvari (S.) wrote:
On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
Modified the if-else statements to remove unnecessary comparisons
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree
On Wed, May 27, 2015 at 07:53:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
your patch is corrupt and can not be applied.
But even then, can this be called as code improvement?
regards
sudip
Signed-off-by:
On Mon, May 25, 2015 at 07:22:40PM +0300, Dan Carpenter wrote:
On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
the if comparison is always true
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari S shari...@visteon.com
you should not use initials in the
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe
On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
On 25/05/15 13:35, Dan Carpenter wrote:
This is also wrong then.
regards,
dan carpenter
Hi Dan,
Yes, you are right. It is the next sparse warning in line for that file.
Including the fix for that, the patch would be as
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from the intern list
(no idea what that is) were sent to lkml/devel@driverdev lists
for review before actually being applied.
Its the outreachy program. And
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
It'd be better if the approved patches from the intern list
(no idea what that is) were sent to lkml/devel
I haven't been using kernel v4.1 so I haven't seen this warning, but looking
at the code it seems to originate from the two recent patches to remove
_cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml
[1]
that changes del_timer_sync back to del_timer in more places.
On Sat, May 23, 2015 at 07:53:28PM -0700, tolga ceylan wrote:
On 05/12/2015 08:55 PM, Tolga Ceylan wrote:
snip
I haven't gotten a response for this patch. Just checking back.
no response means no one is having anything to say about it. Final say
will be Greg's when he reviews that when he
On Sat, May 23, 2015 at 08:09:54AM -0400, Michael Shuey wrote:
BTW, you keep mentioning a v5 that I sent. Where is that, exactly?
The last round of patches I sent I've kept labeled as PATCH v4, and
I only hit git send-email once. Could you forward me something from
this v5 series, so I could
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare jdelv...@suse.de
Acked-by: Wolfram Sang w...@the-dreams.de
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: Changed to one space instead of tab in i2c_parport_driver.
i2c_parport_cb is made
On Wed, May 20, 2015 at 10:36:04PM +0200, Richard Weinberger wrote:
Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes:
On Wed, 20 May 2015 17:46:44 +0200
Richard Weinberger richard.weinber...@gmail.com wrote:
On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com
On Wed, May 20, 2015 at 10:00:45AM +0100, Ian Abbott wrote:
On 20/05/15 09:22, Sudip Mukherjee wrote:
On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
snip
Converted to use the new device-model parallel port.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
The comment about panel_cb.flags can be removed, it is kept just
for the comment to remind us that it might be better to use
PARPORT_DEV_EXCL.
drivers/staging/panel/panel.c | 14
-by: Sudip Mukherjee su...@vectorindia.org
---
patch: renaming of cnt and one label, added one comment.
instead of probe check for devmodel. Define a default probe.
No change in core functionality.
v5:
a) addition/removal of ports are now handled.
b) is_parport moved
501 - 600 of 962 matches
Mail list logo
