Lets give the parport subsystem a proper name and start
maintaining the files.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
MAINTAINERS | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 86d9398..0eb5ce2 100644
--- a/MAINTAINERS
Modify paride driver to use the new parallel port device model.
Tested-by: Alan Cox gno...@lxorguk.ukuu.org.uk
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
One change after testing by Alan, par_cb is made a local variable
instead of a global one.
drivers/block/paride/paride.c | 57
As of now i2c-parport was connecting to all the available parallel
ports. Lets limit that to maximum of 4 instances and at the same time
define which instance connects to which parallel port.
Tested-by: Jean Delvare jdelv...@suse.de
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
.
Sudip Mukherjee (6):
parport: add device-model to parport subsystem
staging: panel: use new parport device model
i2c-parport: define ports to connect
i2c-parport: use new parport device model
paride: use new parport device model
MAINTAINERS: maintain parport
MAINTAINERS
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare jdelv...@suse.de
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
i2c_parport_cb is made local, devmodel added to driver structure,
and probe removed.
drivers/i2c/busses/i2c
On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare jdelv...@suse.de
Signed-off-by: Sudip Mukherjee su
On Wed, May 20, 2015 at 09:28:16AM -0700, Joe Perches wrote:
On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote:
On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Lets give the parport subsystem a proper name and start
maintaining the files
On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
This patch fixes coding style errors reported by checkpatch.pl for
cb_pcidas64.c, about too long source code lines.
Signed-off-by: Amaury Denoyelle amaury.denoye...@gmail.com
---
drivers/staging/comedi/drivers/cb_pcidas64.c
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.)
wrote:
setup_timer is used for timer parameter setup rather than direct
assignment
Signed
On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
setup_timer is used for timer parameter setup rather than direct
assignment
Signed-off-by: Gnanachandran Dhanapal gdhan...@visteon.com
your From: name and Signed-off-by: names are not matching. They should
be same.
On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
Merge two pr_debug lines with literal strings splitted across several lines
into one single line, simplifying prism2_wep_init error check code.
I would have split this patch into three.
1) introduce pr_fmt and remove
On Mon, May 18, 2015 at 08:51:29PM +0200, Amaury Denoyelle wrote:
Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
Thanks for your review. I was aware of the coding style for multi-line
comments, but I chose to follow
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
From: douglasbsf eng.douglasfigueir...@gmail.com
Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
1) mention which coding style problem you fixed in the commit message.
2) no need to mention the challenge in
On Mon, May 18, 2015 at 11:45:49AM +0200, Wim de With wrote:
This is a patch that fixes the function declarations in
visorbus/visorchipset.c by removing newlines after the function return
type
But this is not an error nor it is a coding style error. Instead your
patch will now introduce new
On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
This patch fixes coding style errors reported by checkpatch.pl for
cb_pcidas64.c, about too long source code lines.
Signed-off-by: Amaury Denoyelle amaury.denoye...@gmail.com
---
snip
}
-/* adjusts the size of hardware
-by: Arek Rusniak arek.r...@gmail.com
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
how to close the bug in bugzilla? The FAQ page says VERIFIED and CLOSE
status, but Arek says he can only see RESOLVED and NEW.
drivers/staging/rtl8712/rtl8712_led.c | 144
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
the if comparison is always true as anything bitwise and-ing with 0x1E
can never be equal to 0x03.
Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id
the if comparison is always true as anything bitwise and-ing with 0x1E
can never be equal to 0x03.
Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881
Reported-by: David Binderman dcb...@hotmail.com
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rts5208
, which should be the ideal case as the detach will be called if
we try to unregister the driver or if the parport is removed.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: addded previous commit id to commit message
Faced this problem while working on the device-model code
On Tue, May 12, 2015 at 02:27:13PM +0300, Dan Carpenter wrote:
On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote:
if we load the module, unload and then again try to load the module, we
will get a stackdump. In the module_exit function we are unregistering
the device
function, which should be the ideal case as the detach will be called if
we try to unregister the driver or if the parport is removed.
Fixes: bb046fef9668 ('staging: panel: register reboot')
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v3: mention commit id in proper format
v2: addded
On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
On 10.05.2015 09:49, Sudip Mukherjee wrote:
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
You're running checkpatch --strict right?
1) multiple blank lines
2) Blank lines aren't necessary before
On Tue, May 12, 2015 at 06:57:46PM -0700, Tolga Ceylan wrote:
To fix sparse warning of incorrect type when calling vfree()
(different address space), added annotation __force.
Garret Kelly posted a similar patch before, please see the discussion
about that patch at
On Sun, May 10, 2015 at 03:01:30PM +0200, Greg Kroah-Hartman wrote:
On Fri, May 08, 2015 at 01:06:19PM +0530, Sudip Mukherjee wrote:
these functions were just defined and never used. after removing the
functions the variable visorchipset_cache_buffers_in_use is becoming
unused, so removed
there variables were not used anywhere and was showing as build warning.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/lustre/lustre/lov/lov_request.c | 4 +---
drivers/staging/lustre/lustre/obdclass/acl.c| 1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff
to unregister the driver or if the parport is removed.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
This was caused by one of my patch :(
Faced this problem while working on the device-model code of
parallelport.
drivers/staging/panel/panel.c | 44
On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
- if (set-set_pga) {
- int len = set-set_oabufs * sizeof(*set-set_pga);
+ if (set-set_pga)
OBD_FREE_LARGE(set-set_pga, len
On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote:
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
checkpatch
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
apart from long line it is also giving warnings
dgap_sindex() is being only called from dgap_getword() which searches
for either ' ' or '\t' or '\n'. this part of the code with '^' at the
beginning is never used.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/dgap/dgap.c | 21 -
1 file changed, 4
these functions were just defined and never used. after removing the
functions the variable visorchipset_cache_buffers_in_use is becoming
unused, so removed it as well.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: combined both patches of v1 together
drivers/staging/unisys
On Fri, May 08, 2015 at 10:34:49AM +0300, Dan Carpenter wrote:
On Fri, May 08, 2015 at 09:54:44AM +0530, Sudip Mukherjee wrote:
On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
the previous patch
On Fri, May 08, 2015 at 05:04:28PM +0800, Huacai Chen wrote:
If image-depth != 1, lynxfb_ops_imageblit() should fallback to call
cfb_imageblit(), not return directly. Otherwise it can't display the
boot logo.
why resending?
regards
sudip
___
devel
On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
the previous patch of the series made this variable unused.
What do you mean? There was only one other patch in this series, never
send a patch that causes
On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers
move the cleanup function before the remove call as the next patch of
the series is going to use that.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/dgap/dgap.c | 61 ++---
1 file changed, 30 insertions(+), 31 deletions(-)
diff
On Wed, May 06, 2015 at 10:06:21AM +0300, Dan Carpenter wrote:
Looks good.
but its applying to linux-next and not applying to staging-testing.
There are a few patches which Greg applied to staging-testing before the
merge-window but they were not applied to staging-next. I guess he has
been
On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote:
Clean up spacing in some variable declarations, to be more consistent.
It's small, but I need to start somewhere. Please let me know if I'm not
adhering to proper procedure for trivial cleanups.
these comments should not come here.
there variables were not used anywhere and was showing as build warning.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/lustre/lustre/llite/file.c | 2 --
drivers/staging/lustre/lustre/llite/llite_lib.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
Errors found by checkpatch.pl.
ERROR: code indent should use tabs where possible
/drivers/staging/comedi/drivers/das16m1.c:49
/drivers/staging/comedi/drivers/das16m1.c:50
Signed-off-by: Jaime Arrocha j...@kerneldev.net
---
you
On Mon, Apr 27, 2015 at 02:36:53PM +, Teddy Wang 王力强 wrote:
The image-depth != 1 case means the image is color.
The current driver only does 2d in mono color image. I think we can let the
driver fall back to cfb_imageblit() currently. Then we implement the color
image 2d later.
If
On Mon, Apr 27, 2015 at 04:10:53PM +0800, Huacai Chen wrote:
If image-depth != 1, lynxfb_ops_imageblit() should fallback to call
cfb_imageblit(), not return directly. Otherwise it can't display the
boot logo.
I think it is wrong. lynxfb_ops_imageblit() is the imageblit callback
if 2D
On Thu, Apr 23, 2015 at 05:04:08PM -0400, Charles Rose wrote:
This patch fixes space prohibited errors reported by checkpatch.pl
and related indentation. The module builds without error.
Signed-off-by: Charles Rose charles.rose.li...@gmail.com
snip
- if ( x == 800 y == 600 )
-
On Fri, Apr 24, 2015 at 03:33:58PM +0800, 陈华才 wrote:
Hi, Sudip,
Upstream driver still can't show logo, we are debugging.
Hi Huacai,
I checked with the upstream driver only.
I checked with next-20150423 and it showed me the penguin logo on upper
left hand corner of my screen when
On Thu, Apr 23, 2015 at 10:29:48AM +0530, Sudip Mukherjee wrote:
On Thu, Apr 23, 2015 at 12:43:40PM +0800, 陈华才 wrote:
Hi, Teddy,
In the code It seems that only SM718/SM750 is supported in Sudip's driver.
Hi Huacai,
The driver that Teddy gave me originally was a mix driver of
SM712
removed the smtc_alloc_fb_info() and smtc_free_fb_info() functions which
were not used anymore.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/sm7xxfb
On Thu, Apr 23, 2015 at 03:00:14PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
This patch removes unused return variable in this file.
Signed-off-by: Gnanachandran Dhanapal gdhan...@visteon.com
---
your From: name and Signed-off-by: name is not matching.
regards
sudip
On Thu, Apr 23, 2015 at 12:43:40PM +0800, 陈华才 wrote:
Hi, Teddy,
In the code It seems that only SM718/SM750 is supported in Sudip's driver.
Hi Huacai,
The driver that Teddy gave me originally was a mix driver of
SM712/SM750/SM502. The one in staging is only SM750, since we already
have SM712
, not CONFIG_FB_SM7XX.
Thus fix it to make the sm750fb can be built successfully.
I always used to build sm750fb and sm7xxfb together, so failed to notice
the error. thanks.
Acked-by: Sudip Mukherjee su...@vectorindia.org
___
devel mailing list
de
-by: Sudip Mukherjee su...@vectorindia.org
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Apr 15, 2015 at 03:31:15PM +0200, Greg Kroah-Hartman wrote:
On Wed, Apr 15, 2015 at 01:18:41PM +0530, Sudip Mukherjee wrote:
@@ -29,6 +31,7 @@
snip
+struct bus_type parport_bus_type = {
+ .name = parport,
+};
+EXPORT_SYMBOL(parport_bus_type);
They bus type
of this patch series.
snip
On Wed, Apr 15, 2015 at 01:18:41PM +0530, Sudip Mukherjee wrote:
Don't print warnings on kmalloc() failure.
I think kzalloc() is better here. That way if the -init_state()
functions don't set it, then we know it's zeroed out.
yes, i will.
Infact
as parport starts using the device-model, update the documentation
to show the newly added functions and update TODO with some other
planned modifications.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/parport-lowlevel.txt | 49
modified the required functions to start using the new parport
device-model
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers
converted.
I am also in the process of procuring a parallel port printer so that
the code can properly be maintained and can be marked as Maintained.
Sudip Mukherjee (4):
parport: modify parport subsystem to use devicemodel
parport: update TODO and documentation
i2c-parport: use device-model
modified the functions to use the new device-model of parport.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/i2c/busses/i2c-parport.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-parport.c b/drivers/i2c/busses
On Wed, Apr 15, 2015 at 11:33:59AM +0300, Dan Carpenter wrote:
On Wed, Apr 15, 2015 at 01:18:41PM +0530, Sudip Mukherjee wrote:
The difference between parport_register_device() and
parport_register_dev() isn't clear from the name.
i kept the name similar deliberately as I thought that after
On Wed, Apr 15, 2015 at 12:45:00PM +0300, Dan Carpenter wrote:
On Wed, Apr 15, 2015 at 02:50:55PM +0530, Sudip Mukherjee wrote:
snip
+ tmp-name = name;
I wonder who frees this name variable. My concern is that it gets
freed before we are done using it or something. (I have
On Sat, Apr 11, 2015 at 03:20:43PM +0300, Giedrius Statkevičius wrote:
On Sat, 11 Apr 2015, Sudip Mukherjee wrote:
On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote:
Well, I think this is wrong because:
yes. I looked at many of the tty drivers and all of them have used
On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote:
Remove the dead code protected by in_user in dgnc_tty_write() because it is
set
to 0 and never changed to 1 thus the code in ifs never gets executed.
dgnc_tty_write() is being called by dgnc_tty_put_char() and it is also
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/drivers/portman2x4.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff
On Wed, Apr 08, 2015 at 02:44:37PM +0300, Dan Carpenter wrote:
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
Then we convert one driver to use the new function pointer and see if
it simplifies the code. If so we can transition the others as well. If
not then we give up.
i
code from parport_register_driver.
Sudip Mukherjee (14):
parport: return value of attach and parport_register_driver
ALSA: portman2x4: return proper error values from attach
ALSA: mts64: return proper error values from attach
staging: panel: return proper error values from attach
spi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/drivers/mts64.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/spi/spi-butterfly.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/scsi/imm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
also return the proper error code in module_init.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/net/plip/plip.c | 16 ++--
1 file
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/scsi/ppa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/pps/generators/pps_gen_parport.c | 9 +
1 file changed, 5 insertions(+), 4 deletions
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/spi/spi-lm70llp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
only mark attach as failed only if it has never
returned a 0.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/parport/share.c | 20 +++-
include/linux/parport.h | 2 +-
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/parport/share.c b/drivers
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/i2c/busses/i2c-parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/pps/clients/pps_parport.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
now that we are monitoring the return value from attach, make the
required changes to return proper value from its attach function.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/char/ppdev.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers
On Wed, Apr 08, 2015 at 04:32:57PM +0300, Sergei Shtylyov wrote:
Hello.
On 4/8/2015 2:20 PM, Sudip Mukherjee wrote:
now that we are monitoring the return value from attach, make the
So you've first changed the method prototype and follow up with
the changes to the actual
marking
keypad_initialized and lcd.initialized as false. so this part of the
code will never execute.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/panel/panel.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers
On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote:
On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote:
I hadn't looked at this driver much before. It sucks that
parport_driver -attach() functions can't fail...
then maybe, we can change the code of parport
On Mon, Apr 06, 2015 at 10:02:27PM -0400, Nickolaus Woodruff wrote:
This patch fixes the following sparse warning:
CHECK drivers/staging/lustre/lustre/libcfs/hash.c
drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
'cfs_sched_rehash' was not declared. Should it be static?
On Tue, Apr 07, 2015 at 05:11:15PM +0300, Giedrius Statkevičius wrote:
If one of the allocations of memory for storing a channel information struct
fails then free all the successful allocations and return -ENOMEM that gets
propogated to the pci layer. Also, remove a bogus skipping in the next
On Tue, Apr 07, 2015 at 11:24:43AM -0300, Fabio Estevam wrote:
On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such
commit.
I have already seen the patch. But being the maintainer
On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote:
now. do you think it is worth that i pick up the code and modify
it for our latest kernel and submit to Greg ?
If you have some parport hardware, and want to take it on, that would be
great. The code needs a
On Tue, Apr 07, 2015 at 11:01:57AM -0300, Fabio Estevam wrote:
On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Hi Greg,
I saw that you have reveretd one commit
6ad6b5ed3e2472b399b567a2f036006bf25df467
Staging: sm750fb: Fix C99 Comments in staging
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
On Tue, Apr 07, 2015
On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
Hi Greg,
I saw that you have reveretd one commit
6ad6b5ed3e2472b399b567a2f036006bf25df467
Staging: sm750fb: Fix C99 Comments in staging/sm750fb.
I was trying
Hi Greg,
I saw that you have reveretd one commit
6ad6b5ed3e2472b399b567a2f036006bf25df467
Staging: sm750fb: Fix C99 Comments in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to
find that in my personal mails nor in lkml. can you please let me know
when it was
On Tue, Apr 07, 2015 at 02:25:39PM +, Dhere, Chaitanya (C.) wrote:
This change was detected with the help of coccinelle tool.
It performs the same function as kzalloc amd memcpy.
Signed-off-by: Chaitanya Dhere cvija...@visteon.com
your From: name and this name does not match.
regards
On Sun, Apr 05, 2015 at 07:11:47AM +0530, Amitoj Kaur Chawla wrote:
Removes extra parentheses around bitwise right shift operation.
this is not applying. please work against staging-testing.
regards
sudip
___
devel mailing list
On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning:
symbol 'ieee80211_check_auth_response' was not declared. Should it be
On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote:
On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
Changed bool to u8 to get rid of sparse warning.
but i am not getting this warning. which version
On Sat, Mar 28, 2015 at 05:26:34PM -0700, Shirish Gajera wrote:
On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote:
//richard
Are you sure you want me to do this changes. Because it will conflict
the things written on http://kernelnewbies.org/
where is the conflict? you
disable the pci device when the module exits.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 149286e..77f51a0 100644
before starting to access any address inside the PCI region we should
reserve the resource and release the resource when the module exits.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
Changed bool to u8 to get rid of sparse warning.
but i am not getting this warning. which version of sparse are you
using?
and why you have sent the same patch two times?
regards
sudip
Signed-off-by: Piotr Witoslawski pwi...@gmail.com
we were just returning -1 to the calling function which was again
returning that if the module failed to load. Now we are returning the
actual error codes.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/visorchipset/file.c | 12 +++-
1 file changed, 7
after registering the major numbers if the cdev_add fails then we were
not releasing the major numbers. now we are doing that.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/visorchipset/file.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On Fri, Mar 27, 2015 at 09:47:16AM +0100, Greg Kroah-Hartman wrote:
On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote:
}
rc = cdev_add(file_cdev, MKDEV(MAJOR(major_dev), 0), 1);
if (rc 0) {
unregister_chrdev_region(major_dev, 1
rearranged the functions to get rid of the forward declarations.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/unisys/visorchipset/file.c | 80 ++
1 file changed, 37 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/unisys
after registering the major numbers if the cdev_add fails then we were
not releasing the major numbers. now we are doing that.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: removed extra space
drivers/staging/unisys/visorchipset/file.c | 4 +++-
1 file changed, 3 insertions
we were just returning -1 to the calling function which was again
returning that if the module failed to load. Now we are returning the
actual error codes.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
v2: removed extra space
drivers/staging/unisys/visorchipset/file.c | 12
601 - 700 of 962 matches
Mail list logo
