[PATCH] staging: octeon-usb: fix misspelled "re-enable"

Fixes misspelled "re-enable" in comment. Reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/octeon-usb/octeon-hcd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-h

[PATCH] staging: mt7621-mmc: place a check for sscanf

Placed a check for the return value of sscanf. -EINVAL is returned if the value is anything other than expected. Reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/mt7621-mmc/dbg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging: gasket: fix code indent for conditional statement

Fixed a coding style issue related to indentation. Reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket

[PATCH] staging: lustre: lnet: return of an error code should be negative

Return value of error codes should typically be negative. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lnet/selftest/framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustr

[PATCH] staging: lustre: lnet: remove null check before kfree

Since kfree(NULL) is safe there is no need to place a check before it. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lnet/lnet/lib-move.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s

[PATCH] staging: lustre: lnet: prefer kcalloc over kzalloc with multiply

Use kcalloc for allocating an array instead of kzalloc with multiply. kcalloc is the preferred API. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lnet/lnet/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] staging: lustre: lmv: prefer kstrto to single variable sscanf

A kstrto should be preferred for a single variable instead of sscanf to convert string to the the required datatype. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 14 -- 1 file chan

[PATCH] staging: rts5208: sd: fix misspelled constant

Fixes the misspelled constant to 'SWITCH_NO_ERR'. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/rts5208/sd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts520

[PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers

Fixed coding style issue regarding null comparison at multiple lines. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- v2: Updated the patch title and description. drivers/staging/greybus/camera.c | 16 1 file changed, 8 inse

Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers

On Mon, Jan 8, 2018 at 8:15 PM, Johan Hovold wrote: > Since you're not really fixing anything here, besides silencing a > checkpatch suggestion when run with the --strict option (or on staging > code), I suggest you reword you commit summary (Subject) to, for > example: > >

[PATCH] Staging: greybus: Fix multiple checks for null pointers

Fixes the following coding style issue as noted by checkpatch.pl at multiple lines: Comparison to NULL could be written "!token" Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/greybus/camera.c | 16 1 file changed, 8 insertions

[PATCH v2] Staging: iio: cdc: Prefer using BIT macro

This patch fixes the following checkpatch.pl issue at multiple lines: CHECK: Prefer using the BIT macro Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- v2: Added the specific driver being changed to the patch title and the appropriate fixes as suggested. drivers/staging/i

Re: [PATCH] Staging: iio: Prefer using BIT macro

On Sat, Jan 6, 2018 at 6:12 PM, Jonathan Cameron <ji...@kernel.org> wrote: > On Thu, 4 Jan 2018 22:06:31 +0530 > Sumit Pundir <pundirsumi...@gmail.com> wrote: > > Patch title needs to mention the specific driver being changed. > >> This patch fixes the followin

[PATCH] Staging: lustre: Fix prefer kcalloc over kzalloc with multiply

Use kcalloc for allocating an array instead of kzalloc with multiply. kcalloc is the preferred API. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH] Staging: lustre: Fix prefer seq_puts to seq_printf

Use seq_puts() for strings without format specifiers instead of seq_printf(). Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

am > > >> This patch fixes the following checkpatch.pl issue at multiple lines: >> >> WARNING: Prefer 'unsigned int' to bare use of 'unsigned' >> >> Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> >> --- >> drivers/staging/irda/drivers/act200l-sir.

[PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

This patch fixes the following checkpatch.pl issue at multiple lines: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/irda/drivers/act200l-sir.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH] Staging: iio: Prefer using BIT macro

This patch fixes the following checkpatch.pl error at multiple lines: CHECK: Prefer using the BIT macro Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/iio/cdc/ad7152.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/stagi

[PATCH] Staging: greybus: audio_codec.c: Change uint32_t to u32

This patch fixes the following checkpatch.pl issue at multiple lines: CHECK: Prefer kernel type 'u32' over 'uint32_t' + uint32_t format, rate; Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/greybus/audio_codec.c | 6 +++--- 1 file changed, 3 insertions

[PATCH] Staging: greybus: audio_codec.h: Change uint32_t to u32

' + uint32_t rate, u8 channels, Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/greybus/audio_codec.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/g

[PATCH] Staging: vt6656: Fix unnecessary parantheses

eeprom[EEP_OFS_MINOR_VER] >= 0x4' Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/staging/vt6656/main_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 1b51b83.

[PATCH] Staging: vt6656: Fix unnecessary 'out of memory' message

This patch fixes one of the warnings as noted by checkpatch.pl related to unnecessary 'out of memory' message. This patch fixes the following checkpatch.pl error: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- drivers/s

[PATCH] Staging: vt6656: fix unnecessary parantheses

This patch fixes a coding style issue as noted by checkpatch.pl related to unnecessary parentheses. This patch fixes the following checkpatch.pl warning: WARNING: Unnecessary parentheses around 'priv->basic_rates'. Signed-off-by: Sumit Pundir <pundirsumi...@gmail.com> --- driver