Instead of using a private copy of struct net_device_stats in
struct octeon_ethernet, use stats from struct net_device. Also remove
the now unnecessary .ndo_get_stats function.
Signed-off-by: Tobias Klauser <tklau...@distanz.ch>
---
drivers/staging/octeon/ethernet-rx.c | 6 +++---
d
...@marvell.com>
Cc: Stephen Hemminger <step...@networkplumber.org>
Signed-off-by: Tobias Klauser <tklau...@distanz.ch>
---
arch/m68k/emu/nfeth.c | 1 -
drivers/net/ethernet/cavium/liquidio/lio_main.c| 1 -
drivers/net/ethernet/cavium/liquidio/lio_v
Make hv_irq_mask and hv_irq_unmask static as they are only used in
pci-hyperv.c
This fixes a sparse warning.
Signed-off-by: Tobias Klauser <tklau...@distanz.ch>
---
drivers/pci/host/pci-hyperv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/ho
On 2015-01-21 at 23:56:06 +0100, Ahmad Hassan ahmad.hassan...@gmail.com wrote:
Removed ERR macro since it is not used anymore in the emxx_udc.c file.
Signed-off-by: Ahmad Hassan ahmad.hassan...@gmail.com
---
drivers/staging/emxx_udc/emxx_udc.h | 1 -
1 file changed, 1 deletion(-)
diff
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick
stephanie.s.wall...@intel.com wrote:
This is where we handle media specific packets and transport. The MS driver
interfaces with a media agnostic (MA) driver via a series of transfer pairs.
Transfer pairs consist of a set of functions to pass
On 2014-09-22 at 23:28:03 +0200, Mark Einon mark.ei...@gmail.com wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
There are no known issues at this time.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
This patch will
On 2014-09-23 at 11:46:15 +0200, Mark Einon mark.ei...@gmail.com wrote:
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
+/* et131x_rx_dma_memory_alloc
+ *
+ * Allocates Free buffer ring 1
On 2014-09-17 at 21:17:29 +0200, Benedict Boerger
benedict.boer...@cs.tu-dortmund.de wrote:
Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it
be static?
The function CAM_read_entry is not used and therefore deleted.
Your patch is missing a Signed-off-by line.
The pci_state member of struct vnt_private is used nowhere in the code,
so remove it. Supposedly it was used to save the PCI configuration space
which is now done using pci_save_state().
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/vt6655/device.h | 4
1 file
ethtool (and SIOCETHTOOL in particular) is part of Linux since the
pre-git era, it thus makes no sense no sense to make the include of
linux/ethtool.h conditional. Also remove the unused define
DEVICE_ETHTOOL_IOCTL_SUPPORT.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging
Instead of using an own copy of struct net_device_stats in struct
vnt_private, use stats from struct net_device. Also remove the thus
unnecessary device_get_stats(), as it would now just return
netdev-stats, which is the default in dev_get_stats().
Signed-off-by: Tobias Klauser tklau
On 2014-09-08 at 21:02:49 +0200, Adrian Nicoara anico...@uwaterloo.ca wrote:
Cleanup checkpatch.pl warnings.
Please state which warning this is fixing. Same goes for patches 1-3.
Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca
---
Somehow I missed the comment Tobias made on the line
Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.
On 2014-09-07 at 20:28:25 +0200, anicoara anico...@uwaterloo.ca wrote:
No changelog text? Please add a short notice, describing why this change
is done.
Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.
On 2014-09-07 at 20:25:35 +0200, anicoara anico...@uwaterloo.ca wrote:
Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca
No changelog text? Please add a short
Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.
On 2014-09-07 at 20:24:03 +0200, anicoara anico...@uwaterloo.ca wrote:
Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca
No changelog text? Please add a short
Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.
On 2014-09-07 at 20:21:41 +0200, anicoara anico...@uwaterloo.ca wrote:
Changelog text is missing. Please add a short notice, describing why
this change is done.
On 2014-08-31 at 09:57:01 +0200, Eli Billauer eli.billa...@gmail.com wrote:
This driver has been functional and stable throughout the year it has spent
in the staging area. It has been patched for minor bugs, coding style issues
and improvements during this period, so I suppose its time has
On 2014-08-13 at 21:11:19 +0200, Jeshwanth Kumar N K jeshkumar...@gmail.com
wrote:
On Wed, Aug 13, 2014 at 12:06 PM, Tobias Klauser tklau...@distanz.ch
wrote:
On 2014-08-12 at 20:54:48 +0200, Jeshwanth Kumar N K
jeshkumar...@gmail.com wrote:
removed goto label, and directly returning
On 2014-08-12 at 20:54:48 +0200, Jeshwanth Kumar N K jeshkumar...@gmail.com
wrote:
removed goto label, and directly returning 0 not through goto.
Signed-off-by: Jeshwanth Kumar N K jeshkumar...@gmail.com
---
drivers/staging/wlan-ng/prism2mgmt.c | 14 --
1 file changed, 4
On 2014-08-11 at 18:15:58 +0200, Jeshwanth Kumar N K jeshkumar...@gmail.com
wrote:
Fixes up warning, break is not useful after a goto or return statement
Signed-off-by: Jeshwanth Kumar N K jeshkumar...@gmail.com
---
drivers/staging/wlan-ng/prism2mgmt.c | 3 ---
1 file changed, 3
On 2014-07-30 at 12:41:59 +0200, Anil Belur ask...@gmail.com wrote:
From: Anil Belur ask...@gmail.com
This line is only necessary if you're sending the patch on behalf of
someone else. Also there is no need to have the 1/1 in the Subject line
as you're only sending one patch, not an entire
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com
fernando.apesteg...@gmail.com wrote:
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to the definition of the pci device table.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
This change is
On 2014-07-28 at 09:58:12 +0200, Anil Belur ask...@gmail.com wrote:
From: Anil Belur ask...@gmail.com
- private_ioctl() the internally calls copy_{to,from}_user() and does
not use '__user' while refrencing user space pointers.
- this patch passes __user annotation as a cast, when the
of stats counters to the more
common postfix increment idiom.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/wlan-ng/hfa384x_usb.c | 18 +++
drivers/staging/wlan-ng/p80211netdev.c | 40 ++
drivers/staging/wlan-ng/p80211netdev.h | 1
Instead of using an own copy of struct net_device_stats in struct nic,
use stats from struct net_device. Also remove the thus unnecessary
.ndo_get_stats function, as it would now just return netdev-stats,
which is the default in dev_get_stats().
Signed-off-by: Tobias Klauser tklau...@distanz.ch
Instead of using an own copy of struct net_device_stats in struct
et131x_adapter, use stats from struct net_device.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/et131x/et131x.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git
The memory for struct net_device private data is allocated using
kzalloc/vzalloc in alloc_netdev_mqs, thus there is no need to zero it
again in the driver.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/gdm72xx/gdm_wimax.c | 2 --
1 file changed, 2 deletions(-)
diff --git
No need for two return statements, just call xillybus_do_cleanup() in
case of an error before returning.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/xillybus/xillybus_pcie.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
whether it makes sense to apply the patch
for the time being.
Thanks
Tobias
Thanks,
Eli
On 18/06/14 15:10, Tobias Klauser wrote:
No need for two return statements, just call xillybus_do_cleanup() in
case of an error before returning.
Signed-off-by: Tobias Klausertklau...@distanz.ch
iput() already checks for the inode being NULL, thus it's unnecessary to
check before calling.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/lustre/lustre/llite/llite_lib.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre
On 2014-05-20 at 15:04:50 +0200, Matthias Beyer m...@beyermatthias.de wrote:
Hi,
I did some cleanup for the file
drivers/staging/bcm/Bcmchar.c
The patches shorten some lines and do some code outsourcing from large
functions
into smaller ones.
Can someone tell me how to compile
On 2014-05-12 at 17:22:46 +0200, Denis Pithon denis.pit...@gmail.com wrote:
Extract new static function from p80211netdev_rx_bh() to fix coding
style issue (too many leading tabs).
Signed-off-by: Denis Pithon denis.pit...@gmail.com
---
drivers/staging/wlan-ng/p80211netdev.c | 74
On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote:
This patch replaced printk with pr_info.
It would be even better to use dev_err(), since these are error messages
and you can use the struct dev from link-dev. You can also drop the
ft1000: prefix then.
Cheers
Tobias
ethernet header. Make that clear by specifying the
proper destination buffer.
Also remove the unnecessary casts of the source argument.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/vt6656/rxtx.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
pFifoHead is dereferenced before it is checked for NULL which implies it
can potentially be NULL. Thus move the check before the dereference.
Found by the coverity scanner, CID 1127221.
Reported-by: scan-ad...@coverity.com
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging
On 2014-04-25 at 15:11:05 +0200, Dan Carpenter dan.carpen...@oracle.com wrote:
On Fri, Apr 25, 2014 at 01:54:51PM +0200, Tobias Klauser wrote:
pFifoHead is dereferenced before it is checked for NULL which implies it
can potentially be NULL. Thus move the check before the dereference
NULL check warning reported by the coverity
scanner in CID 1127221.
Cc: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/vt6656/rxtx.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging
pfncount is of type u32 and thus can never be smaller than 0.
Found by the coverity scanner, CID 143213.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/hv/channel.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv
On 2014-03-05 at 03:37:15 +0100, Daeseok Youn daeseok.y...@gmail.com wrote:
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn daeseok.y...@gmail.com wrote:
It doesn't need to assign name array address to np pointer.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/linux.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
The C99 specification states in section 6.11.5:
The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
---
drivers/staging/lustre/lustre/lov/lov_object.c
On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn daeseok.y...@gmail.com wrote:
2014-03-05 19:13 GMT+09:00 Tobias Klauser tklau...@distanz.ch:
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn daeseok.y...@gmail.com
wrote:
It doesn't need to assign name array address to np pointer.
Signed
42 matches
Mail list logo
