[PATCH] staging: ks7010: remove me from CC list

I lost interest in this driver years ago because I could't keep up with testing the incoming janitorial patches. So, drop me from CC. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/TODO b/drivers/staging

Re: [PATCH 00/34] treewide: simplify getting the adapter of an I2C client

Hi Peter, > Similar things go on in: > > drivers/hwmon/lm90.c > drivers/leds/leds-is31fl319x.c > drivers/of/unittest.c Right. I'll fix them, too. > And drivers/rtc/rtc-fm3130.c has a couple of these: These are fixed in patch 26 of this series. Thanks and happy hacking, Wolfram

[PATCH 31/34] staging: media: soc_camera: imx074: simplify getting the adapter of a client

We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/imx074.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 32/34] staging: media: soc_camera: mt9t031: simplify getting the adapter of a client

We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/mt9t031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 00/34] treewide: simplify getting the adapter of an I2C client

nch can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/no_to_adapter Please apply the patches to the individual subsystem trees. There are no dependencies. Thanks and kind regards, Wolfram Wolfram Sang (34): clk: clk-cdce706: simplify getting the adapter o

[PATCH 33/34] staging: media: soc_camera: soc_mt9v022: simplify getting the adapter of a client

We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 10/10] docs: fix broken documentation links

located at > Documentation/firmware-guide/acpi/enumeration.rst. > > > Method 2: Instantiate the devices explicitly For this I2C part: Reviewed-by: Wolfram Sang signature.asc Description: PGP signature ___ devel mailing list de...@li

[PATCH 1/1] staging: media: imx: imx7-mipi-csis: simplify getting .driver_data

We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH 48/61] staging: iio: adc: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/iio/adc/ad7606_par

[PATCH 47/61] staging: greybus: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/greybus/arche-platform

[PATCH 00/61] tree-wide: simplify getting .drvdata

t_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - >dev + d ...> Kind regards, Wolfram Wolfram Sang (61): ARM: plat-samsung: simplify getting .drvdata ata: simplify getting .drvdata auxdisplay: simplify getting .drvdata bus: simplif

[PATCH 49/61] staging: nvec: simplify getting .drvdata

We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/staging/nvec/nvec.c | 6 ++

Re: [PATCH v3 07/20] i2c: Remove depends on HAS_DMA in case of platform dependency

On Tue, Apr 17, 2018 at 07:49:07PM +0200, Geert Uytterhoeven wrote: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol,

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

> To play it safe, you want to postpone the subsystem patches until the core > part has landed upstream. I will rebase and resubmit after v4.17-rc1. Thanks for the heads up. I'll wait for the rebased patch then and apply it after rc1 for 4.17. signature.asc Description: PGP signature

Re: [PATCH v2 00/21] Allow compile-testing NO_DMA (drivers)

> To avoid allmodconfig/allyesconfig regressions on NO_DMA=y platforms, > this (drivers) series should be applied after the previous (core) > series (but not many people may notice/care ;-) I still don't get if there is a dependency on the core patches. I.e. shall I apply the subsystem patch now

Re: ks7010 firmware upload fail

Tobin, > My question is should I be digging further into the MMC code or be doing > something else with the driver code? So, you haven't found any branch that worked? No plain v4.9 or the gen3-sdio branch from my tree? Regards, Wolfram signature.asc Description: PGP signature

Re: drivers/staging/ks7010 hardware test

Hi Tobin, > I began testing the card you sent today. I'm getting a firmware load > error like you mentioned. Nice. Firstly, that means the card is alive and survived the mailing. > I checked out code from when you originally merged into staging, > however I built the module in a 4.9 kernel. I

Re: [bug report] staging: ks7010: add driver from Nanonote extra-repository

On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote: Adding Tobin to CC, he is way more into the driver than I am these days... > Hello Wolfram Sang, > > The patch 13a9930d15b4: "staging: ks7010: add driver from Nanonote > extra-repository" from May 31, 2016,

Re: [PATCH RFC] remove custom Michael MIC implementation

Hi Tobin, > over this last month :). This is the reason for this email. Can I > please take you up on the offer of the SDW-823 card, if you can find > it? Sure, I have it here. Just mail me (privately) the address to send it to and I'll ship right away. > Secondly, I think I should spend some

Re: ks7010 endianness question

> I think we can call this question resolved. Remove the comment and > change the hostif_hdr description to > > struct hostif_hdr { > __be16 size; > __be16 event; > } __packed; > > Are you happy with this? Yes, I trust you. signature.asc Description: PGP signature

Re: [PATCH RFC] remove custom Michael MIC implementation

Hi, > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > a SDW-823 and should use the ks7010 driver. Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for which no driver is known: https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29 For SDW-821 (SD

Re: [PATCH RFC] remove custom Michael MIC implementation

> The code is untested, I have hardware in the mail. Cool! > If any one is interested and has any comments I would really like to > hear them. I am open to all suggestions (even down to trivial coding > style issues). I'll just repeat that the key move to get this driver out of staging is to

Re: Michael MIC

Hi, > Is there some technical reason why module ks7010 includes a > implementation of Michael MIC instead of using the implementation in > crypto/? > > Or is this covered by the statement from the TODO > > - check what other upstream wireless mechanisms can be used instead of the > custom

Re: [PATCH 2/2] staging: ks7010: remove dead code

On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote: > Driver has dead code compiled out using preprocessor directives. TODO > file asks for these not to be removed - ignore this. Why? signature.asc Description: PGP signature ___ devel

Re: [PATCH v2 00/10] staging: ks7010: Fine-tuning for a SDIO card driver

On Thu, Aug 11, 2016 at 07:17:12AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > > Further update suggestions were taken into account Which ones? Please describe them to ease review. > after a patch was applied from static source code analysis. I

Re: staging: ks7010: Replace three printk() calls by pr_err()

> Nothing what I would find noteworthy for increasing the usage of a function > like "dev_err". > > Are you on "a mission" to improve software around logging calls a bit more? I have two of those cards and I would like to know which one caused an error. dev_err helps with exactly that.

[PATCH 3/6] staging: media: lirc: lirc_sasem: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/media/lirc/lirc_sasem.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/medi

[PATCH 2/6] staging: media: lirc: lirc_imon: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/media/lirc/lirc_imon.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/s

[PATCH 6/6] staging: vt6656: main_usb: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/vt6656/main_usb.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/

[PATCH 0/6] staging: don't print error when allocating urb fails

we talked about it at LCJ in Tokyo a few weeks ago. Wolfram Sang (6): staging: comedi: drivers: usbduxfast: don't print error when allocating urb fails staging: media: lirc: lirc_imon: don't print error when allocating urb fails staging: media: lirc: lirc_sasem: don't print error when

[PATCH 4/6] staging: most: hdm-usb: hdm_usb: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/most/hdm-usb/hdm_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/stagin

[PATCH 1/6] staging: comedi: drivers: usbduxfast: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/comedi/drivers/usbduxfast.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/d

[PATCH 5/6] staging: rtl8192u: r8192U_core: don't print error when allocating urb fails

kmalloc will print enough information in case of failure. Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> --- drivers/staging/rtl8192u/r8192U_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/s

Re: staging: ks7010: Replace three printk() calls by pr_err()

On Wed, Aug 10, 2016 at 09:41:37PM +0200, SF Markus Elfring wrote: > >> Please and and use pr_fmt > > > > Can't we use dev_* on the SDIO device? > > How should a connection be constructed from the data structure > "sdio_device_id" > to the corresponding device information for such an use case?

Re: [PATCH] staging: ks7010: declare private functions static

On Tue, Jul 26, 2016 at 06:48:00AM +, Nicholas Mc Guire wrote: > On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote: > > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote: > > > Private functions in ks_hostif.c can be declared static. > > >

Re: [PATCH] staging: ks7010: declare private functions static

On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote: > Private functions in ks_hostif.c can be declared static. > > Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote > extra-repository") > > Signed-off-by: Nicholas Mc Guire <hof...@o

Re: [PATCH] staging: ks7010: fix wait_for_completion_interruptible_timeout return handling

On Mon, Jul 25, 2016 at 09:21:50PM +0200, Nicholas Mc Guire wrote: > wait_for_completion_interruptible_timeout return 0 on timeout and > -ERESTARTSYS if interrupted. The check for > !wait_for_completion_interruptible_timeout() would report an interrupt > as timeout. Further, while HZ/50 will

Re: staging: ks7010: Return directly after a failed kmalloc()

On Fri, Jul 22, 2016 at 09:36:53AM +0200, SF Markus Elfring wrote: > >> I guess that further clarification might be needed for affected > >> implementation details. > > > > That's OK, too. > > > > Acked-by: Wolfram Sang <w...@the-dreams.de

Re: staging: ks7010: Delete unnecessary uses of the variable "retval"

> Do you find such a source code transformation useful? No. I already gave that answer by agreeing to Julia's viewpoint. signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote: > Fixed coding style issue: > Enclose multiple statements macros definition in a do while loop. > Use one space around binary operators. > > Signed-off-by: Bing Sun <sunb...@redflag-linux.com> Reviewed-by: Wolfram San

Re: staging: ks7010: Delete unnecessary uses of the variable "retval"

On Thu, Jul 21, 2016 at 03:35:03PM +0200, SF Markus Elfring wrote: > > if (atomic_read(>sleepstatus.status) == 0) { > > rw_data = GCR_B_DOZE; > > - retval = > > - ks7010_sdio_write(priv, GCR_B, _data, > >

Re: staging: ks7010: Delete unnecessary uses of the variable "retval"

> > * Do you really want to assign every return value from a function call > > to an extra variable before it is used again? > > If it's a choice between 1) function call on many lines, 2) function call > over 80 characters, and 3) extra variable, I definitely prefer the extra > variable. +1

Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval"

On Thu, Jul 21, 2016 at 09:26:33AM +0200, Julia Lawall wrote: > > > On Thu, 21 Jul 2016, Wolfram Sang wrote: > > > > > > >>> if (atomic_read(>sleepstatus.status) == 0) { > > > >>>

Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval"

> >>> if (atomic_read(>sleepstatus.status) == 0) { > >>> rw_data = GCR_B_DOZE; > >>> - retval = > >>> - ks7010_sdio_write(priv, GCR_B, _data, sizeof(rw_data)); > >>> - if (retval) { > >>> + if (ks7010_sdio_write(priv, > >>> +

Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc()

why the function has such strange error values... > > > > Agreed. Markus, can you check if we can use -ENOMEM in those places. > > I find that I do not know this software good enough at the moment > so that I could safely decide on the shown special error values. > I guess tha

Re: staging: ks7010: Rename jump labels

Thank you very much for the heads up, Jean! signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

On Sun, Jul 17, 2016 at 08:51:39PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 19:40:47 +0200 > > > > Three variables will be set to an appropriate value a bit later. > >

Re: [PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote: > Fixed coding style issue: > Enclose multiple statements macros definition in a do while loop. > Use one space around binary operators. > > Signed-off-by: Bing Sun Looks good for what it is. One comment below.

Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces

On Sun, Jul 17, 2016 at 08:55:41PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 18:39:03 +0200 > > > > Do not use curly brackets at some source code places > > where a single

Re: [PATCH 4/9] staging: ks7010: Rename jump labels

On Sun, Jul 17, 2016 at 08:20:12PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 17 Jul 2016 16:26:18 +0200 > > Adjust jump targets according to the Linux coding style convention. Really? Is that documented somewhere? Quoting Jean Delvare:

Re: [PATCH 7/9] staging: ks7010: Replace three printk() calls by pr_err()

On Sun, Jul 17, 2016 at 01:26:03PM -0700, Joe Perches wrote: > On Sun, 2016-07-17 at 20:27 +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 19:12:27 +0200 > > > > Prefer usage of the macro "pr_err" over the interface "printk". > >

Re: [PATCH 8/9] staging: ks7010: Delete a variable in write_to_device()

Delete a variable in write_to_device() > > The local variable "rc" was assigned a zero at one place. > But it was not read within this function. Thus delete it. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Wolfram Sang <w...@the-dr

Re: [PATCH 5/9] staging: ks7010: Delete unnecessary uses of the variable "retval"

On Sun, Jul 17, 2016 at 08:56:59PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 18:15:23 +0200 > > > > Some return values can also be directly used for various condition

Re: [PATCH 3/9] staging: ks7010: Return directly after a failed kmalloc()

On Sun, Jul 17, 2016 at 08:58:14PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 15:55:02 +0200 > > > > Return directly after a memory allocation failed at the beginning. > > >

Re: [PATCH 2/9] staging: ks7010: Delete unnecessary assignments for buffer variables

gned by the following statement. > Thus remove such unnecessary assignments. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Wolfram Sang <w...@the-dreams.de> signature.asc Description: PGP signature ___

Re: [PATCH 1/9] staging: ks7010: Delete unnecessary checks before the function call "kfree"

test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Wolfram Sang <w...@the-dreams.de> signature.asc Description: PGP signature

[PATCH 6/9] staging: ks7010: sdio: remove forward declarations

Move read/write functions to the top and driver struct to the end, so we can remove all forward declarations. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 100 --- 1 file changed, 46 insertions(+), 54 del

[PATCH 9/9] staging: ks7010: drop private handler for driver version

We are upstream now, we don't need seperate driver versioning. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.h | 1 - drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- drivers/staging/ks7010/ks_wlan_net.c | 15 +-- 3 files chan

[PATCH 5/9] staging: ks7010: unify naming to ks7010

No 79xx anymore, this is confusing. Add a comment saying that old versions were probably named 7910/79xx. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 28 ++-- drivers/staging/ks7010/ks7010_sdio.h | 1 + 2 files chang

[PATCH 7/9] staging: ks7010: bail out when registering netdevice fails

There is no need to continue then. Also, this enables us to remove an ugly static variable. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/

[PATCH 2/9] staging: ks7010: function declaration should be in a header file

Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 3 --- drivers/staging/ks7010/ks_wlan.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c

[PATCH 4/9] staging: ks7010: export sdio ids

So the module will be loaded automatically on card insertion. Rename the array while here. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdi

[PATCH 8/9] staging: ks7010: report interface as wlan not eth

Until we switch to cfg80211 (if ever), we must do this manually. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/

[PATCH 1/9] staging: ks7010: remove cfg file handling

. The only useful action, initialization of the configuration struct, is now moved to the sdio main file. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/Makefile| 3 +- drivers/staging/ks7010/TODO| 1 - drivers/staging/ks7010/ks7010_config.c

[PATCH 0/9] staging: ks7010: cleanups

/linux.git staging/ks7010 Thanks, Wolfram Wolfram Sang (9): staging: ks7010: remove cfg file handling staging: ks7010: function declaration should be in a header file staging: ks7010: collect all includes and sort them staging: ks7010: export sdio ids staging: ks7010: unify naming

[PATCH 3/9] staging: ks7010: collect all includes and sort them

Includes probably need a driver-wide clean up, but for now let's at least group all includes from the sdio file together. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- drivers/staging/ks7010/ks7010_sdio.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/d

Re: [PATCH] staging: ks7010: honor 'const' qualifier

On Wed, Jun 15, 2016 at 11:53:11PM +0200, Arnd Bergmann wrote: > The recently-added ks7010 driver produces an annoying build warning: > > drivers/staging/ks7010/ks7010_config.c: In function > 'ks_wlan_read_config_file': > drivers/staging/ks7010/ks7010_config.c:263:8: error: assignment discards

Re: [patch 1/2] staging: ks7010: parsing bugs in ks_wlan_read_config_file()

On Tue, Jun 14, 2016 at 02:16:30PM +0300, Dan Carpenter wrote: > The check for the NUL terminator is wrong so it looks like this could > read beyond the end of the buffer. > > Signed-off-by: Dan Carpenter Thanks, however I have a patch very soon to be submitted which

[PATCH V2 18/31] staging: ks7010: indent ks_hostif.c

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 1960 1 file changed, 1080 insertions(+), 880 deletions(-) diff --git a/drivers/st

[PATCH V2 28/31] staging: ks7010: adapt to new trans_start handling

From: Wolfram Sang <wsa+rene...@sang-engineering.com> trans_start is gone from netdevice, so use the new helper function to set the mark. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH V2 30/31] staging: ks7010: drop counting sd errors

From: Wolfram Sang <wsa+rene...@sang-engineering.com> They were counted but never really used anywhere. Also change the printk to a debug print, since it mostly shows on the expected -ENOMEDIUM on card removal. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- dri

[PATCH V2 25/31] staging: ks7010: indent ks7010_sdio.c

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Unlike the previous patches which are plain indent outcomes, this has some manual fixups to be not overly strict with the 80 char limit. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/k

[PATCH V2 29/31] staging: ks7010: simplify module_init/exit

From: Wolfram Sang <wsa+rene...@sang-engineering.com> The printouts are not needed, the driver core has enough debug output for this if wanted. So, use a helper to save boilerplate code. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010

[PATCH V2 27/31] staging: ks7010: fix module annotations

From: Wolfram Sang <wsa+rene...@sang-engineering.com> List all authors, beautify description, match license to what is stated in file headers, add firmware information. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_sdio.c | 10 +

[PATCH V2 26/31] staging: ks7010: remove supported card table with one element

From: Wolfram Sang <wsa+rene...@sang-engineering.com> There is only this card supported, no need to iterate over the table. The resulting firmware filename wasn't used anyway, but came from the config file or hardcoded default. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engine

[PATCH V2 31/31] staging: ks7010: cleanup file headers

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Remove svn-ids and fix typos in the licence declaration. Add my copyright to the sdio code which I worked on mainly. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/eap_pac

[PATCH V2 16/31] staging: ks7010: indent ks7010_config.c

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 353 + 1 file changed, 184 insertions(+), 169 deletions(-) diff --git a/drivers/st

[PATCH V2 17/31] staging: ks7010: indent ks7010_sdio.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_sdio.h | 64 +--- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/drivers/st

[PATCH V2 21/31] staging: ks7010: indent ks_wlan_ioctl.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.

[PATCH V2 20/31] staging: ks7010: indent ks_wlan.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan.h | 246 +++ 1 file changed, 121 insertions(+), 125 deletions(-) diff --git a/drivers/st

[PATCH V2 19/31] staging: ks7010: indent ks_hostif.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.h | 525 ++--- 1 file changed, 262 insertions(+), 263 deletions(-) diff --git a/drivers/st

[PATCH V2 15/31] staging: ks7010: indent eap_packet.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/eap_packet.h | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/st

[PATCH V2 24/31] staging: ks7010: indent michael_mic.h

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/michael_mic.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.

[PATCH V2 23/31] staging: ks7010: indent michael_mic.c

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/michael_mic.c | 43 ++-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/st

[PATCH V2 14/31] staging: ks7010: remove unecessary typedef

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Let's simply specify the struct to keep in sync with kernel coding style. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 4 +- drivers/staging/ks7010/ks7010_sd

[PATCH V2 04/31] staging: ks7010: remove checks for WIRELESS_EXT version

From: Wolfram Sang <wsa+rene...@sang-engineering.com> We are by far newer than that anyhow. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 23 --- drivers/staging/ks7010/ks_wlan_net.c | 14 ---

[PATCH V2 08/31] staging: ks7010: use kernel helper to print buffer

From: Wolfram Sang <wsa+rene...@sang-engineering.com> No need for an open coded one. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 9 + drivers/staging/ks7010/ks_deb

[PATCH V2 10/31] staging: ks7010: really iterate over multicast addresses

From: Wolfram Sang <wsa+rene...@sang-engineering.com> The loop variable was defined but not really used. Fix this. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH V2 13/31] staging: ks7010: add example cfg file as a reference

From: Wolfram Sang <wsa+rene...@sang-engineering.com> We want to remove it, but to do so properly, it is good to have a working example. Needs to be copied to /lib/firmware in order to be used. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks701

[PATCH V2 11/31] staging: ks7010: make loading config file optional

From: Wolfram Sang <wsa+rene...@sang-engineering.com> We have sane defaults, so we don't need to bail out if there is no config file. Note that the config file should go away completely in favour of configuration mechanisms already upstream. Signed-off-by: Wolfram Sang <wsa+ren

[PATCH V2 09/31] staging: ks7010: delete seperate debug header

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/st

[PATCH V2 12/31] staging: ks7010: fix printk format warnings

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Use proper type for size_t. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 2 files changed, 2 insertions(+),

[PATCH V2 07/31] staging: ks7010: use long preamble as default

From: Wolfram Sang <wsa+rene...@sang-engineering.com> I had a problem connecting to a network with a short preamble, so let's make the safer option the default. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 4 ++-- 1 fil

[PATCH V2 06/31] staging: ks7010: avoid workqueue races

From: Wolfram Sang <wsa+rene...@sang-engineering.com> My Spectec SDW823 card oopsed when it was already inserted during boot. When debugging this, I noticed that the card init was done in a seperate workqueue which was only activated once in probe. After removing the workqueue and c

[PATCH V2 05/31] staging: ks7010: remove code for old kernel versions

From: Wolfram Sang <wsa+rene...@sang-engineering.com> No need to be backwards compatible. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 9 - drivers/staging/ks7010/ks_wlan.h | 28 +

[PATCH V2 03/31] staging: ks7010: remove custom firmware loader

From: Wolfram Sang <wsa+rene...@sang-engineering.com> FW_LOADER works fine, no need for a open coded fallback. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Kconfig | 1 + drivers/staging/ks7010/ks7010_c

[PATCH V2 02/31] staging: ks7010: remove non-SDIO code and #ifdefs

From: Wolfram Sang <wsa+rene...@sang-engineering.com> I couldn't find any trace of code or even products using ks7010 with something else than SDIO. So, remove the conditionals. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Makefile

[PATCH V2 00/31] staging: add driver for KS7010 based SDIO WLAN cards

nks, Wolfram Wolfram Sang (31): staging: ks7010: add driver from Nanonote extra-repository staging: ks7010: remove non-SDIO code and #ifdefs staging: ks7010: remove custom firmware loader staging: ks7010: remove checks for WIRELESS_EXT version staging: ks7010: remove code for old kernel versi

Re: [PATCH 00/27] staging: add driver for KS7010 based SDIO cards

Hi Greg, > An add-on patch is probably easiest for everyone involved here. Any chance for the new-driver-rule for this one? Thanks, Wolfram signature.asc Description: PGP signature ___ devel mailing list de...@linuxdriverproject.org

[PATCH 09/27] staging: ks7010: delete seperate debug header

From: Wolfram Sang <wsa+rene...@sang-engineering.com> Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/st

  1   2   >