On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote:
On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Deleting obvious comments
Signed-off-by: Hari Prasath Gujulan Elango hguju
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
On Tue, Jun 09, 2015 at 10:26:54PM +0300, Dan Carpenter wrote:
On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
method to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch deletes the comments secion which is obvious and outdated
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Addrressed Dan carpenter review comments to remove the entire
comments section as its
effort to check this doesn't happen.
Thanks Regards
Hari Prasath
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove commented code from this file.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 117 --
1 file changed, 117 deletions(-)
diff --git a/drivers
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The function WILC_WFI_InitPriv() is not used anywhere in the
driver.Hence remove it.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 23 ---
1 file
On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Gujulan Elango Hari Prasath hguju...@visteon.com
Remove the unwanted else block
i think you need to refresh your tree
On Tue, Jun 02, 2015 at 12:38:26PM +0530, Sudip Mukherjee wrote:
On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath
(H
On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote:
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From : Hari Prasath Gujulan Elango hguju...@visteon.com
remove unwanted assignment to ih-check here as it will be
overwritten.Its not used
On Tue, Jun 02, 2015 at 09:11:20PM +0900, gre...@linuxfoundation.org wrote:
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From : Hari Prasath Gujulan Elango hguju...@visteon.com
You need to write this as From: not From :, otherwise git will not
work
From : Hari Prasath Gujulan Elango
remove unwanted assignment to ih-check here as it will be
overwritten.Its not used in the ip_fast_csum() function as well.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 2 +-
1 file changed
On Tue, Jun 02, 2015 at 05:45:14PM +0300, Dan Carpenter wrote:
You didn't try to compile this.
regards,
dan carpenter
sorry Dan,I overlooked the build warnings.I will fix and send a
v2.Thanks for the comment.
Regards,
Hari Prasath
___
devel
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Replace the obsolte simple_strtoul function with kstrtoul.This is a
checkpatch warning.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/speakup/kobjects.c| 4 ++--
drivers/staging/speakup/main.c
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove ununecessary typecast for kzalloc.This patch was generated by
coccinelle tool.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/linux_wlan_spi.c | 8
1 file changed, 4 insertions
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28 +---
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango hguju...@visteon.com
use the time_after_eq macro for the comparison operation
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From : Hari Prasath Gujulan Elango hguju...@visteon.com
remove unwanted assignment to ih-check here as it will be
overwritten.Its not used in the ip_fast_csum() function as well.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: From name signed off by were
On Tue, Jun 02, 2015 at 03:06:04PM +0300, Dan Carpenter wrote:
On Tue, Jun 02, 2015 at 12:01:14PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote:
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath
(H
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: Sending it as part of a patchset.Previously sent it as
individual patch.
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: Sending it as part of a patchset.Previously sent it as
individual patch.
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove ununecessary typecast for kzalloc.This patch was generated by
coccinelle tool
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/linux_wlan_spi.c | 8
1 file changed, 4 insertions
From: Hari Prasath Gujulan yyElango hguju...@visteon.com
use the time_after_eq macro for the comparison operation
Signed-off-by: Hari Prasath Gujulan yyElango hguju...@visteon.com
---
v2:sending it as part of a patchset.previusly sent it as a
individual patch.
---
drivers/staging
On Mon, Jun 01, 2015 at 02:02:06PM +0300, Dan Carpenter wrote:
On Mon, Jun 01, 2015 at 10:27:35AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote:
On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath
(H
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove the ununsed Macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Use a table to get a channel plan from a given country code.This was a
TODO mentioned as a comment in the driver.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 19
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
On Mon, Jun 01, 2015 at 09:05:54PM +0900, gre...@linuxfoundation.org wrote:
On Mon, Jun 01, 2015 at 10:08:46AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove the ununsed Macro.This patch needs to be applied after my
On Sun, May 31, 2015 at 09:56:54AM +0900, gre...@linuxfoundation.org wrote:
On Tue, May 12, 2015 at 12:25:22PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Fixed indentation issue in few lines.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
Same name problem :(
v2
On Sat, May 30, 2015 at 11:35:01AM +0530, Sudip Mukherjee wrote:
On Fri, May 29, 2015 at 08:16:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Remove the unwanted else block
something is wrong. This patch is also not applying.
I am on staging-testing.
regards
sudip
Sudip
On Sun, May 31, 2015 at 11:33:32AM +0900, gre...@linuxfoundation.org wrote:
On Thu, May 14, 2015 at 09:04:00AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used
On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote:
On Mon, Jun 01, 2015 at 09:41:52AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This trivial patch removes temporary variable to check return value of
a function
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v4: Final version with From name
On Sun, May 31, 2015 at 11:36:09AM +0900, gre...@linuxfoundation.org wrote:
On Thu, May 28, 2015 at 08:51:06AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
On Sun, May 31, 2015 at 11:34:23AM +0900, gre...@linuxfoundation.org wrote:
On Fri, May 15, 2015 at 11:33:53AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off
From: Hari Prasath Gujulan Elango hguju...@visteon.com
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: From name signed off by were
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Fixed indentation issue in few lines
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:From name signed off by were not matching.Added the From
field in commit message
---
drivers/staging/rtl8712/recv_linux.c
On Sat, May 30, 2015 at 11:18:00AM +0530, Sudip Mukherjee wrote:
On Fri, May 29, 2015 at 07:17:37AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Check the return value of kcalloc first and then use the pointer
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Deleted multiple empty lines as checkpatch.pl with strict
option warned about it as per
From: Gujulan Elango Hari Prasath hguju...@visteon.com
Remove the unwanted else block
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:From name signed off by were not matching.Added the From
field in commit message.
---
drivers/staging/dgnc/dgnc_tty.c | 4
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:signed off by and From names were not matching
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove the ununsed Macro.This patch needs to be applied after my
previous patch is applied whose title is given below because this macro
becomes ununsed after that.This was suggested by Sudip.
staging: dgnc: delete all references to 'flipbuf
On Sat, May 30, 2015 at 11:12:01AM +0530, Sudip Mukherjee wrote:
On Thu, May 28, 2015 at 12:35:22PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Check the return value of kcalloc first and then use the pointer.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote:
Really both patches should have been folded together.
regards,
dan carpenter
Yes Dan they can very well be a single patch.I have already sent
multiple versions of this patch and its confusing.I will leave it as it
is for
From: Hari Prasath Gujulan Elango hguju...@visteon.com
Remove braces around else clause with single line
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/xgifb/vb_init.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers
check return value of kzalloc and return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_tty.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index
On Thu, May 28, 2015 at 04:32:30PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 01:23:57PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Check the return value of kzalloc return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers
This patch deletes all references to 'flipbuf'.Memory is allocated and
freed but never used anywhere in the driver.Also deleted an ununsed
Macro defined in the header file.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 9
Remove the unwanted else block
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_tty.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 2397c66..ca07b7f 100644
--- a/drivers
On Thu, May 28, 2015 at 09:39:14AM -0700, insop.s...@gainspeed.com wrote:
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath
(H.) wrote:
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
No the original code is quite bad but this patch makes
On Fri, May 29, 2015 at 01:52:28PM +0300, Dan Carpenter wrote:
On Fri, May 29, 2015 at 10:06:48AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath
(H
On Fri, May 29, 2015 at 11:54:09AM +0300, Dan Carpenter wrote:
On Fri, May 29, 2015 at 07:44:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
check return value of kzalloc and return error if it fails.
There is a problem with your patch. See if you can spot it. Also can
you add
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:Addressed the review comments by Sudhip Mukherjee as I had
missed out a few other
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review
On Thu, May 28, 2015 at 11:45:28AM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 08:40:41AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
diff --git a/drivers/staging/sm750fb/Kconfig
b/drivers/staging/sm750fb/Kconfig
index c40d088..59d7c52 100644
--- a/drivers/staging/sm750fb
On Thu, May 28, 2015 at 11:57:54AM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 08:54:12AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
I resend v3 but it seems there is a duplicate signature.Please dicard it
as well.I am sending v4 now.
v3 is fine. The duplicate sign-off
The sm750fb driver has few Framebuffer configuration dependencies that
need to be selected in order to get compiled successfully
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3: Fix alignment issues addressed by Dan Carpenter.
v2:Addressed the review
On Thu, May 28, 2015 at 02:07:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 10:51:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/staging
On Thu, May 28, 2015 at 02:37:43PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 11:32:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The reason i did that was if the function doesn't hit any error
condition, then it needs to return 0. If the err variable is not
initialized
On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote:
On Thu, May 28, 2015 at 09:38:23AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
remove redundant code in this function by introducing a new retval
variable.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
remove redundant code in this function.remove return value check for
function that always return success.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v2:address review comments from Dan.Remove return value check
for the function gs_release_image as it always
remove redundant code in this function.remove return value check for
function that always return success
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
v3:Remove initialization of the 'err' variable.
v2:address review comments from Dan.Remove return value
Check the return value of kcalloc first and then use the pointer.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers
Check the return value of kzalloc return error if it fails.
Signed-off-by: Gujulan Elango Hari Prasath hguju...@visteon.com
---
drivers/staging/dgnc/dgnc_driver.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index
On Wed, May 27, 2015 at 11:32:11AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The Kconfig dependency for this driver should include the kernel
configuration FB_MODE_HELPERS which defines the vesa_modes
structure.Without
On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath
(H.) wrote:
replace
On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
your patch is corrupt and can not be applied.
But even then, can
replace kzalloc with devm_kzalloc thereby removing the corresponding
kfree.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/sm750fb/sm750.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging
.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/sm750fb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/Kconfig b/drivers/staging/sm750fb/Kconfig
index c40d088..bfb3429 100644
--- a/drivers/staging/sm750fb
replace the hard coded value for the maximum sequence number of a ieee
802.11 frame by a Macro.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
This macro defines the maximum sequence number for an IEEE802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
On Mon, May 18, 2015 at 03:47:58PM +0300, Dan Carpenter wrote:
Fold this together with the other patch. Do 1 thing per patch, not half
a thing per patch. This change makes no sense on its own.
regards,
dan carpenter
I didn't think of it. I am sending v2 with both the related changes as
On Fri, May 15, 2015 at 04:09:42PM +0300, Dan Carpenter wrote:
On Fri, May 15, 2015 at 12:09:42PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
On Mon, May 18, 2015 at 10:29:55PM +0200, Mateusz Kulikowski wrote:
Hi,
On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
the if block.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rts5208/sd.c | 7 ---
1 file changed, 4
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rts5208/ms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers
remove an unwanted assignment to a variable which is overwritten in the
very next line.The first value assigned is not used.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
The return value of copy_to_user() isn't checked for failure.Hence
return -EFAULT if it fails.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers
On Thu, May 14, 2015 at 12:47:19PM +0300, Dan Carpenter wrote:
On Thu, May 14, 2015 at 09:22:01AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
The return value of copy_to_user() isn't checked for failure.Hence
return -EFAULT if it fails.
Signed-off-by: Hari Prasath Gujulan Elango
check return value of kmalloc before accessing the memory pointer.This
function returns a non-zero value on failure hence a return value of 1
is used.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed, 2 insertions
check the return value of kzalloc before accessing the memory pointer
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
check return value of kmalloc before accessing the memory pointer.This
check return value of kmalloc before accessing the memory pointer and
return -ENOMEM if allocation fails.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Return -ENOMEM for memory allocation failure.
---
drivers/staging/wlan-ng/p80211conv.c | 2 ++
1 file changed
On Wed, May 13, 2015 at 05:27:10PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote:
On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote:
On Wed, May 13
On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju...@visteon.com writes:
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju
Fixed indentation issue in few lines.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8712/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/recv_linux.c
b/drivers/staging/rtl8712/recv_linux.c
This patch replaces a condition check for time elapsed with a
simple time_after macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Fixes a build warning.time_after() macro requires both of
its arguments to be unsigned long.Build warning was missed later
reported
This patch replaces the condition check for time elapsed with a
simplified time_before() macro
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Fixes a build warning.time_before() macro requires both of
its arguments to be unsigned long.Build warning was missed
On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
Gujulan Elango, Hari Prasath (H.) hguju...@visteon.com writes:
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath
Remove the goto and return error directly thereby removing a variable
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep
On Tue, May 05, 2015 at 12:19:57PM +0300, Dan Carpenter wrote:
On Mon, May 04, 2015 at 10:17:09PM +0200, Mateusz Kulikowski wrote:
As far as I know (radio) noise is rarely above 0 dBm - if it is, you're
doing something wrong.
This means we can just change rtllib_rx_stats::noise to s8.
I
On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote:
On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote:
From: Larry Finger larry.fin...@gmail.com on behalf of Larry Finger
larry.fin...@lwfinger.net
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari
On Fri, May 01, 2015 at 10:46:53AM +0300, Dan Carpenter wrote:
The subject says fix but this does not fix a run time bug, it just
silences a warning. It's still the correct thing according to Larry
so that's good.
On Thu, Apr 30, 2015 at 12:06:28PM +, Gujulan Elango, Hari Prasath (H
This patch addresses a spatch warning on assigning a negative
value to a unsigned integer.Similar patch has been submitted by
Larry Finger earlier to silence the same spatch warning in another
file.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2: Address Dan
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
v2:Remove unnecessary goto and return error
From: Dan Carpenter dan.carpen...@oracle.com
Sent: Thursday, April 30, 2015 12:45 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
florian.c.schilha...@googlemail.com; gre...@linuxfoundation.org; Babu
101 - 200 of 222 matches
Mail list logo
