Re: [PATCH] staging: rdma: use setup_timer() api

On Thu, Feb 04, 2016 at 09:38:32AM -0600, Mike Marciniszyn wrote: > > Subject: [PATCH] staging: rdma: use setup_timer() api > > > > From: Hari Prasath Gujulan Elango > > > > Doug, > > We are going to add this to the rdmavt/hfi1/qib work, with the appropriate >

Missed patch for hfi1 from Gregs tree.

Doug, The following patch was not accepted by Greg and does not appear in patchworks https://marc.info/?l=linux-rdma=145090416416677=2 We have this patch and can resubmit it for patchworks but I don't want to get in the way of the original author. Julia, Would you mind if we resubmit it to

Re: Missed patch for hfi1 from Gregs tree.

On Thu, Jan 28, 2016 at 09:52:09PM +0100, Julia Lawall wrote: > > > On Thu, 28 Jan 2016, gre...@linuxfoundation.org wrote: > > > On Thu, Jan 28, 2016 at 03:30:23PM -0500, ira.weiny wrote: > > > Doug, > > > > > > The following patch

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

> > > > > > > > > > If Doug accepts the library changes, let me know that public git > > > > > commit > > > > > and I can pull it into the staging-next branch and you can continue to > > > > > send me staging patches that way. > > > > > > > > Won't this cause a conflict during the merge window?

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

On Tue, Dec 22, 2015 at 06:27:57PM -0800, gre...@linuxfoundation.org wrote: > On Tue, Dec 22, 2015 at 02:15:08PM -0500, ira.weiny wrote: > > On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote: [snip] > > > > > > No, git is good :) > > &g

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote: > On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote: > > On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote: > > > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny w

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote: > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > > Greg, Doug, > > > > As mentioned below, these patches depend on the new rdmavt library > > submitted to > > Doug on

Re: [PATCH v2 0/5] Clean up SDMA engine code

On Mon, Dec 21, 2015 at 04:13:49PM -0800, gre...@linuxfoundation.org wrote: > On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote: > > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > > > From: Ira Weiny <ira.we...@intel.com> > >

Re: [PATCH v2 0/5] Clean up SDMA engine code

On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > Various improvements to the SDMA engine code. Greg, Thanks for reviewing and accepting our patches to staging-testing. I apologize for the conflicts we had between the 3 of us

Re: [PATCH 08/14] staging/rdma/hfi1: Start adding building blocks for TID caching

On Thu, Dec 17, 2015 at 02:59:52PM +0300, Dan Carpenter wrote: > On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote: > > +} > > + > > +static int program_rcvarray(struct file *fp, unsigned long vaddr, > > + struct tid_group *grp, > > +

Re: [PATCH 13/14] staging/rdma/hfi1: Add TID entry program function body

On Thu, Dec 17, 2015 at 03:06:45PM +0300, Dan Carpenter wrote: > On Thu, Dec 17, 2015 at 02:00:23AM -0500, ira.we...@intel.com wrote: > > + mutex_lock(>exp_lock); > > + /* > > +* The first step is to program the RcvArray entries which are complete > > +* groups. > > +*/ > > +

Re: [PATCH 08/14] staging/rdma/hfi1: Start adding building blocks for TID caching

On Thu, Dec 17, 2015 at 02:23:39PM +0300, Dan Carpenter wrote: > On Thu, Dec 17, 2015 at 02:00:18AM -0500, ira.we...@intel.com wrote: > > From: Mitko Haralanov > > +static int unprogram_rcvarray(struct file *fp, u32 tidinfo, > > + struct

Re: [PATCH v4 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

Any further feedback on this series? Ira On Tue, Dec 01, 2015 at 02:47:55PM -0500, ira.we...@intel.com wrote: > From: Ira Weiny > > This was a single patch before. The change to dev_dbg required a precursor > patch to add the dd_dev_dbg which is consistent with the other

[jubin.j...@intel.com: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build]

Greg, It looks like you missed this patch for 4.4-rc5 Could we get it included for rc6? Thanks, Ira - Forwarded message from Jubin John - From: Jubin John To: , CC:

Re: [PATCH 0/2] Fix 4.4 IB merge window regressions

On Mon, Nov 30, 2015 at 09:34:15AM -0500, Mike Marciniszyn wrote: > This two patch series fixes regressions for qib and hfi1 > introduced in the 4.4 merge window. > > These are critical for 4.4 and for rebasing the qib/hfi1 > refactoring. Doug, Greg, It should also be noted that without this

Re: [PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

On Thu, Nov 19, 2015 at 04:54:44PM -0800, Greg KH wrote: > On Mon, Nov 09, 2015 at 06:34:44PM -0500, ira.we...@intel.com wrote: > > From: Vennila Megavannan > > > > Add a module paramter to toggle prescan/Fast ECN Detection and remove the > > Kconfig option which

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

On Tue, Nov 17, 2015 at 02:27:46PM -0800, gre...@linuxfoundation.org wrote: > On Tue, Nov 17, 2015 at 03:30:24PM -0500, ira.weiny wrote: > > On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > > > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com w

Re: HFI1 code duplication todo

On Sat, Nov 21, 2015 at 01:25:23AM +0300, Dan Carpenter wrote: > On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: > > So, as to the hfi1/qib/rxe transport library. The qib driver is in the > > rdma tree, and we aren't going to move it to staging just because it > > depends on

Re: HFI1 code duplication todo

On Fri, Nov 20, 2015 at 10:41:16AM -0500, Doug Ledford wrote: > On 11/19/2015 05:23 PM, Dennis Dalessandro wrote: > > On Thu, Nov 12, 2015 at 04:13:18PM -0500, Dennis Dalessandro wrote: > >> The major todo for the hfi1 driver in staging is getting rid of the > >> verbs code duplication between

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > > From: Jubin John > > > > Correct the checks on diag.c with the latest checkpatch > > > > Reviewed-by: Dennis Dalessandro

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 07:29:46PM +0300, Dan Carpenter wrote: > Ville Syrjälä already posted the answer but his email had no text just a > link inside 300+ lines of quoted output so you may have missed it. AFAICS I have not received anything from Ville. Thanks for the heads up, Ira

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 10:00:04AM -0500, ira. weiny wrote: > On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote: > > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > > > With the latest staging-testing and staging-next[*] I am getting the >

Re: Panic in drm_calc_timestamping_constants in staging-next

On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote: > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > > With the latest staging-testing and staging-next[*] I am getting the > > following panic. > > > > [*] git://git.kernel.org/pub/scm/linux/kernel/git

Panic in drm_calc_timestamping_constants in staging-next

With the latest staging-testing and staging-next[*] I am getting the following panic. [*] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git [ 11.232549] BUG: unable to handle kernel NULL pointer dereference at 00b0 [ 11.232568] IP: []

Re: [PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

On Wed, Nov 11, 2015 at 12:01:08PM +0300, Dan Carpenter wrote: > On Wed, Nov 11, 2015 at 12:43:05AM -0500, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > This goto done is followed by an if (ret) break in the outer switch clause. > > It > > is unnecessary. > > > >

Re: [PATCH v2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

On Tue, Nov 10, 2015 at 12:59:29PM +0300, Dan Carpenter wrote: > Gar... No. Please please get rid of the PC() macro. It makes the code > impossible to understand because instead of hitting CTRL-[ you have > decode it and then manually type out > > :cs find g

Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

> > > > Ok, patch 7-9 of this series do not depend on this patch nor number 6. I > > will > > resend those 3 while I figure out what to do about these 2: > > > > staging/rdma/hfi1: Add function stubs for TID caching > > staging/rdma/hfi1: Implement Expected Receive TID caching > > > > Frankly

Re: [PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

On Fri, Nov 06, 2015 at 05:02:35PM -0800, Greg KH wrote: > On Fri, Oct 30, 2015 at 06:58:44PM -0400, ira.we...@intel.com wrote: > > From: Mitko Haralanov > > > > Add mmu notify helper functions and TID caching function stubs in > > preparation > > for the TID caching

Re: [PATCH v4 6/9] staging/rdma/hfi1: Implement Expected Receive TID caching

On Fri, Nov 06, 2015 at 05:03:28PM -0800, Greg KH wrote: > On Fri, Oct 30, 2015 at 06:58:45PM -0400, ira.we...@intel.com wrote: > > From: Mitko Haralanov > > > > Expected receives work by user-space libraries (PSM) calling into the driver > > with information about the

Re: [PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

On Thu, Nov 05, 2015 at 10:34:48AM +0300, Dan Carpenter wrote: > On Wed, Nov 04, 2015 at 09:06:08PM -0500, ira.we...@intel.com wrote: > > > +#define CCE_PCIE_CTRL_XMT_MARGIN_GEN1_GEN2_OVERWRITE_ENABLE_MASK 0x1ull > > There is absolutely no point to having a variable name which is nine >

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar Also, NAK as has been covered in other responses. However, I wanted to add, similar to the hfi1_ioctl fix, we have follow on

Re: [PATCH 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

On Thu, Nov 05, 2015 at 10:56:27AM +0300, Dan Carpenter wrote: > On Wed, Nov 04, 2015 at 09:10:11PM -0500, ira.we...@intel.com wrote: > > From: Vennila Megavannan > > > > Add a module paramter to toggle prescan/Fast ECN Detection. > > > > In addition change the

Re: [BUG] IB/hfi1: might sleep under spinlock in hfi1_ioctl()

On Sat, Oct 31, 2015 at 12:32:29AM +0300, Alexey Khoroshilov wrote: > Hello, > > hfi1_ioctl() contains many calls to might sleep functions with > dd->hfi1_snoop.snoop_lock spinlock held (for example, access_ok, > copy_from_user, kzalloc(GFP_KERNEL), etc.). > > Should dd->hfi1_snoop.snoop_lock be

Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

> > Can I add the removal of these macros to the TODO list and get this patch > > accepted in the interm? > > Nope, sorry, why would I accept a known-problem patch? Would you do > such a thing? > > > Many of the patches I am queueing up to submit as well as one in this > > series do > > not

Re: [PATCH v3 12/23] staging/rdma/hfi1: Macro code clean up

On Tue, Oct 27, 2015 at 05:19:10PM +0900, Greg KH wrote: > On Mon, Oct 26, 2015 at 10:28:38AM -0400, ira.we...@intel.com wrote: > > From: Mitko Haralanov > > > > Clean up the context and sdma macros and move them to a more logical place > > in > > hfi.h > > > >

Re: [PATCH v3 23/23] staging/rdma/hfi1: Update driver version string to 0.9-294

On Tue, Oct 27, 2015 at 05:46:41PM +0900, Greg KH wrote: > On Mon, Oct 26, 2015 at 10:28:49AM -0400, ira.we...@intel.com wrote: > > From: Jubin John > > > > Signed-off-by: Jubin John > > Signed-off-by: Ira Weiny > > --- > >

Re: [PATCH v2 01/22] staging/rdma/hfi1: Fix regression in send performance

On Wed, Oct 21, 2015 at 04:18:06PM +0300, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 10:11:16PM -0400, ira.we...@intel.com wrote: > > From: Mike Marciniszyn > > > > This additional call is a regression from qib. For small messages the > > progress > > routine

Re: [PATCH v2 15/22] staging/rdma/hfi1: Allow tuning of SDMA interrupt rate

On Thu, Oct 22, 2015 at 01:54:21PM +0300, Dan Carpenter wrote: > What values work well for this parameter? 64. For v3, I've squashed a change which was farther down my list of changes which set this after some testing. Thanks, Ira > > regards, > dan carpenter >

Re: [PATCH v2 14/22] staging/rdma/hfi1: Implement Expected Receive TID caching

On Thu, Oct 22, 2015 at 01:41:58PM +0300, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 10:11:29PM -0400, ira.we...@intel.com wrote: > > + case HFI1_CMD_TID_INVAL_READ: > > + ret = hfi1_user_exp_rcv_invalid(fp, ); > > + if (!ret) { > > + addr = (unsigned

Re: [PATCH 00/23] Update driver to 0.9-294

On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote: > > > > Perhaps I did not chose my words carefully enough. > > > > The largest issue on the TODO list is the refactoring of the code to be > > shared between the hfi1 and qib driver. While the hardware between hfi1 > > and qib is similar