[PATCH 15/18] staging: rtl8188eu: Remove last_tx_complete_time from struct sreset_priv

value stored in variable last_tx_complete_time isn't being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_sreset.c |1 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - drivers/staging/rtl8188eu/os_dep

[PATCH 14/18] staging: rtl8188eu: Remove last_tx_time from struct sreset_priv

value stored in variable last_tx_time isn't being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_sreset.c |1 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |6

[PATCH 17/18] staging: rtl8188eu: Remove unused function declaration

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_osintf.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_osintf.h b/drivers/staging/rtl8188eu/include/usb_osintf.h index 9de99ca..2dce3bf 100644

[PATCH 18/18] staging: rtl8188eu: Remove usb_vendor_req.h header file

driver doesn't need usb_vendor_req.h. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/usb_osintf.h |1 - drivers/staging/rtl8188eu/include/usb_vendor_req.h | 52 drivers/staging/rtl8188eu/os_dep/usb_intf.c|1

Re: [PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()

On Wed, May 28, 2014 at 12:32 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote: Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8712/osdep_service.h |6 -- 1 file changed, 6 deletions

[PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw_type()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |6 -- drivers/staging/rtl8188eu/include/usb_ops.h |1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu

[PATCH 02/15] staging:rtl8188eu:Remove code specific to kernel version 2.6.35

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c index 6089bae..9172380 100644

[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to padapter-chip_type directly

Assign RTL8188E to padapter-chip_type directly instead of calling chip_by_usb_id() function to do same. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 10/15] staging: rtl8188eu:Remove unused variable struct adapter *pbuddy_padapter

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index c1195a0..6fb8caa 100644

[PATCH 09/15] staging: rtl8188eu:Remove unused function rtw_handle_dualmac()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index 6c9e9a1

[PATCH 07/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_init()

rtw_usb_if1_init() initializes pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep

[PATCH 08/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_deinit()

rtw_usb_if1_init() assign NULL to pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers

[PATCH 05/15] staging: rtl8188eu:Remove unused function chip_by_usb_id()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index fbf967d..1e62713 100644 --- a/drivers

[PATCH 13/15] staging: rtl8188eu:Remove inline function rtw_netif_stop_queue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 ++-- drivers/staging/rtl8188eu/os_dep/usb_intf.c |4 ++-- 3 files changed, 4 insertions(+), 9 deletions

[PATCH 11/15] staging: rtl8188eu:Remove inline function rtw_netif_wake_queue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b

[PATCH 14/15] staging: rtl8188eu:Remove unused inline function res_to_status()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index 9d32bb2..b500991

[PATCH 12/15] staging: rtl8188eu:Remove inline function rtw_netif_start_queue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b

[PATCH 15/15] staging: rtl8188eu:Remove unused macros defined in osdep_service.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/osdep_service.h | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index

[PATCH 02/24] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal

[PATCH 03/24] staging: rtl8188eu: Remove unused function pointer -interface_ps_func

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |2 -- drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal

[PATCH 04/24] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9020129..141f85a 100644 --- a/drivers

[PATCH 08/24] staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer. rtl8188e_deinit_dm_priv() has empty defination, so we can remove rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be removed. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging

[PATCH 06/24] staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index 0145a11..f2e1d02 100644 --- a/drivers

[PATCH 05/24] staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index a755df3..0145a11 100644

[PATCH 07/24] staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index cf88bf2..4e9f797 100644

[PATCH 09/24] staging: rtl8188eu: Remove unused function pointer -dm_init

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging

[PATCH 10/24] staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |4 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu

[PATCH 14/24] staging: rtl8188eu: Remove unused macros in odm_interface.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 548a309

[PATCH 15/24] staging: rtl8188eu: Remove unused function pointer declaration.

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 3fc3e3c..5338290

[PATCH 13/24] staging: rtl8188eu: Remove unused structure rtl8192cd_priv

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm.h |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/staging/rtl8188eu/include/odm.h index 9d1a79c..e83812f 100644 --- a/drivers/staging

[PATCH 12/24] staging: rtl8188eu: Remove unused macros and enum defined in odm_types.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_types.h | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_types.h b/drivers/staging/rtl8188eu/include/odm_types.h index 78ee2ba

[PATCH 16/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 5338290..ba58a67 100644

[PATCH 17/24] staging: rtl8188eu: Use ODM_REG_CCK_CCA_11N in ODM_Write_CCK_CCA_Thres()

Use ODM_REG_CCK_CCA_11N directly instead of using ODM_REG(CCK_CCA, pDM_Odm) which produces same after preprocessing. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 20/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in ODM_Write_DIG()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 19/24] staging: rtl8188eu: Remove unnecessary debugging message from ODM_Write_DIG()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2bd68aa..205ba7f 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 18/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in odm_DIGInit()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 21/24] staging: rtl8188eu: Remove unused macros defined in odm_interface.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h | 30 - 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index

[PATCH 22/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 2c2991e..e29ac79

[PATCH 24/24] staging: rtl8188eu: Remove empty file odm_interface.h

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h | 24 - drivers/staging/rtl8188eu/include/odm_precomp.h |1 - 2 files changed, 25 deletions(-) delete mode 100644 drivers/staging/rtl8188eu/include

[PATCH 23/24] staging: rtl8188eu: Remove unused enum odm_h2c_cmd.

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index e29ac79..dc6b1c2

Re: [PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

Hi Greg, Please merge this patchset, It has been pending for some time. regards, navin patidar On Wed, May 7, 2014 at 9:27 AM, navin.pati...@gmail.com wrote: From: navin patidar navin.pati...@gmail.com Following patches remove unused functions, variables and functions with empty definition

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Tue, May 20, 2014 at 12:34 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Mon, May 19, 2014 at 09:19:07PM +0530, navin patidar wrote: You have changed it to return _FAIL instead of true. Perhaps that is ok but you need to explain it in the changelog. oops, I'll resend this patch

[PATCH 00/28] staging: rtl8188eu: Remove unnecessary functions.

Following patches remove functions which are unused or have empty definition. navin patidar (28): staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError(). staging: rtl8188eu: Remove function with empty definition _InitOperationMode() staging: rtl8188eu

[PATCH 01/28] staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 617e4c6..9ce6173 100644 --- a/drivers

[PATCH 03/28] staging: rtl8188eu: Remove function with empty definition _ps_open_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging

[PATCH 02/28] staging: rtl8188eu: Remove function with empty definition _InitOperationMode()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9ce6173..2e7b81ce 100644 --- a/drivers

[PATCH 04/28] staging: rtl8188eu: Remove unused function _ps_close_RF()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 2fe1135..1a83d31 100644 --- a/drivers

[PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 1a83d31..4c3f8c8 100644 --- a/drivers

[PATCH 07/28] staging: rtl8188eu: Remove unused function rtl8188e_PHY_ConfigRFWithParaFile()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 8079fc6

[PATCH 08/28] staging: rtl8188eu: Remove unused function rtl8192c_PHY_GetHWRegOriginalValue()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index b50df3e

[PATCH 09/28] staging: rtl8188eu: Remove unused function PHY_UpdateTxPowerDbm8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |1 - 2 files changed, 38 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b

[PATCH 10/28] staging:rtl8188eu: Remove unused function phy_DbmToTxPwrIdx()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 44 --- 1 file changed, 44 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 7cc7f44

[PATCH 11/28] staging: rtl8188eu: Remove unused funtion PHY_GetTxPowerLevel8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 46 --- 1 file changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 16f46c3

[PATCH 12/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index 099345f

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644

[PATCH 15/28] staging: rtl8188eu: Remove unused function rtl8188e_RF_ChangeTxPath()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rf6052.c index 2f1348f

[PATCH 16/28] staging: rtl8188eu: Remove unused function odm_DIGbyRSSI_LPS()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 45 --- 1 file changed, 45 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 89a26e3..d8482ab 100644

[PATCH 17/28] staging: rtl8188eu: Remove function odm_DynamicBBPowerSaving()

odm_DynamicBBPowerSaving() has empty defination. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index d8482ab

[PATCH 18/28] staging: rtl8188eu: Remove unused function odm_DynamicBBPowerSavingInit()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2e105b4..e8ad880 100644 --- a/drivers/staging

[PATCH 19/28] staging:rtl8188eu: Remove unused function iodm_1R_CCA()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index e8ad880..7319b3e 100644

[PATCH 20/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskMP()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 7319b3e..01946cc 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 21/28] staging: rtl8188eu: Remove unused function odm_RefreshRateAdaptiveMaskAPADSL()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 01946cc..cc73188 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 22/28] staging: rtl8188eu: Remove unused funtion odm_DynamicTxPowerNIC()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index cc73188..8dd5f7e 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 23/28] staging: rtl8188eu: Remove unused function odm_SwAntDivChkAntSwitchCallback()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 8dd5f7e..4442181 100644 --- a/drivers/staging

[PATCH 24/28] staging: rtl8188eu: Remove unused function ConvertTo_dB()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 4442181..425c50a4 100644 --- a/drivers

[PATCH 25/28] staging: rtl8188eu: Remove function with empty defination ODM_CheckPowerStatus()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c index 056052d..7c22658

[PATCH 26/28] staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 323eb93..7c1043c 100644

[PATCH 27/28] staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 7c1043c..a90b2c5 100644

[PATCH 28/28] staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/odm.c |1 - drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 - drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 -- 3 files changed, 8 deletions(-) diff --git a/drivers

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644

Re: [PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Subject line of this patch isn't correct, so please ignore it. I've submitted new patch with [PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E() subject line. regards, navin patidar On Sun, May 18, 2014 at 8:49 PM, navin patidar navin.pati...@gmail.com wrote

[PATCH 04/13] staging: rtl8188eu: Remove struct zero_bulkout_context

From: navin patidar navin.pati...@gmail.com Remove unused struct zero_bulkout_context. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep

[PATCH 03/13] staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_priv

From: navin patidar navin.pati...@gmail.com Remove unused variable 'spinlock_t lock'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions(-) diff

[PATCH 05/13] staging: rtl8188eu: Remove function rtw_os_recv_resource_init()

From: navin patidar navin.pati...@gmail.com rtw_os_recv_resource_init() has empty defination, so we can remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers

[PATCH 02/13] staging: rtl8188eu: Remove unused member variables of struct recv_priv

From: navin patidar navin.pati...@gmail.com Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include

[PATCH 01/13] staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_priv

From: navin patidar navin.pati...@gmail.com Remove unused variable 'semaphore allrxreturnevt'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c|2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 3 deletions

[PATCH 07/13] staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()

From: navin patidar navin.pati...@gmail.com rtw_hostapd_mlme_rx() has empty defination, so we can remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |2 -- drivers/staging/rtl8188eu/include/recv_osdep.h |1 - drivers

[PATCH 08/13] staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()

From: navin patidar navin.pati...@gmail.com Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 +- drivers/staging/rtl8188eu/include/recv_osdep.h |1

[PATCH 10/13] staging: rtl8188eu: Remove unused inline function get_rx_status()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index e5b4e10..dac2e0c 100644 --- a/drivers

[PATCH 09/13] staging: rtl8188eu: Remove unused inline function recvframe_push()

Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index 68c2ad5f..e5b4e10

[PATCH 13/13] staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_frame

Remove unused variable 'u8 fragcnt'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 12/13] staging: rtl8188eu: Remove 'int frame_tag' from struct recv_frame

Remove unused variable 'int frame_tag'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 00/15] staging: rtl8188eu: clean-up struct recv_buf

Following patches remove unnecessary member variables of struct recv_buf. navin patidar (15): staging: rtl8188eu: Remove function rtw_dequeue_recvbuf() staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head() staging: rtl8188eu: Remove function rtw_enqueue_recvbuf() staging

[PATCH 01/15] staging: rtl8188eu: Remove function rtw_dequeue_recvbuf()

rtw_dequeue_recvbuf() is not being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 25 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 26 deletions(-) diff --git a/drivers

[PATCH 03/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf()

rtw_enqueue_recvbuf() is not being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 12 drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 13 deletions(-) diff --git a/drivers/staging

[PATCH 02/15] staging: rtl8188eu: Remove function rtw_enqueue_recvbuf_to_head()

rtw_enqueue_recvbuf_to_head() is not being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c| 12 drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 13 deletions(-) diff --git a/drivers

[PATCH 05/15] staging: rtl8188eu: Remove 'spinlock_t recvbuf_lock' from struct recv_buf

recvbuf_lock is initialized inside rtl8188eu_init_recv_priv() but never used. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git

[PATCH 06/15] staging: rtl8188eu: Remove 'dma_addr_t dma_transfer_addr' from struct recv_buf

Remove unused variable dma_transfer_addr. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h index

[PATCH 08/15] staging: rtl8188eu: Remove pdata, phead, ptail and pend from struct recv_buf

Driver is not making use of value stored in removed variables. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |8 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |9 - drivers/staging/rtl8188eu/include/rtw_recv.h

[PATCH 10/15] staging: rtl8188eu: Remove 'pallocated_buf' from struct recv_buf

pallocated_buf is not being used by driver. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH 11/15] staging: rtl8188eu: Remove 'alloc_sz' from struct recv_buf

Driver isn't making any use of value stored in alloc_sz variable. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers

[PATCH 12/15] staging: rtl8188eu: Remove 'u32 len' from struct recv_buf

Remove unused variable 'u32 len'. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 3 files changed, 3 deletions

[PATCH 09/15] staging: rtl8188eu: Remove 'irp_pending' from struct recv_buf

irp_pending is initialized to false inside rtw_os_recvbuf_resource_alloc() and value of irq_pending never changed after that, so 'if (!precvbuf-irp_pending)' inside rtw_os_read_port() function will be always true. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging

[PATCH 13/15] staging: rtl8188eu: Remove 'u32 ref_cnt' from struct recv_buf

Driver isn't making any use of value stored in variable ref_cnt. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |2 -- drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers/staging/rtl8188eu/os_dep/recv_linux.c |1 - 3

[PATCH 14/15] staging: rtl8188eu: Remove rtl8188eu_init_recvbuf() function

rtl8188eu_init_recvbuf() function definition is empty now, so remove it. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c|4 drivers/staging/rtl8188eu/hal/usb_ops_linux.c |2 -- drivers/staging/rtl8188eu/include

[PATCH 15/15] staging: rtl8188eu: Remove 'u8 *pbuf' from struct recv_buf

Instead of using pbuf to pass sbk data pointer to usb_fill_bulk_urb(), we can use precvbuf-pskb-data to do that. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |5 + drivers/staging/rtl8188eu/include/rtw_recv.h |1 - drivers

[PATCH 1/2] staging: rtl8188eu: Remove debugging messages from usb_dvobj_init()

Unnecessary debugging messages are removed from usb_dvobj_init(). Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 34 +++ 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 2/2] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

Use inline functions provided by USB subsystem to check endpoint type, instead of inline functions implemented by driver to do the same. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 57 +-- 1 file changed, 10

Re: [PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

On Mon, Apr 28, 2014 at 2:55 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote: Use inline functions provided by USB subsystem to check endpoint type, instead of macros implemented by driver to do the same. Unnecessary debugging

[PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

Use inline functions provided by USB subsystem to check endpoint type, instead of macros implemented by driver to do the same. Unnecessary debugging messages are also removed. Signed-off-by: navin patidar navin.pati...@gmail.com --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 92

<    1   2   3   4   5   6   >