Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/kiransuren-osuosl-org/Staging-android-ashmem-changed-struct-file_operations-to-const-file_operations/20201016-131238
base:
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/kiransuren-osuosl-org/Staging-android-ashmem-changed-struct-file_operations-to-const-file_operations/20201016-131238
base:
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Oct 16, 2020 at
On Fri, Oct 16, 2020 at 01:11:11AM -0400, kiransu...@osuosl.org wrote:
> From: kiransuren
This does not match your signed-off-by line :(
>
> Fixed a coding style issue.
What issue? Always be specific.
>
> Signed-off-by: Kiran Surendran
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1
On 10/15/20 10:11 PM, kiransu...@osuosl.org wrote:
> From: kiransuren
>
> Fixed a coding style issue.
>
> Signed-off-by: Kiran Surendran
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
>
From: kiransuren
Fixed a coding style issue.
Signed-off-by: Kiran Surendran
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 10b4be1f3e78..f2b67c4fe8d2 100644
---
