Re: [PATCH] Staging: comedi: Fix coding style issue in poc.c

2014-02-24 Thread Joe Perches
On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote: > This is a patch to remove unneccessary space after function pointer name > found with checkpatch.pl A few comments: Please wrap your commit message to 70 columns or so. There is 1 c in unnecessary. The "This is a patch to " bit isn't p

[PATCH] Staging: comedi: Fix coding style issue in poc.c

2014-02-24 Thread David Roddick
This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/st

Re: [PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-24 Thread Dan Carpenter
Subject is still messed up. Send the email to yourself first and then to the list until you figure it out. (hint add a blank line). regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
Signed-off-by: David Roddick --- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c

Re: [PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread Dan Carpenter
Leave a blank line between the subject and the body of the changelog. The signed-off-by line is missing. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
--- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c +++ b/drivers/staging/comedi/dr

[PATCH] Staging: comedi: Fix coding style issue in poc.c This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl

2014-02-23 Thread David Roddick
--- drivers/staging/comedi/drivers/poc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c index 2ae4ee1..22c7392 100644 --- a/drivers/staging/comedi/drivers/poc.c +++ b/drivers/staging/comedi/dr