Re: [PATCH] Staging: greybus: usb: Fixed a coding style error

2019-04-15 Thread Johan Hovold
On Sun, Mar 31, 2019 at 01:30:40AM -0400, Will Cunningham wrote: > Line was >80 characters. > > Signed-off-by: Will Cunningham > --- > drivers/staging/greybus/usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/usb.c

Re: [PATCH] Staging: greybus: usb: Fixed a coding style error

2019-03-31 Thread Joe Perches
On Sun, 2019-03-31 at 01:30 -0400, Will Cunningham wrote: > Line was >80 characters. [] > diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c [] > @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, > return -ENOMEM; > >

Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error

2019-03-31 Thread Joe Perches
On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote: > On 3/31/19 1:04 AM, Joe Perches wrote: > > Blind adherence to 80 column limits leads to poor looking > > code. Especially with longish identifier lengths. > I agree. If it were me, I'd use a local variable. For example: > > struct

Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error

2019-03-31 Thread Alex Elder
On 3/31/19 1:40 AM, Joe Perches wrote: > On Sun, 2019-03-31 at 01:20 -0500, Alex Elder wrote: >> On 3/31/19 1:04 AM, Joe Perches wrote: >>> Blind adherence to 80 column limits leads to poor looking >>> code. Especially with longish identifier lengths. >> I agree. If it were me, I'd use a local

Re: [greybus-dev] [PATCH] Staging: greybus: usb: Fixed a coding style error

2019-03-31 Thread Alex Elder
On 3/31/19 1:04 AM, Joe Perches wrote: > On Sun, 2019-03-31 at 01:30 -0400, Will Cunningham wrote: >> Line was >80 characters. > [] >> diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c > [] >> @@ -169,8 +169,8 @@ static int gb_usb_probe(struct gbphy_device *gbphy_dev, >>

[PATCH] Staging: greybus: usb: Fixed a coding style error

2019-03-30 Thread Will Cunningham
Line was >80 characters. Signed-off-by: Will Cunningham --- drivers/staging/greybus/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c index 1c246c73a085..5b4cbec88159 100644 ---