Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread 'Greg Kroah-Hartman'
On Thu, Dec 10, 2020 at 12:20:10PM +, József Horváth wrote: > I send this again, because my original mail content was corrupted. > > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. > > Signed-off-by: József Horváth > --- >

[PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread József Horváth
I send this again, because my original mail content was corrupted. This is a serial port driver for Silicon Labs Si4455 Sub-GHz transciver. Signed-off-by: József Horváth --- .../bindings/staging/serial/silabs,si4455.txt | 39 + drivers/staging/Kconfig |2 +

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-10 Thread Dan Carpenter
On Wed, Dec 09, 2020 at 07:41:53PM +, József Horváth wrote: > > > +static int si4455_get_part_info(struct uart_port *port, > > > + struct si4455_part_info *result) > > > +{ > > > + int ret; > > > + u8 dataOut[] = { SI4455_CMD_ID_PART_INFO }; > > > +

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Rob Herring
On Wed, Dec 9, 2020 at 5:17 AM Info wrote: > > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. > > Signed-off-by: József Horváth > --- > .../bindings/staging/serial/silabs,si4455.txt | 39 + Looks straightforward enough to not be in staging. Plus

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread József Horváth
Hello Jérôme, On Wed, Dec 09, 2020 at 06:38:08PM +0100, Jérôme Pouiller wrote: > On Wednesday 9 December 2020 12:09:58 CET Info wrote: > > > > This is a serial port driver for > > Silicon Labs Si4455 Sub-GHz transciver. > > Hello József, > > Thank you for taking care of support of Silabs

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Dan Carpenter
On Wed, Dec 09, 2020 at 06:56:13PM +, József Horváth wrote: > Thank you for your suggestions. I made the canges suggested by you. > > I'll test the driver in my development environment, then I'll come > back with a new patch soon. Take your time. No rush. > > I set up a mail client on my

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread József Horváth
On Wed, Dec 09, 2020 at 03:42:06PM +0300, Dan Carpenter wrote: > Change the From email header to say your name. > > The patch is corrupted and can't be applied. Please read the first > paragraphs of Documentation/process/email-clients.rst > > This driver is pretty small and it might be easier

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Jérôme Pouiller
On Wednesday 9 December 2020 12:09:58 CET Info wrote: > > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. Hello József, Thank you for taking care of support of Silabs products :) > Signed-off-by: József Horváth I think you have to use your personal address to

RE: ***UNCHECKED*** Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Info
> On Wed, Dec 09, 2020 at 12:09:58PM +0100, Info wrote: > > This is a serial port driver for > > Silicon Labs Si4455 Sub-GHz transciver. > > > > Signed-off-by: József Horváth > > Note, your From: line does not match this line, so I can't take this. > > But: > > > --- > >

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Dan Carpenter
Change the From email header to say your name. The patch is corrupted and can't be applied. Please read the first paragraphs of Documentation/process/email-clients.rst This driver is pretty small and it might be easier to clean it up first before merging it into staging. Run checkpatch.pl

Re: [PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread 'Greg Kroah-Hartman'
On Wed, Dec 09, 2020 at 12:09:58PM +0100, Info wrote: > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. > > Signed-off-by: József Horváth Note, your From: line does not match this line, so I can't take this. But: > --- >

[PATCH] Staging: silabs si4455 serial driver

2020-12-09 Thread Info
This is a serial port driver for Silicon Labs Si4455 Sub-GHz transciver. Signed-off-by: József Horváth --- .../bindings/staging/serial/silabs,si4455.txt | 39 + drivers/staging/Kconfig |2 + drivers/staging/Makefile |1 +